From cf0b0332a4b5772d1b8ac97843a9af7018b22f96 Mon Sep 17 00:00:00 2001
From: David Westgate <davidjwestgate@gmail.com>
Date: Tue, 18 Mar 2025 15:21:06 -0700
Subject: [PATCH 1/2] remove uneeded test; fix other skipped tests

---
 .../ChipDistributionSummary.test.tsx          | 54 +++++++------------
 components/__tests__/ChipsSelector.test.tsx   | 19 ++-----
 2 files changed, 23 insertions(+), 50 deletions(-)

diff --git a/components/__tests__/ChipDistributionSummary.test.tsx b/components/__tests__/ChipDistributionSummary.test.tsx
index f0ce2cb..7a99274 100644
--- a/components/__tests__/ChipDistributionSummary.test.tsx
+++ b/components/__tests__/ChipDistributionSummary.test.tsx
@@ -1,5 +1,12 @@
 import React from "react";
-import { render } from "@testing-library/react-native";
+import { Alert } from "react-native";
+
+import {
+  fireEvent,
+  render,
+  userEvent,
+  waitFor,
+} from "@testing-library/react-native";
 import ChipDistributionSummary from "../ChipDistributionSummary";
 
 jest.mock("@expo/vector-icons", () => {
@@ -35,46 +42,23 @@ describe("ChipDistributionSummary Component", () => {
     });
   });
 
-  test.skip("renders fallback message when no valid distribution", () => {
+  test("renders warning message when needed", async () => {
     const { getByText } = render(
       <ChipDistributionSummary
-        playerCount={0}
-        buyInAmount={20}
+        playerCount={6}
+        buyInAmount={25}
         selectedCurrency={"$"}
-        totalChipsCount={[]}
+        totalChipsCount={[100, 50]}
       />
     );
-    expect(getByText("No valid distribution calculated yet.")).toBeTruthy();
-  });
+    const warning = getByText("TestIcon");
+    expect(warning).toBeTruthy();
 
-  test.skip("scales down chips if exceeding MAX_CHIPS", () => {
-    const playerCount = 2;
-    let totalChipsCount = [300, 400, 500, 600, 700];
-    const MAX_CHIPS = 500;
-    const totalChips = totalChipsCount.reduce((sum, count) => sum + count, 0);
-
-    if (totalChips > MAX_CHIPS) {
-      const scaleFactor = MAX_CHIPS / totalChips;
-      totalChipsCount = totalChipsCount.map((count) =>
-        Math.round(count * scaleFactor)
-      );
-    }
-
-    const expectedDistribution = [30, 40, 50, 60, 70]; // Adjust as per actual component calculations
-
-    const { getByText } = render(
-      <ChipDistributionSummary
-        playerCount={playerCount}
-        buyInAmount={100}
-        totalChipsCount={totalChipsCount}
-        selectedCurrency={"$"}
-      />
+    jest.spyOn(Alert, "alert");
+    fireEvent.press(warning);
+    expect(Alert.alert).toHaveBeenCalledWith(
+      "Warning",
+      `Be advised that the value of the distributed chips does not equal the buy-in for these inputs.\n\nHowever, results shown are fair to all players`
     );
-
-    expect(getByText("Distribution & Denomination")).toBeTruthy();
-
-    expectedDistribution.forEach((count) => {
-      expect(getByText(new RegExp(`^${count}\\s+chips:`, "i"))).toBeTruthy();
-    });
   });
 });
diff --git a/components/__tests__/ChipsSelector.test.tsx b/components/__tests__/ChipsSelector.test.tsx
index a81366d..44f22c7 100644
--- a/components/__tests__/ChipsSelector.test.tsx
+++ b/components/__tests__/ChipsSelector.test.tsx
@@ -6,6 +6,7 @@ import {
   waitForElementToBeRemoved,
   fireEvent,
   act,
+  waitFor,
 } from "@testing-library/react-native";
 import ChipsSelector from "@/components/ChipsSelector";
 
@@ -83,27 +84,15 @@ describe("tests for ChipsSelector", () => {
     ]);
   });
 
-  // skip: There is a jest/DOM issue with the button interaction, despite working correctly in-app. Documented to resolve.
-  it.skip("test dec/inc buttons", async () => {
+  it("test dec/inc buttons", async () => {
     rend();
-
-    const blue = screen.getByText(TOTAL_CHIPS_COUNT[3].toString());
-    const black = screen.getByText(TOTAL_CHIPS_COUNT[4].toString());
     const decrement = screen.getByRole("button", { name: /-/i });
     const increment = screen.getByRole("button", { name: /\+/i });
 
     fireEvent.press(decrement);
-    fireEvent.press(decrement);
-
-    // Test that elements are removed after fireEvent
-    await waitForElementToBeRemoved(() => blue);
-    await waitForElementToBeRemoved(() => black);
+    expect(mockSetNumberOfChips).toHaveBeenCalledWith(4);
 
     fireEvent.press(increment);
-    fireEvent.press(increment);
-
-    // Test that new elements re-appear, correctly
-    const blue1 = screen.getByText(TOTAL_CHIPS_COUNT[3].toString());
-    const black1 = screen.getByText(TOTAL_CHIPS_COUNT[4].toString());
+    expect(mockSetNumberOfChips).toHaveBeenCalledWith(4);
   });
 });

From b98d0035d83f5fbfddfd0ee5aa55d1adffe17d6f Mon Sep 17 00:00:00 2001
From: David Westgate <davidjwestgate@gmail.com>
Date: Tue, 18 Mar 2025 15:23:25 -0700
Subject: [PATCH 2/2] remove unused imports

---
 components/__tests__/ChipDistributionSummary.test.tsx | 7 +------
 components/__tests__/ChipsSelector.test.tsx           | 3 ---
 2 files changed, 1 insertion(+), 9 deletions(-)

diff --git a/components/__tests__/ChipDistributionSummary.test.tsx b/components/__tests__/ChipDistributionSummary.test.tsx
index 7a99274..d5a8221 100644
--- a/components/__tests__/ChipDistributionSummary.test.tsx
+++ b/components/__tests__/ChipDistributionSummary.test.tsx
@@ -1,12 +1,7 @@
 import React from "react";
 import { Alert } from "react-native";
 
-import {
-  fireEvent,
-  render,
-  userEvent,
-  waitFor,
-} from "@testing-library/react-native";
+import { fireEvent, render } from "@testing-library/react-native";
 import ChipDistributionSummary from "../ChipDistributionSummary";
 
 jest.mock("@expo/vector-icons", () => {
diff --git a/components/__tests__/ChipsSelector.test.tsx b/components/__tests__/ChipsSelector.test.tsx
index 44f22c7..4bbab86 100644
--- a/components/__tests__/ChipsSelector.test.tsx
+++ b/components/__tests__/ChipsSelector.test.tsx
@@ -3,10 +3,7 @@ import {
   userEvent,
   render,
   screen,
-  waitForElementToBeRemoved,
   fireEvent,
-  act,
-  waitFor,
 } from "@testing-library/react-native";
 import ChipsSelector from "@/components/ChipsSelector";