From 5a2d7cfe5441748b0b039ad8791262245cb01c7e Mon Sep 17 00:00:00 2001
From: David Westgate <davidjwestgate@gmail.com>
Date: Mon, 10 Feb 2025 21:14:52 -0800
Subject: [PATCH] add initial tests; fix up logic in ChipsSelector Modal

---
 components/ChipsSelector.tsx                | 46 ++++++++-----
 components/__tests__/ChipsSelector.test.ts  |  0
 components/__tests__/ChipsSelector.test.tsx | 72 +++++++++++++++++++++
 3 files changed, 102 insertions(+), 16 deletions(-)
 delete mode 100644 components/__tests__/ChipsSelector.test.ts
 create mode 100644 components/__tests__/ChipsSelector.test.tsx

diff --git a/components/ChipsSelector.tsx b/components/ChipsSelector.tsx
index 0a4eca4..e594ffe 100644
--- a/components/ChipsSelector.tsx
+++ b/components/ChipsSelector.tsx
@@ -3,7 +3,6 @@ import {
   View,
   Text,
   TextInput,
-  TouchableOpacity,
   StyleSheet,
   Button,
   ColorValue,
@@ -25,27 +24,40 @@ const ChipInputModal = ({
   const color: ColorValue = useMemo(() => showModal[1], [showModal]);
   const colorIdx = useMemo(() => colors.indexOf(color), [color]);
 
-  const value: number = useMemo(
-    () => totalChipsCount[colorIdx],
-    [totalChipsCount, colorIdx]
-  );
+  const [value, setValue] = useState<number | undefined>(); // value may be undefined initially
+
+  // Reset the color value when the specific color this modal is for, changes. The same modal is shared/reused in all cases.
+  useEffect(() => {
+    setValue(totalChipsCount[colorIdx]);
+  }, [colorIdx]);
 
   return (
     <Modal
       visible={showModal[0]}
       onRequestClose={() => setShowModal([false, color])}
     >
-      <Text>Number of {showModal[1]?.toString()} chips</Text>
-      <TextInput
-        style={{ color: showModal[1] }}
-        keyboardType="numeric"
-        value={value.toString()}
-        onChangeText={(v) => {
-          const n = parseInt(v);
-          update(showModal[1], Number.isNaN(n) ? 0 : n);
+      {value !== undefined && (
+        <>
+          <Text>Number of {showModal[1]?.toString()} chips</Text>
+          <TextInput
+            style={{ color: showModal[1] }}
+            keyboardType="numeric"
+            value={value.toString()}
+            onChangeText={(v) => {
+              const dirtyNum: number = parseInt(v);
+              !isNaN(dirtyNum) ? setValue(dirtyNum) : setValue(0);
+            }}
+            testID="modalInput"
+          />
+        </>
+      )}
+      <Button
+        title="Accept"
+        onPress={() => {
+          update(showModal[1], Number.isNaN(value) ? 0 : value);
+          setShowModal([false, color]);
         }}
       />
-      <Button title="Accept" onPress={() => setShowModal([false, color])} />
     </Modal>
   );
 };
@@ -74,7 +86,7 @@ const ChipsSelector = ({
   numberOfChips,
   totalChipsCount,
   setTotalChipsCount,
-  setNumberOfChips,
+  setNumberOfChips, // todo
 }: {
   numberOfChips: number;
   totalChipsCount: number[];
@@ -90,6 +102,7 @@ const ChipsSelector = ({
     [numberOfChips]
   );
 
+  // Callback for ChipInputModal to update the chips in the parents state.
   const update = useCallback(
     (color: ColorValue, count: number) => {
       const newTotalChipsCount = totalChipsCount.slice();
@@ -99,6 +112,8 @@ const ChipsSelector = ({
     },
     [numberOfChips, totalChipsCount, setTotalChipsCount]
   );
+
+  // When the number of chips changes (dec or inc), update the array being careful to add in sensible default values where they belong
   useEffect(() => {
     if (numberOfChips !== totalChipsCount.length) {
       let newTotalChipsCount = totalChipsCount.slice();
@@ -150,7 +165,6 @@ const styles = StyleSheet.create({
     backgroundColor: "#ddd",
   },
   chip: {
-    // backgroundColor: "blue",
     textAlign: "center",
     fontSize: 16,
     fontWeight: "bold",
diff --git a/components/__tests__/ChipsSelector.test.ts b/components/__tests__/ChipsSelector.test.ts
deleted file mode 100644
index e69de29..0000000
diff --git a/components/__tests__/ChipsSelector.test.tsx b/components/__tests__/ChipsSelector.test.tsx
new file mode 100644
index 0000000..0d92fc5
--- /dev/null
+++ b/components/__tests__/ChipsSelector.test.tsx
@@ -0,0 +1,72 @@
+import React from "react";
+import {
+  userEvent,
+  render,
+  screen,
+  waitForElementToBeRemoved,
+  waitFor,
+} from "@testing-library/react-native";
+import ChipsSelector from "@/components/ChipsSelector";
+
+const TOTAL_CHIPS_COUNT = [100, 80, 60, 20, 10];
+
+const mocktTotalChipsCount = jest.fn();
+const mockSetNumberOfChips = jest.fn();
+
+const rend = () =>
+  render(
+    <ChipsSelector
+      numberOfChips={TOTAL_CHIPS_COUNT.length}
+      totalChipsCount={TOTAL_CHIPS_COUNT}
+      setTotalChipsCount={mocktTotalChipsCount}
+      setNumberOfChips={mockSetNumberOfChips}
+    />
+  );
+
+describe("tests for ChipsSelector", () => {
+  test("ChipsSelector appears with correct default values", () => {
+    rend();
+    const white = screen.getByText(TOTAL_CHIPS_COUNT[0].toString());
+    expect(white).toHaveStyle({ color: "white" });
+
+    const red = screen.getByText(TOTAL_CHIPS_COUNT[1].toString());
+    expect(red).toHaveStyle({ color: "red" });
+
+    const green = screen.getByText(TOTAL_CHIPS_COUNT[2].toString());
+    expect(green).toHaveStyle({ color: "green" });
+
+    const blue = screen.getByText(TOTAL_CHIPS_COUNT[3].toString());
+    expect(blue).toHaveStyle({ color: "blue" });
+
+    const black = screen.getByText(TOTAL_CHIPS_COUNT[4].toString());
+    expect(black).toHaveStyle({ color: "black" });
+  });
+
+  test("updating chip count works as expected", async () => {
+    rend();
+
+    const green = screen.getByText("60");
+    expect(green).toHaveStyle({ color: "green" });
+
+    userEvent.press(green);
+    const modalLabel = await screen.findByText(/number of green chips/i);
+    expect(modalLabel).toBeDefined();
+
+    const modalInput = screen.getByTestId("modalInput");
+    expect(modalInput).toHaveDisplayValue("60");
+
+    await userEvent.press(modalInput);
+    await userEvent.clear(modalInput);
+    await userEvent.type(modalInput, "64");
+
+    const acceptButton = screen.getByRole("button", { name: /accept/i });
+    await userEvent.press(acceptButton);
+
+    const modalLabelAgain = screen.queryByText(/number of green chips/i); //If the label is gone, we know the modal is no longer visible
+    expect(modalLabelAgain).not.toBeVisible();
+
+    expect(mocktTotalChipsCount).toHaveBeenCalledWith([100, 80, 64, 20, 10]);
+  });
+
+  test.todo("updating total amount of color chips works as expected");
+});