david/poker-chips-helper
1
1
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Add app title and app icon #23 #28

Merged
Vutukuri15 merged 1 commits from vutukuri15/23 into main 2025-02-23 10:51:55 -08:00
Conversation 1 Commits 1 Files Changed 2 +2 -2
Vutukuri15 commented 2025-02-23 10:11:01 -08:00 (Migrated from github.com)
Copy Link

Set the application title to "Poker Chips Helper" to ensure clarity and ease of identification.
Designed and added a app icon that blends poker elements (chips/cards) with a calculator symbol.
Ensured the icon is properly licensed for use.
Verified that the title appears correctly within the app.

Set the application title to "Poker Chips Helper" to ensure clarity and ease of identification. Designed and added a app icon that blends poker elements (chips/cards) with a calculator symbol. Ensured the icon is properly licensed for use. Verified that the title appears correctly within the app.
MantashaNoyela (Migrated from github.com) reviewed 2025-02-23 10:11:01 -08:00
djwesty (Migrated from github.com) approved these changes 2025-02-23 10:32:56 -08:00
djwesty (Migrated from github.com) left a comment
Copy Link

Interesting icon. The AI artifacts are not subtle, but I like the overall design and aesthetic.

The icon will be small and the details hard to see on the phone, so I say this is good enough ✅

Interesting icon. The AI artifacts are not subtle, but I like the overall design and aesthetic. The icon will be small and the details hard to see on the phone, so I say this is good enough ✅
app.json
@ -7,3 +7,3 @@
"icon": "./assets/images/icon.png",
"icon": "./assets/images/icon1.png",
"scheme": "myapp",
"userInterfaceStyle": "automatic",
djwesty (Migrated from github.com) commented 2025-02-23 10:28:22 -08:00
Copy Link

I suggest just replacing the default icon.png with the new image rather than adding a new file icon1.png.
In the interest of app cleanliness and reducing bloat we do not need to keep unused graphic resources in our app.

You can resolve this thread

I suggest just replacing the default `icon.png` with the new image rather than adding a new file `icon1.png`. In the interest of app cleanliness and reducing bloat we do not need to keep unused graphic resources in our app. You can resolve this thread
Vutukuri15 commented 2025-02-23 10:51:36 -08:00 (Migrated from github.com)
Copy Link

Thank you

Thank you
Sign in to join this conversation.
Reviewers
No reviewers
MantashaNoyela
djwesty
Labels
Clear labels   
Large

5-10 Days

  
Medium

2-5 Days

  
Small

0-2 Days

  
bug

Something isn't working

  
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
invalid

This doesn't seem right

  
question

Further information is requested

  
wontfix

This will not be worked on

No Label
Large
Medium
Small
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Project Sprint 2
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: david/poker-chips-helper#28
No description provided.
Delete Branch "vutukuri15/23"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?