Issue with Image Detection setting chip colors #45

Closed
opened 2025-02-27 18:27:13 -08:00 by djwesty · 0 comments
djwesty commented 2025-02-27 18:27:13 -08:00 (Migrated from github.com)

Background

There is an issue with Chip detection not setting the correct colors.

Recreation

Notice how while the API is likely returning data for all colors (white, green, blue, red, black), and the white chips are being properly updated, the other color chips are not being added in
https://github.com/user-attachments/assets/fadf5d3c-62f5-48d4-9ff8-a2c13fd1974f

Expected behavior

The Component should either add chip colors, or remove chip colors as needed from the chip selector depending on the result of the API.

Notes

It is possible there is a logic issue in the chip detection, it is also possible the issue might be elsewhere.
We should add or update a test to ensure this regression bug does not come back

## Background There is an issue with Chip detection not setting the correct colors. ## Recreation Notice how while the API is likely returning data for all colors (white, green, blue, red, black), and the white chips are being properly updated, the other color chips are not being added in https://github.com/user-attachments/assets/fadf5d3c-62f5-48d4-9ff8-a2c13fd1974f ## Expected behavior The Component should either add chip colors, or remove chip colors as needed from the chip selector depending on the result of the API. ## Notes It is possible there is a logic issue in the chip detection, it is also possible the issue might be elsewhere. We should add or update a test to ensure this regression bug does not come back
Sign in to join this conversation.
No Milestone
No project
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: david/poker-chips-helper#45
No description provided.