Implement BuyInAmount Selector Component (Issue #3) #15

Merged
Vutukuri15 merged 2 commits from vutukuri15/3 into main 2025-02-09 21:37:45 -08:00
2 changed files with 38 additions and 22 deletions
Showing only changes of commit 76342ed534 - Show all commits

View File

@ -4,29 +4,29 @@ import {
djwesty commented 2025-02-09 19:35:52 -08:00 (Migrated from github.com)
Review

I have a couple concerns with hardcoding this reference here.

  • The link is a dependency of our app. If it breaks one day or the user has no network, could be a bad experience
  • Though you may know its ok, I'm not sure if we have the rights to use this for our app.

One approach would be to save and render the image locally in our app. This solves point 1
Another approach would be to use some public icons, like @expo/vector-icons. If there is a good match, that addresses point 1 and 2.

This should be fixed, but up to you on your approach. You can resolve this thread when done

I have a couple concerns with hardcoding this reference here. * The link is a dependency of our app. If it breaks one day or the user has no network, could be a bad experience * Though you may know its ok, I'm not sure if we have the rights to use this for our app. One approach would be to save and render the image locally in our app. This solves point 1 Another approach would be to use some public icons, like [@expo/vector-icons](https://icons.expo.fyi/Index). If there is a good match, that addresses point 1 and 2. This should be fixed, but up to you on your approach. You can resolve this thread when done
djwesty commented 2025-02-09 19:35:52 -08:00 (Migrated from github.com)
Review

I have a couple concerns with hardcoding this reference here.

  • The link is a dependency of our app. If it breaks one day or the user has no network, could be a bad experience
  • Though you may know its ok, I'm not sure if we have the rights to use this for our app.

One approach would be to save and render the image locally in our app. This solves point 1
Another approach would be to use some public icons, like @expo/vector-icons. If there is a good match, that addresses point 1 and 2.

This should be fixed, but up to you on your approach. You can resolve this thread when done

I have a couple concerns with hardcoding this reference here. * The link is a dependency of our app. If it breaks one day or the user has no network, could be a bad experience * Though you may know its ok, I'm not sure if we have the rights to use this for our app. One approach would be to save and render the image locally in our app. This solves point 1 Another approach would be to use some public icons, like [@expo/vector-icons](https://icons.expo.fyi/Index). If there is a good match, that addresses point 1 and 2. This should be fixed, but up to you on your approach. You can resolve this thread when done
Vutukuri15 commented 2025-02-09 20:11:27 -08:00 (Migrated from github.com)
Review

Thanks for the feedback! I'll check local storage or @expo/vector-icons and update once fixed.

Thanks for the feedback! I'll check local storage or @expo/vector-icons and update once fixed.
Vutukuri15 commented 2025-02-09 20:11:27 -08:00 (Migrated from github.com)
Review

Thanks for the feedback! I'll check local storage or @expo/vector-icons and update once fixed.

Thanks for the feedback! I'll check local storage or @expo/vector-icons and update once fixed.
Vutukuri15 commented 2025-02-09 21:28:07 -08:00 (Migrated from github.com)
Review

I've replaced the external image link with the MaterialIcons from @expo/vector-icons, which addresses both the dependency issue and the rights concern.
Let me know if there's anything else to modify.

I've replaced the external image link with the MaterialIcons from @expo/vector-icons, which addresses both the dependency issue and the rights concern. Let me know if there's anything else to modify.
Vutukuri15 commented 2025-02-09 21:28:07 -08:00 (Migrated from github.com)
Review

I've replaced the external image link with the MaterialIcons from @expo/vector-icons, which addresses both the dependency issue and the rights concern.
Let me know if there's anything else to modify.

I've replaced the external image link with the MaterialIcons from @expo/vector-icons, which addresses both the dependency issue and the rights concern. Let me know if there's anything else to modify.
Text, Text,
TextInput, TextInput,
TouchableOpacity, TouchableOpacity,
Image,
djwesty commented 2025-02-09 19:35:52 -08:00 (Migrated from github.com)
Review

I have a couple concerns with hardcoding this reference here.

  • The link is a dependency of our app. If it breaks one day or the user has no network, could be a bad experience
  • Though you may know its ok, I'm not sure if we have the rights to use this for our app.

One approach would be to save and render the image locally in our app. This solves point 1
Another approach would be to use some public icons, like @expo/vector-icons. If there is a good match, that addresses point 1 and 2.

This should be fixed, but up to you on your approach. You can resolve this thread when done

I have a couple concerns with hardcoding this reference here. * The link is a dependency of our app. If it breaks one day or the user has no network, could be a bad experience * Though you may know its ok, I'm not sure if we have the rights to use this for our app. One approach would be to save and render the image locally in our app. This solves point 1 Another approach would be to use some public icons, like [@expo/vector-icons](https://icons.expo.fyi/Index). If there is a good match, that addresses point 1 and 2. This should be fixed, but up to you on your approach. You can resolve this thread when done
Vutukuri15 commented 2025-02-09 20:11:27 -08:00 (Migrated from github.com)
Review

Thanks for the feedback! I'll check local storage or @expo/vector-icons and update once fixed.

Thanks for the feedback! I'll check local storage or @expo/vector-icons and update once fixed.
Vutukuri15 commented 2025-02-09 21:28:07 -08:00 (Migrated from github.com)
Review

I've replaced the external image link with the MaterialIcons from @expo/vector-icons, which addresses both the dependency issue and the rights concern.
Let me know if there's anything else to modify.

I've replaced the external image link with the MaterialIcons from @expo/vector-icons, which addresses both the dependency issue and the rights concern. Let me know if there's anything else to modify.
StyleSheet, StyleSheet,
} from "react-native"; } from "react-native";
import { MaterialIcons } from "@expo/vector-icons";
djwesty commented 2025-02-09 19:35:52 -08:00 (Migrated from github.com)
Review

I have a couple concerns with hardcoding this reference here.

  • The link is a dependency of our app. If it breaks one day or the user has no network, could be a bad experience
  • Though you may know its ok, I'm not sure if we have the rights to use this for our app.

One approach would be to save and render the image locally in our app. This solves point 1
Another approach would be to use some public icons, like @expo/vector-icons. If there is a good match, that addresses point 1 and 2.

This should be fixed, but up to you on your approach. You can resolve this thread when done

I have a couple concerns with hardcoding this reference here. * The link is a dependency of our app. If it breaks one day or the user has no network, could be a bad experience * Though you may know its ok, I'm not sure if we have the rights to use this for our app. One approach would be to save and render the image locally in our app. This solves point 1 Another approach would be to use some public icons, like [@expo/vector-icons](https://icons.expo.fyi/Index). If there is a good match, that addresses point 1 and 2. This should be fixed, but up to you on your approach. You can resolve this thread when done
Vutukuri15 commented 2025-02-09 20:11:27 -08:00 (Migrated from github.com)
Review

Thanks for the feedback! I'll check local storage or @expo/vector-icons and update once fixed.

Thanks for the feedback! I'll check local storage or @expo/vector-icons and update once fixed.
Vutukuri15 commented 2025-02-09 21:28:07 -08:00 (Migrated from github.com)
Review

I've replaced the external image link with the MaterialIcons from @expo/vector-icons, which addresses both the dependency issue and the rights concern.
Let me know if there's anything else to modify.

I've replaced the external image link with the MaterialIcons from @expo/vector-icons, which addresses both the dependency issue and the rights concern. Let me know if there's anything else to modify.
interface BuyInSelectorProps { interface BuyInSelectorProps {
setBuyInAmount: React.Dispatch<React.SetStateAction<number | null>>; setBuyInAmount: React.Dispatch<React.SetStateAction<number | null>>;
} }
const defaultBuyInOptions = [10, 25, 50]; // Default buy-in values const defaultBuyInOptions = [10, 25, 50];
djwesty commented 2025-02-09 19:35:52 -08:00 (Migrated from github.com)
Review

I have a couple concerns with hardcoding this reference here.

  • The link is a dependency of our app. If it breaks one day or the user has no network, could be a bad experience
  • Though you may know its ok, I'm not sure if we have the rights to use this for our app.

One approach would be to save and render the image locally in our app. This solves point 1
Another approach would be to use some public icons, like @expo/vector-icons. If there is a good match, that addresses point 1 and 2.

This should be fixed, but up to you on your approach. You can resolve this thread when done

I have a couple concerns with hardcoding this reference here. * The link is a dependency of our app. If it breaks one day or the user has no network, could be a bad experience * Though you may know its ok, I'm not sure if we have the rights to use this for our app. One approach would be to save and render the image locally in our app. This solves point 1 Another approach would be to use some public icons, like [@expo/vector-icons](https://icons.expo.fyi/Index). If there is a good match, that addresses point 1 and 2. This should be fixed, but up to you on your approach. You can resolve this thread when done
Vutukuri15 commented 2025-02-09 20:11:27 -08:00 (Migrated from github.com)
Review

Thanks for the feedback! I'll check local storage or @expo/vector-icons and update once fixed.

Thanks for the feedback! I'll check local storage or @expo/vector-icons and update once fixed.
Vutukuri15 commented 2025-02-09 21:28:07 -08:00 (Migrated from github.com)
Review

I've replaced the external image link with the MaterialIcons from @expo/vector-icons, which addresses both the dependency issue and the rights concern.
Let me know if there's anything else to modify.

I've replaced the external image link with the MaterialIcons from @expo/vector-icons, which addresses both the dependency issue and the rights concern. Let me know if there's anything else to modify.
djwesty commented 2025-02-09 19:35:52 -08:00 (Migrated from github.com)
Review

I have a couple concerns with hardcoding this reference here.

  • The link is a dependency of our app. If it breaks one day or the user has no network, could be a bad experience
  • Though you may know its ok, I'm not sure if we have the rights to use this for our app.

One approach would be to save and render the image locally in our app. This solves point 1
Another approach would be to use some public icons, like @expo/vector-icons. If there is a good match, that addresses point 1 and 2.

This should be fixed, but up to you on your approach. You can resolve this thread when done

I have a couple concerns with hardcoding this reference here. * The link is a dependency of our app. If it breaks one day or the user has no network, could be a bad experience * Though you may know its ok, I'm not sure if we have the rights to use this for our app. One approach would be to save and render the image locally in our app. This solves point 1 Another approach would be to use some public icons, like [@expo/vector-icons](https://icons.expo.fyi/Index). If there is a good match, that addresses point 1 and 2. This should be fixed, but up to you on your approach. You can resolve this thread when done
Vutukuri15 commented 2025-02-09 20:11:27 -08:00 (Migrated from github.com)
Review

Thanks for the feedback! I'll check local storage or @expo/vector-icons and update once fixed.

Thanks for the feedback! I'll check local storage or @expo/vector-icons and update once fixed.
Vutukuri15 commented 2025-02-09 21:28:07 -08:00 (Migrated from github.com)
Review

I've replaced the external image link with the MaterialIcons from @expo/vector-icons, which addresses both the dependency issue and the rights concern.
Let me know if there's anything else to modify.

I've replaced the external image link with the MaterialIcons from @expo/vector-icons, which addresses both the dependency issue and the rights concern. Let me know if there's anything else to modify.
const BuyInSelector: React.FC<BuyInSelectorProps> = ({ setBuyInAmount }) => { const BuyInSelector: React.FC<BuyInSelectorProps> = ({ setBuyInAmount }) => {
const [customAmount, setCustomAmount] = useState(""); const [customAmount, setCustomAmount] = useState("");
const [buyInAmount, setBuyInAmountState] = useState<number | null>(null); // Store the selected amount locally const [buyInAmount, setBuyInAmountState] = useState<number | null>(null);
djwesty commented 2025-02-09 19:35:52 -08:00 (Migrated from github.com)
Review

I have a couple concerns with hardcoding this reference here.

  • The link is a dependency of our app. If it breaks one day or the user has no network, could be a bad experience
  • Though you may know its ok, I'm not sure if we have the rights to use this for our app.

One approach would be to save and render the image locally in our app. This solves point 1
Another approach would be to use some public icons, like @expo/vector-icons. If there is a good match, that addresses point 1 and 2.

This should be fixed, but up to you on your approach. You can resolve this thread when done

I have a couple concerns with hardcoding this reference here. * The link is a dependency of our app. If it breaks one day or the user has no network, could be a bad experience * Though you may know its ok, I'm not sure if we have the rights to use this for our app. One approach would be to save and render the image locally in our app. This solves point 1 Another approach would be to use some public icons, like [@expo/vector-icons](https://icons.expo.fyi/Index). If there is a good match, that addresses point 1 and 2. This should be fixed, but up to you on your approach. You can resolve this thread when done
Vutukuri15 commented 2025-02-09 20:11:27 -08:00 (Migrated from github.com)
Review

Thanks for the feedback! I'll check local storage or @expo/vector-icons and update once fixed.

Thanks for the feedback! I'll check local storage or @expo/vector-icons and update once fixed.
Vutukuri15 commented 2025-02-09 21:28:07 -08:00 (Migrated from github.com)
Review

I've replaced the external image link with the MaterialIcons from @expo/vector-icons, which addresses both the dependency issue and the rights concern.
Let me know if there's anything else to modify.

I've replaced the external image link with the MaterialIcons from @expo/vector-icons, which addresses both the dependency issue and the rights concern. Let me know if there's anything else to modify.
djwesty commented 2025-02-09 19:35:52 -08:00 (Migrated from github.com)
Review

I have a couple concerns with hardcoding this reference here.

  • The link is a dependency of our app. If it breaks one day or the user has no network, could be a bad experience
  • Though you may know its ok, I'm not sure if we have the rights to use this for our app.

One approach would be to save and render the image locally in our app. This solves point 1
Another approach would be to use some public icons, like @expo/vector-icons. If there is a good match, that addresses point 1 and 2.

This should be fixed, but up to you on your approach. You can resolve this thread when done

I have a couple concerns with hardcoding this reference here. * The link is a dependency of our app. If it breaks one day or the user has no network, could be a bad experience * Though you may know its ok, I'm not sure if we have the rights to use this for our app. One approach would be to save and render the image locally in our app. This solves point 1 Another approach would be to use some public icons, like [@expo/vector-icons](https://icons.expo.fyi/Index). If there is a good match, that addresses point 1 and 2. This should be fixed, but up to you on your approach. You can resolve this thread when done
Vutukuri15 commented 2025-02-09 20:11:27 -08:00 (Migrated from github.com)
Review

Thanks for the feedback! I'll check local storage or @expo/vector-icons and update once fixed.

Thanks for the feedback! I'll check local storage or @expo/vector-icons and update once fixed.
Vutukuri15 commented 2025-02-09 21:28:07 -08:00 (Migrated from github.com)
Review

I've replaced the external image link with the MaterialIcons from @expo/vector-icons, which addresses both the dependency issue and the rights concern.
Let me know if there's anything else to modify.

I've replaced the external image link with the MaterialIcons from @expo/vector-icons, which addresses both the dependency issue and the rights concern. Let me know if there's anything else to modify.
const handleCustomAmountChange = (value: string) => { const handleCustomAmountChange = (value: string) => {
const numericValue = parseFloat(value); const numericValue = parseFloat(value);
if (!isNaN(numericValue) && numericValue >= 0) { if (!isNaN(numericValue) && numericValue >= 0) {
setCustomAmount(value); setCustomAmount(value);
setBuyInAmountState(numericValue); // Update buy-in amount setBuyInAmountState(numericValue);
djwesty commented 2025-02-09 19:35:52 -08:00 (Migrated from github.com)
Review

I have a couple concerns with hardcoding this reference here.

  • The link is a dependency of our app. If it breaks one day or the user has no network, could be a bad experience
  • Though you may know its ok, I'm not sure if we have the rights to use this for our app.

One approach would be to save and render the image locally in our app. This solves point 1
Another approach would be to use some public icons, like @expo/vector-icons. If there is a good match, that addresses point 1 and 2.

This should be fixed, but up to you on your approach. You can resolve this thread when done

I have a couple concerns with hardcoding this reference here. * The link is a dependency of our app. If it breaks one day or the user has no network, could be a bad experience * Though you may know its ok, I'm not sure if we have the rights to use this for our app. One approach would be to save and render the image locally in our app. This solves point 1 Another approach would be to use some public icons, like [@expo/vector-icons](https://icons.expo.fyi/Index). If there is a good match, that addresses point 1 and 2. This should be fixed, but up to you on your approach. You can resolve this thread when done
Vutukuri15 commented 2025-02-09 20:11:27 -08:00 (Migrated from github.com)
Review

Thanks for the feedback! I'll check local storage or @expo/vector-icons and update once fixed.

Thanks for the feedback! I'll check local storage or @expo/vector-icons and update once fixed.
Vutukuri15 commented 2025-02-09 21:28:07 -08:00 (Migrated from github.com)
Review

I've replaced the external image link with the MaterialIcons from @expo/vector-icons, which addresses both the dependency issue and the rights concern.
Let me know if there's anything else to modify.

I've replaced the external image link with the MaterialIcons from @expo/vector-icons, which addresses both the dependency issue and the rights concern. Let me know if there's anything else to modify.
djwesty commented 2025-02-09 19:35:52 -08:00 (Migrated from github.com)
Review

I have a couple concerns with hardcoding this reference here.

  • The link is a dependency of our app. If it breaks one day or the user has no network, could be a bad experience
  • Though you may know its ok, I'm not sure if we have the rights to use this for our app.

One approach would be to save and render the image locally in our app. This solves point 1
Another approach would be to use some public icons, like @expo/vector-icons. If there is a good match, that addresses point 1 and 2.

This should be fixed, but up to you on your approach. You can resolve this thread when done

I have a couple concerns with hardcoding this reference here. * The link is a dependency of our app. If it breaks one day or the user has no network, could be a bad experience * Though you may know its ok, I'm not sure if we have the rights to use this for our app. One approach would be to save and render the image locally in our app. This solves point 1 Another approach would be to use some public icons, like [@expo/vector-icons](https://icons.expo.fyi/Index). If there is a good match, that addresses point 1 and 2. This should be fixed, but up to you on your approach. You can resolve this thread when done
Vutukuri15 commented 2025-02-09 20:11:27 -08:00 (Migrated from github.com)
Review

Thanks for the feedback! I'll check local storage or @expo/vector-icons and update once fixed.

Thanks for the feedback! I'll check local storage or @expo/vector-icons and update once fixed.
Vutukuri15 commented 2025-02-09 21:28:07 -08:00 (Migrated from github.com)
Review

I've replaced the external image link with the MaterialIcons from @expo/vector-icons, which addresses both the dependency issue and the rights concern.
Let me know if there's anything else to modify.

I've replaced the external image link with the MaterialIcons from @expo/vector-icons, which addresses both the dependency issue and the rights concern. Let me know if there's anything else to modify.
setBuyInAmount(numericValue); // Pass it back to parent component setBuyInAmount(numericValue);
djwesty commented 2025-02-09 19:35:52 -08:00 (Migrated from github.com)
Review

I have a couple concerns with hardcoding this reference here.

  • The link is a dependency of our app. If it breaks one day or the user has no network, could be a bad experience
  • Though you may know its ok, I'm not sure if we have the rights to use this for our app.

One approach would be to save and render the image locally in our app. This solves point 1
Another approach would be to use some public icons, like @expo/vector-icons. If there is a good match, that addresses point 1 and 2.

This should be fixed, but up to you on your approach. You can resolve this thread when done

I have a couple concerns with hardcoding this reference here. * The link is a dependency of our app. If it breaks one day or the user has no network, could be a bad experience * Though you may know its ok, I'm not sure if we have the rights to use this for our app. One approach would be to save and render the image locally in our app. This solves point 1 Another approach would be to use some public icons, like [@expo/vector-icons](https://icons.expo.fyi/Index). If there is a good match, that addresses point 1 and 2. This should be fixed, but up to you on your approach. You can resolve this thread when done
Vutukuri15 commented 2025-02-09 20:11:27 -08:00 (Migrated from github.com)
Review

Thanks for the feedback! I'll check local storage or @expo/vector-icons and update once fixed.

Thanks for the feedback! I'll check local storage or @expo/vector-icons and update once fixed.
Vutukuri15 commented 2025-02-09 21:28:07 -08:00 (Migrated from github.com)
Review

I've replaced the external image link with the MaterialIcons from @expo/vector-icons, which addresses both the dependency issue and the rights concern.
Let me know if there's anything else to modify.

I've replaced the external image link with the MaterialIcons from @expo/vector-icons, which addresses both the dependency issue and the rights concern. Let me know if there's anything else to modify.
djwesty commented 2025-02-09 19:35:52 -08:00 (Migrated from github.com)
Review

I have a couple concerns with hardcoding this reference here.

  • The link is a dependency of our app. If it breaks one day or the user has no network, could be a bad experience
  • Though you may know its ok, I'm not sure if we have the rights to use this for our app.

One approach would be to save and render the image locally in our app. This solves point 1
Another approach would be to use some public icons, like @expo/vector-icons. If there is a good match, that addresses point 1 and 2.

This should be fixed, but up to you on your approach. You can resolve this thread when done

I have a couple concerns with hardcoding this reference here. * The link is a dependency of our app. If it breaks one day or the user has no network, could be a bad experience * Though you may know its ok, I'm not sure if we have the rights to use this for our app. One approach would be to save and render the image locally in our app. This solves point 1 Another approach would be to use some public icons, like [@expo/vector-icons](https://icons.expo.fyi/Index). If there is a good match, that addresses point 1 and 2. This should be fixed, but up to you on your approach. You can resolve this thread when done
Vutukuri15 commented 2025-02-09 20:11:27 -08:00 (Migrated from github.com)
Review

Thanks for the feedback! I'll check local storage or @expo/vector-icons and update once fixed.

Thanks for the feedback! I'll check local storage or @expo/vector-icons and update once fixed.
Vutukuri15 commented 2025-02-09 21:28:07 -08:00 (Migrated from github.com)
Review

I've replaced the external image link with the MaterialIcons from @expo/vector-icons, which addresses both the dependency issue and the rights concern.
Let me know if there's anything else to modify.

I've replaced the external image link with the MaterialIcons from @expo/vector-icons, which addresses both the dependency issue and the rights concern. Let me know if there's anything else to modify.
} else { } else {
setCustomAmount(""); setCustomAmount("");
setBuyInAmountState(null); // Reset if invalid setBuyInAmountState(null);
djwesty commented 2025-02-09 19:35:52 -08:00 (Migrated from github.com)
Review

I have a couple concerns with hardcoding this reference here.

  • The link is a dependency of our app. If it breaks one day or the user has no network, could be a bad experience
  • Though you may know its ok, I'm not sure if we have the rights to use this for our app.

One approach would be to save and render the image locally in our app. This solves point 1
Another approach would be to use some public icons, like @expo/vector-icons. If there is a good match, that addresses point 1 and 2.

This should be fixed, but up to you on your approach. You can resolve this thread when done

I have a couple concerns with hardcoding this reference here. * The link is a dependency of our app. If it breaks one day or the user has no network, could be a bad experience * Though you may know its ok, I'm not sure if we have the rights to use this for our app. One approach would be to save and render the image locally in our app. This solves point 1 Another approach would be to use some public icons, like [@expo/vector-icons](https://icons.expo.fyi/Index). If there is a good match, that addresses point 1 and 2. This should be fixed, but up to you on your approach. You can resolve this thread when done
Vutukuri15 commented 2025-02-09 20:11:27 -08:00 (Migrated from github.com)
Review

Thanks for the feedback! I'll check local storage or @expo/vector-icons and update once fixed.

Thanks for the feedback! I'll check local storage or @expo/vector-icons and update once fixed.
Vutukuri15 commented 2025-02-09 21:28:07 -08:00 (Migrated from github.com)
Review

I've replaced the external image link with the MaterialIcons from @expo/vector-icons, which addresses both the dependency issue and the rights concern.
Let me know if there's anything else to modify.

I've replaced the external image link with the MaterialIcons from @expo/vector-icons, which addresses both the dependency issue and the rights concern. Let me know if there's anything else to modify.
djwesty commented 2025-02-09 19:35:52 -08:00 (Migrated from github.com)
Review

I have a couple concerns with hardcoding this reference here.

  • The link is a dependency of our app. If it breaks one day or the user has no network, could be a bad experience
  • Though you may know its ok, I'm not sure if we have the rights to use this for our app.

One approach would be to save and render the image locally in our app. This solves point 1
Another approach would be to use some public icons, like @expo/vector-icons. If there is a good match, that addresses point 1 and 2.

This should be fixed, but up to you on your approach. You can resolve this thread when done

I have a couple concerns with hardcoding this reference here. * The link is a dependency of our app. If it breaks one day or the user has no network, could be a bad experience * Though you may know its ok, I'm not sure if we have the rights to use this for our app. One approach would be to save and render the image locally in our app. This solves point 1 Another approach would be to use some public icons, like [@expo/vector-icons](https://icons.expo.fyi/Index). If there is a good match, that addresses point 1 and 2. This should be fixed, but up to you on your approach. You can resolve this thread when done
Vutukuri15 commented 2025-02-09 20:11:27 -08:00 (Migrated from github.com)
Review

Thanks for the feedback! I'll check local storage or @expo/vector-icons and update once fixed.

Thanks for the feedback! I'll check local storage or @expo/vector-icons and update once fixed.
Vutukuri15 commented 2025-02-09 21:28:07 -08:00 (Migrated from github.com)
Review

I've replaced the external image link with the MaterialIcons from @expo/vector-icons, which addresses both the dependency issue and the rights concern.
Let me know if there's anything else to modify.

I've replaced the external image link with the MaterialIcons from @expo/vector-icons, which addresses both the dependency issue and the rights concern. Let me know if there's anything else to modify.
setBuyInAmount(null); setBuyInAmount(null);
} }
}; };
@ -34,23 +34,16 @@ const BuyInSelector: React.FC<BuyInSelectorProps> = ({ setBuyInAmount }) => {
djwesty commented 2025-02-09 19:35:52 -08:00 (Migrated from github.com)
Review

I have a couple concerns with hardcoding this reference here.

  • The link is a dependency of our app. If it breaks one day or the user has no network, could be a bad experience
  • Though you may know its ok, I'm not sure if we have the rights to use this for our app.

One approach would be to save and render the image locally in our app. This solves point 1
Another approach would be to use some public icons, like @expo/vector-icons. If there is a good match, that addresses point 1 and 2.

This should be fixed, but up to you on your approach. You can resolve this thread when done

I have a couple concerns with hardcoding this reference here. * The link is a dependency of our app. If it breaks one day or the user has no network, could be a bad experience * Though you may know its ok, I'm not sure if we have the rights to use this for our app. One approach would be to save and render the image locally in our app. This solves point 1 Another approach would be to use some public icons, like [@expo/vector-icons](https://icons.expo.fyi/Index). If there is a good match, that addresses point 1 and 2. This should be fixed, but up to you on your approach. You can resolve this thread when done
djwesty commented 2025-02-09 19:35:52 -08:00 (Migrated from github.com)
Review

I have a couple concerns with hardcoding this reference here.

  • The link is a dependency of our app. If it breaks one day or the user has no network, could be a bad experience
  • Though you may know its ok, I'm not sure if we have the rights to use this for our app.

One approach would be to save and render the image locally in our app. This solves point 1
Another approach would be to use some public icons, like @expo/vector-icons. If there is a good match, that addresses point 1 and 2.

This should be fixed, but up to you on your approach. You can resolve this thread when done

I have a couple concerns with hardcoding this reference here. * The link is a dependency of our app. If it breaks one day or the user has no network, could be a bad experience * Though you may know its ok, I'm not sure if we have the rights to use this for our app. One approach would be to save and render the image locally in our app. This solves point 1 Another approach would be to use some public icons, like [@expo/vector-icons](https://icons.expo.fyi/Index). If there is a good match, that addresses point 1 and 2. This should be fixed, but up to you on your approach. You can resolve this thread when done
Vutukuri15 commented 2025-02-09 20:11:27 -08:00 (Migrated from github.com)
Review

Thanks for the feedback! I'll check local storage or @expo/vector-icons and update once fixed.

Thanks for the feedback! I'll check local storage or @expo/vector-icons and update once fixed.
Vutukuri15 commented 2025-02-09 20:11:27 -08:00 (Migrated from github.com)
Review

Thanks for the feedback! I'll check local storage or @expo/vector-icons and update once fixed.

Thanks for the feedback! I'll check local storage or @expo/vector-icons and update once fixed.
Vutukuri15 commented 2025-02-09 21:28:07 -08:00 (Migrated from github.com)
Review

I've replaced the external image link with the MaterialIcons from @expo/vector-icons, which addresses both the dependency issue and the rights concern.
Let me know if there's anything else to modify.

I've replaced the external image link with the MaterialIcons from @expo/vector-icons, which addresses both the dependency issue and the rights concern. Let me know if there's anything else to modify.
Vutukuri15 commented 2025-02-09 21:28:07 -08:00 (Migrated from github.com)
Review

I've replaced the external image link with the MaterialIcons from @expo/vector-icons, which addresses both the dependency issue and the rights concern.
Let me know if there's anything else to modify.

I've replaced the external image link with the MaterialIcons from @expo/vector-icons, which addresses both the dependency issue and the rights concern. Let me know if there's anything else to modify.
const handleBuyInSelection = (amount: number) => { const handleBuyInSelection = (amount: number) => {
setBuyInAmountState(amount); setBuyInAmountState(amount);
setCustomAmount(""); setCustomAmount("");
setBuyInAmount(amount); // Pass it back to parent component setBuyInAmount(amount);
djwesty commented 2025-02-09 19:35:52 -08:00 (Migrated from github.com)
Review

I have a couple concerns with hardcoding this reference here.

  • The link is a dependency of our app. If it breaks one day or the user has no network, could be a bad experience
  • Though you may know its ok, I'm not sure if we have the rights to use this for our app.

One approach would be to save and render the image locally in our app. This solves point 1
Another approach would be to use some public icons, like @expo/vector-icons. If there is a good match, that addresses point 1 and 2.

This should be fixed, but up to you on your approach. You can resolve this thread when done

I have a couple concerns with hardcoding this reference here. * The link is a dependency of our app. If it breaks one day or the user has no network, could be a bad experience * Though you may know its ok, I'm not sure if we have the rights to use this for our app. One approach would be to save and render the image locally in our app. This solves point 1 Another approach would be to use some public icons, like [@expo/vector-icons](https://icons.expo.fyi/Index). If there is a good match, that addresses point 1 and 2. This should be fixed, but up to you on your approach. You can resolve this thread when done
Vutukuri15 commented 2025-02-09 20:11:27 -08:00 (Migrated from github.com)
Review

Thanks for the feedback! I'll check local storage or @expo/vector-icons and update once fixed.

Thanks for the feedback! I'll check local storage or @expo/vector-icons and update once fixed.
Vutukuri15 commented 2025-02-09 21:28:07 -08:00 (Migrated from github.com)
Review

I've replaced the external image link with the MaterialIcons from @expo/vector-icons, which addresses both the dependency issue and the rights concern.
Let me know if there's anything else to modify.

I've replaced the external image link with the MaterialIcons from @expo/vector-icons, which addresses both the dependency issue and the rights concern. Let me know if there's anything else to modify.
djwesty commented 2025-02-09 19:35:52 -08:00 (Migrated from github.com)
Review

I have a couple concerns with hardcoding this reference here.

  • The link is a dependency of our app. If it breaks one day or the user has no network, could be a bad experience
  • Though you may know its ok, I'm not sure if we have the rights to use this for our app.

One approach would be to save and render the image locally in our app. This solves point 1
Another approach would be to use some public icons, like @expo/vector-icons. If there is a good match, that addresses point 1 and 2.

This should be fixed, but up to you on your approach. You can resolve this thread when done

I have a couple concerns with hardcoding this reference here. * The link is a dependency of our app. If it breaks one day or the user has no network, could be a bad experience * Though you may know its ok, I'm not sure if we have the rights to use this for our app. One approach would be to save and render the image locally in our app. This solves point 1 Another approach would be to use some public icons, like [@expo/vector-icons](https://icons.expo.fyi/Index). If there is a good match, that addresses point 1 and 2. This should be fixed, but up to you on your approach. You can resolve this thread when done
Vutukuri15 commented 2025-02-09 20:11:27 -08:00 (Migrated from github.com)
Review

Thanks for the feedback! I'll check local storage or @expo/vector-icons and update once fixed.

Thanks for the feedback! I'll check local storage or @expo/vector-icons and update once fixed.
Vutukuri15 commented 2025-02-09 21:28:07 -08:00 (Migrated from github.com)
Review

I've replaced the external image link with the MaterialIcons from @expo/vector-icons, which addresses both the dependency issue and the rights concern.
Let me know if there's anything else to modify.

I've replaced the external image link with the MaterialIcons from @expo/vector-icons, which addresses both the dependency issue and the rights concern. Let me know if there's anything else to modify.
}; };
return ( return (
<View style={styles.container}> <View style={styles.container}>
{/* Title with Money Icon */}
djwesty commented 2025-02-09 19:35:52 -08:00 (Migrated from github.com)
Review

I have a couple concerns with hardcoding this reference here.

  • The link is a dependency of our app. If it breaks one day or the user has no network, could be a bad experience
  • Though you may know its ok, I'm not sure if we have the rights to use this for our app.

One approach would be to save and render the image locally in our app. This solves point 1
Another approach would be to use some public icons, like @expo/vector-icons. If there is a good match, that addresses point 1 and 2.

This should be fixed, but up to you on your approach. You can resolve this thread when done

I have a couple concerns with hardcoding this reference here. * The link is a dependency of our app. If it breaks one day or the user has no network, could be a bad experience * Though you may know its ok, I'm not sure if we have the rights to use this for our app. One approach would be to save and render the image locally in our app. This solves point 1 Another approach would be to use some public icons, like [@expo/vector-icons](https://icons.expo.fyi/Index). If there is a good match, that addresses point 1 and 2. This should be fixed, but up to you on your approach. You can resolve this thread when done
Vutukuri15 commented 2025-02-09 20:11:27 -08:00 (Migrated from github.com)
Review

Thanks for the feedback! I'll check local storage or @expo/vector-icons and update once fixed.

Thanks for the feedback! I'll check local storage or @expo/vector-icons and update once fixed.
Vutukuri15 commented 2025-02-09 21:28:07 -08:00 (Migrated from github.com)
Review

I've replaced the external image link with the MaterialIcons from @expo/vector-icons, which addresses both the dependency issue and the rights concern.
Let me know if there's anything else to modify.

I've replaced the external image link with the MaterialIcons from @expo/vector-icons, which addresses both the dependency issue and the rights concern. Let me know if there's anything else to modify.
<View style={styles.header}> <View style={styles.header}>
<Image <MaterialIcons name="monetization-on" size={30} color="green" />
djwesty commented 2025-02-09 19:35:52 -08:00 (Migrated from github.com)
Review

I have a couple concerns with hardcoding this reference here.

  • The link is a dependency of our app. If it breaks one day or the user has no network, could be a bad experience
  • Though you may know its ok, I'm not sure if we have the rights to use this for our app.

One approach would be to save and render the image locally in our app. This solves point 1
Another approach would be to use some public icons, like @expo/vector-icons. If there is a good match, that addresses point 1 and 2.

This should be fixed, but up to you on your approach. You can resolve this thread when done

I have a couple concerns with hardcoding this reference here. * The link is a dependency of our app. If it breaks one day or the user has no network, could be a bad experience * Though you may know its ok, I'm not sure if we have the rights to use this for our app. One approach would be to save and render the image locally in our app. This solves point 1 Another approach would be to use some public icons, like [@expo/vector-icons](https://icons.expo.fyi/Index). If there is a good match, that addresses point 1 and 2. This should be fixed, but up to you on your approach. You can resolve this thread when done
Vutukuri15 commented 2025-02-09 20:11:27 -08:00 (Migrated from github.com)
Review

Thanks for the feedback! I'll check local storage or @expo/vector-icons and update once fixed.

Thanks for the feedback! I'll check local storage or @expo/vector-icons and update once fixed.
Vutukuri15 commented 2025-02-09 21:28:07 -08:00 (Migrated from github.com)
Review

I've replaced the external image link with the MaterialIcons from @expo/vector-icons, which addresses both the dependency issue and the rights concern.
Let me know if there's anything else to modify.

I've replaced the external image link with the MaterialIcons from @expo/vector-icons, which addresses both the dependency issue and the rights concern. Let me know if there's anything else to modify.
djwesty commented 2025-02-09 19:35:52 -08:00 (Migrated from github.com)
Review

I have a couple concerns with hardcoding this reference here.

  • The link is a dependency of our app. If it breaks one day or the user has no network, could be a bad experience
  • Though you may know its ok, I'm not sure if we have the rights to use this for our app.

One approach would be to save and render the image locally in our app. This solves point 1
Another approach would be to use some public icons, like @expo/vector-icons. If there is a good match, that addresses point 1 and 2.

This should be fixed, but up to you on your approach. You can resolve this thread when done

I have a couple concerns with hardcoding this reference here. * The link is a dependency of our app. If it breaks one day or the user has no network, could be a bad experience * Though you may know its ok, I'm not sure if we have the rights to use this for our app. One approach would be to save and render the image locally in our app. This solves point 1 Another approach would be to use some public icons, like [@expo/vector-icons](https://icons.expo.fyi/Index). If there is a good match, that addresses point 1 and 2. This should be fixed, but up to you on your approach. You can resolve this thread when done
Vutukuri15 commented 2025-02-09 20:11:27 -08:00 (Migrated from github.com)
Review

Thanks for the feedback! I'll check local storage or @expo/vector-icons and update once fixed.

Thanks for the feedback! I'll check local storage or @expo/vector-icons and update once fixed.
Vutukuri15 commented 2025-02-09 21:28:07 -08:00 (Migrated from github.com)
Review

I've replaced the external image link with the MaterialIcons from @expo/vector-icons, which addresses both the dependency issue and the rights concern.
Let me know if there's anything else to modify.

I've replaced the external image link with the MaterialIcons from @expo/vector-icons, which addresses both the dependency issue and the rights concern. Let me know if there's anything else to modify.
source={{
djwesty commented 2025-02-09 19:35:52 -08:00 (Migrated from github.com)
Review

I have a couple concerns with hardcoding this reference here.

  • The link is a dependency of our app. If it breaks one day or the user has no network, could be a bad experience
  • Though you may know its ok, I'm not sure if we have the rights to use this for our app.

One approach would be to save and render the image locally in our app. This solves point 1
Another approach would be to use some public icons, like @expo/vector-icons. If there is a good match, that addresses point 1 and 2.

This should be fixed, but up to you on your approach. You can resolve this thread when done

I have a couple concerns with hardcoding this reference here. * The link is a dependency of our app. If it breaks one day or the user has no network, could be a bad experience * Though you may know its ok, I'm not sure if we have the rights to use this for our app. One approach would be to save and render the image locally in our app. This solves point 1 Another approach would be to use some public icons, like [@expo/vector-icons](https://icons.expo.fyi/Index). If there is a good match, that addresses point 1 and 2. This should be fixed, but up to you on your approach. You can resolve this thread when done
Vutukuri15 commented 2025-02-09 20:11:27 -08:00 (Migrated from github.com)
Review

Thanks for the feedback! I'll check local storage or @expo/vector-icons and update once fixed.

Thanks for the feedback! I'll check local storage or @expo/vector-icons and update once fixed.
Vutukuri15 commented 2025-02-09 21:28:07 -08:00 (Migrated from github.com)
Review

I've replaced the external image link with the MaterialIcons from @expo/vector-icons, which addresses both the dependency issue and the rights concern.
Let me know if there's anything else to modify.

I've replaced the external image link with the MaterialIcons from @expo/vector-icons, which addresses both the dependency issue and the rights concern. Let me know if there's anything else to modify.
uri: "https://png.pngtree.com/png-vector/20191128/ourmid/pngtree-coin-money-icon-png-image_2049478.jpg",
djwesty commented 2025-02-09 19:35:52 -08:00 (Migrated from github.com)
Review

I have a couple concerns with hardcoding this reference here.

  • The link is a dependency of our app. If it breaks one day or the user has no network, could be a bad experience
  • Though you may know its ok, I'm not sure if we have the rights to use this for our app.

One approach would be to save and render the image locally in our app. This solves point 1
Another approach would be to use some public icons, like @expo/vector-icons. If there is a good match, that addresses point 1 and 2.

This should be fixed, but up to you on your approach. You can resolve this thread when done

I have a couple concerns with hardcoding this reference here. * The link is a dependency of our app. If it breaks one day or the user has no network, could be a bad experience * Though you may know its ok, I'm not sure if we have the rights to use this for our app. One approach would be to save and render the image locally in our app. This solves point 1 Another approach would be to use some public icons, like [@expo/vector-icons](https://icons.expo.fyi/Index). If there is a good match, that addresses point 1 and 2. This should be fixed, but up to you on your approach. You can resolve this thread when done
Vutukuri15 commented 2025-02-09 20:11:27 -08:00 (Migrated from github.com)
Review

Thanks for the feedback! I'll check local storage or @expo/vector-icons and update once fixed.

Thanks for the feedback! I'll check local storage or @expo/vector-icons and update once fixed.
Vutukuri15 commented 2025-02-09 21:28:07 -08:00 (Migrated from github.com)
Review

I've replaced the external image link with the MaterialIcons from @expo/vector-icons, which addresses both the dependency issue and the rights concern.
Let me know if there's anything else to modify.

I've replaced the external image link with the MaterialIcons from @expo/vector-icons, which addresses both the dependency issue and the rights concern. Let me know if there's anything else to modify.
}}
djwesty commented 2025-02-09 19:35:52 -08:00 (Migrated from github.com)
Review

I have a couple concerns with hardcoding this reference here.

  • The link is a dependency of our app. If it breaks one day or the user has no network, could be a bad experience
  • Though you may know its ok, I'm not sure if we have the rights to use this for our app.

One approach would be to save and render the image locally in our app. This solves point 1
Another approach would be to use some public icons, like @expo/vector-icons. If there is a good match, that addresses point 1 and 2.

This should be fixed, but up to you on your approach. You can resolve this thread when done

I have a couple concerns with hardcoding this reference here. * The link is a dependency of our app. If it breaks one day or the user has no network, could be a bad experience * Though you may know its ok, I'm not sure if we have the rights to use this for our app. One approach would be to save and render the image locally in our app. This solves point 1 Another approach would be to use some public icons, like [@expo/vector-icons](https://icons.expo.fyi/Index). If there is a good match, that addresses point 1 and 2. This should be fixed, but up to you on your approach. You can resolve this thread when done
Vutukuri15 commented 2025-02-09 20:11:27 -08:00 (Migrated from github.com)
Review

Thanks for the feedback! I'll check local storage or @expo/vector-icons and update once fixed.

Thanks for the feedback! I'll check local storage or @expo/vector-icons and update once fixed.
Vutukuri15 commented 2025-02-09 21:28:07 -08:00 (Migrated from github.com)
Review

I've replaced the external image link with the MaterialIcons from @expo/vector-icons, which addresses both the dependency issue and the rights concern.
Let me know if there's anything else to modify.

I've replaced the external image link with the MaterialIcons from @expo/vector-icons, which addresses both the dependency issue and the rights concern. Let me know if there's anything else to modify.
style={styles.icon}
djwesty commented 2025-02-09 19:35:52 -08:00 (Migrated from github.com)
Review

I have a couple concerns with hardcoding this reference here.

  • The link is a dependency of our app. If it breaks one day or the user has no network, could be a bad experience
  • Though you may know its ok, I'm not sure if we have the rights to use this for our app.

One approach would be to save and render the image locally in our app. This solves point 1
Another approach would be to use some public icons, like @expo/vector-icons. If there is a good match, that addresses point 1 and 2.

This should be fixed, but up to you on your approach. You can resolve this thread when done

I have a couple concerns with hardcoding this reference here. * The link is a dependency of our app. If it breaks one day or the user has no network, could be a bad experience * Though you may know its ok, I'm not sure if we have the rights to use this for our app. One approach would be to save and render the image locally in our app. This solves point 1 Another approach would be to use some public icons, like [@expo/vector-icons](https://icons.expo.fyi/Index). If there is a good match, that addresses point 1 and 2. This should be fixed, but up to you on your approach. You can resolve this thread when done
Vutukuri15 commented 2025-02-09 20:11:27 -08:00 (Migrated from github.com)
Review

Thanks for the feedback! I'll check local storage or @expo/vector-icons and update once fixed.

Thanks for the feedback! I'll check local storage or @expo/vector-icons and update once fixed.
Vutukuri15 commented 2025-02-09 21:28:07 -08:00 (Migrated from github.com)
Review

I've replaced the external image link with the MaterialIcons from @expo/vector-icons, which addresses both the dependency issue and the rights concern.
Let me know if there's anything else to modify.

I've replaced the external image link with the MaterialIcons from @expo/vector-icons, which addresses both the dependency issue and the rights concern. Let me know if there's anything else to modify.
/>
djwesty commented 2025-02-09 19:35:52 -08:00 (Migrated from github.com)
Review

I have a couple concerns with hardcoding this reference here.

  • The link is a dependency of our app. If it breaks one day or the user has no network, could be a bad experience
  • Though you may know its ok, I'm not sure if we have the rights to use this for our app.

One approach would be to save and render the image locally in our app. This solves point 1
Another approach would be to use some public icons, like @expo/vector-icons. If there is a good match, that addresses point 1 and 2.

This should be fixed, but up to you on your approach. You can resolve this thread when done

I have a couple concerns with hardcoding this reference here. * The link is a dependency of our app. If it breaks one day or the user has no network, could be a bad experience * Though you may know its ok, I'm not sure if we have the rights to use this for our app. One approach would be to save and render the image locally in our app. This solves point 1 Another approach would be to use some public icons, like [@expo/vector-icons](https://icons.expo.fyi/Index). If there is a good match, that addresses point 1 and 2. This should be fixed, but up to you on your approach. You can resolve this thread when done
Vutukuri15 commented 2025-02-09 20:11:27 -08:00 (Migrated from github.com)
Review

Thanks for the feedback! I'll check local storage or @expo/vector-icons and update once fixed.

Thanks for the feedback! I'll check local storage or @expo/vector-icons and update once fixed.
Vutukuri15 commented 2025-02-09 21:28:07 -08:00 (Migrated from github.com)
Review

I've replaced the external image link with the MaterialIcons from @expo/vector-icons, which addresses both the dependency issue and the rights concern.
Let me know if there's anything else to modify.

I've replaced the external image link with the MaterialIcons from @expo/vector-icons, which addresses both the dependency issue and the rights concern. Let me know if there's anything else to modify.
<Text style={styles.title}>Select Buy-in Amount:</Text> <Text style={styles.title}>Select Buy-in Amount:</Text>
</View> </View>
{/* Default Buy-In Options */}
djwesty commented 2025-02-09 19:35:52 -08:00 (Migrated from github.com)
Review

I have a couple concerns with hardcoding this reference here.

  • The link is a dependency of our app. If it breaks one day or the user has no network, could be a bad experience
  • Though you may know its ok, I'm not sure if we have the rights to use this for our app.

One approach would be to save and render the image locally in our app. This solves point 1
Another approach would be to use some public icons, like @expo/vector-icons. If there is a good match, that addresses point 1 and 2.

This should be fixed, but up to you on your approach. You can resolve this thread when done

I have a couple concerns with hardcoding this reference here. * The link is a dependency of our app. If it breaks one day or the user has no network, could be a bad experience * Though you may know its ok, I'm not sure if we have the rights to use this for our app. One approach would be to save and render the image locally in our app. This solves point 1 Another approach would be to use some public icons, like [@expo/vector-icons](https://icons.expo.fyi/Index). If there is a good match, that addresses point 1 and 2. This should be fixed, but up to you on your approach. You can resolve this thread when done
Vutukuri15 commented 2025-02-09 20:11:27 -08:00 (Migrated from github.com)
Review

Thanks for the feedback! I'll check local storage or @expo/vector-icons and update once fixed.

Thanks for the feedback! I'll check local storage or @expo/vector-icons and update once fixed.
Vutukuri15 commented 2025-02-09 21:28:07 -08:00 (Migrated from github.com)
Review

I've replaced the external image link with the MaterialIcons from @expo/vector-icons, which addresses both the dependency issue and the rights concern.
Let me know if there's anything else to modify.

I've replaced the external image link with the MaterialIcons from @expo/vector-icons, which addresses both the dependency issue and the rights concern. Let me know if there's anything else to modify.
<View style={styles.optionsContainer}> <View style={styles.optionsContainer}>
{defaultBuyInOptions.map((amount) => ( {defaultBuyInOptions.map((amount) => (
<TouchableOpacity <TouchableOpacity
@ -66,7 +59,6 @@ const BuyInSelector: React.FC<BuyInSelectorProps> = ({ setBuyInAmount }) => {
djwesty commented 2025-02-09 19:35:52 -08:00 (Migrated from github.com)
Review

I have a couple concerns with hardcoding this reference here.

  • The link is a dependency of our app. If it breaks one day or the user has no network, could be a bad experience
  • Though you may know its ok, I'm not sure if we have the rights to use this for our app.

One approach would be to save and render the image locally in our app. This solves point 1
Another approach would be to use some public icons, like @expo/vector-icons. If there is a good match, that addresses point 1 and 2.

This should be fixed, but up to you on your approach. You can resolve this thread when done

I have a couple concerns with hardcoding this reference here. * The link is a dependency of our app. If it breaks one day or the user has no network, could be a bad experience * Though you may know its ok, I'm not sure if we have the rights to use this for our app. One approach would be to save and render the image locally in our app. This solves point 1 Another approach would be to use some public icons, like [@expo/vector-icons](https://icons.expo.fyi/Index). If there is a good match, that addresses point 1 and 2. This should be fixed, but up to you on your approach. You can resolve this thread when done
djwesty commented 2025-02-09 19:35:52 -08:00 (Migrated from github.com)
Review

I have a couple concerns with hardcoding this reference here.

  • The link is a dependency of our app. If it breaks one day or the user has no network, could be a bad experience
  • Though you may know its ok, I'm not sure if we have the rights to use this for our app.

One approach would be to save and render the image locally in our app. This solves point 1
Another approach would be to use some public icons, like @expo/vector-icons. If there is a good match, that addresses point 1 and 2.

This should be fixed, but up to you on your approach. You can resolve this thread when done

I have a couple concerns with hardcoding this reference here. * The link is a dependency of our app. If it breaks one day or the user has no network, could be a bad experience * Though you may know its ok, I'm not sure if we have the rights to use this for our app. One approach would be to save and render the image locally in our app. This solves point 1 Another approach would be to use some public icons, like [@expo/vector-icons](https://icons.expo.fyi/Index). If there is a good match, that addresses point 1 and 2. This should be fixed, but up to you on your approach. You can resolve this thread when done
Vutukuri15 commented 2025-02-09 20:11:27 -08:00 (Migrated from github.com)
Review

Thanks for the feedback! I'll check local storage or @expo/vector-icons and update once fixed.

Thanks for the feedback! I'll check local storage or @expo/vector-icons and update once fixed.
Vutukuri15 commented 2025-02-09 20:11:27 -08:00 (Migrated from github.com)
Review

Thanks for the feedback! I'll check local storage or @expo/vector-icons and update once fixed.

Thanks for the feedback! I'll check local storage or @expo/vector-icons and update once fixed.
Vutukuri15 commented 2025-02-09 21:28:07 -08:00 (Migrated from github.com)
Review

I've replaced the external image link with the MaterialIcons from @expo/vector-icons, which addresses both the dependency issue and the rights concern.
Let me know if there's anything else to modify.

I've replaced the external image link with the MaterialIcons from @expo/vector-icons, which addresses both the dependency issue and the rights concern. Let me know if there's anything else to modify.
Vutukuri15 commented 2025-02-09 21:28:07 -08:00 (Migrated from github.com)
Review

I've replaced the external image link with the MaterialIcons from @expo/vector-icons, which addresses both the dependency issue and the rights concern.
Let me know if there's anything else to modify.

I've replaced the external image link with the MaterialIcons from @expo/vector-icons, which addresses both the dependency issue and the rights concern. Let me know if there's anything else to modify.
))} ))}
</View> </View>
{/* Custom Amount Input */}
djwesty commented 2025-02-09 19:35:52 -08:00 (Migrated from github.com)
Review

I have a couple concerns with hardcoding this reference here.

  • The link is a dependency of our app. If it breaks one day or the user has no network, could be a bad experience
  • Though you may know its ok, I'm not sure if we have the rights to use this for our app.

One approach would be to save and render the image locally in our app. This solves point 1
Another approach would be to use some public icons, like @expo/vector-icons. If there is a good match, that addresses point 1 and 2.

This should be fixed, but up to you on your approach. You can resolve this thread when done

I have a couple concerns with hardcoding this reference here. * The link is a dependency of our app. If it breaks one day or the user has no network, could be a bad experience * Though you may know its ok, I'm not sure if we have the rights to use this for our app. One approach would be to save and render the image locally in our app. This solves point 1 Another approach would be to use some public icons, like [@expo/vector-icons](https://icons.expo.fyi/Index). If there is a good match, that addresses point 1 and 2. This should be fixed, but up to you on your approach. You can resolve this thread when done
Vutukuri15 commented 2025-02-09 20:11:27 -08:00 (Migrated from github.com)
Review

Thanks for the feedback! I'll check local storage or @expo/vector-icons and update once fixed.

Thanks for the feedback! I'll check local storage or @expo/vector-icons and update once fixed.
Vutukuri15 commented 2025-02-09 21:28:07 -08:00 (Migrated from github.com)
Review

I've replaced the external image link with the MaterialIcons from @expo/vector-icons, which addresses both the dependency issue and the rights concern.
Let me know if there's anything else to modify.

I've replaced the external image link with the MaterialIcons from @expo/vector-icons, which addresses both the dependency issue and the rights concern. Let me know if there's anything else to modify.
<Text style={styles.orText}>Or enter a custom amount:</Text> <Text style={styles.orText}>Or enter a custom amount:</Text>
<TextInput <TextInput
style={styles.input} style={styles.input}
@ -76,7 +68,6 @@ const BuyInSelector: React.FC<BuyInSelectorProps> = ({ setBuyInAmount }) => {
djwesty commented 2025-02-09 19:35:52 -08:00 (Migrated from github.com)
Review

I have a couple concerns with hardcoding this reference here.

  • The link is a dependency of our app. If it breaks one day or the user has no network, could be a bad experience
  • Though you may know its ok, I'm not sure if we have the rights to use this for our app.

One approach would be to save and render the image locally in our app. This solves point 1
Another approach would be to use some public icons, like @expo/vector-icons. If there is a good match, that addresses point 1 and 2.

This should be fixed, but up to you on your approach. You can resolve this thread when done

I have a couple concerns with hardcoding this reference here. * The link is a dependency of our app. If it breaks one day or the user has no network, could be a bad experience * Though you may know its ok, I'm not sure if we have the rights to use this for our app. One approach would be to save and render the image locally in our app. This solves point 1 Another approach would be to use some public icons, like [@expo/vector-icons](https://icons.expo.fyi/Index). If there is a good match, that addresses point 1 and 2. This should be fixed, but up to you on your approach. You can resolve this thread when done
djwesty commented 2025-02-09 19:35:52 -08:00 (Migrated from github.com)
Review

I have a couple concerns with hardcoding this reference here.

  • The link is a dependency of our app. If it breaks one day or the user has no network, could be a bad experience
  • Though you may know its ok, I'm not sure if we have the rights to use this for our app.

One approach would be to save and render the image locally in our app. This solves point 1
Another approach would be to use some public icons, like @expo/vector-icons. If there is a good match, that addresses point 1 and 2.

This should be fixed, but up to you on your approach. You can resolve this thread when done

I have a couple concerns with hardcoding this reference here. * The link is a dependency of our app. If it breaks one day or the user has no network, could be a bad experience * Though you may know its ok, I'm not sure if we have the rights to use this for our app. One approach would be to save and render the image locally in our app. This solves point 1 Another approach would be to use some public icons, like [@expo/vector-icons](https://icons.expo.fyi/Index). If there is a good match, that addresses point 1 and 2. This should be fixed, but up to you on your approach. You can resolve this thread when done
Vutukuri15 commented 2025-02-09 20:11:27 -08:00 (Migrated from github.com)
Review

Thanks for the feedback! I'll check local storage or @expo/vector-icons and update once fixed.

Thanks for the feedback! I'll check local storage or @expo/vector-icons and update once fixed.
Vutukuri15 commented 2025-02-09 20:11:27 -08:00 (Migrated from github.com)
Review

Thanks for the feedback! I'll check local storage or @expo/vector-icons and update once fixed.

Thanks for the feedback! I'll check local storage or @expo/vector-icons and update once fixed.
Vutukuri15 commented 2025-02-09 21:28:07 -08:00 (Migrated from github.com)
Review

I've replaced the external image link with the MaterialIcons from @expo/vector-icons, which addresses both the dependency issue and the rights concern.
Let me know if there's anything else to modify.

I've replaced the external image link with the MaterialIcons from @expo/vector-icons, which addresses both the dependency issue and the rights concern. Let me know if there's anything else to modify.
Vutukuri15 commented 2025-02-09 21:28:07 -08:00 (Migrated from github.com)
Review

I've replaced the external image link with the MaterialIcons from @expo/vector-icons, which addresses both the dependency issue and the rights concern.
Let me know if there's anything else to modify.

I've replaced the external image link with the MaterialIcons from @expo/vector-icons, which addresses both the dependency issue and the rights concern. Let me know if there's anything else to modify.
keyboardType="numeric" keyboardType="numeric"
/> />
{/* Display the selected buy-in amount */}
djwesty commented 2025-02-09 19:35:52 -08:00 (Migrated from github.com)
Review

I have a couple concerns with hardcoding this reference here.

  • The link is a dependency of our app. If it breaks one day or the user has no network, could be a bad experience
  • Though you may know its ok, I'm not sure if we have the rights to use this for our app.

One approach would be to save and render the image locally in our app. This solves point 1
Another approach would be to use some public icons, like @expo/vector-icons. If there is a good match, that addresses point 1 and 2.

This should be fixed, but up to you on your approach. You can resolve this thread when done

I have a couple concerns with hardcoding this reference here. * The link is a dependency of our app. If it breaks one day or the user has no network, could be a bad experience * Though you may know its ok, I'm not sure if we have the rights to use this for our app. One approach would be to save and render the image locally in our app. This solves point 1 Another approach would be to use some public icons, like [@expo/vector-icons](https://icons.expo.fyi/Index). If there is a good match, that addresses point 1 and 2. This should be fixed, but up to you on your approach. You can resolve this thread when done
Vutukuri15 commented 2025-02-09 20:11:27 -08:00 (Migrated from github.com)
Review

Thanks for the feedback! I'll check local storage or @expo/vector-icons and update once fixed.

Thanks for the feedback! I'll check local storage or @expo/vector-icons and update once fixed.
Vutukuri15 commented 2025-02-09 21:28:07 -08:00 (Migrated from github.com)
Review

I've replaced the external image link with the MaterialIcons from @expo/vector-icons, which addresses both the dependency issue and the rights concern.
Let me know if there's anything else to modify.

I've replaced the external image link with the MaterialIcons from @expo/vector-icons, which addresses both the dependency issue and the rights concern. Let me know if there's anything else to modify.
<Text style={styles.selectionText}> <Text style={styles.selectionText}>
Selected Buy-in: {buyInAmount !== null ? buyInAmount : "None"} Selected Buy-in: {buyInAmount !== null ? buyInAmount : "None"}
</Text> </Text>
@ -93,13 +84,9 @@ const styles = StyleSheet.create({
djwesty commented 2025-02-09 19:35:52 -08:00 (Migrated from github.com)
Review

I have a couple concerns with hardcoding this reference here.

  • The link is a dependency of our app. If it breaks one day or the user has no network, could be a bad experience
  • Though you may know its ok, I'm not sure if we have the rights to use this for our app.

One approach would be to save and render the image locally in our app. This solves point 1
Another approach would be to use some public icons, like @expo/vector-icons. If there is a good match, that addresses point 1 and 2.

This should be fixed, but up to you on your approach. You can resolve this thread when done

I have a couple concerns with hardcoding this reference here. * The link is a dependency of our app. If it breaks one day or the user has no network, could be a bad experience * Though you may know its ok, I'm not sure if we have the rights to use this for our app. One approach would be to save and render the image locally in our app. This solves point 1 Another approach would be to use some public icons, like [@expo/vector-icons](https://icons.expo.fyi/Index). If there is a good match, that addresses point 1 and 2. This should be fixed, but up to you on your approach. You can resolve this thread when done
djwesty commented 2025-02-09 19:35:52 -08:00 (Migrated from github.com)
Review

I have a couple concerns with hardcoding this reference here.

  • The link is a dependency of our app. If it breaks one day or the user has no network, could be a bad experience
  • Though you may know its ok, I'm not sure if we have the rights to use this for our app.

One approach would be to save and render the image locally in our app. This solves point 1
Another approach would be to use some public icons, like @expo/vector-icons. If there is a good match, that addresses point 1 and 2.

This should be fixed, but up to you on your approach. You can resolve this thread when done

I have a couple concerns with hardcoding this reference here. * The link is a dependency of our app. If it breaks one day or the user has no network, could be a bad experience * Though you may know its ok, I'm not sure if we have the rights to use this for our app. One approach would be to save and render the image locally in our app. This solves point 1 Another approach would be to use some public icons, like [@expo/vector-icons](https://icons.expo.fyi/Index). If there is a good match, that addresses point 1 and 2. This should be fixed, but up to you on your approach. You can resolve this thread when done
Vutukuri15 commented 2025-02-09 20:11:27 -08:00 (Migrated from github.com)
Review

Thanks for the feedback! I'll check local storage or @expo/vector-icons and update once fixed.

Thanks for the feedback! I'll check local storage or @expo/vector-icons and update once fixed.
Vutukuri15 commented 2025-02-09 20:11:27 -08:00 (Migrated from github.com)
Review

Thanks for the feedback! I'll check local storage or @expo/vector-icons and update once fixed.

Thanks for the feedback! I'll check local storage or @expo/vector-icons and update once fixed.
Vutukuri15 commented 2025-02-09 21:28:07 -08:00 (Migrated from github.com)
Review

I've replaced the external image link with the MaterialIcons from @expo/vector-icons, which addresses both the dependency issue and the rights concern.
Let me know if there's anything else to modify.

I've replaced the external image link with the MaterialIcons from @expo/vector-icons, which addresses both the dependency issue and the rights concern. Let me know if there's anything else to modify.
Vutukuri15 commented 2025-02-09 21:28:07 -08:00 (Migrated from github.com)
Review

I've replaced the external image link with the MaterialIcons from @expo/vector-icons, which addresses both the dependency issue and the rights concern.
Let me know if there's anything else to modify.

I've replaced the external image link with the MaterialIcons from @expo/vector-icons, which addresses both the dependency issue and the rights concern. Let me know if there's anything else to modify.
alignItems: "center", alignItems: "center",
marginBottom: 10, marginBottom: 10,
}, },
icon: {
djwesty commented 2025-02-09 19:35:52 -08:00 (Migrated from github.com)
Review

I have a couple concerns with hardcoding this reference here.

  • The link is a dependency of our app. If it breaks one day or the user has no network, could be a bad experience
  • Though you may know its ok, I'm not sure if we have the rights to use this for our app.

One approach would be to save and render the image locally in our app. This solves point 1
Another approach would be to use some public icons, like @expo/vector-icons. If there is a good match, that addresses point 1 and 2.

This should be fixed, but up to you on your approach. You can resolve this thread when done

I have a couple concerns with hardcoding this reference here. * The link is a dependency of our app. If it breaks one day or the user has no network, could be a bad experience * Though you may know its ok, I'm not sure if we have the rights to use this for our app. One approach would be to save and render the image locally in our app. This solves point 1 Another approach would be to use some public icons, like [@expo/vector-icons](https://icons.expo.fyi/Index). If there is a good match, that addresses point 1 and 2. This should be fixed, but up to you on your approach. You can resolve this thread when done
Vutukuri15 commented 2025-02-09 20:11:27 -08:00 (Migrated from github.com)
Review

Thanks for the feedback! I'll check local storage or @expo/vector-icons and update once fixed.

Thanks for the feedback! I'll check local storage or @expo/vector-icons and update once fixed.
Vutukuri15 commented 2025-02-09 21:28:07 -08:00 (Migrated from github.com)
Review

I've replaced the external image link with the MaterialIcons from @expo/vector-icons, which addresses both the dependency issue and the rights concern.
Let me know if there's anything else to modify.

I've replaced the external image link with the MaterialIcons from @expo/vector-icons, which addresses both the dependency issue and the rights concern. Let me know if there's anything else to modify.
width: 50,
djwesty commented 2025-02-09 19:35:52 -08:00 (Migrated from github.com)
Review

I have a couple concerns with hardcoding this reference here.

  • The link is a dependency of our app. If it breaks one day or the user has no network, could be a bad experience
  • Though you may know its ok, I'm not sure if we have the rights to use this for our app.

One approach would be to save and render the image locally in our app. This solves point 1
Another approach would be to use some public icons, like @expo/vector-icons. If there is a good match, that addresses point 1 and 2.

This should be fixed, but up to you on your approach. You can resolve this thread when done

I have a couple concerns with hardcoding this reference here. * The link is a dependency of our app. If it breaks one day or the user has no network, could be a bad experience * Though you may know its ok, I'm not sure if we have the rights to use this for our app. One approach would be to save and render the image locally in our app. This solves point 1 Another approach would be to use some public icons, like [@expo/vector-icons](https://icons.expo.fyi/Index). If there is a good match, that addresses point 1 and 2. This should be fixed, but up to you on your approach. You can resolve this thread when done
Vutukuri15 commented 2025-02-09 20:11:27 -08:00 (Migrated from github.com)
Review

Thanks for the feedback! I'll check local storage or @expo/vector-icons and update once fixed.

Thanks for the feedback! I'll check local storage or @expo/vector-icons and update once fixed.
Vutukuri15 commented 2025-02-09 21:28:07 -08:00 (Migrated from github.com)
Review

I've replaced the external image link with the MaterialIcons from @expo/vector-icons, which addresses both the dependency issue and the rights concern.
Let me know if there's anything else to modify.

I've replaced the external image link with the MaterialIcons from @expo/vector-icons, which addresses both the dependency issue and the rights concern. Let me know if there's anything else to modify.
height: 50,
djwesty commented 2025-02-09 19:35:52 -08:00 (Migrated from github.com)
Review

I have a couple concerns with hardcoding this reference here.

  • The link is a dependency of our app. If it breaks one day or the user has no network, could be a bad experience
  • Though you may know its ok, I'm not sure if we have the rights to use this for our app.

One approach would be to save and render the image locally in our app. This solves point 1
Another approach would be to use some public icons, like @expo/vector-icons. If there is a good match, that addresses point 1 and 2.

This should be fixed, but up to you on your approach. You can resolve this thread when done

I have a couple concerns with hardcoding this reference here. * The link is a dependency of our app. If it breaks one day or the user has no network, could be a bad experience * Though you may know its ok, I'm not sure if we have the rights to use this for our app. One approach would be to save and render the image locally in our app. This solves point 1 Another approach would be to use some public icons, like [@expo/vector-icons](https://icons.expo.fyi/Index). If there is a good match, that addresses point 1 and 2. This should be fixed, but up to you on your approach. You can resolve this thread when done
Vutukuri15 commented 2025-02-09 20:11:27 -08:00 (Migrated from github.com)
Review

Thanks for the feedback! I'll check local storage or @expo/vector-icons and update once fixed.

Thanks for the feedback! I'll check local storage or @expo/vector-icons and update once fixed.
Vutukuri15 commented 2025-02-09 21:28:07 -08:00 (Migrated from github.com)
Review

I've replaced the external image link with the MaterialIcons from @expo/vector-icons, which addresses both the dependency issue and the rights concern.
Let me know if there's anything else to modify.

I've replaced the external image link with the MaterialIcons from @expo/vector-icons, which addresses both the dependency issue and the rights concern. Let me know if there's anything else to modify.
marginRight: 15,
djwesty commented 2025-02-09 19:35:52 -08:00 (Migrated from github.com)
Review

I have a couple concerns with hardcoding this reference here.

  • The link is a dependency of our app. If it breaks one day or the user has no network, could be a bad experience
  • Though you may know its ok, I'm not sure if we have the rights to use this for our app.

One approach would be to save and render the image locally in our app. This solves point 1
Another approach would be to use some public icons, like @expo/vector-icons. If there is a good match, that addresses point 1 and 2.

This should be fixed, but up to you on your approach. You can resolve this thread when done

I have a couple concerns with hardcoding this reference here. * The link is a dependency of our app. If it breaks one day or the user has no network, could be a bad experience * Though you may know its ok, I'm not sure if we have the rights to use this for our app. One approach would be to save and render the image locally in our app. This solves point 1 Another approach would be to use some public icons, like [@expo/vector-icons](https://icons.expo.fyi/Index). If there is a good match, that addresses point 1 and 2. This should be fixed, but up to you on your approach. You can resolve this thread when done
Vutukuri15 commented 2025-02-09 20:11:27 -08:00 (Migrated from github.com)
Review

Thanks for the feedback! I'll check local storage or @expo/vector-icons and update once fixed.

Thanks for the feedback! I'll check local storage or @expo/vector-icons and update once fixed.
Vutukuri15 commented 2025-02-09 21:28:07 -08:00 (Migrated from github.com)
Review

I've replaced the external image link with the MaterialIcons from @expo/vector-icons, which addresses both the dependency issue and the rights concern.
Let me know if there's anything else to modify.

I've replaced the external image link with the MaterialIcons from @expo/vector-icons, which addresses both the dependency issue and the rights concern. Let me know if there's anything else to modify.
},
djwesty commented 2025-02-09 19:35:52 -08:00 (Migrated from github.com)
Review

I have a couple concerns with hardcoding this reference here.

  • The link is a dependency of our app. If it breaks one day or the user has no network, could be a bad experience
  • Though you may know its ok, I'm not sure if we have the rights to use this for our app.

One approach would be to save and render the image locally in our app. This solves point 1
Another approach would be to use some public icons, like @expo/vector-icons. If there is a good match, that addresses point 1 and 2.

This should be fixed, but up to you on your approach. You can resolve this thread when done

I have a couple concerns with hardcoding this reference here. * The link is a dependency of our app. If it breaks one day or the user has no network, could be a bad experience * Though you may know its ok, I'm not sure if we have the rights to use this for our app. One approach would be to save and render the image locally in our app. This solves point 1 Another approach would be to use some public icons, like [@expo/vector-icons](https://icons.expo.fyi/Index). If there is a good match, that addresses point 1 and 2. This should be fixed, but up to you on your approach. You can resolve this thread when done
Vutukuri15 commented 2025-02-09 20:11:27 -08:00 (Migrated from github.com)
Review

Thanks for the feedback! I'll check local storage or @expo/vector-icons and update once fixed.

Thanks for the feedback! I'll check local storage or @expo/vector-icons and update once fixed.
Vutukuri15 commented 2025-02-09 21:28:07 -08:00 (Migrated from github.com)
Review

I've replaced the external image link with the MaterialIcons from @expo/vector-icons, which addresses both the dependency issue and the rights concern.
Let me know if there's anything else to modify.

I've replaced the external image link with the MaterialIcons from @expo/vector-icons, which addresses both the dependency issue and the rights concern. Let me know if there's anything else to modify.
title: { title: {
fontSize: 22, fontSize: 22,
marginLeft: 10,
djwesty commented 2025-02-09 19:35:52 -08:00 (Migrated from github.com)
Review

I have a couple concerns with hardcoding this reference here.

  • The link is a dependency of our app. If it breaks one day or the user has no network, could be a bad experience
  • Though you may know its ok, I'm not sure if we have the rights to use this for our app.

One approach would be to save and render the image locally in our app. This solves point 1
Another approach would be to use some public icons, like @expo/vector-icons. If there is a good match, that addresses point 1 and 2.

This should be fixed, but up to you on your approach. You can resolve this thread when done

I have a couple concerns with hardcoding this reference here. * The link is a dependency of our app. If it breaks one day or the user has no network, could be a bad experience * Though you may know its ok, I'm not sure if we have the rights to use this for our app. One approach would be to save and render the image locally in our app. This solves point 1 Another approach would be to use some public icons, like [@expo/vector-icons](https://icons.expo.fyi/Index). If there is a good match, that addresses point 1 and 2. This should be fixed, but up to you on your approach. You can resolve this thread when done
Vutukuri15 commented 2025-02-09 20:11:27 -08:00 (Migrated from github.com)
Review

Thanks for the feedback! I'll check local storage or @expo/vector-icons and update once fixed.

Thanks for the feedback! I'll check local storage or @expo/vector-icons and update once fixed.
Vutukuri15 commented 2025-02-09 21:28:07 -08:00 (Migrated from github.com)
Review

I've replaced the external image link with the MaterialIcons from @expo/vector-icons, which addresses both the dependency issue and the rights concern.
Let me know if there's anything else to modify.

I've replaced the external image link with the MaterialIcons from @expo/vector-icons, which addresses both the dependency issue and the rights concern. Let me know if there's anything else to modify.
}, },
optionsContainer: { optionsContainer: {
flexDirection: "row", flexDirection: "row",

djwesty commented 2025-02-09 19:35:52 -08:00 (Migrated from github.com)
Review

I have a couple concerns with hardcoding this reference here.

  • The link is a dependency of our app. If it breaks one day or the user has no network, could be a bad experience
  • Though you may know its ok, I'm not sure if we have the rights to use this for our app.

One approach would be to save and render the image locally in our app. This solves point 1
Another approach would be to use some public icons, like @expo/vector-icons. If there is a good match, that addresses point 1 and 2.

This should be fixed, but up to you on your approach. You can resolve this thread when done

I have a couple concerns with hardcoding this reference here. * The link is a dependency of our app. If it breaks one day or the user has no network, could be a bad experience * Though you may know its ok, I'm not sure if we have the rights to use this for our app. One approach would be to save and render the image locally in our app. This solves point 1 Another approach would be to use some public icons, like [@expo/vector-icons](https://icons.expo.fyi/Index). If there is a good match, that addresses point 1 and 2. This should be fixed, but up to you on your approach. You can resolve this thread when done
djwesty commented 2025-02-09 19:35:52 -08:00 (Migrated from github.com)
Review

I have a couple concerns with hardcoding this reference here.

  • The link is a dependency of our app. If it breaks one day or the user has no network, could be a bad experience
  • Though you may know its ok, I'm not sure if we have the rights to use this for our app.

One approach would be to save and render the image locally in our app. This solves point 1
Another approach would be to use some public icons, like @expo/vector-icons. If there is a good match, that addresses point 1 and 2.

This should be fixed, but up to you on your approach. You can resolve this thread when done

I have a couple concerns with hardcoding this reference here. * The link is a dependency of our app. If it breaks one day or the user has no network, could be a bad experience * Though you may know its ok, I'm not sure if we have the rights to use this for our app. One approach would be to save and render the image locally in our app. This solves point 1 Another approach would be to use some public icons, like [@expo/vector-icons](https://icons.expo.fyi/Index). If there is a good match, that addresses point 1 and 2. This should be fixed, but up to you on your approach. You can resolve this thread when done
Vutukuri15 commented 2025-02-09 20:11:27 -08:00 (Migrated from github.com)
Review

Thanks for the feedback! I'll check local storage or @expo/vector-icons and update once fixed.

Thanks for the feedback! I'll check local storage or @expo/vector-icons and update once fixed.
Vutukuri15 commented 2025-02-09 20:11:27 -08:00 (Migrated from github.com)
Review

Thanks for the feedback! I'll check local storage or @expo/vector-icons and update once fixed.

Thanks for the feedback! I'll check local storage or @expo/vector-icons and update once fixed.
Vutukuri15 commented 2025-02-09 21:28:07 -08:00 (Migrated from github.com)
Review

I've replaced the external image link with the MaterialIcons from @expo/vector-icons, which addresses both the dependency issue and the rights concern.
Let me know if there's anything else to modify.

I've replaced the external image link with the MaterialIcons from @expo/vector-icons, which addresses both the dependency issue and the rights concern. Let me know if there's anything else to modify.
Vutukuri15 commented 2025-02-09 21:28:07 -08:00 (Migrated from github.com)
Review

I've replaced the external image link with the MaterialIcons from @expo/vector-icons, which addresses both the dependency issue and the rights concern.
Let me know if there's anything else to modify.

I've replaced the external image link with the MaterialIcons from @expo/vector-icons, which addresses both the dependency issue and the rights concern. Let me know if there's anything else to modify.

View File

@ -2,6 +2,14 @@ import React from "react";
import { fireEvent, render } from "@testing-library/react-native"; import { fireEvent, render } from "@testing-library/react-native";
import BuyInSelector from "@/components/BuyInSelector"; import BuyInSelector from "@/components/BuyInSelector";
jest.mock("@expo/vector-icons", () => {
const React = require("react");
const { Text } = require("react-native");
return {
MaterialIcons: () => <Text>MaterialIcons</Text>,
};
});
describe("BuyInSelector Component", () => { describe("BuyInSelector Component", () => {
it("renders the buy-in options and input correctly", () => { it("renders the buy-in options and input correctly", () => {
const setBuyInAmount = jest.fn(); const setBuyInAmount = jest.fn();
@ -23,6 +31,7 @@ describe("BuyInSelector Component", () => {
); );
fireEvent.press(getByText("25")); fireEvent.press(getByText("25"));
expect(setBuyInAmount).toHaveBeenCalledWith(25); expect(setBuyInAmount).toHaveBeenCalledWith(25);
}); });
@ -33,6 +42,7 @@ describe("BuyInSelector Component", () => {
); );
fireEvent.changeText(getByPlaceholderText("Enter custom buy-in"), "100"); fireEvent.changeText(getByPlaceholderText("Enter custom buy-in"), "100");
expect(setBuyInAmount).toHaveBeenCalledWith(100); expect(setBuyInAmount).toHaveBeenCalledWith(100);
}); });
@ -43,6 +53,7 @@ describe("BuyInSelector Component", () => {
); );
fireEvent.changeText(getByPlaceholderText("Enter custom buy-in"), "-10"); fireEvent.changeText(getByPlaceholderText("Enter custom buy-in"), "-10");
expect(setBuyInAmount).toHaveBeenCalledWith(null); expect(setBuyInAmount).toHaveBeenCalledWith(null);
}); });
@ -53,7 +64,25 @@ describe("BuyInSelector Component", () => {
); );
fireEvent.changeText(getByPlaceholderText("Enter custom buy-in"), "100"); fireEvent.changeText(getByPlaceholderText("Enter custom buy-in"), "100");
fireEvent.press(getByText("50")); fireEvent.press(getByText("50"));
expect(setBuyInAmount).toHaveBeenCalledWith(50); expect(setBuyInAmount).toHaveBeenCalledWith(50);
}); });
it("handles valid and invalid input for custom amount correctly", () => {
const setBuyInAmount = jest.fn();
const { getByPlaceholderText } = render(
<BuyInSelector setBuyInAmount={setBuyInAmount} />
);
fireEvent.changeText(getByPlaceholderText("Enter custom buy-in"), "75");
expect(setBuyInAmount).toHaveBeenCalledWith(75);
fireEvent.changeText(getByPlaceholderText("Enter custom buy-in"), "-5");
expect(setBuyInAmount).toHaveBeenCalledWith(null);
fireEvent.changeText(getByPlaceholderText("Enter custom buy-in"), "abc");
expect(setBuyInAmount).toHaveBeenCalledWith(null);
});
}); });