Ability to save and load calculator states into two slots #37

Merged
MantashaNoyela merged 4 commits from MantashaNoyela/26 into main 2025-02-25 23:28:55 -08:00
5 changed files with 176 additions and 54 deletions
Showing only changes of commit 9952ea3687 - Show all commits

View File

@ -1,53 +1,46 @@
djwesty commented 2025-02-25 21:23:25 -08:00 (Migrated from github.com)
Review

It appears that when resolving the merge conflicts, there may have been some regressions. That is to say, these things were changed and committed before you started work, but then undone here. Things I notice on quick glace

  • This title "Poker chips helper" was removed
  • The default state of buyInAmount near the top was changed to 20 from null

Can you fix these up?

It appears that when resolving the merge conflicts, there may have been some regressions. That is to say, these things were changed and committed before you started work, but then undone here. Things I notice on quick glace - This title "Poker chips helper" was removed - The default state of `buyInAmount` near the top was changed to `20` from `null` Can you fix these up?
djwesty commented 2025-02-25 21:23:25 -08:00 (Migrated from github.com)
Review

It appears that when resolving the merge conflicts, there may have been some regressions. That is to say, these things were changed and committed before you started work, but then undone here. Things I notice on quick glace

  • This title "Poker chips helper" was removed
  • The default state of buyInAmount near the top was changed to 20 from null

Can you fix these up?

It appears that when resolving the merge conflicts, there may have been some regressions. That is to say, these things were changed and committed before you started work, but then undone here. Things I notice on quick glace - This title "Poker chips helper" was removed - The default state of `buyInAmount` near the top was changed to `20` from `null` Can you fix these up?
djwesty commented 2025-02-25 21:26:34 -08:00 (Migrated from github.com)
Review

These buttons at the end are ok and satisfy the issue. In the next sprint, we should explore moving them to the title bar and maybe replacing them with an icon or something similar.

Nothing to do for now, but keep a mental note

These buttons at the end are ok and satisfy the issue. In the next sprint, we should explore moving them to the title bar and maybe replacing them with an icon or something similar. Nothing to do for now, but keep a mental note
djwesty commented 2025-02-25 21:26:34 -08:00 (Migrated from github.com)
Review

These buttons at the end are ok and satisfy the issue. In the next sprint, we should explore moving them to the title bar and maybe replacing them with an icon or something similar.

Nothing to do for now, but keep a mental note

These buttons at the end are ok and satisfy the issue. In the next sprint, we should explore moving them to the title bar and maybe replacing them with an icon or something similar. Nothing to do for now, but keep a mental note
MantashaNoyela commented 2025-02-25 22:03:04 -08:00 (Migrated from github.com)
Review

As I encountered the conflict problem, I removed the folder from my laptop and cloned it again. But I used the code which I had written way before that. May be that's why these problem occured.

As I encountered the conflict problem, I removed the folder from my laptop and cloned it again. But I used the code which I had written way before that. May be that's why these problem occured.
MantashaNoyela commented 2025-02-25 22:03:04 -08:00 (Migrated from github.com)
Review

As I encountered the conflict problem, I removed the folder from my laptop and cloned it again. But I used the code which I had written way before that. May be that's why these problem occured.

As I encountered the conflict problem, I removed the folder from my laptop and cloned it again. But I used the code which I had written way before that. May be that's why these problem occured.
MantashaNoyela commented 2025-02-25 22:04:33 -08:00 (Migrated from github.com)
Review

got it

got it
MantashaNoyela commented 2025-02-25 22:04:33 -08:00 (Migrated from github.com)
Review

got it

got it
MantashaNoyela commented 2025-02-25 22:21:05 -08:00 (Migrated from github.com)
Review

I have changed it

I have changed it
MantashaNoyela commented 2025-02-25 22:21:05 -08:00 (Migrated from github.com)
Review

I have changed it

I have changed it
import React, { useState } from "react"; import React, { useState } from "react";
import { ScrollView, Text, Alert, Button } from "react-native"; import { ScrollView, Text, Alert, Button, View, StyleSheet } from "react-native";
djwesty commented 2025-02-25 21:23:25 -08:00 (Migrated from github.com)
Review

It appears that when resolving the merge conflicts, there may have been some regressions. That is to say, these things were changed and committed before you started work, but then undone here. Things I notice on quick glace

  • This title "Poker chips helper" was removed
  • The default state of buyInAmount near the top was changed to 20 from null

Can you fix these up?

It appears that when resolving the merge conflicts, there may have been some regressions. That is to say, these things were changed and committed before you started work, but then undone here. Things I notice on quick glace - This title "Poker chips helper" was removed - The default state of `buyInAmount` near the top was changed to `20` from `null` Can you fix these up?
djwesty commented 2025-02-25 21:26:34 -08:00 (Migrated from github.com)
Review

These buttons at the end are ok and satisfy the issue. In the next sprint, we should explore moving them to the title bar and maybe replacing them with an icon or something similar.

Nothing to do for now, but keep a mental note

These buttons at the end are ok and satisfy the issue. In the next sprint, we should explore moving them to the title bar and maybe replacing them with an icon or something similar. Nothing to do for now, but keep a mental note
MantashaNoyela commented 2025-02-25 22:03:04 -08:00 (Migrated from github.com)
Review

As I encountered the conflict problem, I removed the folder from my laptop and cloned it again. But I used the code which I had written way before that. May be that's why these problem occured.

As I encountered the conflict problem, I removed the folder from my laptop and cloned it again. But I used the code which I had written way before that. May be that's why these problem occured.
MantashaNoyela commented 2025-02-25 22:04:33 -08:00 (Migrated from github.com)
Review

got it

got it
MantashaNoyela commented 2025-02-25 22:21:05 -08:00 (Migrated from github.com)
Review

I have changed it

I have changed it
djwesty commented 2025-02-25 21:23:25 -08:00 (Migrated from github.com)
Review

It appears that when resolving the merge conflicts, there may have been some regressions. That is to say, these things were changed and committed before you started work, but then undone here. Things I notice on quick glace

  • This title "Poker chips helper" was removed
  • The default state of buyInAmount near the top was changed to 20 from null

Can you fix these up?

It appears that when resolving the merge conflicts, there may have been some regressions. That is to say, these things were changed and committed before you started work, but then undone here. Things I notice on quick glace - This title "Poker chips helper" was removed - The default state of `buyInAmount` near the top was changed to `20` from `null` Can you fix these up?
djwesty commented 2025-02-25 21:26:34 -08:00 (Migrated from github.com)
Review

These buttons at the end are ok and satisfy the issue. In the next sprint, we should explore moving them to the title bar and maybe replacing them with an icon or something similar.

Nothing to do for now, but keep a mental note

These buttons at the end are ok and satisfy the issue. In the next sprint, we should explore moving them to the title bar and maybe replacing them with an icon or something similar. Nothing to do for now, but keep a mental note
MantashaNoyela commented 2025-02-25 22:03:04 -08:00 (Migrated from github.com)
Review

As I encountered the conflict problem, I removed the folder from my laptop and cloned it again. But I used the code which I had written way before that. May be that's why these problem occured.

As I encountered the conflict problem, I removed the folder from my laptop and cloned it again. But I used the code which I had written way before that. May be that's why these problem occured.
MantashaNoyela commented 2025-02-25 22:04:33 -08:00 (Migrated from github.com)
Review

got it

got it
MantashaNoyela commented 2025-02-25 22:21:05 -08:00 (Migrated from github.com)
Review

I have changed it

I have changed it
import PlayerSelector from "@/components/PlayerSelector"; import PlayerSelector from "@/components/PlayerSelector";
import BuyInSelector from "@/components/BuyInSelector"; import BuyInSelector from "@/components/BuyInSelector";
import ChipsSelector from "@/components/ChipsSelector"; import ChipsSelector from "@/components/ChipsSelector";
import ChipDistributionSummary from "@/components/ChipDistributionSummary"; import ChipDistributionSummary from "@/components/ChipDistributionSummary";
import ChipDetection from "@/components/ChipDetection"; import { saveState, loadState } from "../components/CalculatorState";
djwesty commented 2025-02-25 21:23:25 -08:00 (Migrated from github.com)
Review

It appears that when resolving the merge conflicts, there may have been some regressions. That is to say, these things were changed and committed before you started work, but then undone here. Things I notice on quick glace

  • This title "Poker chips helper" was removed
  • The default state of buyInAmount near the top was changed to 20 from null

Can you fix these up?

It appears that when resolving the merge conflicts, there may have been some regressions. That is to say, these things were changed and committed before you started work, but then undone here. Things I notice on quick glace - This title "Poker chips helper" was removed - The default state of `buyInAmount` near the top was changed to `20` from `null` Can you fix these up?
djwesty commented 2025-02-25 21:26:34 -08:00 (Migrated from github.com)
Review

These buttons at the end are ok and satisfy the issue. In the next sprint, we should explore moving them to the title bar and maybe replacing them with an icon or something similar.

Nothing to do for now, but keep a mental note

These buttons at the end are ok and satisfy the issue. In the next sprint, we should explore moving them to the title bar and maybe replacing them with an icon or something similar. Nothing to do for now, but keep a mental note
MantashaNoyela commented 2025-02-25 22:03:04 -08:00 (Migrated from github.com)
Review

As I encountered the conflict problem, I removed the folder from my laptop and cloned it again. But I used the code which I had written way before that. May be that's why these problem occured.

As I encountered the conflict problem, I removed the folder from my laptop and cloned it again. But I used the code which I had written way before that. May be that's why these problem occured.
MantashaNoyela commented 2025-02-25 22:04:33 -08:00 (Migrated from github.com)
Review

got it

got it
MantashaNoyela commented 2025-02-25 22:21:05 -08:00 (Migrated from github.com)
Review

I have changed it

I have changed it
djwesty commented 2025-02-25 21:23:25 -08:00 (Migrated from github.com)
Review

It appears that when resolving the merge conflicts, there may have been some regressions. That is to say, these things were changed and committed before you started work, but then undone here. Things I notice on quick glace

  • This title "Poker chips helper" was removed
  • The default state of buyInAmount near the top was changed to 20 from null

Can you fix these up?

It appears that when resolving the merge conflicts, there may have been some regressions. That is to say, these things were changed and committed before you started work, but then undone here. Things I notice on quick glace - This title "Poker chips helper" was removed - The default state of `buyInAmount` near the top was changed to `20` from `null` Can you fix these up?
djwesty commented 2025-02-25 21:26:34 -08:00 (Migrated from github.com)
Review

These buttons at the end are ok and satisfy the issue. In the next sprint, we should explore moving them to the title bar and maybe replacing them with an icon or something similar.

Nothing to do for now, but keep a mental note

These buttons at the end are ok and satisfy the issue. In the next sprint, we should explore moving them to the title bar and maybe replacing them with an icon or something similar. Nothing to do for now, but keep a mental note
MantashaNoyela commented 2025-02-25 22:03:04 -08:00 (Migrated from github.com)
Review

As I encountered the conflict problem, I removed the folder from my laptop and cloned it again. But I used the code which I had written way before that. May be that's why these problem occured.

As I encountered the conflict problem, I removed the folder from my laptop and cloned it again. But I used the code which I had written way before that. May be that's why these problem occured.
MantashaNoyela commented 2025-02-25 22:04:33 -08:00 (Migrated from github.com)
Review

got it

got it
MantashaNoyela commented 2025-02-25 22:21:05 -08:00 (Migrated from github.com)
Review

I have changed it

I have changed it
export enum COLORS { const IndexScreen = () => {
djwesty commented 2025-02-25 21:23:25 -08:00 (Migrated from github.com)
Review

It appears that when resolving the merge conflicts, there may have been some regressions. That is to say, these things were changed and committed before you started work, but then undone here. Things I notice on quick glace

  • This title "Poker chips helper" was removed
  • The default state of buyInAmount near the top was changed to 20 from null

Can you fix these up?

It appears that when resolving the merge conflicts, there may have been some regressions. That is to say, these things were changed and committed before you started work, but then undone here. Things I notice on quick glace - This title "Poker chips helper" was removed - The default state of `buyInAmount` near the top was changed to `20` from `null` Can you fix these up?
djwesty commented 2025-02-25 21:26:34 -08:00 (Migrated from github.com)
Review

These buttons at the end are ok and satisfy the issue. In the next sprint, we should explore moving them to the title bar and maybe replacing them with an icon or something similar.

Nothing to do for now, but keep a mental note

These buttons at the end are ok and satisfy the issue. In the next sprint, we should explore moving them to the title bar and maybe replacing them with an icon or something similar. Nothing to do for now, but keep a mental note
MantashaNoyela commented 2025-02-25 22:03:04 -08:00 (Migrated from github.com)
Review

As I encountered the conflict problem, I removed the folder from my laptop and cloned it again. But I used the code which I had written way before that. May be that's why these problem occured.

As I encountered the conflict problem, I removed the folder from my laptop and cloned it again. But I used the code which I had written way before that. May be that's why these problem occured.
MantashaNoyela commented 2025-02-25 22:04:33 -08:00 (Migrated from github.com)
Review

got it

got it
MantashaNoyela commented 2025-02-25 22:21:05 -08:00 (Migrated from github.com)
Review

I have changed it

I have changed it
djwesty commented 2025-02-25 21:23:25 -08:00 (Migrated from github.com)
Review

It appears that when resolving the merge conflicts, there may have been some regressions. That is to say, these things were changed and committed before you started work, but then undone here. Things I notice on quick glace

  • This title "Poker chips helper" was removed
  • The default state of buyInAmount near the top was changed to 20 from null

Can you fix these up?

It appears that when resolving the merge conflicts, there may have been some regressions. That is to say, these things were changed and committed before you started work, but then undone here. Things I notice on quick glace - This title "Poker chips helper" was removed - The default state of `buyInAmount` near the top was changed to `20` from `null` Can you fix these up?
djwesty commented 2025-02-25 21:26:34 -08:00 (Migrated from github.com)
Review

These buttons at the end are ok and satisfy the issue. In the next sprint, we should explore moving them to the title bar and maybe replacing them with an icon or something similar.

Nothing to do for now, but keep a mental note

These buttons at the end are ok and satisfy the issue. In the next sprint, we should explore moving them to the title bar and maybe replacing them with an icon or something similar. Nothing to do for now, but keep a mental note
MantashaNoyela commented 2025-02-25 22:03:04 -08:00 (Migrated from github.com)
Review

As I encountered the conflict problem, I removed the folder from my laptop and cloned it again. But I used the code which I had written way before that. May be that's why these problem occured.

As I encountered the conflict problem, I removed the folder from my laptop and cloned it again. But I used the code which I had written way before that. May be that's why these problem occured.
MantashaNoyela commented 2025-02-25 22:04:33 -08:00 (Migrated from github.com)
Review

got it

got it
MantashaNoyela commented 2025-02-25 22:21:05 -08:00 (Migrated from github.com)
Review

I have changed it

I have changed it
"white",
djwesty commented 2025-02-25 21:23:25 -08:00 (Migrated from github.com)
Review

It appears that when resolving the merge conflicts, there may have been some regressions. That is to say, these things were changed and committed before you started work, but then undone here. Things I notice on quick glace

  • This title "Poker chips helper" was removed
  • The default state of buyInAmount near the top was changed to 20 from null

Can you fix these up?

It appears that when resolving the merge conflicts, there may have been some regressions. That is to say, these things were changed and committed before you started work, but then undone here. Things I notice on quick glace - This title "Poker chips helper" was removed - The default state of `buyInAmount` near the top was changed to `20` from `null` Can you fix these up?
djwesty commented 2025-02-25 21:26:34 -08:00 (Migrated from github.com)
Review

These buttons at the end are ok and satisfy the issue. In the next sprint, we should explore moving them to the title bar and maybe replacing them with an icon or something similar.

Nothing to do for now, but keep a mental note

These buttons at the end are ok and satisfy the issue. In the next sprint, we should explore moving them to the title bar and maybe replacing them with an icon or something similar. Nothing to do for now, but keep a mental note
MantashaNoyela commented 2025-02-25 22:03:04 -08:00 (Migrated from github.com)
Review

As I encountered the conflict problem, I removed the folder from my laptop and cloned it again. But I used the code which I had written way before that. May be that's why these problem occured.

As I encountered the conflict problem, I removed the folder from my laptop and cloned it again. But I used the code which I had written way before that. May be that's why these problem occured.
MantashaNoyela commented 2025-02-25 22:04:33 -08:00 (Migrated from github.com)
Review

got it

got it
MantashaNoyela commented 2025-02-25 22:21:05 -08:00 (Migrated from github.com)
Review

I have changed it

I have changed it
"red",
djwesty commented 2025-02-25 21:23:25 -08:00 (Migrated from github.com)
Review

It appears that when resolving the merge conflicts, there may have been some regressions. That is to say, these things were changed and committed before you started work, but then undone here. Things I notice on quick glace

  • This title "Poker chips helper" was removed
  • The default state of buyInAmount near the top was changed to 20 from null

Can you fix these up?

It appears that when resolving the merge conflicts, there may have been some regressions. That is to say, these things were changed and committed before you started work, but then undone here. Things I notice on quick glace - This title "Poker chips helper" was removed - The default state of `buyInAmount` near the top was changed to `20` from `null` Can you fix these up?
djwesty commented 2025-02-25 21:26:34 -08:00 (Migrated from github.com)
Review

These buttons at the end are ok and satisfy the issue. In the next sprint, we should explore moving them to the title bar and maybe replacing them with an icon or something similar.

Nothing to do for now, but keep a mental note

These buttons at the end are ok and satisfy the issue. In the next sprint, we should explore moving them to the title bar and maybe replacing them with an icon or something similar. Nothing to do for now, but keep a mental note
MantashaNoyela commented 2025-02-25 22:03:04 -08:00 (Migrated from github.com)
Review

As I encountered the conflict problem, I removed the folder from my laptop and cloned it again. But I used the code which I had written way before that. May be that's why these problem occured.

As I encountered the conflict problem, I removed the folder from my laptop and cloned it again. But I used the code which I had written way before that. May be that's why these problem occured.
MantashaNoyela commented 2025-02-25 22:04:33 -08:00 (Migrated from github.com)
Review

got it

got it
MantashaNoyela commented 2025-02-25 22:21:05 -08:00 (Migrated from github.com)
Review

I have changed it

I have changed it
"green",
djwesty commented 2025-02-25 21:23:25 -08:00 (Migrated from github.com)
Review

It appears that when resolving the merge conflicts, there may have been some regressions. That is to say, these things were changed and committed before you started work, but then undone here. Things I notice on quick glace

  • This title "Poker chips helper" was removed
  • The default state of buyInAmount near the top was changed to 20 from null

Can you fix these up?

It appears that when resolving the merge conflicts, there may have been some regressions. That is to say, these things were changed and committed before you started work, but then undone here. Things I notice on quick glace - This title "Poker chips helper" was removed - The default state of `buyInAmount` near the top was changed to `20` from `null` Can you fix these up?
djwesty commented 2025-02-25 21:26:34 -08:00 (Migrated from github.com)
Review

These buttons at the end are ok and satisfy the issue. In the next sprint, we should explore moving them to the title bar and maybe replacing them with an icon or something similar.

Nothing to do for now, but keep a mental note

These buttons at the end are ok and satisfy the issue. In the next sprint, we should explore moving them to the title bar and maybe replacing them with an icon or something similar. Nothing to do for now, but keep a mental note
MantashaNoyela commented 2025-02-25 22:03:04 -08:00 (Migrated from github.com)
Review

As I encountered the conflict problem, I removed the folder from my laptop and cloned it again. But I used the code which I had written way before that. May be that's why these problem occured.

As I encountered the conflict problem, I removed the folder from my laptop and cloned it again. But I used the code which I had written way before that. May be that's why these problem occured.
MantashaNoyela commented 2025-02-25 22:04:33 -08:00 (Migrated from github.com)
Review

got it

got it
MantashaNoyela commented 2025-02-25 22:21:05 -08:00 (Migrated from github.com)
Review

I have changed it

I have changed it
"blue",
djwesty commented 2025-02-25 21:23:25 -08:00 (Migrated from github.com)
Review

It appears that when resolving the merge conflicts, there may have been some regressions. That is to say, these things were changed and committed before you started work, but then undone here. Things I notice on quick glace

  • This title "Poker chips helper" was removed
  • The default state of buyInAmount near the top was changed to 20 from null

Can you fix these up?

It appears that when resolving the merge conflicts, there may have been some regressions. That is to say, these things were changed and committed before you started work, but then undone here. Things I notice on quick glace - This title "Poker chips helper" was removed - The default state of `buyInAmount` near the top was changed to `20` from `null` Can you fix these up?
djwesty commented 2025-02-25 21:26:34 -08:00 (Migrated from github.com)
Review

These buttons at the end are ok and satisfy the issue. In the next sprint, we should explore moving them to the title bar and maybe replacing them with an icon or something similar.

Nothing to do for now, but keep a mental note

These buttons at the end are ok and satisfy the issue. In the next sprint, we should explore moving them to the title bar and maybe replacing them with an icon or something similar. Nothing to do for now, but keep a mental note
MantashaNoyela commented 2025-02-25 22:03:04 -08:00 (Migrated from github.com)
Review

As I encountered the conflict problem, I removed the folder from my laptop and cloned it again. But I used the code which I had written way before that. May be that's why these problem occured.

As I encountered the conflict problem, I removed the folder from my laptop and cloned it again. But I used the code which I had written way before that. May be that's why these problem occured.
MantashaNoyela commented 2025-02-25 22:04:33 -08:00 (Migrated from github.com)
Review

got it

got it
MantashaNoyela commented 2025-02-25 22:21:05 -08:00 (Migrated from github.com)
Review

I have changed it

I have changed it
"black",
djwesty commented 2025-02-25 21:23:25 -08:00 (Migrated from github.com)
Review

It appears that when resolving the merge conflicts, there may have been some regressions. That is to say, these things were changed and committed before you started work, but then undone here. Things I notice on quick glace

  • This title "Poker chips helper" was removed
  • The default state of buyInAmount near the top was changed to 20 from null

Can you fix these up?

It appears that when resolving the merge conflicts, there may have been some regressions. That is to say, these things were changed and committed before you started work, but then undone here. Things I notice on quick glace - This title "Poker chips helper" was removed - The default state of `buyInAmount` near the top was changed to `20` from `null` Can you fix these up?
djwesty commented 2025-02-25 21:26:34 -08:00 (Migrated from github.com)
Review

These buttons at the end are ok and satisfy the issue. In the next sprint, we should explore moving them to the title bar and maybe replacing them with an icon or something similar.

Nothing to do for now, but keep a mental note

These buttons at the end are ok and satisfy the issue. In the next sprint, we should explore moving them to the title bar and maybe replacing them with an icon or something similar. Nothing to do for now, but keep a mental note
MantashaNoyela commented 2025-02-25 22:03:04 -08:00 (Migrated from github.com)
Review

As I encountered the conflict problem, I removed the folder from my laptop and cloned it again. But I used the code which I had written way before that. May be that's why these problem occured.

As I encountered the conflict problem, I removed the folder from my laptop and cloned it again. But I used the code which I had written way before that. May be that's why these problem occured.
MantashaNoyela commented 2025-02-25 22:04:33 -08:00 (Migrated from github.com)
Review

got it

got it
MantashaNoyela commented 2025-02-25 22:21:05 -08:00 (Migrated from github.com)
Review

I have changed it

I have changed it
}
djwesty commented 2025-02-25 21:23:25 -08:00 (Migrated from github.com)
Review

It appears that when resolving the merge conflicts, there may have been some regressions. That is to say, these things were changed and committed before you started work, but then undone here. Things I notice on quick glace

  • This title "Poker chips helper" was removed
  • The default state of buyInAmount near the top was changed to 20 from null

Can you fix these up?

It appears that when resolving the merge conflicts, there may have been some regressions. That is to say, these things were changed and committed before you started work, but then undone here. Things I notice on quick glace - This title "Poker chips helper" was removed - The default state of `buyInAmount` near the top was changed to `20` from `null` Can you fix these up?
djwesty commented 2025-02-25 21:26:34 -08:00 (Migrated from github.com)
Review

These buttons at the end are ok and satisfy the issue. In the next sprint, we should explore moving them to the title bar and maybe replacing them with an icon or something similar.

Nothing to do for now, but keep a mental note

These buttons at the end are ok and satisfy the issue. In the next sprint, we should explore moving them to the title bar and maybe replacing them with an icon or something similar. Nothing to do for now, but keep a mental note
MantashaNoyela commented 2025-02-25 22:03:04 -08:00 (Migrated from github.com)
Review

As I encountered the conflict problem, I removed the folder from my laptop and cloned it again. But I used the code which I had written way before that. May be that's why these problem occured.

As I encountered the conflict problem, I removed the folder from my laptop and cloned it again. But I used the code which I had written way before that. May be that's why these problem occured.
MantashaNoyela commented 2025-02-25 22:04:33 -08:00 (Migrated from github.com)
Review

got it

got it
MantashaNoyela commented 2025-02-25 22:21:05 -08:00 (Migrated from github.com)
Review

I have changed it

I have changed it
djwesty commented 2025-02-25 21:23:25 -08:00 (Migrated from github.com)
Review

It appears that when resolving the merge conflicts, there may have been some regressions. That is to say, these things were changed and committed before you started work, but then undone here. Things I notice on quick glace

  • This title "Poker chips helper" was removed
  • The default state of buyInAmount near the top was changed to 20 from null

Can you fix these up?

It appears that when resolving the merge conflicts, there may have been some regressions. That is to say, these things were changed and committed before you started work, but then undone here. Things I notice on quick glace - This title "Poker chips helper" was removed - The default state of `buyInAmount` near the top was changed to `20` from `null` Can you fix these up?
djwesty commented 2025-02-25 21:26:34 -08:00 (Migrated from github.com)
Review

These buttons at the end are ok and satisfy the issue. In the next sprint, we should explore moving them to the title bar and maybe replacing them with an icon or something similar.

Nothing to do for now, but keep a mental note

These buttons at the end are ok and satisfy the issue. In the next sprint, we should explore moving them to the title bar and maybe replacing them with an icon or something similar. Nothing to do for now, but keep a mental note
MantashaNoyela commented 2025-02-25 22:03:04 -08:00 (Migrated from github.com)
Review

As I encountered the conflict problem, I removed the folder from my laptop and cloned it again. But I used the code which I had written way before that. May be that's why these problem occured.

As I encountered the conflict problem, I removed the folder from my laptop and cloned it again. But I used the code which I had written way before that. May be that's why these problem occured.
MantashaNoyela commented 2025-02-25 22:04:33 -08:00 (Migrated from github.com)
Review

got it

got it
MantashaNoyela commented 2025-02-25 22:21:05 -08:00 (Migrated from github.com)
Review

I have changed it

I have changed it
const IndexScreen: React.FC = () => {
djwesty commented 2025-02-25 21:23:25 -08:00 (Migrated from github.com)
Review

It appears that when resolving the merge conflicts, there may have been some regressions. That is to say, these things were changed and committed before you started work, but then undone here. Things I notice on quick glace

  • This title "Poker chips helper" was removed
  • The default state of buyInAmount near the top was changed to 20 from null

Can you fix these up?

It appears that when resolving the merge conflicts, there may have been some regressions. That is to say, these things were changed and committed before you started work, but then undone here. Things I notice on quick glace - This title "Poker chips helper" was removed - The default state of `buyInAmount` near the top was changed to `20` from `null` Can you fix these up?
djwesty commented 2025-02-25 21:26:34 -08:00 (Migrated from github.com)
Review

These buttons at the end are ok and satisfy the issue. In the next sprint, we should explore moving them to the title bar and maybe replacing them with an icon or something similar.

Nothing to do for now, but keep a mental note

These buttons at the end are ok and satisfy the issue. In the next sprint, we should explore moving them to the title bar and maybe replacing them with an icon or something similar. Nothing to do for now, but keep a mental note
MantashaNoyela commented 2025-02-25 22:03:04 -08:00 (Migrated from github.com)
Review

As I encountered the conflict problem, I removed the folder from my laptop and cloned it again. But I used the code which I had written way before that. May be that's why these problem occured.

As I encountered the conflict problem, I removed the folder from my laptop and cloned it again. But I used the code which I had written way before that. May be that's why these problem occured.
MantashaNoyela commented 2025-02-25 22:04:33 -08:00 (Migrated from github.com)
Review

got it

got it
MantashaNoyela commented 2025-02-25 22:21:05 -08:00 (Migrated from github.com)
Review

I have changed it

I have changed it
const [playerCount, setPlayerCount] = useState(2); const [playerCount, setPlayerCount] = useState(2);
const [buyInAmount, setBuyInAmount] = useState<number>(20); const [buyInAmount, setBuyInAmount] = useState<number | null>(null);
djwesty commented 2025-02-25 21:23:25 -08:00 (Migrated from github.com)
Review

It appears that when resolving the merge conflicts, there may have been some regressions. That is to say, these things were changed and committed before you started work, but then undone here. Things I notice on quick glace

  • This title "Poker chips helper" was removed
  • The default state of buyInAmount near the top was changed to 20 from null

Can you fix these up?

It appears that when resolving the merge conflicts, there may have been some regressions. That is to say, these things were changed and committed before you started work, but then undone here. Things I notice on quick glace - This title "Poker chips helper" was removed - The default state of `buyInAmount` near the top was changed to `20` from `null` Can you fix these up?
djwesty commented 2025-02-25 21:26:34 -08:00 (Migrated from github.com)
Review

These buttons at the end are ok and satisfy the issue. In the next sprint, we should explore moving them to the title bar and maybe replacing them with an icon or something similar.

Nothing to do for now, but keep a mental note

These buttons at the end are ok and satisfy the issue. In the next sprint, we should explore moving them to the title bar and maybe replacing them with an icon or something similar. Nothing to do for now, but keep a mental note
MantashaNoyela commented 2025-02-25 22:03:04 -08:00 (Migrated from github.com)
Review

As I encountered the conflict problem, I removed the folder from my laptop and cloned it again. But I used the code which I had written way before that. May be that's why these problem occured.

As I encountered the conflict problem, I removed the folder from my laptop and cloned it again. But I used the code which I had written way before that. May be that's why these problem occured.
MantashaNoyela commented 2025-02-25 22:04:33 -08:00 (Migrated from github.com)
Review

got it

got it
MantashaNoyela commented 2025-02-25 22:21:05 -08:00 (Migrated from github.com)
Review

I have changed it

I have changed it
djwesty commented 2025-02-25 21:23:25 -08:00 (Migrated from github.com)
Review

It appears that when resolving the merge conflicts, there may have been some regressions. That is to say, these things were changed and committed before you started work, but then undone here. Things I notice on quick glace

  • This title "Poker chips helper" was removed
  • The default state of buyInAmount near the top was changed to 20 from null

Can you fix these up?

It appears that when resolving the merge conflicts, there may have been some regressions. That is to say, these things were changed and committed before you started work, but then undone here. Things I notice on quick glace - This title "Poker chips helper" was removed - The default state of `buyInAmount` near the top was changed to `20` from `null` Can you fix these up?
djwesty commented 2025-02-25 21:26:34 -08:00 (Migrated from github.com)
Review

These buttons at the end are ok and satisfy the issue. In the next sprint, we should explore moving them to the title bar and maybe replacing them with an icon or something similar.

Nothing to do for now, but keep a mental note

These buttons at the end are ok and satisfy the issue. In the next sprint, we should explore moving them to the title bar and maybe replacing them with an icon or something similar. Nothing to do for now, but keep a mental note
MantashaNoyela commented 2025-02-25 22:03:04 -08:00 (Migrated from github.com)
Review

As I encountered the conflict problem, I removed the folder from my laptop and cloned it again. But I used the code which I had written way before that. May be that's why these problem occured.

As I encountered the conflict problem, I removed the folder from my laptop and cloned it again. But I used the code which I had written way before that. May be that's why these problem occured.
MantashaNoyela commented 2025-02-25 22:04:33 -08:00 (Migrated from github.com)
Review

got it

got it
MantashaNoyela commented 2025-02-25 22:21:05 -08:00 (Migrated from github.com)
Review

I have changed it

I have changed it
const [numberOfChips, setNumberOfChips] = useState<number>(5); const [numberOfChips, setNumberOfChips] = useState<number>(5);
const [totalChipsCount, setTotalChipsCount] = useState<number[]>([]); const [totalChipsCount, setTotalChipsCount] = useState<number[]>([]);
const handleSave = () => { const handleSave = async (slot: "SLOT1" | "SLOT2") => {
djwesty commented 2025-02-25 21:23:25 -08:00 (Migrated from github.com)
Review

It appears that when resolving the merge conflicts, there may have been some regressions. That is to say, these things were changed and committed before you started work, but then undone here. Things I notice on quick glace

  • This title "Poker chips helper" was removed
  • The default state of buyInAmount near the top was changed to 20 from null

Can you fix these up?

It appears that when resolving the merge conflicts, there may have been some regressions. That is to say, these things were changed and committed before you started work, but then undone here. Things I notice on quick glace - This title "Poker chips helper" was removed - The default state of `buyInAmount` near the top was changed to `20` from `null` Can you fix these up?
djwesty commented 2025-02-25 21:26:34 -08:00 (Migrated from github.com)
Review

These buttons at the end are ok and satisfy the issue. In the next sprint, we should explore moving them to the title bar and maybe replacing them with an icon or something similar.

Nothing to do for now, but keep a mental note

These buttons at the end are ok and satisfy the issue. In the next sprint, we should explore moving them to the title bar and maybe replacing them with an icon or something similar. Nothing to do for now, but keep a mental note
MantashaNoyela commented 2025-02-25 22:03:04 -08:00 (Migrated from github.com)
Review

As I encountered the conflict problem, I removed the folder from my laptop and cloned it again. But I used the code which I had written way before that. May be that's why these problem occured.

As I encountered the conflict problem, I removed the folder from my laptop and cloned it again. But I used the code which I had written way before that. May be that's why these problem occured.
MantashaNoyela commented 2025-02-25 22:04:33 -08:00 (Migrated from github.com)
Review

got it

got it
MantashaNoyela commented 2025-02-25 22:21:05 -08:00 (Migrated from github.com)
Review

I have changed it

I have changed it
djwesty commented 2025-02-25 21:23:25 -08:00 (Migrated from github.com)
Review

It appears that when resolving the merge conflicts, there may have been some regressions. That is to say, these things were changed and committed before you started work, but then undone here. Things I notice on quick glace

  • This title "Poker chips helper" was removed
  • The default state of buyInAmount near the top was changed to 20 from null

Can you fix these up?

It appears that when resolving the merge conflicts, there may have been some regressions. That is to say, these things were changed and committed before you started work, but then undone here. Things I notice on quick glace - This title "Poker chips helper" was removed - The default state of `buyInAmount` near the top was changed to `20` from `null` Can you fix these up?
djwesty commented 2025-02-25 21:26:34 -08:00 (Migrated from github.com)
Review

These buttons at the end are ok and satisfy the issue. In the next sprint, we should explore moving them to the title bar and maybe replacing them with an icon or something similar.

Nothing to do for now, but keep a mental note

These buttons at the end are ok and satisfy the issue. In the next sprint, we should explore moving them to the title bar and maybe replacing them with an icon or something similar. Nothing to do for now, but keep a mental note
MantashaNoyela commented 2025-02-25 22:03:04 -08:00 (Migrated from github.com)
Review

As I encountered the conflict problem, I removed the folder from my laptop and cloned it again. But I used the code which I had written way before that. May be that's why these problem occured.

As I encountered the conflict problem, I removed the folder from my laptop and cloned it again. But I used the code which I had written way before that. May be that's why these problem occured.
MantashaNoyela commented 2025-02-25 22:04:33 -08:00 (Migrated from github.com)
Review

got it

got it
MantashaNoyela commented 2025-02-25 22:21:05 -08:00 (Migrated from github.com)
Review

I have changed it

I have changed it
if (buyInAmount === null) { if (buyInAmount === null) {
Alert.alert("Error", "Please select a valid buy-in amount"); Alert.alert("Error", "Please select a valid buy-in amount");
return;
djwesty commented 2025-02-25 21:23:25 -08:00 (Migrated from github.com)
Review

It appears that when resolving the merge conflicts, there may have been some regressions. That is to say, these things were changed and committed before you started work, but then undone here. Things I notice on quick glace

  • This title "Poker chips helper" was removed
  • The default state of buyInAmount near the top was changed to 20 from null

Can you fix these up?

It appears that when resolving the merge conflicts, there may have been some regressions. That is to say, these things were changed and committed before you started work, but then undone here. Things I notice on quick glace - This title "Poker chips helper" was removed - The default state of `buyInAmount` near the top was changed to `20` from `null` Can you fix these up?
djwesty commented 2025-02-25 21:26:34 -08:00 (Migrated from github.com)
Review

These buttons at the end are ok and satisfy the issue. In the next sprint, we should explore moving them to the title bar and maybe replacing them with an icon or something similar.

Nothing to do for now, but keep a mental note

These buttons at the end are ok and satisfy the issue. In the next sprint, we should explore moving them to the title bar and maybe replacing them with an icon or something similar. Nothing to do for now, but keep a mental note
MantashaNoyela commented 2025-02-25 22:03:04 -08:00 (Migrated from github.com)
Review

As I encountered the conflict problem, I removed the folder from my laptop and cloned it again. But I used the code which I had written way before that. May be that's why these problem occured.

As I encountered the conflict problem, I removed the folder from my laptop and cloned it again. But I used the code which I had written way before that. May be that's why these problem occured.
MantashaNoyela commented 2025-02-25 22:04:33 -08:00 (Migrated from github.com)
Review

got it

got it
MantashaNoyela commented 2025-02-25 22:21:05 -08:00 (Migrated from github.com)
Review

I have changed it

I have changed it
}
djwesty commented 2025-02-25 21:23:25 -08:00 (Migrated from github.com)
Review

It appears that when resolving the merge conflicts, there may have been some regressions. That is to say, these things were changed and committed before you started work, but then undone here. Things I notice on quick glace

  • This title "Poker chips helper" was removed
  • The default state of buyInAmount near the top was changed to 20 from null

Can you fix these up?

It appears that when resolving the merge conflicts, there may have been some regressions. That is to say, these things were changed and committed before you started work, but then undone here. Things I notice on quick glace - This title "Poker chips helper" was removed - The default state of `buyInAmount` near the top was changed to `20` from `null` Can you fix these up?
djwesty commented 2025-02-25 21:26:34 -08:00 (Migrated from github.com)
Review

These buttons at the end are ok and satisfy the issue. In the next sprint, we should explore moving them to the title bar and maybe replacing them with an icon or something similar.

Nothing to do for now, but keep a mental note

These buttons at the end are ok and satisfy the issue. In the next sprint, we should explore moving them to the title bar and maybe replacing them with an icon or something similar. Nothing to do for now, but keep a mental note
MantashaNoyela commented 2025-02-25 22:03:04 -08:00 (Migrated from github.com)
Review

As I encountered the conflict problem, I removed the folder from my laptop and cloned it again. But I used the code which I had written way before that. May be that's why these problem occured.

As I encountered the conflict problem, I removed the folder from my laptop and cloned it again. But I used the code which I had written way before that. May be that's why these problem occured.
MantashaNoyela commented 2025-02-25 22:04:33 -08:00 (Migrated from github.com)
Review

got it

got it
MantashaNoyela commented 2025-02-25 22:21:05 -08:00 (Migrated from github.com)
Review

I have changed it

I have changed it
const state = { playerCount, buyInAmount, numberOfChips, totalChipsCount };
djwesty commented 2025-02-25 21:23:25 -08:00 (Migrated from github.com)
Review

It appears that when resolving the merge conflicts, there may have been some regressions. That is to say, these things were changed and committed before you started work, but then undone here. Things I notice on quick glace

  • This title "Poker chips helper" was removed
  • The default state of buyInAmount near the top was changed to 20 from null

Can you fix these up?

It appears that when resolving the merge conflicts, there may have been some regressions. That is to say, these things were changed and committed before you started work, but then undone here. Things I notice on quick glace - This title "Poker chips helper" was removed - The default state of `buyInAmount` near the top was changed to `20` from `null` Can you fix these up?
djwesty commented 2025-02-25 21:26:34 -08:00 (Migrated from github.com)
Review

These buttons at the end are ok and satisfy the issue. In the next sprint, we should explore moving them to the title bar and maybe replacing them with an icon or something similar.

Nothing to do for now, but keep a mental note

These buttons at the end are ok and satisfy the issue. In the next sprint, we should explore moving them to the title bar and maybe replacing them with an icon or something similar. Nothing to do for now, but keep a mental note
MantashaNoyela commented 2025-02-25 22:03:04 -08:00 (Migrated from github.com)
Review

As I encountered the conflict problem, I removed the folder from my laptop and cloned it again. But I used the code which I had written way before that. May be that's why these problem occured.

As I encountered the conflict problem, I removed the folder from my laptop and cloned it again. But I used the code which I had written way before that. May be that's why these problem occured.
MantashaNoyela commented 2025-02-25 22:04:33 -08:00 (Migrated from github.com)
Review

got it

got it
MantashaNoyela commented 2025-02-25 22:21:05 -08:00 (Migrated from github.com)
Review

I have changed it

I have changed it
const result = await saveState(slot, state);
djwesty commented 2025-02-25 21:23:25 -08:00 (Migrated from github.com)
Review

It appears that when resolving the merge conflicts, there may have been some regressions. That is to say, these things were changed and committed before you started work, but then undone here. Things I notice on quick glace

  • This title "Poker chips helper" was removed
  • The default state of buyInAmount near the top was changed to 20 from null

Can you fix these up?

It appears that when resolving the merge conflicts, there may have been some regressions. That is to say, these things were changed and committed before you started work, but then undone here. Things I notice on quick glace - This title "Poker chips helper" was removed - The default state of `buyInAmount` near the top was changed to `20` from `null` Can you fix these up?
djwesty commented 2025-02-25 21:26:34 -08:00 (Migrated from github.com)
Review

These buttons at the end are ok and satisfy the issue. In the next sprint, we should explore moving them to the title bar and maybe replacing them with an icon or something similar.

Nothing to do for now, but keep a mental note

These buttons at the end are ok and satisfy the issue. In the next sprint, we should explore moving them to the title bar and maybe replacing them with an icon or something similar. Nothing to do for now, but keep a mental note
MantashaNoyela commented 2025-02-25 22:03:04 -08:00 (Migrated from github.com)
Review

As I encountered the conflict problem, I removed the folder from my laptop and cloned it again. But I used the code which I had written way before that. May be that's why these problem occured.

As I encountered the conflict problem, I removed the folder from my laptop and cloned it again. But I used the code which I had written way before that. May be that's why these problem occured.
MantashaNoyela commented 2025-02-25 22:04:33 -08:00 (Migrated from github.com)
Review

got it

got it
MantashaNoyela commented 2025-02-25 22:21:05 -08:00 (Migrated from github.com)
Review

I have changed it

I have changed it
Alert.alert(result.success ? "Success" : "Error", result.message);
djwesty commented 2025-02-25 21:23:25 -08:00 (Migrated from github.com)
Review

It appears that when resolving the merge conflicts, there may have been some regressions. That is to say, these things were changed and committed before you started work, but then undone here. Things I notice on quick glace

  • This title "Poker chips helper" was removed
  • The default state of buyInAmount near the top was changed to 20 from null

Can you fix these up?

It appears that when resolving the merge conflicts, there may have been some regressions. That is to say, these things were changed and committed before you started work, but then undone here. Things I notice on quick glace - This title "Poker chips helper" was removed - The default state of `buyInAmount` near the top was changed to `20` from `null` Can you fix these up?
djwesty commented 2025-02-25 21:26:34 -08:00 (Migrated from github.com)
Review

These buttons at the end are ok and satisfy the issue. In the next sprint, we should explore moving them to the title bar and maybe replacing them with an icon or something similar.

Nothing to do for now, but keep a mental note

These buttons at the end are ok and satisfy the issue. In the next sprint, we should explore moving them to the title bar and maybe replacing them with an icon or something similar. Nothing to do for now, but keep a mental note
MantashaNoyela commented 2025-02-25 22:03:04 -08:00 (Migrated from github.com)
Review

As I encountered the conflict problem, I removed the folder from my laptop and cloned it again. But I used the code which I had written way before that. May be that's why these problem occured.

As I encountered the conflict problem, I removed the folder from my laptop and cloned it again. But I used the code which I had written way before that. May be that's why these problem occured.
MantashaNoyela commented 2025-02-25 22:04:33 -08:00 (Migrated from github.com)
Review

got it

got it
MantashaNoyela commented 2025-02-25 22:21:05 -08:00 (Migrated from github.com)
Review

I have changed it

I have changed it
};
djwesty commented 2025-02-25 21:23:25 -08:00 (Migrated from github.com)
Review

It appears that when resolving the merge conflicts, there may have been some regressions. That is to say, these things were changed and committed before you started work, but then undone here. Things I notice on quick glace

  • This title "Poker chips helper" was removed
  • The default state of buyInAmount near the top was changed to 20 from null

Can you fix these up?

It appears that when resolving the merge conflicts, there may have been some regressions. That is to say, these things were changed and committed before you started work, but then undone here. Things I notice on quick glace - This title "Poker chips helper" was removed - The default state of `buyInAmount` near the top was changed to `20` from `null` Can you fix these up?
djwesty commented 2025-02-25 21:26:34 -08:00 (Migrated from github.com)
Review

These buttons at the end are ok and satisfy the issue. In the next sprint, we should explore moving them to the title bar and maybe replacing them with an icon or something similar.

Nothing to do for now, but keep a mental note

These buttons at the end are ok and satisfy the issue. In the next sprint, we should explore moving them to the title bar and maybe replacing them with an icon or something similar. Nothing to do for now, but keep a mental note
MantashaNoyela commented 2025-02-25 22:03:04 -08:00 (Migrated from github.com)
Review

As I encountered the conflict problem, I removed the folder from my laptop and cloned it again. But I used the code which I had written way before that. May be that's why these problem occured.

As I encountered the conflict problem, I removed the folder from my laptop and cloned it again. But I used the code which I had written way before that. May be that's why these problem occured.
MantashaNoyela commented 2025-02-25 22:04:33 -08:00 (Migrated from github.com)
Review

got it

got it
MantashaNoyela commented 2025-02-25 22:21:05 -08:00 (Migrated from github.com)
Review

I have changed it

I have changed it
djwesty commented 2025-02-25 21:23:25 -08:00 (Migrated from github.com)
Review

It appears that when resolving the merge conflicts, there may have been some regressions. That is to say, these things were changed and committed before you started work, but then undone here. Things I notice on quick glace

  • This title "Poker chips helper" was removed
  • The default state of buyInAmount near the top was changed to 20 from null

Can you fix these up?

It appears that when resolving the merge conflicts, there may have been some regressions. That is to say, these things were changed and committed before you started work, but then undone here. Things I notice on quick glace - This title "Poker chips helper" was removed - The default state of `buyInAmount` near the top was changed to `20` from `null` Can you fix these up?
djwesty commented 2025-02-25 21:26:34 -08:00 (Migrated from github.com)
Review

These buttons at the end are ok and satisfy the issue. In the next sprint, we should explore moving them to the title bar and maybe replacing them with an icon or something similar.

Nothing to do for now, but keep a mental note

These buttons at the end are ok and satisfy the issue. In the next sprint, we should explore moving them to the title bar and maybe replacing them with an icon or something similar. Nothing to do for now, but keep a mental note
MantashaNoyela commented 2025-02-25 22:03:04 -08:00 (Migrated from github.com)
Review

As I encountered the conflict problem, I removed the folder from my laptop and cloned it again. But I used the code which I had written way before that. May be that's why these problem occured.

As I encountered the conflict problem, I removed the folder from my laptop and cloned it again. But I used the code which I had written way before that. May be that's why these problem occured.
MantashaNoyela commented 2025-02-25 22:04:33 -08:00 (Migrated from github.com)
Review

got it

got it
MantashaNoyela commented 2025-02-25 22:21:05 -08:00 (Migrated from github.com)
Review

I have changed it

I have changed it
const handleLoad = async (slot: "SLOT1" | "SLOT2") => {
djwesty commented 2025-02-25 21:23:25 -08:00 (Migrated from github.com)
Review

It appears that when resolving the merge conflicts, there may have been some regressions. That is to say, these things were changed and committed before you started work, but then undone here. Things I notice on quick glace

  • This title "Poker chips helper" was removed
  • The default state of buyInAmount near the top was changed to 20 from null

Can you fix these up?

It appears that when resolving the merge conflicts, there may have been some regressions. That is to say, these things were changed and committed before you started work, but then undone here. Things I notice on quick glace - This title "Poker chips helper" was removed - The default state of `buyInAmount` near the top was changed to `20` from `null` Can you fix these up?
djwesty commented 2025-02-25 21:26:34 -08:00 (Migrated from github.com)
Review

These buttons at the end are ok and satisfy the issue. In the next sprint, we should explore moving them to the title bar and maybe replacing them with an icon or something similar.

Nothing to do for now, but keep a mental note

These buttons at the end are ok and satisfy the issue. In the next sprint, we should explore moving them to the title bar and maybe replacing them with an icon or something similar. Nothing to do for now, but keep a mental note
MantashaNoyela commented 2025-02-25 22:03:04 -08:00 (Migrated from github.com)
Review

As I encountered the conflict problem, I removed the folder from my laptop and cloned it again. But I used the code which I had written way before that. May be that's why these problem occured.

As I encountered the conflict problem, I removed the folder from my laptop and cloned it again. But I used the code which I had written way before that. May be that's why these problem occured.
MantashaNoyela commented 2025-02-25 22:04:33 -08:00 (Migrated from github.com)
Review

got it

got it
MantashaNoyela commented 2025-02-25 22:21:05 -08:00 (Migrated from github.com)
Review

I have changed it

I have changed it
const loadedState = await loadState(slot);
djwesty commented 2025-02-25 21:23:25 -08:00 (Migrated from github.com)
Review

It appears that when resolving the merge conflicts, there may have been some regressions. That is to say, these things were changed and committed before you started work, but then undone here. Things I notice on quick glace

  • This title "Poker chips helper" was removed
  • The default state of buyInAmount near the top was changed to 20 from null

Can you fix these up?

It appears that when resolving the merge conflicts, there may have been some regressions. That is to say, these things were changed and committed before you started work, but then undone here. Things I notice on quick glace - This title "Poker chips helper" was removed - The default state of `buyInAmount` near the top was changed to `20` from `null` Can you fix these up?
djwesty commented 2025-02-25 21:26:34 -08:00 (Migrated from github.com)
Review

These buttons at the end are ok and satisfy the issue. In the next sprint, we should explore moving them to the title bar and maybe replacing them with an icon or something similar.

Nothing to do for now, but keep a mental note

These buttons at the end are ok and satisfy the issue. In the next sprint, we should explore moving them to the title bar and maybe replacing them with an icon or something similar. Nothing to do for now, but keep a mental note
MantashaNoyela commented 2025-02-25 22:03:04 -08:00 (Migrated from github.com)
Review

As I encountered the conflict problem, I removed the folder from my laptop and cloned it again. But I used the code which I had written way before that. May be that's why these problem occured.

As I encountered the conflict problem, I removed the folder from my laptop and cloned it again. But I used the code which I had written way before that. May be that's why these problem occured.
MantashaNoyela commented 2025-02-25 22:04:33 -08:00 (Migrated from github.com)
Review

got it

got it
MantashaNoyela commented 2025-02-25 22:21:05 -08:00 (Migrated from github.com)
Review

I have changed it

I have changed it
if (loadedState) {
djwesty commented 2025-02-25 21:23:25 -08:00 (Migrated from github.com)
Review

It appears that when resolving the merge conflicts, there may have been some regressions. That is to say, these things were changed and committed before you started work, but then undone here. Things I notice on quick glace

  • This title "Poker chips helper" was removed
  • The default state of buyInAmount near the top was changed to 20 from null

Can you fix these up?

It appears that when resolving the merge conflicts, there may have been some regressions. That is to say, these things were changed and committed before you started work, but then undone here. Things I notice on quick glace - This title "Poker chips helper" was removed - The default state of `buyInAmount` near the top was changed to `20` from `null` Can you fix these up?
djwesty commented 2025-02-25 21:26:34 -08:00 (Migrated from github.com)
Review

These buttons at the end are ok and satisfy the issue. In the next sprint, we should explore moving them to the title bar and maybe replacing them with an icon or something similar.

Nothing to do for now, but keep a mental note

These buttons at the end are ok and satisfy the issue. In the next sprint, we should explore moving them to the title bar and maybe replacing them with an icon or something similar. Nothing to do for now, but keep a mental note
MantashaNoyela commented 2025-02-25 22:03:04 -08:00 (Migrated from github.com)
Review

As I encountered the conflict problem, I removed the folder from my laptop and cloned it again. But I used the code which I had written way before that. May be that's why these problem occured.

As I encountered the conflict problem, I removed the folder from my laptop and cloned it again. But I used the code which I had written way before that. May be that's why these problem occured.
MantashaNoyela commented 2025-02-25 22:04:33 -08:00 (Migrated from github.com)
Review

got it

got it
MantashaNoyela commented 2025-02-25 22:21:05 -08:00 (Migrated from github.com)
Review

I have changed it

I have changed it
setPlayerCount(loadedState.playerCount);
djwesty commented 2025-02-25 21:23:25 -08:00 (Migrated from github.com)
Review

It appears that when resolving the merge conflicts, there may have been some regressions. That is to say, these things were changed and committed before you started work, but then undone here. Things I notice on quick glace

  • This title "Poker chips helper" was removed
  • The default state of buyInAmount near the top was changed to 20 from null

Can you fix these up?

It appears that when resolving the merge conflicts, there may have been some regressions. That is to say, these things were changed and committed before you started work, but then undone here. Things I notice on quick glace - This title "Poker chips helper" was removed - The default state of `buyInAmount` near the top was changed to `20` from `null` Can you fix these up?
djwesty commented 2025-02-25 21:26:34 -08:00 (Migrated from github.com)
Review

These buttons at the end are ok and satisfy the issue. In the next sprint, we should explore moving them to the title bar and maybe replacing them with an icon or something similar.

Nothing to do for now, but keep a mental note

These buttons at the end are ok and satisfy the issue. In the next sprint, we should explore moving them to the title bar and maybe replacing them with an icon or something similar. Nothing to do for now, but keep a mental note
MantashaNoyela commented 2025-02-25 22:03:04 -08:00 (Migrated from github.com)
Review

As I encountered the conflict problem, I removed the folder from my laptop and cloned it again. But I used the code which I had written way before that. May be that's why these problem occured.

As I encountered the conflict problem, I removed the folder from my laptop and cloned it again. But I used the code which I had written way before that. May be that's why these problem occured.
MantashaNoyela commented 2025-02-25 22:04:33 -08:00 (Migrated from github.com)
Review

got it

got it
MantashaNoyela commented 2025-02-25 22:21:05 -08:00 (Migrated from github.com)
Review

I have changed it

I have changed it
setBuyInAmount(loadedState.buyInAmount);
djwesty commented 2025-02-25 21:23:25 -08:00 (Migrated from github.com)
Review

It appears that when resolving the merge conflicts, there may have been some regressions. That is to say, these things were changed and committed before you started work, but then undone here. Things I notice on quick glace

  • This title "Poker chips helper" was removed
  • The default state of buyInAmount near the top was changed to 20 from null

Can you fix these up?

It appears that when resolving the merge conflicts, there may have been some regressions. That is to say, these things were changed and committed before you started work, but then undone here. Things I notice on quick glace - This title "Poker chips helper" was removed - The default state of `buyInAmount` near the top was changed to `20` from `null` Can you fix these up?
djwesty commented 2025-02-25 21:26:34 -08:00 (Migrated from github.com)
Review

These buttons at the end are ok and satisfy the issue. In the next sprint, we should explore moving them to the title bar and maybe replacing them with an icon or something similar.

Nothing to do for now, but keep a mental note

These buttons at the end are ok and satisfy the issue. In the next sprint, we should explore moving them to the title bar and maybe replacing them with an icon or something similar. Nothing to do for now, but keep a mental note
MantashaNoyela commented 2025-02-25 22:03:04 -08:00 (Migrated from github.com)
Review

As I encountered the conflict problem, I removed the folder from my laptop and cloned it again. But I used the code which I had written way before that. May be that's why these problem occured.

As I encountered the conflict problem, I removed the folder from my laptop and cloned it again. But I used the code which I had written way before that. May be that's why these problem occured.
MantashaNoyela commented 2025-02-25 22:04:33 -08:00 (Migrated from github.com)
Review

got it

got it
MantashaNoyela commented 2025-02-25 22:21:05 -08:00 (Migrated from github.com)
Review

I have changed it

I have changed it
setNumberOfChips(loadedState.numberOfChips);
djwesty commented 2025-02-25 21:23:25 -08:00 (Migrated from github.com)
Review

It appears that when resolving the merge conflicts, there may have been some regressions. That is to say, these things were changed and committed before you started work, but then undone here. Things I notice on quick glace

  • This title "Poker chips helper" was removed
  • The default state of buyInAmount near the top was changed to 20 from null

Can you fix these up?

It appears that when resolving the merge conflicts, there may have been some regressions. That is to say, these things were changed and committed before you started work, but then undone here. Things I notice on quick glace - This title "Poker chips helper" was removed - The default state of `buyInAmount` near the top was changed to `20` from `null` Can you fix these up?
djwesty commented 2025-02-25 21:26:34 -08:00 (Migrated from github.com)
Review

These buttons at the end are ok and satisfy the issue. In the next sprint, we should explore moving them to the title bar and maybe replacing them with an icon or something similar.

Nothing to do for now, but keep a mental note

These buttons at the end are ok and satisfy the issue. In the next sprint, we should explore moving them to the title bar and maybe replacing them with an icon or something similar. Nothing to do for now, but keep a mental note
MantashaNoyela commented 2025-02-25 22:03:04 -08:00 (Migrated from github.com)
Review

As I encountered the conflict problem, I removed the folder from my laptop and cloned it again. But I used the code which I had written way before that. May be that's why these problem occured.

As I encountered the conflict problem, I removed the folder from my laptop and cloned it again. But I used the code which I had written way before that. May be that's why these problem occured.
MantashaNoyela commented 2025-02-25 22:04:33 -08:00 (Migrated from github.com)
Review

got it

got it
MantashaNoyela commented 2025-02-25 22:21:05 -08:00 (Migrated from github.com)
Review

I have changed it

I have changed it
setTotalChipsCount(loadedState.totalChipsCount);
djwesty commented 2025-02-25 21:23:25 -08:00 (Migrated from github.com)
Review

It appears that when resolving the merge conflicts, there may have been some regressions. That is to say, these things were changed and committed before you started work, but then undone here. Things I notice on quick glace

  • This title "Poker chips helper" was removed
  • The default state of buyInAmount near the top was changed to 20 from null

Can you fix these up?

It appears that when resolving the merge conflicts, there may have been some regressions. That is to say, these things were changed and committed before you started work, but then undone here. Things I notice on quick glace - This title "Poker chips helper" was removed - The default state of `buyInAmount` near the top was changed to `20` from `null` Can you fix these up?
djwesty commented 2025-02-25 21:26:34 -08:00 (Migrated from github.com)
Review

These buttons at the end are ok and satisfy the issue. In the next sprint, we should explore moving them to the title bar and maybe replacing them with an icon or something similar.

Nothing to do for now, but keep a mental note

These buttons at the end are ok and satisfy the issue. In the next sprint, we should explore moving them to the title bar and maybe replacing them with an icon or something similar. Nothing to do for now, but keep a mental note
MantashaNoyela commented 2025-02-25 22:03:04 -08:00 (Migrated from github.com)
Review

As I encountered the conflict problem, I removed the folder from my laptop and cloned it again. But I used the code which I had written way before that. May be that's why these problem occured.

As I encountered the conflict problem, I removed the folder from my laptop and cloned it again. But I used the code which I had written way before that. May be that's why these problem occured.
MantashaNoyela commented 2025-02-25 22:04:33 -08:00 (Migrated from github.com)
Review

got it

got it
MantashaNoyela commented 2025-02-25 22:21:05 -08:00 (Migrated from github.com)
Review

I have changed it

I have changed it
Alert.alert("Success", `State loaded from ${slot}`);
djwesty commented 2025-02-25 21:23:25 -08:00 (Migrated from github.com)
Review

It appears that when resolving the merge conflicts, there may have been some regressions. That is to say, these things were changed and committed before you started work, but then undone here. Things I notice on quick glace

  • This title "Poker chips helper" was removed
  • The default state of buyInAmount near the top was changed to 20 from null

Can you fix these up?

It appears that when resolving the merge conflicts, there may have been some regressions. That is to say, these things were changed and committed before you started work, but then undone here. Things I notice on quick glace - This title "Poker chips helper" was removed - The default state of `buyInAmount` near the top was changed to `20` from `null` Can you fix these up?
djwesty commented 2025-02-25 21:26:34 -08:00 (Migrated from github.com)
Review

These buttons at the end are ok and satisfy the issue. In the next sprint, we should explore moving them to the title bar and maybe replacing them with an icon or something similar.

Nothing to do for now, but keep a mental note

These buttons at the end are ok and satisfy the issue. In the next sprint, we should explore moving them to the title bar and maybe replacing them with an icon or something similar. Nothing to do for now, but keep a mental note
MantashaNoyela commented 2025-02-25 22:03:04 -08:00 (Migrated from github.com)
Review

As I encountered the conflict problem, I removed the folder from my laptop and cloned it again. But I used the code which I had written way before that. May be that's why these problem occured.

As I encountered the conflict problem, I removed the folder from my laptop and cloned it again. But I used the code which I had written way before that. May be that's why these problem occured.
MantashaNoyela commented 2025-02-25 22:04:33 -08:00 (Migrated from github.com)
Review

got it

got it
MantashaNoyela commented 2025-02-25 22:21:05 -08:00 (Migrated from github.com)
Review

I have changed it

I have changed it
} else { } else {
Alert.alert( Alert.alert("Info", "No saved state found");
djwesty commented 2025-02-25 21:23:25 -08:00 (Migrated from github.com)
Review

It appears that when resolving the merge conflicts, there may have been some regressions. That is to say, these things were changed and committed before you started work, but then undone here. Things I notice on quick glace

  • This title "Poker chips helper" was removed
  • The default state of buyInAmount near the top was changed to 20 from null

Can you fix these up?

It appears that when resolving the merge conflicts, there may have been some regressions. That is to say, these things were changed and committed before you started work, but then undone here. Things I notice on quick glace - This title "Poker chips helper" was removed - The default state of `buyInAmount` near the top was changed to `20` from `null` Can you fix these up?
djwesty commented 2025-02-25 21:26:34 -08:00 (Migrated from github.com)
Review

These buttons at the end are ok and satisfy the issue. In the next sprint, we should explore moving them to the title bar and maybe replacing them with an icon or something similar.

Nothing to do for now, but keep a mental note

These buttons at the end are ok and satisfy the issue. In the next sprint, we should explore moving them to the title bar and maybe replacing them with an icon or something similar. Nothing to do for now, but keep a mental note
MantashaNoyela commented 2025-02-25 22:03:04 -08:00 (Migrated from github.com)
Review

As I encountered the conflict problem, I removed the folder from my laptop and cloned it again. But I used the code which I had written way before that. May be that's why these problem occured.

As I encountered the conflict problem, I removed the folder from my laptop and cloned it again. But I used the code which I had written way before that. May be that's why these problem occured.
MantashaNoyela commented 2025-02-25 22:04:33 -08:00 (Migrated from github.com)
Review

got it

got it
MantashaNoyela commented 2025-02-25 22:21:05 -08:00 (Migrated from github.com)
Review

I have changed it

I have changed it
djwesty commented 2025-02-25 21:23:25 -08:00 (Migrated from github.com)
Review

It appears that when resolving the merge conflicts, there may have been some regressions. That is to say, these things were changed and committed before you started work, but then undone here. Things I notice on quick glace

  • This title "Poker chips helper" was removed
  • The default state of buyInAmount near the top was changed to 20 from null

Can you fix these up?

It appears that when resolving the merge conflicts, there may have been some regressions. That is to say, these things were changed and committed before you started work, but then undone here. Things I notice on quick glace - This title "Poker chips helper" was removed - The default state of `buyInAmount` near the top was changed to `20` from `null` Can you fix these up?
djwesty commented 2025-02-25 21:26:34 -08:00 (Migrated from github.com)
Review

These buttons at the end are ok and satisfy the issue. In the next sprint, we should explore moving them to the title bar and maybe replacing them with an icon or something similar.

Nothing to do for now, but keep a mental note

These buttons at the end are ok and satisfy the issue. In the next sprint, we should explore moving them to the title bar and maybe replacing them with an icon or something similar. Nothing to do for now, but keep a mental note
MantashaNoyela commented 2025-02-25 22:03:04 -08:00 (Migrated from github.com)
Review

As I encountered the conflict problem, I removed the folder from my laptop and cloned it again. But I used the code which I had written way before that. May be that's why these problem occured.

As I encountered the conflict problem, I removed the folder from my laptop and cloned it again. But I used the code which I had written way before that. May be that's why these problem occured.
MantashaNoyela commented 2025-02-25 22:04:33 -08:00 (Migrated from github.com)
Review

got it

got it
MantashaNoyela commented 2025-02-25 22:21:05 -08:00 (Migrated from github.com)
Review

I have changed it

I have changed it
"Success",
djwesty commented 2025-02-25 21:23:25 -08:00 (Migrated from github.com)
Review

It appears that when resolving the merge conflicts, there may have been some regressions. That is to say, these things were changed and committed before you started work, but then undone here. Things I notice on quick glace

  • This title "Poker chips helper" was removed
  • The default state of buyInAmount near the top was changed to 20 from null

Can you fix these up?

It appears that when resolving the merge conflicts, there may have been some regressions. That is to say, these things were changed and committed before you started work, but then undone here. Things I notice on quick glace - This title "Poker chips helper" was removed - The default state of `buyInAmount` near the top was changed to `20` from `null` Can you fix these up?
djwesty commented 2025-02-25 21:26:34 -08:00 (Migrated from github.com)
Review

These buttons at the end are ok and satisfy the issue. In the next sprint, we should explore moving them to the title bar and maybe replacing them with an icon or something similar.

Nothing to do for now, but keep a mental note

These buttons at the end are ok and satisfy the issue. In the next sprint, we should explore moving them to the title bar and maybe replacing them with an icon or something similar. Nothing to do for now, but keep a mental note
MantashaNoyela commented 2025-02-25 22:03:04 -08:00 (Migrated from github.com)
Review

As I encountered the conflict problem, I removed the folder from my laptop and cloned it again. But I used the code which I had written way before that. May be that's why these problem occured.

As I encountered the conflict problem, I removed the folder from my laptop and cloned it again. But I used the code which I had written way before that. May be that's why these problem occured.
MantashaNoyela commented 2025-02-25 22:04:33 -08:00 (Migrated from github.com)
Review

got it

got it
MantashaNoyela commented 2025-02-25 22:21:05 -08:00 (Migrated from github.com)
Review

I have changed it

I have changed it
`Buy-in amount set to ${buyInAmount} for ${playerCount} players`
djwesty commented 2025-02-25 21:23:25 -08:00 (Migrated from github.com)
Review

It appears that when resolving the merge conflicts, there may have been some regressions. That is to say, these things were changed and committed before you started work, but then undone here. Things I notice on quick glace

  • This title "Poker chips helper" was removed
  • The default state of buyInAmount near the top was changed to 20 from null

Can you fix these up?

It appears that when resolving the merge conflicts, there may have been some regressions. That is to say, these things were changed and committed before you started work, but then undone here. Things I notice on quick glace - This title "Poker chips helper" was removed - The default state of `buyInAmount` near the top was changed to `20` from `null` Can you fix these up?
djwesty commented 2025-02-25 21:26:34 -08:00 (Migrated from github.com)
Review

These buttons at the end are ok and satisfy the issue. In the next sprint, we should explore moving them to the title bar and maybe replacing them with an icon or something similar.

Nothing to do for now, but keep a mental note

These buttons at the end are ok and satisfy the issue. In the next sprint, we should explore moving them to the title bar and maybe replacing them with an icon or something similar. Nothing to do for now, but keep a mental note
MantashaNoyela commented 2025-02-25 22:03:04 -08:00 (Migrated from github.com)
Review

As I encountered the conflict problem, I removed the folder from my laptop and cloned it again. But I used the code which I had written way before that. May be that's why these problem occured.

As I encountered the conflict problem, I removed the folder from my laptop and cloned it again. But I used the code which I had written way before that. May be that's why these problem occured.
MantashaNoyela commented 2025-02-25 22:04:33 -08:00 (Migrated from github.com)
Review

got it

got it
MantashaNoyela commented 2025-02-25 22:21:05 -08:00 (Migrated from github.com)
Review

I have changed it

I have changed it
);
djwesty commented 2025-02-25 21:23:25 -08:00 (Migrated from github.com)
Review

It appears that when resolving the merge conflicts, there may have been some regressions. That is to say, these things were changed and committed before you started work, but then undone here. Things I notice on quick glace

  • This title "Poker chips helper" was removed
  • The default state of buyInAmount near the top was changed to 20 from null

Can you fix these up?

It appears that when resolving the merge conflicts, there may have been some regressions. That is to say, these things were changed and committed before you started work, but then undone here. Things I notice on quick glace - This title "Poker chips helper" was removed - The default state of `buyInAmount` near the top was changed to `20` from `null` Can you fix these up?
djwesty commented 2025-02-25 21:26:34 -08:00 (Migrated from github.com)
Review

These buttons at the end are ok and satisfy the issue. In the next sprint, we should explore moving them to the title bar and maybe replacing them with an icon or something similar.

Nothing to do for now, but keep a mental note

These buttons at the end are ok and satisfy the issue. In the next sprint, we should explore moving them to the title bar and maybe replacing them with an icon or something similar. Nothing to do for now, but keep a mental note
MantashaNoyela commented 2025-02-25 22:03:04 -08:00 (Migrated from github.com)
Review

As I encountered the conflict problem, I removed the folder from my laptop and cloned it again. But I used the code which I had written way before that. May be that's why these problem occured.

As I encountered the conflict problem, I removed the folder from my laptop and cloned it again. But I used the code which I had written way before that. May be that's why these problem occured.
MantashaNoyela commented 2025-02-25 22:04:33 -08:00 (Migrated from github.com)
Review

got it

got it
MantashaNoyela commented 2025-02-25 22:21:05 -08:00 (Migrated from github.com)
Review

I have changed it

I have changed it
} }
}; };
// Update chip count based on detection or manual edit
djwesty commented 2025-02-25 21:23:25 -08:00 (Migrated from github.com)
Review

It appears that when resolving the merge conflicts, there may have been some regressions. That is to say, these things were changed and committed before you started work, but then undone here. Things I notice on quick glace

  • This title "Poker chips helper" was removed
  • The default state of buyInAmount near the top was changed to 20 from null

Can you fix these up?

It appears that when resolving the merge conflicts, there may have been some regressions. That is to say, these things were changed and committed before you started work, but then undone here. Things I notice on quick glace - This title "Poker chips helper" was removed - The default state of `buyInAmount` near the top was changed to `20` from `null` Can you fix these up?
djwesty commented 2025-02-25 21:26:34 -08:00 (Migrated from github.com)
Review

These buttons at the end are ok and satisfy the issue. In the next sprint, we should explore moving them to the title bar and maybe replacing them with an icon or something similar.

Nothing to do for now, but keep a mental note

These buttons at the end are ok and satisfy the issue. In the next sprint, we should explore moving them to the title bar and maybe replacing them with an icon or something similar. Nothing to do for now, but keep a mental note
MantashaNoyela commented 2025-02-25 22:03:04 -08:00 (Migrated from github.com)
Review

As I encountered the conflict problem, I removed the folder from my laptop and cloned it again. But I used the code which I had written way before that. May be that's why these problem occured.

As I encountered the conflict problem, I removed the folder from my laptop and cloned it again. But I used the code which I had written way before that. May be that's why these problem occured.
MantashaNoyela commented 2025-02-25 22:04:33 -08:00 (Migrated from github.com)
Review

got it

got it
MantashaNoyela commented 2025-02-25 22:21:05 -08:00 (Migrated from github.com)
Review

I have changed it

I have changed it
const updateChipCount = (chipData: { [color: string]: number }) => {
djwesty commented 2025-02-25 21:23:25 -08:00 (Migrated from github.com)
Review

It appears that when resolving the merge conflicts, there may have been some regressions. That is to say, these things were changed and committed before you started work, but then undone here. Things I notice on quick glace

  • This title "Poker chips helper" was removed
  • The default state of buyInAmount near the top was changed to 20 from null

Can you fix these up?

It appears that when resolving the merge conflicts, there may have been some regressions. That is to say, these things were changed and committed before you started work, but then undone here. Things I notice on quick glace - This title "Poker chips helper" was removed - The default state of `buyInAmount` near the top was changed to `20` from `null` Can you fix these up?
djwesty commented 2025-02-25 21:26:34 -08:00 (Migrated from github.com)
Review

These buttons at the end are ok and satisfy the issue. In the next sprint, we should explore moving them to the title bar and maybe replacing them with an icon or something similar.

Nothing to do for now, but keep a mental note

These buttons at the end are ok and satisfy the issue. In the next sprint, we should explore moving them to the title bar and maybe replacing them with an icon or something similar. Nothing to do for now, but keep a mental note
MantashaNoyela commented 2025-02-25 22:03:04 -08:00 (Migrated from github.com)
Review

As I encountered the conflict problem, I removed the folder from my laptop and cloned it again. But I used the code which I had written way before that. May be that's why these problem occured.

As I encountered the conflict problem, I removed the folder from my laptop and cloned it again. But I used the code which I had written way before that. May be that's why these problem occured.
MantashaNoyela commented 2025-02-25 22:04:33 -08:00 (Migrated from github.com)
Review

got it

got it
MantashaNoyela commented 2025-02-25 22:21:05 -08:00 (Migrated from github.com)
Review

I have changed it

I have changed it
// Convert the chip data from the API response or manual edit to a count array
djwesty commented 2025-02-25 21:23:25 -08:00 (Migrated from github.com)
Review

It appears that when resolving the merge conflicts, there may have been some regressions. That is to say, these things were changed and committed before you started work, but then undone here. Things I notice on quick glace

  • This title "Poker chips helper" was removed
  • The default state of buyInAmount near the top was changed to 20 from null

Can you fix these up?

It appears that when resolving the merge conflicts, there may have been some regressions. That is to say, these things were changed and committed before you started work, but then undone here. Things I notice on quick glace - This title "Poker chips helper" was removed - The default state of `buyInAmount` near the top was changed to `20` from `null` Can you fix these up?
djwesty commented 2025-02-25 21:26:34 -08:00 (Migrated from github.com)
Review

These buttons at the end are ok and satisfy the issue. In the next sprint, we should explore moving them to the title bar and maybe replacing them with an icon or something similar.

Nothing to do for now, but keep a mental note

These buttons at the end are ok and satisfy the issue. In the next sprint, we should explore moving them to the title bar and maybe replacing them with an icon or something similar. Nothing to do for now, but keep a mental note
MantashaNoyela commented 2025-02-25 22:03:04 -08:00 (Migrated from github.com)
Review

As I encountered the conflict problem, I removed the folder from my laptop and cloned it again. But I used the code which I had written way before that. May be that's why these problem occured.

As I encountered the conflict problem, I removed the folder from my laptop and cloned it again. But I used the code which I had written way before that. May be that's why these problem occured.
MantashaNoyela commented 2025-02-25 22:04:33 -08:00 (Migrated from github.com)
Review

got it

got it
MantashaNoyela commented 2025-02-25 22:21:05 -08:00 (Migrated from github.com)
Review

I have changed it

I have changed it
const chipCountArray = Object.entries(chipData).map(
djwesty commented 2025-02-25 21:23:25 -08:00 (Migrated from github.com)
Review

It appears that when resolving the merge conflicts, there may have been some regressions. That is to say, these things were changed and committed before you started work, but then undone here. Things I notice on quick glace

  • This title "Poker chips helper" was removed
  • The default state of buyInAmount near the top was changed to 20 from null

Can you fix these up?

It appears that when resolving the merge conflicts, there may have been some regressions. That is to say, these things were changed and committed before you started work, but then undone here. Things I notice on quick glace - This title "Poker chips helper" was removed - The default state of `buyInAmount` near the top was changed to `20` from `null` Can you fix these up?
djwesty commented 2025-02-25 21:26:34 -08:00 (Migrated from github.com)
Review

These buttons at the end are ok and satisfy the issue. In the next sprint, we should explore moving them to the title bar and maybe replacing them with an icon or something similar.

Nothing to do for now, but keep a mental note

These buttons at the end are ok and satisfy the issue. In the next sprint, we should explore moving them to the title bar and maybe replacing them with an icon or something similar. Nothing to do for now, but keep a mental note
MantashaNoyela commented 2025-02-25 22:03:04 -08:00 (Migrated from github.com)
Review

As I encountered the conflict problem, I removed the folder from my laptop and cloned it again. But I used the code which I had written way before that. May be that's why these problem occured.

As I encountered the conflict problem, I removed the folder from my laptop and cloned it again. But I used the code which I had written way before that. May be that's why these problem occured.
MantashaNoyela commented 2025-02-25 22:04:33 -08:00 (Migrated from github.com)
Review

got it

got it
MantashaNoyela commented 2025-02-25 22:21:05 -08:00 (Migrated from github.com)
Review

I have changed it

I have changed it
([color, count]) => count
djwesty commented 2025-02-25 21:23:25 -08:00 (Migrated from github.com)
Review

It appears that when resolving the merge conflicts, there may have been some regressions. That is to say, these things were changed and committed before you started work, but then undone here. Things I notice on quick glace

  • This title "Poker chips helper" was removed
  • The default state of buyInAmount near the top was changed to 20 from null

Can you fix these up?

It appears that when resolving the merge conflicts, there may have been some regressions. That is to say, these things were changed and committed before you started work, but then undone here. Things I notice on quick glace - This title "Poker chips helper" was removed - The default state of `buyInAmount` near the top was changed to `20` from `null` Can you fix these up?
djwesty commented 2025-02-25 21:26:34 -08:00 (Migrated from github.com)
Review

These buttons at the end are ok and satisfy the issue. In the next sprint, we should explore moving them to the title bar and maybe replacing them with an icon or something similar.

Nothing to do for now, but keep a mental note

These buttons at the end are ok and satisfy the issue. In the next sprint, we should explore moving them to the title bar and maybe replacing them with an icon or something similar. Nothing to do for now, but keep a mental note
MantashaNoyela commented 2025-02-25 22:03:04 -08:00 (Migrated from github.com)
Review

As I encountered the conflict problem, I removed the folder from my laptop and cloned it again. But I used the code which I had written way before that. May be that's why these problem occured.

As I encountered the conflict problem, I removed the folder from my laptop and cloned it again. But I used the code which I had written way before that. May be that's why these problem occured.
MantashaNoyela commented 2025-02-25 22:04:33 -08:00 (Migrated from github.com)
Review

got it

got it
MantashaNoyela commented 2025-02-25 22:21:05 -08:00 (Migrated from github.com)
Review

I have changed it

I have changed it
);
djwesty commented 2025-02-25 21:23:25 -08:00 (Migrated from github.com)
Review

It appears that when resolving the merge conflicts, there may have been some regressions. That is to say, these things were changed and committed before you started work, but then undone here. Things I notice on quick glace

  • This title "Poker chips helper" was removed
  • The default state of buyInAmount near the top was changed to 20 from null

Can you fix these up?

It appears that when resolving the merge conflicts, there may have been some regressions. That is to say, these things were changed and committed before you started work, but then undone here. Things I notice on quick glace - This title "Poker chips helper" was removed - The default state of `buyInAmount` near the top was changed to `20` from `null` Can you fix these up?
djwesty commented 2025-02-25 21:26:34 -08:00 (Migrated from github.com)
Review

These buttons at the end are ok and satisfy the issue. In the next sprint, we should explore moving them to the title bar and maybe replacing them with an icon or something similar.

Nothing to do for now, but keep a mental note

These buttons at the end are ok and satisfy the issue. In the next sprint, we should explore moving them to the title bar and maybe replacing them with an icon or something similar. Nothing to do for now, but keep a mental note
MantashaNoyela commented 2025-02-25 22:03:04 -08:00 (Migrated from github.com)
Review

As I encountered the conflict problem, I removed the folder from my laptop and cloned it again. But I used the code which I had written way before that. May be that's why these problem occured.

As I encountered the conflict problem, I removed the folder from my laptop and cloned it again. But I used the code which I had written way before that. May be that's why these problem occured.
MantashaNoyela commented 2025-02-25 22:04:33 -08:00 (Migrated from github.com)
Review

got it

got it
MantashaNoyela commented 2025-02-25 22:21:05 -08:00 (Migrated from github.com)
Review

I have changed it

I have changed it
setTotalChipsCount(chipCountArray); // Update the parent component's state
djwesty commented 2025-02-25 21:23:25 -08:00 (Migrated from github.com)
Review

It appears that when resolving the merge conflicts, there may have been some regressions. That is to say, these things were changed and committed before you started work, but then undone here. Things I notice on quick glace

  • This title "Poker chips helper" was removed
  • The default state of buyInAmount near the top was changed to 20 from null

Can you fix these up?

It appears that when resolving the merge conflicts, there may have been some regressions. That is to say, these things were changed and committed before you started work, but then undone here. Things I notice on quick glace - This title "Poker chips helper" was removed - The default state of `buyInAmount` near the top was changed to `20` from `null` Can you fix these up?
djwesty commented 2025-02-25 21:26:34 -08:00 (Migrated from github.com)
Review

These buttons at the end are ok and satisfy the issue. In the next sprint, we should explore moving them to the title bar and maybe replacing them with an icon or something similar.

Nothing to do for now, but keep a mental note

These buttons at the end are ok and satisfy the issue. In the next sprint, we should explore moving them to the title bar and maybe replacing them with an icon or something similar. Nothing to do for now, but keep a mental note
MantashaNoyela commented 2025-02-25 22:03:04 -08:00 (Migrated from github.com)
Review

As I encountered the conflict problem, I removed the folder from my laptop and cloned it again. But I used the code which I had written way before that. May be that's why these problem occured.

As I encountered the conflict problem, I removed the folder from my laptop and cloned it again. But I used the code which I had written way before that. May be that's why these problem occured.
MantashaNoyela commented 2025-02-25 22:04:33 -08:00 (Migrated from github.com)
Review

got it

got it
MantashaNoyela commented 2025-02-25 22:21:05 -08:00 (Migrated from github.com)
Review

I have changed it

I have changed it
};
djwesty commented 2025-02-25 21:23:25 -08:00 (Migrated from github.com)
Review

It appears that when resolving the merge conflicts, there may have been some regressions. That is to say, these things were changed and committed before you started work, but then undone here. Things I notice on quick glace

  • This title "Poker chips helper" was removed
  • The default state of buyInAmount near the top was changed to 20 from null

Can you fix these up?

It appears that when resolving the merge conflicts, there may have been some regressions. That is to say, these things were changed and committed before you started work, but then undone here. Things I notice on quick glace - This title "Poker chips helper" was removed - The default state of `buyInAmount` near the top was changed to `20` from `null` Can you fix these up?
djwesty commented 2025-02-25 21:26:34 -08:00 (Migrated from github.com)
Review

These buttons at the end are ok and satisfy the issue. In the next sprint, we should explore moving them to the title bar and maybe replacing them with an icon or something similar.

Nothing to do for now, but keep a mental note

These buttons at the end are ok and satisfy the issue. In the next sprint, we should explore moving them to the title bar and maybe replacing them with an icon or something similar. Nothing to do for now, but keep a mental note
MantashaNoyela commented 2025-02-25 22:03:04 -08:00 (Migrated from github.com)
Review

As I encountered the conflict problem, I removed the folder from my laptop and cloned it again. But I used the code which I had written way before that. May be that's why these problem occured.

As I encountered the conflict problem, I removed the folder from my laptop and cloned it again. But I used the code which I had written way before that. May be that's why these problem occured.
MantashaNoyela commented 2025-02-25 22:04:33 -08:00 (Migrated from github.com)
Review

got it

got it
MantashaNoyela commented 2025-02-25 22:21:05 -08:00 (Migrated from github.com)
Review

I have changed it

I have changed it
djwesty commented 2025-02-25 21:23:25 -08:00 (Migrated from github.com)
Review

It appears that when resolving the merge conflicts, there may have been some regressions. That is to say, these things were changed and committed before you started work, but then undone here. Things I notice on quick glace

  • This title "Poker chips helper" was removed
  • The default state of buyInAmount near the top was changed to 20 from null

Can you fix these up?

It appears that when resolving the merge conflicts, there may have been some regressions. That is to say, these things were changed and committed before you started work, but then undone here. Things I notice on quick glace - This title "Poker chips helper" was removed - The default state of `buyInAmount` near the top was changed to `20` from `null` Can you fix these up?
djwesty commented 2025-02-25 21:26:34 -08:00 (Migrated from github.com)
Review

These buttons at the end are ok and satisfy the issue. In the next sprint, we should explore moving them to the title bar and maybe replacing them with an icon or something similar.

Nothing to do for now, but keep a mental note

These buttons at the end are ok and satisfy the issue. In the next sprint, we should explore moving them to the title bar and maybe replacing them with an icon or something similar. Nothing to do for now, but keep a mental note
MantashaNoyela commented 2025-02-25 22:03:04 -08:00 (Migrated from github.com)
Review

As I encountered the conflict problem, I removed the folder from my laptop and cloned it again. But I used the code which I had written way before that. May be that's why these problem occured.

As I encountered the conflict problem, I removed the folder from my laptop and cloned it again. But I used the code which I had written way before that. May be that's why these problem occured.
MantashaNoyela commented 2025-02-25 22:04:33 -08:00 (Migrated from github.com)
Review

got it

got it
MantashaNoyela commented 2025-02-25 22:21:05 -08:00 (Migrated from github.com)
Review

I have changed it

I have changed it
return ( return (
<View style={styles.container}>
djwesty commented 2025-02-25 21:23:25 -08:00 (Migrated from github.com)
Review

It appears that when resolving the merge conflicts, there may have been some regressions. That is to say, these things were changed and committed before you started work, but then undone here. Things I notice on quick glace

  • This title "Poker chips helper" was removed
  • The default state of buyInAmount near the top was changed to 20 from null

Can you fix these up?

It appears that when resolving the merge conflicts, there may have been some regressions. That is to say, these things were changed and committed before you started work, but then undone here. Things I notice on quick glace - This title "Poker chips helper" was removed - The default state of `buyInAmount` near the top was changed to `20` from `null` Can you fix these up?
djwesty commented 2025-02-25 21:26:34 -08:00 (Migrated from github.com)
Review

These buttons at the end are ok and satisfy the issue. In the next sprint, we should explore moving them to the title bar and maybe replacing them with an icon or something similar.

Nothing to do for now, but keep a mental note

These buttons at the end are ok and satisfy the issue. In the next sprint, we should explore moving them to the title bar and maybe replacing them with an icon or something similar. Nothing to do for now, but keep a mental note
MantashaNoyela commented 2025-02-25 22:03:04 -08:00 (Migrated from github.com)
Review

As I encountered the conflict problem, I removed the folder from my laptop and cloned it again. But I used the code which I had written way before that. May be that's why these problem occured.

As I encountered the conflict problem, I removed the folder from my laptop and cloned it again. But I used the code which I had written way before that. May be that's why these problem occured.
MantashaNoyela commented 2025-02-25 22:04:33 -08:00 (Migrated from github.com)
Review

got it

got it
MantashaNoyela commented 2025-02-25 22:21:05 -08:00 (Migrated from github.com)
Review

I have changed it

I have changed it
<ScrollView contentContainerStyle={{ padding: 20, flexGrow: 1 }}> <ScrollView contentContainerStyle={{ padding: 20, flexGrow: 1 }}>
<PlayerSelector <Text style={styles.title}>Poker Chip Helper</Text>
djwesty commented 2025-02-25 21:23:25 -08:00 (Migrated from github.com)
Review

It appears that when resolving the merge conflicts, there may have been some regressions. That is to say, these things were changed and committed before you started work, but then undone here. Things I notice on quick glace

  • This title "Poker chips helper" was removed
  • The default state of buyInAmount near the top was changed to 20 from null

Can you fix these up?

It appears that when resolving the merge conflicts, there may have been some regressions. That is to say, these things were changed and committed before you started work, but then undone here. Things I notice on quick glace - This title "Poker chips helper" was removed - The default state of `buyInAmount` near the top was changed to `20` from `null` Can you fix these up?
djwesty commented 2025-02-25 21:26:34 -08:00 (Migrated from github.com)
Review

These buttons at the end are ok and satisfy the issue. In the next sprint, we should explore moving them to the title bar and maybe replacing them with an icon or something similar.

Nothing to do for now, but keep a mental note

These buttons at the end are ok and satisfy the issue. In the next sprint, we should explore moving them to the title bar and maybe replacing them with an icon or something similar. Nothing to do for now, but keep a mental note
MantashaNoyela commented 2025-02-25 22:03:04 -08:00 (Migrated from github.com)
Review

As I encountered the conflict problem, I removed the folder from my laptop and cloned it again. But I used the code which I had written way before that. May be that's why these problem occured.

As I encountered the conflict problem, I removed the folder from my laptop and cloned it again. But I used the code which I had written way before that. May be that's why these problem occured.
MantashaNoyela commented 2025-02-25 22:04:33 -08:00 (Migrated from github.com)
Review

got it

got it
MantashaNoyela commented 2025-02-25 22:21:05 -08:00 (Migrated from github.com)
Review

I have changed it

I have changed it
djwesty commented 2025-02-25 21:23:25 -08:00 (Migrated from github.com)
Review

It appears that when resolving the merge conflicts, there may have been some regressions. That is to say, these things were changed and committed before you started work, but then undone here. Things I notice on quick glace

  • This title "Poker chips helper" was removed
  • The default state of buyInAmount near the top was changed to 20 from null

Can you fix these up?

It appears that when resolving the merge conflicts, there may have been some regressions. That is to say, these things were changed and committed before you started work, but then undone here. Things I notice on quick glace - This title "Poker chips helper" was removed - The default state of `buyInAmount` near the top was changed to `20` from `null` Can you fix these up?
djwesty commented 2025-02-25 21:26:34 -08:00 (Migrated from github.com)
Review

These buttons at the end are ok and satisfy the issue. In the next sprint, we should explore moving them to the title bar and maybe replacing them with an icon or something similar.

Nothing to do for now, but keep a mental note

These buttons at the end are ok and satisfy the issue. In the next sprint, we should explore moving them to the title bar and maybe replacing them with an icon or something similar. Nothing to do for now, but keep a mental note
MantashaNoyela commented 2025-02-25 22:03:04 -08:00 (Migrated from github.com)
Review

As I encountered the conflict problem, I removed the folder from my laptop and cloned it again. But I used the code which I had written way before that. May be that's why these problem occured.

As I encountered the conflict problem, I removed the folder from my laptop and cloned it again. But I used the code which I had written way before that. May be that's why these problem occured.
MantashaNoyela commented 2025-02-25 22:04:33 -08:00 (Migrated from github.com)
Review

got it

got it
MantashaNoyela commented 2025-02-25 22:21:05 -08:00 (Migrated from github.com)
Review

I have changed it

I have changed it
playerCount={playerCount} <PlayerSelector playerCount={playerCount} setPlayerCount={setPlayerCount} />
djwesty commented 2025-02-25 21:23:25 -08:00 (Migrated from github.com)
Review

It appears that when resolving the merge conflicts, there may have been some regressions. That is to say, these things were changed and committed before you started work, but then undone here. Things I notice on quick glace

  • This title "Poker chips helper" was removed
  • The default state of buyInAmount near the top was changed to 20 from null

Can you fix these up?

It appears that when resolving the merge conflicts, there may have been some regressions. That is to say, these things were changed and committed before you started work, but then undone here. Things I notice on quick glace - This title "Poker chips helper" was removed - The default state of `buyInAmount` near the top was changed to `20` from `null` Can you fix these up?
djwesty commented 2025-02-25 21:26:34 -08:00 (Migrated from github.com)
Review

These buttons at the end are ok and satisfy the issue. In the next sprint, we should explore moving them to the title bar and maybe replacing them with an icon or something similar.

Nothing to do for now, but keep a mental note

These buttons at the end are ok and satisfy the issue. In the next sprint, we should explore moving them to the title bar and maybe replacing them with an icon or something similar. Nothing to do for now, but keep a mental note
MantashaNoyela commented 2025-02-25 22:03:04 -08:00 (Migrated from github.com)
Review

As I encountered the conflict problem, I removed the folder from my laptop and cloned it again. But I used the code which I had written way before that. May be that's why these problem occured.

As I encountered the conflict problem, I removed the folder from my laptop and cloned it again. But I used the code which I had written way before that. May be that's why these problem occured.
MantashaNoyela commented 2025-02-25 22:04:33 -08:00 (Migrated from github.com)
Review

got it

got it
MantashaNoyela commented 2025-02-25 22:21:05 -08:00 (Migrated from github.com)
Review

I have changed it

I have changed it
djwesty commented 2025-02-25 21:23:25 -08:00 (Migrated from github.com)
Review

It appears that when resolving the merge conflicts, there may have been some regressions. That is to say, these things were changed and committed before you started work, but then undone here. Things I notice on quick glace

  • This title "Poker chips helper" was removed
  • The default state of buyInAmount near the top was changed to 20 from null

Can you fix these up?

It appears that when resolving the merge conflicts, there may have been some regressions. That is to say, these things were changed and committed before you started work, but then undone here. Things I notice on quick glace - This title "Poker chips helper" was removed - The default state of `buyInAmount` near the top was changed to `20` from `null` Can you fix these up?
djwesty commented 2025-02-25 21:26:34 -08:00 (Migrated from github.com)
Review

These buttons at the end are ok and satisfy the issue. In the next sprint, we should explore moving them to the title bar and maybe replacing them with an icon or something similar.

Nothing to do for now, but keep a mental note

These buttons at the end are ok and satisfy the issue. In the next sprint, we should explore moving them to the title bar and maybe replacing them with an icon or something similar. Nothing to do for now, but keep a mental note
MantashaNoyela commented 2025-02-25 22:03:04 -08:00 (Migrated from github.com)
Review

As I encountered the conflict problem, I removed the folder from my laptop and cloned it again. But I used the code which I had written way before that. May be that's why these problem occured.

As I encountered the conflict problem, I removed the folder from my laptop and cloned it again. But I used the code which I had written way before that. May be that's why these problem occured.
MantashaNoyela commented 2025-02-25 22:04:33 -08:00 (Migrated from github.com)
Review

got it

got it
MantashaNoyela commented 2025-02-25 22:21:05 -08:00 (Migrated from github.com)
Review

I have changed it

I have changed it
setPlayerCount={setPlayerCount}
djwesty commented 2025-02-25 21:23:25 -08:00 (Migrated from github.com)
Review

It appears that when resolving the merge conflicts, there may have been some regressions. That is to say, these things were changed and committed before you started work, but then undone here. Things I notice on quick glace

  • This title "Poker chips helper" was removed
  • The default state of buyInAmount near the top was changed to 20 from null

Can you fix these up?

It appears that when resolving the merge conflicts, there may have been some regressions. That is to say, these things were changed and committed before you started work, but then undone here. Things I notice on quick glace - This title "Poker chips helper" was removed - The default state of `buyInAmount` near the top was changed to `20` from `null` Can you fix these up?
djwesty commented 2025-02-25 21:26:34 -08:00 (Migrated from github.com)
Review

These buttons at the end are ok and satisfy the issue. In the next sprint, we should explore moving them to the title bar and maybe replacing them with an icon or something similar.

Nothing to do for now, but keep a mental note

These buttons at the end are ok and satisfy the issue. In the next sprint, we should explore moving them to the title bar and maybe replacing them with an icon or something similar. Nothing to do for now, but keep a mental note
MantashaNoyela commented 2025-02-25 22:03:04 -08:00 (Migrated from github.com)
Review

As I encountered the conflict problem, I removed the folder from my laptop and cloned it again. But I used the code which I had written way before that. May be that's why these problem occured.

As I encountered the conflict problem, I removed the folder from my laptop and cloned it again. But I used the code which I had written way before that. May be that's why these problem occured.
MantashaNoyela commented 2025-02-25 22:04:33 -08:00 (Migrated from github.com)
Review

got it

got it
MantashaNoyela commented 2025-02-25 22:21:05 -08:00 (Migrated from github.com)
Review

I have changed it

I have changed it
/>
djwesty commented 2025-02-25 21:23:25 -08:00 (Migrated from github.com)
Review

It appears that when resolving the merge conflicts, there may have been some regressions. That is to say, these things were changed and committed before you started work, but then undone here. Things I notice on quick glace

  • This title "Poker chips helper" was removed
  • The default state of buyInAmount near the top was changed to 20 from null

Can you fix these up?

It appears that when resolving the merge conflicts, there may have been some regressions. That is to say, these things were changed and committed before you started work, but then undone here. Things I notice on quick glace - This title "Poker chips helper" was removed - The default state of `buyInAmount` near the top was changed to `20` from `null` Can you fix these up?
djwesty commented 2025-02-25 21:26:34 -08:00 (Migrated from github.com)
Review

These buttons at the end are ok and satisfy the issue. In the next sprint, we should explore moving them to the title bar and maybe replacing them with an icon or something similar.

Nothing to do for now, but keep a mental note

These buttons at the end are ok and satisfy the issue. In the next sprint, we should explore moving them to the title bar and maybe replacing them with an icon or something similar. Nothing to do for now, but keep a mental note
MantashaNoyela commented 2025-02-25 22:03:04 -08:00 (Migrated from github.com)
Review

As I encountered the conflict problem, I removed the folder from my laptop and cloned it again. But I used the code which I had written way before that. May be that's why these problem occured.

As I encountered the conflict problem, I removed the folder from my laptop and cloned it again. But I used the code which I had written way before that. May be that's why these problem occured.
MantashaNoyela commented 2025-02-25 22:04:33 -08:00 (Migrated from github.com)
Review

got it

got it
MantashaNoyela commented 2025-02-25 22:21:05 -08:00 (Migrated from github.com)
Review

I have changed it

I have changed it
<BuyInSelector setBuyInAmount={setBuyInAmount} /> <BuyInSelector setBuyInAmount={setBuyInAmount} />
<ChipDetection updateChipCount={updateChipCount} />
djwesty commented 2025-02-25 21:23:25 -08:00 (Migrated from github.com)
Review

It appears that when resolving the merge conflicts, there may have been some regressions. That is to say, these things were changed and committed before you started work, but then undone here. Things I notice on quick glace

  • This title "Poker chips helper" was removed
  • The default state of buyInAmount near the top was changed to 20 from null

Can you fix these up?

It appears that when resolving the merge conflicts, there may have been some regressions. That is to say, these things were changed and committed before you started work, but then undone here. Things I notice on quick glace - This title "Poker chips helper" was removed - The default state of `buyInAmount` near the top was changed to `20` from `null` Can you fix these up?
djwesty commented 2025-02-25 21:26:34 -08:00 (Migrated from github.com)
Review

These buttons at the end are ok and satisfy the issue. In the next sprint, we should explore moving them to the title bar and maybe replacing them with an icon or something similar.

Nothing to do for now, but keep a mental note

These buttons at the end are ok and satisfy the issue. In the next sprint, we should explore moving them to the title bar and maybe replacing them with an icon or something similar. Nothing to do for now, but keep a mental note
MantashaNoyela commented 2025-02-25 22:03:04 -08:00 (Migrated from github.com)
Review

As I encountered the conflict problem, I removed the folder from my laptop and cloned it again. But I used the code which I had written way before that. May be that's why these problem occured.

As I encountered the conflict problem, I removed the folder from my laptop and cloned it again. But I used the code which I had written way before that. May be that's why these problem occured.
MantashaNoyela commented 2025-02-25 22:04:33 -08:00 (Migrated from github.com)
Review

got it

got it
MantashaNoyela commented 2025-02-25 22:21:05 -08:00 (Migrated from github.com)
Review

I have changed it

I have changed it
<ChipsSelector <ChipsSelector
totalChipsCount={totalChipsCount} totalChipsCount={totalChipsCount}
setTotalChipsCount={setTotalChipsCount} setTotalChipsCount={setTotalChipsCount}
@ -59,13 +52,25 @@ const IndexScreen: React.FC = () => {
djwesty commented 2025-02-25 21:23:25 -08:00 (Migrated from github.com)
Review

It appears that when resolving the merge conflicts, there may have been some regressions. That is to say, these things were changed and committed before you started work, but then undone here. Things I notice on quick glace

  • This title "Poker chips helper" was removed
  • The default state of buyInAmount near the top was changed to 20 from null

Can you fix these up?

It appears that when resolving the merge conflicts, there may have been some regressions. That is to say, these things were changed and committed before you started work, but then undone here. Things I notice on quick glace - This title "Poker chips helper" was removed - The default state of `buyInAmount` near the top was changed to `20` from `null` Can you fix these up?
djwesty commented 2025-02-25 21:23:25 -08:00 (Migrated from github.com)
Review

It appears that when resolving the merge conflicts, there may have been some regressions. That is to say, these things were changed and committed before you started work, but then undone here. Things I notice on quick glace

  • This title "Poker chips helper" was removed
  • The default state of buyInAmount near the top was changed to 20 from null

Can you fix these up?

It appears that when resolving the merge conflicts, there may have been some regressions. That is to say, these things were changed and committed before you started work, but then undone here. Things I notice on quick glace - This title "Poker chips helper" was removed - The default state of `buyInAmount` near the top was changed to `20` from `null` Can you fix these up?
djwesty commented 2025-02-25 21:26:34 -08:00 (Migrated from github.com)
Review

These buttons at the end are ok and satisfy the issue. In the next sprint, we should explore moving them to the title bar and maybe replacing them with an icon or something similar.

Nothing to do for now, but keep a mental note

These buttons at the end are ok and satisfy the issue. In the next sprint, we should explore moving them to the title bar and maybe replacing them with an icon or something similar. Nothing to do for now, but keep a mental note
djwesty commented 2025-02-25 21:26:34 -08:00 (Migrated from github.com)
Review

These buttons at the end are ok and satisfy the issue. In the next sprint, we should explore moving them to the title bar and maybe replacing them with an icon or something similar.

Nothing to do for now, but keep a mental note

These buttons at the end are ok and satisfy the issue. In the next sprint, we should explore moving them to the title bar and maybe replacing them with an icon or something similar. Nothing to do for now, but keep a mental note
MantashaNoyela commented 2025-02-25 22:03:04 -08:00 (Migrated from github.com)
Review

As I encountered the conflict problem, I removed the folder from my laptop and cloned it again. But I used the code which I had written way before that. May be that's why these problem occured.

As I encountered the conflict problem, I removed the folder from my laptop and cloned it again. But I used the code which I had written way before that. May be that's why these problem occured.
MantashaNoyela commented 2025-02-25 22:03:04 -08:00 (Migrated from github.com)
Review

As I encountered the conflict problem, I removed the folder from my laptop and cloned it again. But I used the code which I had written way before that. May be that's why these problem occured.

As I encountered the conflict problem, I removed the folder from my laptop and cloned it again. But I used the code which I had written way before that. May be that's why these problem occured.
MantashaNoyela commented 2025-02-25 22:04:33 -08:00 (Migrated from github.com)
Review

got it

got it
MantashaNoyela commented 2025-02-25 22:04:33 -08:00 (Migrated from github.com)
Review

got it

got it
MantashaNoyela commented 2025-02-25 22:21:05 -08:00 (Migrated from github.com)
Review

I have changed it

I have changed it
MantashaNoyela commented 2025-02-25 22:21:05 -08:00 (Migrated from github.com)
Review

I have changed it

I have changed it
buyInAmount={buyInAmount} buyInAmount={buyInAmount}
totalChipsCount={totalChipsCount} totalChipsCount={totalChipsCount}
/> />
<Button <Button title="Save to Slot 1" onPress={() => handleSave("SLOT1")} disabled={buyInAmount === null} />
djwesty commented 2025-02-25 21:23:25 -08:00 (Migrated from github.com)
Review

It appears that when resolving the merge conflicts, there may have been some regressions. That is to say, these things were changed and committed before you started work, but then undone here. Things I notice on quick glace

  • This title "Poker chips helper" was removed
  • The default state of buyInAmount near the top was changed to 20 from null

Can you fix these up?

It appears that when resolving the merge conflicts, there may have been some regressions. That is to say, these things were changed and committed before you started work, but then undone here. Things I notice on quick glace - This title "Poker chips helper" was removed - The default state of `buyInAmount` near the top was changed to `20` from `null` Can you fix these up?
djwesty commented 2025-02-25 21:26:34 -08:00 (Migrated from github.com)
Review

These buttons at the end are ok and satisfy the issue. In the next sprint, we should explore moving them to the title bar and maybe replacing them with an icon or something similar.

Nothing to do for now, but keep a mental note

These buttons at the end are ok and satisfy the issue. In the next sprint, we should explore moving them to the title bar and maybe replacing them with an icon or something similar. Nothing to do for now, but keep a mental note
MantashaNoyela commented 2025-02-25 22:03:04 -08:00 (Migrated from github.com)
Review

As I encountered the conflict problem, I removed the folder from my laptop and cloned it again. But I used the code which I had written way before that. May be that's why these problem occured.

As I encountered the conflict problem, I removed the folder from my laptop and cloned it again. But I used the code which I had written way before that. May be that's why these problem occured.
MantashaNoyela commented 2025-02-25 22:04:33 -08:00 (Migrated from github.com)
Review

got it

got it
MantashaNoyela commented 2025-02-25 22:21:05 -08:00 (Migrated from github.com)
Review

I have changed it

I have changed it
djwesty commented 2025-02-25 21:23:25 -08:00 (Migrated from github.com)
Review

It appears that when resolving the merge conflicts, there may have been some regressions. That is to say, these things were changed and committed before you started work, but then undone here. Things I notice on quick glace

  • This title "Poker chips helper" was removed
  • The default state of buyInAmount near the top was changed to 20 from null

Can you fix these up?

It appears that when resolving the merge conflicts, there may have been some regressions. That is to say, these things were changed and committed before you started work, but then undone here. Things I notice on quick glace - This title "Poker chips helper" was removed - The default state of `buyInAmount` near the top was changed to `20` from `null` Can you fix these up?
djwesty commented 2025-02-25 21:26:34 -08:00 (Migrated from github.com)
Review

These buttons at the end are ok and satisfy the issue. In the next sprint, we should explore moving them to the title bar and maybe replacing them with an icon or something similar.

Nothing to do for now, but keep a mental note

These buttons at the end are ok and satisfy the issue. In the next sprint, we should explore moving them to the title bar and maybe replacing them with an icon or something similar. Nothing to do for now, but keep a mental note
MantashaNoyela commented 2025-02-25 22:03:04 -08:00 (Migrated from github.com)
Review

As I encountered the conflict problem, I removed the folder from my laptop and cloned it again. But I used the code which I had written way before that. May be that's why these problem occured.

As I encountered the conflict problem, I removed the folder from my laptop and cloned it again. But I used the code which I had written way before that. May be that's why these problem occured.
MantashaNoyela commented 2025-02-25 22:04:33 -08:00 (Migrated from github.com)
Review

got it

got it
MantashaNoyela commented 2025-02-25 22:21:05 -08:00 (Migrated from github.com)
Review

I have changed it

I have changed it
title="Save" <Button title="Save to Slot 2" onPress={() => handleSave("SLOT2")} disabled={buyInAmount === null} />
djwesty commented 2025-02-25 21:23:25 -08:00 (Migrated from github.com)
Review

It appears that when resolving the merge conflicts, there may have been some regressions. That is to say, these things were changed and committed before you started work, but then undone here. Things I notice on quick glace

  • This title "Poker chips helper" was removed
  • The default state of buyInAmount near the top was changed to 20 from null

Can you fix these up?

It appears that when resolving the merge conflicts, there may have been some regressions. That is to say, these things were changed and committed before you started work, but then undone here. Things I notice on quick glace - This title "Poker chips helper" was removed - The default state of `buyInAmount` near the top was changed to `20` from `null` Can you fix these up?
djwesty commented 2025-02-25 21:26:34 -08:00 (Migrated from github.com)
Review

These buttons at the end are ok and satisfy the issue. In the next sprint, we should explore moving them to the title bar and maybe replacing them with an icon or something similar.

Nothing to do for now, but keep a mental note

These buttons at the end are ok and satisfy the issue. In the next sprint, we should explore moving them to the title bar and maybe replacing them with an icon or something similar. Nothing to do for now, but keep a mental note
MantashaNoyela commented 2025-02-25 22:03:04 -08:00 (Migrated from github.com)
Review

As I encountered the conflict problem, I removed the folder from my laptop and cloned it again. But I used the code which I had written way before that. May be that's why these problem occured.

As I encountered the conflict problem, I removed the folder from my laptop and cloned it again. But I used the code which I had written way before that. May be that's why these problem occured.
MantashaNoyela commented 2025-02-25 22:04:33 -08:00 (Migrated from github.com)
Review

got it

got it
MantashaNoyela commented 2025-02-25 22:21:05 -08:00 (Migrated from github.com)
Review

I have changed it

I have changed it
djwesty commented 2025-02-25 21:23:25 -08:00 (Migrated from github.com)
Review

It appears that when resolving the merge conflicts, there may have been some regressions. That is to say, these things were changed and committed before you started work, but then undone here. Things I notice on quick glace

  • This title "Poker chips helper" was removed
  • The default state of buyInAmount near the top was changed to 20 from null

Can you fix these up?

It appears that when resolving the merge conflicts, there may have been some regressions. That is to say, these things were changed and committed before you started work, but then undone here. Things I notice on quick glace - This title "Poker chips helper" was removed - The default state of `buyInAmount` near the top was changed to `20` from `null` Can you fix these up?
djwesty commented 2025-02-25 21:26:34 -08:00 (Migrated from github.com)
Review

These buttons at the end are ok and satisfy the issue. In the next sprint, we should explore moving them to the title bar and maybe replacing them with an icon or something similar.

Nothing to do for now, but keep a mental note

These buttons at the end are ok and satisfy the issue. In the next sprint, we should explore moving them to the title bar and maybe replacing them with an icon or something similar. Nothing to do for now, but keep a mental note
MantashaNoyela commented 2025-02-25 22:03:04 -08:00 (Migrated from github.com)
Review

As I encountered the conflict problem, I removed the folder from my laptop and cloned it again. But I used the code which I had written way before that. May be that's why these problem occured.

As I encountered the conflict problem, I removed the folder from my laptop and cloned it again. But I used the code which I had written way before that. May be that's why these problem occured.
MantashaNoyela commented 2025-02-25 22:04:33 -08:00 (Migrated from github.com)
Review

got it

got it
MantashaNoyela commented 2025-02-25 22:21:05 -08:00 (Migrated from github.com)
Review

I have changed it

I have changed it
onPress={handleSave} <Button title="Load from Slot 1" onPress={() => handleLoad("SLOT1")} />
djwesty commented 2025-02-25 21:23:25 -08:00 (Migrated from github.com)
Review

It appears that when resolving the merge conflicts, there may have been some regressions. That is to say, these things were changed and committed before you started work, but then undone here. Things I notice on quick glace

  • This title "Poker chips helper" was removed
  • The default state of buyInAmount near the top was changed to 20 from null

Can you fix these up?

It appears that when resolving the merge conflicts, there may have been some regressions. That is to say, these things were changed and committed before you started work, but then undone here. Things I notice on quick glace - This title "Poker chips helper" was removed - The default state of `buyInAmount` near the top was changed to `20` from `null` Can you fix these up?
djwesty commented 2025-02-25 21:26:34 -08:00 (Migrated from github.com)
Review

These buttons at the end are ok and satisfy the issue. In the next sprint, we should explore moving them to the title bar and maybe replacing them with an icon or something similar.

Nothing to do for now, but keep a mental note

These buttons at the end are ok and satisfy the issue. In the next sprint, we should explore moving them to the title bar and maybe replacing them with an icon or something similar. Nothing to do for now, but keep a mental note
MantashaNoyela commented 2025-02-25 22:03:04 -08:00 (Migrated from github.com)
Review

As I encountered the conflict problem, I removed the folder from my laptop and cloned it again. But I used the code which I had written way before that. May be that's why these problem occured.

As I encountered the conflict problem, I removed the folder from my laptop and cloned it again. But I used the code which I had written way before that. May be that's why these problem occured.
MantashaNoyela commented 2025-02-25 22:04:33 -08:00 (Migrated from github.com)
Review

got it

got it
MantashaNoyela commented 2025-02-25 22:21:05 -08:00 (Migrated from github.com)
Review

I have changed it

I have changed it
djwesty commented 2025-02-25 21:23:25 -08:00 (Migrated from github.com)
Review

It appears that when resolving the merge conflicts, there may have been some regressions. That is to say, these things were changed and committed before you started work, but then undone here. Things I notice on quick glace

  • This title "Poker chips helper" was removed
  • The default state of buyInAmount near the top was changed to 20 from null

Can you fix these up?

It appears that when resolving the merge conflicts, there may have been some regressions. That is to say, these things were changed and committed before you started work, but then undone here. Things I notice on quick glace - This title "Poker chips helper" was removed - The default state of `buyInAmount` near the top was changed to `20` from `null` Can you fix these up?
djwesty commented 2025-02-25 21:26:34 -08:00 (Migrated from github.com)
Review

These buttons at the end are ok and satisfy the issue. In the next sprint, we should explore moving them to the title bar and maybe replacing them with an icon or something similar.

Nothing to do for now, but keep a mental note

These buttons at the end are ok and satisfy the issue. In the next sprint, we should explore moving them to the title bar and maybe replacing them with an icon or something similar. Nothing to do for now, but keep a mental note
MantashaNoyela commented 2025-02-25 22:03:04 -08:00 (Migrated from github.com)
Review

As I encountered the conflict problem, I removed the folder from my laptop and cloned it again. But I used the code which I had written way before that. May be that's why these problem occured.

As I encountered the conflict problem, I removed the folder from my laptop and cloned it again. But I used the code which I had written way before that. May be that's why these problem occured.
MantashaNoyela commented 2025-02-25 22:04:33 -08:00 (Migrated from github.com)
Review

got it

got it
MantashaNoyela commented 2025-02-25 22:21:05 -08:00 (Migrated from github.com)
Review

I have changed it

I have changed it
disabled={buyInAmount === null} <Button title="Load from Slot 2" onPress={() => handleLoad("SLOT2")} />
djwesty commented 2025-02-25 21:23:25 -08:00 (Migrated from github.com)
Review

It appears that when resolving the merge conflicts, there may have been some regressions. That is to say, these things were changed and committed before you started work, but then undone here. Things I notice on quick glace

  • This title "Poker chips helper" was removed
  • The default state of buyInAmount near the top was changed to 20 from null

Can you fix these up?

It appears that when resolving the merge conflicts, there may have been some regressions. That is to say, these things were changed and committed before you started work, but then undone here. Things I notice on quick glace - This title "Poker chips helper" was removed - The default state of `buyInAmount` near the top was changed to `20` from `null` Can you fix these up?
djwesty commented 2025-02-25 21:26:34 -08:00 (Migrated from github.com)
Review

These buttons at the end are ok and satisfy the issue. In the next sprint, we should explore moving them to the title bar and maybe replacing them with an icon or something similar.

Nothing to do for now, but keep a mental note

These buttons at the end are ok and satisfy the issue. In the next sprint, we should explore moving them to the title bar and maybe replacing them with an icon or something similar. Nothing to do for now, but keep a mental note
MantashaNoyela commented 2025-02-25 22:03:04 -08:00 (Migrated from github.com)
Review

As I encountered the conflict problem, I removed the folder from my laptop and cloned it again. But I used the code which I had written way before that. May be that's why these problem occured.

As I encountered the conflict problem, I removed the folder from my laptop and cloned it again. But I used the code which I had written way before that. May be that's why these problem occured.
MantashaNoyela commented 2025-02-25 22:04:33 -08:00 (Migrated from github.com)
Review

got it

got it
MantashaNoyela commented 2025-02-25 22:21:05 -08:00 (Migrated from github.com)
Review

I have changed it

I have changed it
djwesty commented 2025-02-25 21:23:25 -08:00 (Migrated from github.com)
Review

It appears that when resolving the merge conflicts, there may have been some regressions. That is to say, these things were changed and committed before you started work, but then undone here. Things I notice on quick glace

  • This title "Poker chips helper" was removed
  • The default state of buyInAmount near the top was changed to 20 from null

Can you fix these up?

It appears that when resolving the merge conflicts, there may have been some regressions. That is to say, these things were changed and committed before you started work, but then undone here. Things I notice on quick glace - This title "Poker chips helper" was removed - The default state of `buyInAmount` near the top was changed to `20` from `null` Can you fix these up?
djwesty commented 2025-02-25 21:26:34 -08:00 (Migrated from github.com)
Review

These buttons at the end are ok and satisfy the issue. In the next sprint, we should explore moving them to the title bar and maybe replacing them with an icon or something similar.

Nothing to do for now, but keep a mental note

These buttons at the end are ok and satisfy the issue. In the next sprint, we should explore moving them to the title bar and maybe replacing them with an icon or something similar. Nothing to do for now, but keep a mental note
MantashaNoyela commented 2025-02-25 22:03:04 -08:00 (Migrated from github.com)
Review

As I encountered the conflict problem, I removed the folder from my laptop and cloned it again. But I used the code which I had written way before that. May be that's why these problem occured.

As I encountered the conflict problem, I removed the folder from my laptop and cloned it again. But I used the code which I had written way before that. May be that's why these problem occured.
MantashaNoyela commented 2025-02-25 22:04:33 -08:00 (Migrated from github.com)
Review

got it

got it
MantashaNoyela commented 2025-02-25 22:21:05 -08:00 (Migrated from github.com)
Review

I have changed it

I have changed it
/>
djwesty commented 2025-02-25 21:23:25 -08:00 (Migrated from github.com)
Review

It appears that when resolving the merge conflicts, there may have been some regressions. That is to say, these things were changed and committed before you started work, but then undone here. Things I notice on quick glace

  • This title "Poker chips helper" was removed
  • The default state of buyInAmount near the top was changed to 20 from null

Can you fix these up?

It appears that when resolving the merge conflicts, there may have been some regressions. That is to say, these things were changed and committed before you started work, but then undone here. Things I notice on quick glace - This title "Poker chips helper" was removed - The default state of `buyInAmount` near the top was changed to `20` from `null` Can you fix these up?
djwesty commented 2025-02-25 21:26:34 -08:00 (Migrated from github.com)
Review

These buttons at the end are ok and satisfy the issue. In the next sprint, we should explore moving them to the title bar and maybe replacing them with an icon or something similar.

Nothing to do for now, but keep a mental note

These buttons at the end are ok and satisfy the issue. In the next sprint, we should explore moving them to the title bar and maybe replacing them with an icon or something similar. Nothing to do for now, but keep a mental note
MantashaNoyela commented 2025-02-25 22:03:04 -08:00 (Migrated from github.com)
Review

As I encountered the conflict problem, I removed the folder from my laptop and cloned it again. But I used the code which I had written way before that. May be that's why these problem occured.

As I encountered the conflict problem, I removed the folder from my laptop and cloned it again. But I used the code which I had written way before that. May be that's why these problem occured.
MantashaNoyela commented 2025-02-25 22:04:33 -08:00 (Migrated from github.com)
Review

got it

got it
MantashaNoyela commented 2025-02-25 22:21:05 -08:00 (Migrated from github.com)
Review

I have changed it

I have changed it
</ScrollView> </ScrollView>
</View>
djwesty commented 2025-02-25 21:23:25 -08:00 (Migrated from github.com)
Review

It appears that when resolving the merge conflicts, there may have been some regressions. That is to say, these things were changed and committed before you started work, but then undone here. Things I notice on quick glace

  • This title "Poker chips helper" was removed
  • The default state of buyInAmount near the top was changed to 20 from null

Can you fix these up?

It appears that when resolving the merge conflicts, there may have been some regressions. That is to say, these things were changed and committed before you started work, but then undone here. Things I notice on quick glace - This title "Poker chips helper" was removed - The default state of `buyInAmount` near the top was changed to `20` from `null` Can you fix these up?
djwesty commented 2025-02-25 21:26:34 -08:00 (Migrated from github.com)
Review

These buttons at the end are ok and satisfy the issue. In the next sprint, we should explore moving them to the title bar and maybe replacing them with an icon or something similar.

Nothing to do for now, but keep a mental note

These buttons at the end are ok and satisfy the issue. In the next sprint, we should explore moving them to the title bar and maybe replacing them with an icon or something similar. Nothing to do for now, but keep a mental note
MantashaNoyela commented 2025-02-25 22:03:04 -08:00 (Migrated from github.com)
Review

As I encountered the conflict problem, I removed the folder from my laptop and cloned it again. But I used the code which I had written way before that. May be that's why these problem occured.

As I encountered the conflict problem, I removed the folder from my laptop and cloned it again. But I used the code which I had written way before that. May be that's why these problem occured.
MantashaNoyela commented 2025-02-25 22:04:33 -08:00 (Migrated from github.com)
Review

got it

got it
MantashaNoyela commented 2025-02-25 22:21:05 -08:00 (Migrated from github.com)
Review

I have changed it

I have changed it
); );
}; };
const styles = StyleSheet.create({
djwesty commented 2025-02-25 21:23:25 -08:00 (Migrated from github.com)
Review

It appears that when resolving the merge conflicts, there may have been some regressions. That is to say, these things were changed and committed before you started work, but then undone here. Things I notice on quick glace

  • This title "Poker chips helper" was removed
  • The default state of buyInAmount near the top was changed to 20 from null

Can you fix these up?

It appears that when resolving the merge conflicts, there may have been some regressions. That is to say, these things were changed and committed before you started work, but then undone here. Things I notice on quick glace - This title "Poker chips helper" was removed - The default state of `buyInAmount` near the top was changed to `20` from `null` Can you fix these up?
djwesty commented 2025-02-25 21:26:34 -08:00 (Migrated from github.com)
Review

These buttons at the end are ok and satisfy the issue. In the next sprint, we should explore moving them to the title bar and maybe replacing them with an icon or something similar.

Nothing to do for now, but keep a mental note

These buttons at the end are ok and satisfy the issue. In the next sprint, we should explore moving them to the title bar and maybe replacing them with an icon or something similar. Nothing to do for now, but keep a mental note
MantashaNoyela commented 2025-02-25 22:03:04 -08:00 (Migrated from github.com)
Review

As I encountered the conflict problem, I removed the folder from my laptop and cloned it again. But I used the code which I had written way before that. May be that's why these problem occured.

As I encountered the conflict problem, I removed the folder from my laptop and cloned it again. But I used the code which I had written way before that. May be that's why these problem occured.
MantashaNoyela commented 2025-02-25 22:04:33 -08:00 (Migrated from github.com)
Review

got it

got it
MantashaNoyela commented 2025-02-25 22:21:05 -08:00 (Migrated from github.com)
Review

I have changed it

I have changed it
container: {
djwesty commented 2025-02-25 21:23:25 -08:00 (Migrated from github.com)
Review

It appears that when resolving the merge conflicts, there may have been some regressions. That is to say, these things were changed and committed before you started work, but then undone here. Things I notice on quick glace

  • This title "Poker chips helper" was removed
  • The default state of buyInAmount near the top was changed to 20 from null

Can you fix these up?

It appears that when resolving the merge conflicts, there may have been some regressions. That is to say, these things were changed and committed before you started work, but then undone here. Things I notice on quick glace - This title "Poker chips helper" was removed - The default state of `buyInAmount` near the top was changed to `20` from `null` Can you fix these up?
djwesty commented 2025-02-25 21:26:34 -08:00 (Migrated from github.com)
Review

These buttons at the end are ok and satisfy the issue. In the next sprint, we should explore moving them to the title bar and maybe replacing them with an icon or something similar.

Nothing to do for now, but keep a mental note

These buttons at the end are ok and satisfy the issue. In the next sprint, we should explore moving them to the title bar and maybe replacing them with an icon or something similar. Nothing to do for now, but keep a mental note
MantashaNoyela commented 2025-02-25 22:03:04 -08:00 (Migrated from github.com)
Review

As I encountered the conflict problem, I removed the folder from my laptop and cloned it again. But I used the code which I had written way before that. May be that's why these problem occured.

As I encountered the conflict problem, I removed the folder from my laptop and cloned it again. But I used the code which I had written way before that. May be that's why these problem occured.
MantashaNoyela commented 2025-02-25 22:04:33 -08:00 (Migrated from github.com)
Review

got it

got it
MantashaNoyela commented 2025-02-25 22:21:05 -08:00 (Migrated from github.com)
Review

I have changed it

I have changed it
flex: 1,
djwesty commented 2025-02-25 21:23:25 -08:00 (Migrated from github.com)
Review

It appears that when resolving the merge conflicts, there may have been some regressions. That is to say, these things were changed and committed before you started work, but then undone here. Things I notice on quick glace

  • This title "Poker chips helper" was removed
  • The default state of buyInAmount near the top was changed to 20 from null

Can you fix these up?

It appears that when resolving the merge conflicts, there may have been some regressions. That is to say, these things were changed and committed before you started work, but then undone here. Things I notice on quick glace - This title "Poker chips helper" was removed - The default state of `buyInAmount` near the top was changed to `20` from `null` Can you fix these up?
djwesty commented 2025-02-25 21:26:34 -08:00 (Migrated from github.com)
Review

These buttons at the end are ok and satisfy the issue. In the next sprint, we should explore moving them to the title bar and maybe replacing them with an icon or something similar.

Nothing to do for now, but keep a mental note

These buttons at the end are ok and satisfy the issue. In the next sprint, we should explore moving them to the title bar and maybe replacing them with an icon or something similar. Nothing to do for now, but keep a mental note
MantashaNoyela commented 2025-02-25 22:03:04 -08:00 (Migrated from github.com)
Review

As I encountered the conflict problem, I removed the folder from my laptop and cloned it again. But I used the code which I had written way before that. May be that's why these problem occured.

As I encountered the conflict problem, I removed the folder from my laptop and cloned it again. But I used the code which I had written way before that. May be that's why these problem occured.
MantashaNoyela commented 2025-02-25 22:04:33 -08:00 (Migrated from github.com)
Review

got it

got it
MantashaNoyela commented 2025-02-25 22:21:05 -08:00 (Migrated from github.com)
Review

I have changed it

I have changed it
},
djwesty commented 2025-02-25 21:23:25 -08:00 (Migrated from github.com)
Review

It appears that when resolving the merge conflicts, there may have been some regressions. That is to say, these things were changed and committed before you started work, but then undone here. Things I notice on quick glace

  • This title "Poker chips helper" was removed
  • The default state of buyInAmount near the top was changed to 20 from null

Can you fix these up?

It appears that when resolving the merge conflicts, there may have been some regressions. That is to say, these things were changed and committed before you started work, but then undone here. Things I notice on quick glace - This title "Poker chips helper" was removed - The default state of `buyInAmount` near the top was changed to `20` from `null` Can you fix these up?
djwesty commented 2025-02-25 21:26:34 -08:00 (Migrated from github.com)
Review

These buttons at the end are ok and satisfy the issue. In the next sprint, we should explore moving them to the title bar and maybe replacing them with an icon or something similar.

Nothing to do for now, but keep a mental note

These buttons at the end are ok and satisfy the issue. In the next sprint, we should explore moving them to the title bar and maybe replacing them with an icon or something similar. Nothing to do for now, but keep a mental note
MantashaNoyela commented 2025-02-25 22:03:04 -08:00 (Migrated from github.com)
Review

As I encountered the conflict problem, I removed the folder from my laptop and cloned it again. But I used the code which I had written way before that. May be that's why these problem occured.

As I encountered the conflict problem, I removed the folder from my laptop and cloned it again. But I used the code which I had written way before that. May be that's why these problem occured.
MantashaNoyela commented 2025-02-25 22:04:33 -08:00 (Migrated from github.com)
Review

got it

got it
MantashaNoyela commented 2025-02-25 22:21:05 -08:00 (Migrated from github.com)
Review

I have changed it

I have changed it
title: {
djwesty commented 2025-02-25 21:23:25 -08:00 (Migrated from github.com)
Review

It appears that when resolving the merge conflicts, there may have been some regressions. That is to say, these things were changed and committed before you started work, but then undone here. Things I notice on quick glace

  • This title "Poker chips helper" was removed
  • The default state of buyInAmount near the top was changed to 20 from null

Can you fix these up?

It appears that when resolving the merge conflicts, there may have been some regressions. That is to say, these things were changed and committed before you started work, but then undone here. Things I notice on quick glace - This title "Poker chips helper" was removed - The default state of `buyInAmount` near the top was changed to `20` from `null` Can you fix these up?
djwesty commented 2025-02-25 21:26:34 -08:00 (Migrated from github.com)
Review

These buttons at the end are ok and satisfy the issue. In the next sprint, we should explore moving them to the title bar and maybe replacing them with an icon or something similar.

Nothing to do for now, but keep a mental note

These buttons at the end are ok and satisfy the issue. In the next sprint, we should explore moving them to the title bar and maybe replacing them with an icon or something similar. Nothing to do for now, but keep a mental note
MantashaNoyela commented 2025-02-25 22:03:04 -08:00 (Migrated from github.com)
Review

As I encountered the conflict problem, I removed the folder from my laptop and cloned it again. But I used the code which I had written way before that. May be that's why these problem occured.

As I encountered the conflict problem, I removed the folder from my laptop and cloned it again. But I used the code which I had written way before that. May be that's why these problem occured.
MantashaNoyela commented 2025-02-25 22:04:33 -08:00 (Migrated from github.com)
Review

got it

got it
MantashaNoyela commented 2025-02-25 22:21:05 -08:00 (Migrated from github.com)
Review

I have changed it

I have changed it
fontSize: 24,
djwesty commented 2025-02-25 21:23:25 -08:00 (Migrated from github.com)
Review

It appears that when resolving the merge conflicts, there may have been some regressions. That is to say, these things were changed and committed before you started work, but then undone here. Things I notice on quick glace

  • This title "Poker chips helper" was removed
  • The default state of buyInAmount near the top was changed to 20 from null

Can you fix these up?

It appears that when resolving the merge conflicts, there may have been some regressions. That is to say, these things were changed and committed before you started work, but then undone here. Things I notice on quick glace - This title "Poker chips helper" was removed - The default state of `buyInAmount` near the top was changed to `20` from `null` Can you fix these up?
djwesty commented 2025-02-25 21:26:34 -08:00 (Migrated from github.com)
Review

These buttons at the end are ok and satisfy the issue. In the next sprint, we should explore moving them to the title bar and maybe replacing them with an icon or something similar.

Nothing to do for now, but keep a mental note

These buttons at the end are ok and satisfy the issue. In the next sprint, we should explore moving them to the title bar and maybe replacing them with an icon or something similar. Nothing to do for now, but keep a mental note
MantashaNoyela commented 2025-02-25 22:03:04 -08:00 (Migrated from github.com)
Review

As I encountered the conflict problem, I removed the folder from my laptop and cloned it again. But I used the code which I had written way before that. May be that's why these problem occured.

As I encountered the conflict problem, I removed the folder from my laptop and cloned it again. But I used the code which I had written way before that. May be that's why these problem occured.
MantashaNoyela commented 2025-02-25 22:04:33 -08:00 (Migrated from github.com)
Review

got it

got it
MantashaNoyela commented 2025-02-25 22:21:05 -08:00 (Migrated from github.com)
Review

I have changed it

I have changed it
marginBottom: 30,
djwesty commented 2025-02-25 21:23:25 -08:00 (Migrated from github.com)
Review

It appears that when resolving the merge conflicts, there may have been some regressions. That is to say, these things were changed and committed before you started work, but then undone here. Things I notice on quick glace

  • This title "Poker chips helper" was removed
  • The default state of buyInAmount near the top was changed to 20 from null

Can you fix these up?

It appears that when resolving the merge conflicts, there may have been some regressions. That is to say, these things were changed and committed before you started work, but then undone here. Things I notice on quick glace - This title "Poker chips helper" was removed - The default state of `buyInAmount` near the top was changed to `20` from `null` Can you fix these up?
djwesty commented 2025-02-25 21:26:34 -08:00 (Migrated from github.com)
Review

These buttons at the end are ok and satisfy the issue. In the next sprint, we should explore moving them to the title bar and maybe replacing them with an icon or something similar.

Nothing to do for now, but keep a mental note

These buttons at the end are ok and satisfy the issue. In the next sprint, we should explore moving them to the title bar and maybe replacing them with an icon or something similar. Nothing to do for now, but keep a mental note
MantashaNoyela commented 2025-02-25 22:03:04 -08:00 (Migrated from github.com)
Review

As I encountered the conflict problem, I removed the folder from my laptop and cloned it again. But I used the code which I had written way before that. May be that's why these problem occured.

As I encountered the conflict problem, I removed the folder from my laptop and cloned it again. But I used the code which I had written way before that. May be that's why these problem occured.
MantashaNoyela commented 2025-02-25 22:04:33 -08:00 (Migrated from github.com)
Review

got it

got it
MantashaNoyela commented 2025-02-25 22:21:05 -08:00 (Migrated from github.com)
Review

I have changed it

I have changed it
marginTop: 50,
djwesty commented 2025-02-25 21:23:25 -08:00 (Migrated from github.com)
Review

It appears that when resolving the merge conflicts, there may have been some regressions. That is to say, these things were changed and committed before you started work, but then undone here. Things I notice on quick glace

  • This title "Poker chips helper" was removed
  • The default state of buyInAmount near the top was changed to 20 from null

Can you fix these up?

It appears that when resolving the merge conflicts, there may have been some regressions. That is to say, these things were changed and committed before you started work, but then undone here. Things I notice on quick glace - This title "Poker chips helper" was removed - The default state of `buyInAmount` near the top was changed to `20` from `null` Can you fix these up?
djwesty commented 2025-02-25 21:26:34 -08:00 (Migrated from github.com)
Review

These buttons at the end are ok and satisfy the issue. In the next sprint, we should explore moving them to the title bar and maybe replacing them with an icon or something similar.

Nothing to do for now, but keep a mental note

These buttons at the end are ok and satisfy the issue. In the next sprint, we should explore moving them to the title bar and maybe replacing them with an icon or something similar. Nothing to do for now, but keep a mental note
MantashaNoyela commented 2025-02-25 22:03:04 -08:00 (Migrated from github.com)
Review

As I encountered the conflict problem, I removed the folder from my laptop and cloned it again. But I used the code which I had written way before that. May be that's why these problem occured.

As I encountered the conflict problem, I removed the folder from my laptop and cloned it again. But I used the code which I had written way before that. May be that's why these problem occured.
MantashaNoyela commented 2025-02-25 22:04:33 -08:00 (Migrated from github.com)
Review

got it

got it
MantashaNoyela commented 2025-02-25 22:21:05 -08:00 (Migrated from github.com)
Review

I have changed it

I have changed it
textAlign: "center",
djwesty commented 2025-02-25 21:23:25 -08:00 (Migrated from github.com)
Review

It appears that when resolving the merge conflicts, there may have been some regressions. That is to say, these things were changed and committed before you started work, but then undone here. Things I notice on quick glace

  • This title "Poker chips helper" was removed
  • The default state of buyInAmount near the top was changed to 20 from null

Can you fix these up?

It appears that when resolving the merge conflicts, there may have been some regressions. That is to say, these things were changed and committed before you started work, but then undone here. Things I notice on quick glace - This title "Poker chips helper" was removed - The default state of `buyInAmount` near the top was changed to `20` from `null` Can you fix these up?
djwesty commented 2025-02-25 21:26:34 -08:00 (Migrated from github.com)
Review

These buttons at the end are ok and satisfy the issue. In the next sprint, we should explore moving them to the title bar and maybe replacing them with an icon or something similar.

Nothing to do for now, but keep a mental note

These buttons at the end are ok and satisfy the issue. In the next sprint, we should explore moving them to the title bar and maybe replacing them with an icon or something similar. Nothing to do for now, but keep a mental note
MantashaNoyela commented 2025-02-25 22:03:04 -08:00 (Migrated from github.com)
Review

As I encountered the conflict problem, I removed the folder from my laptop and cloned it again. But I used the code which I had written way before that. May be that's why these problem occured.

As I encountered the conflict problem, I removed the folder from my laptop and cloned it again. But I used the code which I had written way before that. May be that's why these problem occured.
MantashaNoyela commented 2025-02-25 22:04:33 -08:00 (Migrated from github.com)
Review

got it

got it
MantashaNoyela commented 2025-02-25 22:21:05 -08:00 (Migrated from github.com)
Review

I have changed it

I have changed it
},
djwesty commented 2025-02-25 21:23:25 -08:00 (Migrated from github.com)
Review

It appears that when resolving the merge conflicts, there may have been some regressions. That is to say, these things were changed and committed before you started work, but then undone here. Things I notice on quick glace

  • This title "Poker chips helper" was removed
  • The default state of buyInAmount near the top was changed to 20 from null

Can you fix these up?

It appears that when resolving the merge conflicts, there may have been some regressions. That is to say, these things were changed and committed before you started work, but then undone here. Things I notice on quick glace - This title "Poker chips helper" was removed - The default state of `buyInAmount` near the top was changed to `20` from `null` Can you fix these up?
djwesty commented 2025-02-25 21:26:34 -08:00 (Migrated from github.com)
Review

These buttons at the end are ok and satisfy the issue. In the next sprint, we should explore moving them to the title bar and maybe replacing them with an icon or something similar.

Nothing to do for now, but keep a mental note

These buttons at the end are ok and satisfy the issue. In the next sprint, we should explore moving them to the title bar and maybe replacing them with an icon or something similar. Nothing to do for now, but keep a mental note
MantashaNoyela commented 2025-02-25 22:03:04 -08:00 (Migrated from github.com)
Review

As I encountered the conflict problem, I removed the folder from my laptop and cloned it again. But I used the code which I had written way before that. May be that's why these problem occured.

As I encountered the conflict problem, I removed the folder from my laptop and cloned it again. But I used the code which I had written way before that. May be that's why these problem occured.
MantashaNoyela commented 2025-02-25 22:04:33 -08:00 (Migrated from github.com)
Review

got it

got it
MantashaNoyela commented 2025-02-25 22:21:05 -08:00 (Migrated from github.com)
Review

I have changed it

I have changed it
});
djwesty commented 2025-02-25 21:23:25 -08:00 (Migrated from github.com)
Review

It appears that when resolving the merge conflicts, there may have been some regressions. That is to say, these things were changed and committed before you started work, but then undone here. Things I notice on quick glace

  • This title "Poker chips helper" was removed
  • The default state of buyInAmount near the top was changed to 20 from null

Can you fix these up?

It appears that when resolving the merge conflicts, there may have been some regressions. That is to say, these things were changed and committed before you started work, but then undone here. Things I notice on quick glace - This title "Poker chips helper" was removed - The default state of `buyInAmount` near the top was changed to `20` from `null` Can you fix these up?
djwesty commented 2025-02-25 21:26:34 -08:00 (Migrated from github.com)
Review

These buttons at the end are ok and satisfy the issue. In the next sprint, we should explore moving them to the title bar and maybe replacing them with an icon or something similar.

Nothing to do for now, but keep a mental note

These buttons at the end are ok and satisfy the issue. In the next sprint, we should explore moving them to the title bar and maybe replacing them with an icon or something similar. Nothing to do for now, but keep a mental note
MantashaNoyela commented 2025-02-25 22:03:04 -08:00 (Migrated from github.com)
Review

As I encountered the conflict problem, I removed the folder from my laptop and cloned it again. But I used the code which I had written way before that. May be that's why these problem occured.

As I encountered the conflict problem, I removed the folder from my laptop and cloned it again. But I used the code which I had written way before that. May be that's why these problem occured.
MantashaNoyela commented 2025-02-25 22:04:33 -08:00 (Migrated from github.com)
Review

got it

got it
MantashaNoyela commented 2025-02-25 22:21:05 -08:00 (Migrated from github.com)
Review

I have changed it

I have changed it
djwesty commented 2025-02-25 21:23:25 -08:00 (Migrated from github.com)
Review

It appears that when resolving the merge conflicts, there may have been some regressions. That is to say, these things were changed and committed before you started work, but then undone here. Things I notice on quick glace

  • This title "Poker chips helper" was removed
  • The default state of buyInAmount near the top was changed to 20 from null

Can you fix these up?

It appears that when resolving the merge conflicts, there may have been some regressions. That is to say, these things were changed and committed before you started work, but then undone here. Things I notice on quick glace - This title "Poker chips helper" was removed - The default state of `buyInAmount` near the top was changed to `20` from `null` Can you fix these up?
djwesty commented 2025-02-25 21:26:34 -08:00 (Migrated from github.com)
Review

These buttons at the end are ok and satisfy the issue. In the next sprint, we should explore moving them to the title bar and maybe replacing them with an icon or something similar.

Nothing to do for now, but keep a mental note

These buttons at the end are ok and satisfy the issue. In the next sprint, we should explore moving them to the title bar and maybe replacing them with an icon or something similar. Nothing to do for now, but keep a mental note
MantashaNoyela commented 2025-02-25 22:03:04 -08:00 (Migrated from github.com)
Review

As I encountered the conflict problem, I removed the folder from my laptop and cloned it again. But I used the code which I had written way before that. May be that's why these problem occured.

As I encountered the conflict problem, I removed the folder from my laptop and cloned it again. But I used the code which I had written way before that. May be that's why these problem occured.
MantashaNoyela commented 2025-02-25 22:04:33 -08:00 (Migrated from github.com)
Review

got it

got it
MantashaNoyela commented 2025-02-25 22:21:05 -08:00 (Migrated from github.com)
Review

I have changed it

I have changed it
export default IndexScreen; export default IndexScreen;

djwesty commented 2025-02-25 21:23:25 -08:00 (Migrated from github.com)
Review

It appears that when resolving the merge conflicts, there may have been some regressions. That is to say, these things were changed and committed before you started work, but then undone here. Things I notice on quick glace

  • This title "Poker chips helper" was removed
  • The default state of buyInAmount near the top was changed to 20 from null

Can you fix these up?

It appears that when resolving the merge conflicts, there may have been some regressions. That is to say, these things were changed and committed before you started work, but then undone here. Things I notice on quick glace - This title "Poker chips helper" was removed - The default state of `buyInAmount` near the top was changed to `20` from `null` Can you fix these up?
djwesty commented 2025-02-25 21:23:25 -08:00 (Migrated from github.com)
Review

It appears that when resolving the merge conflicts, there may have been some regressions. That is to say, these things were changed and committed before you started work, but then undone here. Things I notice on quick glace

  • This title "Poker chips helper" was removed
  • The default state of buyInAmount near the top was changed to 20 from null

Can you fix these up?

It appears that when resolving the merge conflicts, there may have been some regressions. That is to say, these things were changed and committed before you started work, but then undone here. Things I notice on quick glace - This title "Poker chips helper" was removed - The default state of `buyInAmount` near the top was changed to `20` from `null` Can you fix these up?
djwesty commented 2025-02-25 21:26:34 -08:00 (Migrated from github.com)
Review

These buttons at the end are ok and satisfy the issue. In the next sprint, we should explore moving them to the title bar and maybe replacing them with an icon or something similar.

Nothing to do for now, but keep a mental note

These buttons at the end are ok and satisfy the issue. In the next sprint, we should explore moving them to the title bar and maybe replacing them with an icon or something similar. Nothing to do for now, but keep a mental note
djwesty commented 2025-02-25 21:26:34 -08:00 (Migrated from github.com)
Review

These buttons at the end are ok and satisfy the issue. In the next sprint, we should explore moving them to the title bar and maybe replacing them with an icon or something similar.

Nothing to do for now, but keep a mental note

These buttons at the end are ok and satisfy the issue. In the next sprint, we should explore moving them to the title bar and maybe replacing them with an icon or something similar. Nothing to do for now, but keep a mental note
MantashaNoyela commented 2025-02-25 22:03:04 -08:00 (Migrated from github.com)
Review

As I encountered the conflict problem, I removed the folder from my laptop and cloned it again. But I used the code which I had written way before that. May be that's why these problem occured.

As I encountered the conflict problem, I removed the folder from my laptop and cloned it again. But I used the code which I had written way before that. May be that's why these problem occured.
MantashaNoyela commented 2025-02-25 22:03:04 -08:00 (Migrated from github.com)
Review

As I encountered the conflict problem, I removed the folder from my laptop and cloned it again. But I used the code which I had written way before that. May be that's why these problem occured.

As I encountered the conflict problem, I removed the folder from my laptop and cloned it again. But I used the code which I had written way before that. May be that's why these problem occured.
MantashaNoyela commented 2025-02-25 22:04:33 -08:00 (Migrated from github.com)
Review

got it

got it
MantashaNoyela commented 2025-02-25 22:04:33 -08:00 (Migrated from github.com)
Review

got it

got it
MantashaNoyela commented 2025-02-25 22:21:05 -08:00 (Migrated from github.com)
Review

I have changed it

I have changed it
MantashaNoyela commented 2025-02-25 22:21:05 -08:00 (Migrated from github.com)
Review

I have changed it

I have changed it

View File

@ -0,0 +1,31 @@
import AsyncStorage from "@react-native-async-storage/async-storage";
const STORAGE_KEYS = {
SLOT1: "@poker_state_slot1",
SLOT2: "@poker_state_slot2",
};
export interface PokerState {
playerCount: number;
buyInAmount: number | null;
numberOfChips: number;
totalChipsCount: number[];
}
export const saveState = async (slot: keyof typeof STORAGE_KEYS, state: PokerState) => {
try {
await AsyncStorage.setItem(STORAGE_KEYS[slot], JSON.stringify(state));
return { success: true, message: `State saved to ${slot}` };
} catch (error) {
return { success: false, message: "Failed to save state" };
}
};
export const loadState = async (slot: keyof typeof STORAGE_KEYS): Promise<PokerState | null> => {
try {
const storedState = await AsyncStorage.getItem(STORAGE_KEYS[slot]);
return storedState ? JSON.parse(storedState) : null;
} catch (error) {
return null;
}
};
djwesty commented 2025-02-25 21:18:28 -08:00 (Migrated from github.com)
Review

From what I can tell, this file seems to be a set of helper functions and interface like things. Since the file is not a React component, we can organize it a little better

  • The file should probably be in another location, not components. One idea is to put it in a new directory like util
  • The file can just use the extension .ts not .tsx
From what I can tell, this file seems to be a set of helper functions and interface like things. Since the file is not a React component, we can organize it a little better - The file should probably be in another location, not `components`. One idea is to put it in a new directory like `util` - The file can just use the extension `.ts` not `.tsx`
MantashaNoyela commented 2025-02-25 22:05:22 -08:00 (Migrated from github.com)
Review

Do I have to pull request again?

Do I have to pull request again?
djwesty commented 2025-02-25 23:21:48 -08:00 (Migrated from github.com)
Review

No, just address changes with a new commit

No, just address changes with a new commit

View File

@ -0,0 +1,52 @@
Vutukuri15 commented 2025-02-25 22:06:36 -08:00 (Migrated from github.com)
Review

Good work, Well-structured tests

Good work, Well-structured tests
Vutukuri15 commented 2025-02-25 22:06:36 -08:00 (Migrated from github.com)
Review

Good work, Well-structured tests

Good work, Well-structured tests
import AsyncStorage from "@react-native-async-storage/async-storage";
Vutukuri15 commented 2025-02-25 22:06:36 -08:00 (Migrated from github.com)
Review

Good work, Well-structured tests

Good work, Well-structured tests
import { saveState, loadState, PokerState } from "../CalculatorState";
Vutukuri15 commented 2025-02-25 22:06:36 -08:00 (Migrated from github.com)
Review

Good work, Well-structured tests

Good work, Well-structured tests
Vutukuri15 commented 2025-02-25 22:06:36 -08:00 (Migrated from github.com)
Review

Good work, Well-structured tests

Good work, Well-structured tests
jest.mock("@react-native-async-storage/async-storage", () =>
Vutukuri15 commented 2025-02-25 22:06:36 -08:00 (Migrated from github.com)
Review

Good work, Well-structured tests

Good work, Well-structured tests
require("@react-native-async-storage/async-storage/jest/async-storage-mock")
Vutukuri15 commented 2025-02-25 22:06:36 -08:00 (Migrated from github.com)
Review

Good work, Well-structured tests

Good work, Well-structured tests
);
Vutukuri15 commented 2025-02-25 22:06:36 -08:00 (Migrated from github.com)
Review

Good work, Well-structured tests

Good work, Well-structured tests
Vutukuri15 commented 2025-02-25 22:06:36 -08:00 (Migrated from github.com)
Review

Good work, Well-structured tests

Good work, Well-structured tests
describe("CalculatorState.tsx", () => {
Vutukuri15 commented 2025-02-25 22:06:36 -08:00 (Migrated from github.com)
Review

Good work, Well-structured tests

Good work, Well-structured tests
const mockState: PokerState = {
Vutukuri15 commented 2025-02-25 22:06:36 -08:00 (Migrated from github.com)
Review

Good work, Well-structured tests

Good work, Well-structured tests
playerCount: 4,
Vutukuri15 commented 2025-02-25 22:06:36 -08:00 (Migrated from github.com)
Review

Good work, Well-structured tests

Good work, Well-structured tests
buyInAmount: 50,
Vutukuri15 commented 2025-02-25 22:06:36 -08:00 (Migrated from github.com)
Review

Good work, Well-structured tests

Good work, Well-structured tests
numberOfChips: 5,
Vutukuri15 commented 2025-02-25 22:06:36 -08:00 (Migrated from github.com)
Review

Good work, Well-structured tests

Good work, Well-structured tests
totalChipsCount: [100, 200, 150, 50, 75],
Vutukuri15 commented 2025-02-25 22:06:36 -08:00 (Migrated from github.com)
Review

Good work, Well-structured tests

Good work, Well-structured tests
};
Vutukuri15 commented 2025-02-25 22:06:36 -08:00 (Migrated from github.com)
Review

Good work, Well-structured tests

Good work, Well-structured tests
Vutukuri15 commented 2025-02-25 22:06:36 -08:00 (Migrated from github.com)
Review

Good work, Well-structured tests

Good work, Well-structured tests
beforeEach(() => {
Vutukuri15 commented 2025-02-25 22:06:36 -08:00 (Migrated from github.com)
Review

Good work, Well-structured tests

Good work, Well-structured tests
jest.clearAllMocks();
Vutukuri15 commented 2025-02-25 22:06:36 -08:00 (Migrated from github.com)
Review

Good work, Well-structured tests

Good work, Well-structured tests
});
Vutukuri15 commented 2025-02-25 22:06:36 -08:00 (Migrated from github.com)
Review

Good work, Well-structured tests

Good work, Well-structured tests
Vutukuri15 commented 2025-02-25 22:06:36 -08:00 (Migrated from github.com)
Review

Good work, Well-structured tests

Good work, Well-structured tests
it("should save state successfully", async () => {
Vutukuri15 commented 2025-02-25 22:06:36 -08:00 (Migrated from github.com)
Review

Good work, Well-structured tests

Good work, Well-structured tests
await saveState("SLOT1", mockState);
Vutukuri15 commented 2025-02-25 22:06:36 -08:00 (Migrated from github.com)
Review

Good work, Well-structured tests

Good work, Well-structured tests
expect(AsyncStorage.setItem).toHaveBeenCalledWith(
Vutukuri15 commented 2025-02-25 22:06:36 -08:00 (Migrated from github.com)
Review

Good work, Well-structured tests

Good work, Well-structured tests
"@poker_state_slot1",
Vutukuri15 commented 2025-02-25 22:06:36 -08:00 (Migrated from github.com)
Review

Good work, Well-structured tests

Good work, Well-structured tests
JSON.stringify(mockState)
Vutukuri15 commented 2025-02-25 22:06:36 -08:00 (Migrated from github.com)
Review

Good work, Well-structured tests

Good work, Well-structured tests
);
Vutukuri15 commented 2025-02-25 22:06:36 -08:00 (Migrated from github.com)
Review

Good work, Well-structured tests

Good work, Well-structured tests
});
Vutukuri15 commented 2025-02-25 22:06:36 -08:00 (Migrated from github.com)
Review

Good work, Well-structured tests

Good work, Well-structured tests
Vutukuri15 commented 2025-02-25 22:06:36 -08:00 (Migrated from github.com)
Review

Good work, Well-structured tests

Good work, Well-structured tests
it("should fail to save state if an error occurs", async () => {
Vutukuri15 commented 2025-02-25 22:06:36 -08:00 (Migrated from github.com)
Review

Good work, Well-structured tests

Good work, Well-structured tests
jest.spyOn(AsyncStorage, "setItem").mockRejectedValueOnce(new Error("Failed to save"));
Vutukuri15 commented 2025-02-25 22:06:36 -08:00 (Migrated from github.com)
Review

Good work, Well-structured tests

Good work, Well-structured tests
const result = await saveState("SLOT1", mockState);
Vutukuri15 commented 2025-02-25 22:06:36 -08:00 (Migrated from github.com)
Review

Good work, Well-structured tests

Good work, Well-structured tests
expect(result.success).toBe(false);
Vutukuri15 commented 2025-02-25 22:06:36 -08:00 (Migrated from github.com)
Review

Good work, Well-structured tests

Good work, Well-structured tests
expect(result.message).toBe("Failed to save state");
Vutukuri15 commented 2025-02-25 22:06:36 -08:00 (Migrated from github.com)
Review

Good work, Well-structured tests

Good work, Well-structured tests
});
Vutukuri15 commented 2025-02-25 22:06:36 -08:00 (Migrated from github.com)
Review

Good work, Well-structured tests

Good work, Well-structured tests
Vutukuri15 commented 2025-02-25 22:06:36 -08:00 (Migrated from github.com)
Review

Good work, Well-structured tests

Good work, Well-structured tests
it("should load state successfully", async () => {
Vutukuri15 commented 2025-02-25 22:06:36 -08:00 (Migrated from github.com)
Review

Good work, Well-structured tests

Good work, Well-structured tests
await AsyncStorage.setItem("@poker_state_slot1", JSON.stringify(mockState));
Vutukuri15 commented 2025-02-25 22:06:36 -08:00 (Migrated from github.com)
Review

Good work, Well-structured tests

Good work, Well-structured tests
const result = await loadState("SLOT1");
Vutukuri15 commented 2025-02-25 22:06:36 -08:00 (Migrated from github.com)
Review

Good work, Well-structured tests

Good work, Well-structured tests
expect(result).toEqual(mockState);
Vutukuri15 commented 2025-02-25 22:06:36 -08:00 (Migrated from github.com)
Review

Good work, Well-structured tests

Good work, Well-structured tests
});
Vutukuri15 commented 2025-02-25 22:06:36 -08:00 (Migrated from github.com)
Review

Good work, Well-structured tests

Good work, Well-structured tests
Vutukuri15 commented 2025-02-25 22:06:36 -08:00 (Migrated from github.com)
Review

Good work, Well-structured tests

Good work, Well-structured tests
it("should return null if no state is found", async () => {
Vutukuri15 commented 2025-02-25 22:06:36 -08:00 (Migrated from github.com)
Review

Good work, Well-structured tests

Good work, Well-structured tests
jest.spyOn(AsyncStorage, "getItem").mockResolvedValueOnce(null);
Vutukuri15 commented 2025-02-25 22:06:36 -08:00 (Migrated from github.com)
Review

Good work, Well-structured tests

Good work, Well-structured tests
const result = await loadState("SLOT1");
Vutukuri15 commented 2025-02-25 22:06:36 -08:00 (Migrated from github.com)
Review

Good work, Well-structured tests

Good work, Well-structured tests
expect(result).toBeNull();
Vutukuri15 commented 2025-02-25 22:06:36 -08:00 (Migrated from github.com)
Review

Good work, Well-structured tests

Good work, Well-structured tests
});
Vutukuri15 commented 2025-02-25 22:06:36 -08:00 (Migrated from github.com)
Review

Good work, Well-structured tests

Good work, Well-structured tests
Vutukuri15 commented 2025-02-25 22:06:36 -08:00 (Migrated from github.com)
Review

Good work, Well-structured tests

Good work, Well-structured tests
it("should return null if an error occurs while loading state", async () => {
Vutukuri15 commented 2025-02-25 22:06:36 -08:00 (Migrated from github.com)
Review

Good work, Well-structured tests

Good work, Well-structured tests
jest.spyOn(AsyncStorage, "getItem").mockRejectedValueOnce(new Error("Failed to load"));
Vutukuri15 commented 2025-02-25 22:06:36 -08:00 (Migrated from github.com)
Review

Good work, Well-structured tests

Good work, Well-structured tests
const result = await loadState("SLOT1");
Vutukuri15 commented 2025-02-25 22:06:36 -08:00 (Migrated from github.com)
Review

Good work, Well-structured tests

Good work, Well-structured tests
expect(result).toBeNull();
Vutukuri15 commented 2025-02-25 22:06:36 -08:00 (Migrated from github.com)
Review

Good work, Well-structured tests

Good work, Well-structured tests
});
Vutukuri15 commented 2025-02-25 22:06:36 -08:00 (Migrated from github.com)
Review

Good work, Well-structured tests

Good work, Well-structured tests
});
Vutukuri15 commented 2025-02-25 22:06:36 -08:00 (Migrated from github.com)
Review

Good work, Well-structured tests

Good work, Well-structured tests

39
package-lock.json generated
View File

@ -9,9 +9,10 @@
"version": "1.0.0", "version": "1.0.0",
"dependencies": { "dependencies": {
"@expo/vector-icons": "14.0.4", "@expo/vector-icons": "14.0.4",
"@react-native-async-storage/async-storage": "^2.1.1",
"@react-navigation/bottom-tabs": "7.2.0", "@react-navigation/bottom-tabs": "7.2.0",
"@react-navigation/native": "7.0.14", "@react-navigation/native": "7.0.14",
"expo": "52.0.37", "expo": "^52.0.37",
"expo-blur": "14.0.3", "expo-blur": "14.0.3",
"expo-constants": "17.0.7", "expo-constants": "17.0.7",
"expo-file-system": "18.0.11", "expo-file-system": "18.0.11",
@ -57,8 +58,7 @@
"typescript": "5.7.3" "typescript": "5.7.3"
}, },
"engines": { "engines": {
"node": ">=22.0.0 <23.0.0", "node": ">=22.0.0 <23.0.0"
"npm": ">=8.0.0"
} }
}, },
"node_modules/@0no-co/graphql.web": { "node_modules/@0no-co/graphql.web": {
@ -3914,6 +3914,18 @@
"react": "^16.8 || ^17.0 || ^18.0" "react": "^16.8 || ^17.0 || ^18.0"
} }
}, },
"node_modules/@react-native-async-storage/async-storage": {
"version": "2.1.1",
"resolved": "https://registry.npmjs.org/@react-native-async-storage/async-storage/-/async-storage-2.1.1.tgz",
"integrity": "sha512-UqlnxddwM3rlCHvteFz+HpIXjqhQM7GkBgVQ9sMvMdl8QVOJQDjG7BODCUvabysMDw+9QfMFlLiOI8U6c0VzzQ==",
"license": "MIT",
"dependencies": {
"merge-options": "^3.0.4"
},
"peerDependencies": {
"react-native": "^0.0.0-0 || >=0.65 <1.0"
}
},
"node_modules/@react-native/assets-registry": { "node_modules/@react-native/assets-registry": {
"version": "0.76.7", "version": "0.76.7",
"resolved": "https://registry.npmjs.org/@react-native/assets-registry/-/assets-registry-0.76.7.tgz", "resolved": "https://registry.npmjs.org/@react-native/assets-registry/-/assets-registry-0.76.7.tgz",
@ -9905,6 +9917,15 @@
"node": ">=8" "node": ">=8"
} }
}, },
"node_modules/is-plain-obj": {
"version": "2.1.0",
"resolved": "https://registry.npmjs.org/is-plain-obj/-/is-plain-obj-2.1.0.tgz",
"integrity": "sha512-YWnfyRwxL/+SsrWYfOpUtz5b3YD+nyfkHvjbcanzk8zgyO4ASD67uVMRt8k5bM4lLMDnXfriRhOpemw+NfT1eA==",
"license": "MIT",
"engines": {
"node": ">=8"
}
},
"node_modules/is-plain-object": { "node_modules/is-plain-object": {
"version": "2.0.4", "version": "2.0.4",
"resolved": "https://registry.npmjs.org/is-plain-object/-/is-plain-object-2.0.4.tgz", "resolved": "https://registry.npmjs.org/is-plain-object/-/is-plain-object-2.0.4.tgz",
@ -12268,6 +12289,18 @@
"integrity": "sha512-zYiwtZUcYyXKo/np96AGZAckk+FWWsUdJ3cHGGmld7+AhvcWmQyGCYUh1hc4Q/pkOhb65dQR/pqCyK0cOaHz4Q==", "integrity": "sha512-zYiwtZUcYyXKo/np96AGZAckk+FWWsUdJ3cHGGmld7+AhvcWmQyGCYUh1hc4Q/pkOhb65dQR/pqCyK0cOaHz4Q==",
"license": "MIT" "license": "MIT"
}, },
"node_modules/merge-options": {
"version": "3.0.4",
"resolved": "https://registry.npmjs.org/merge-options/-/merge-options-3.0.4.tgz",
"integrity": "sha512-2Sug1+knBjkaMsMgf1ctR1Ujx+Ayku4EdJN4Z+C2+JzoeF7A3OZ9KM2GY0CpQS51NR61LTurMJrRKPhSs3ZRTQ==",
"license": "MIT",
"dependencies": {
"is-plain-obj": "^2.1.0"
},
"engines": {
"node": ">=10"
}
},
"node_modules/merge-stream": { "node_modules/merge-stream": {
"version": "2.0.0", "version": "2.0.0",
"resolved": "https://registry.npmjs.org/merge-stream/-/merge-stream-2.0.0.tgz", "resolved": "https://registry.npmjs.org/merge-stream/-/merge-stream-2.0.0.tgz",

View File

@ -19,9 +19,10 @@
}, },
"dependencies": { "dependencies": {
"@expo/vector-icons": "14.0.4", "@expo/vector-icons": "14.0.4",
"@react-native-async-storage/async-storage": "^2.1.1",
"@react-navigation/bottom-tabs": "7.2.0", "@react-navigation/bottom-tabs": "7.2.0",
"@react-navigation/native": "7.0.14", "@react-navigation/native": "7.0.14",
"expo": "52.0.37", "expo": "^52.0.37",
"expo-blur": "14.0.3", "expo-blur": "14.0.3",
"expo-constants": "17.0.7", "expo-constants": "17.0.7",
"expo-file-system": "18.0.11", "expo-file-system": "18.0.11",