Changed Styles and Screen Size for Mobile Device #59

Merged
MantashaNoyela merged 5 commits from MantashaNoyela/22 into main 2025-03-18 15:11:30 -07:00
17 changed files with 268 additions and 279 deletions
Showing only changes of commit e720e2e010 - Show all commits

View File

@ -1,9 +1,11 @@
import i18n from "@/i18n/i18n";
import { COLORS } from "@/styles/styles";
import AppContext, { IAppContext } from "@/util/context";
import { MaterialIcons } from "@expo/vector-icons";
import { Stack } from "expo-router";
import React, { useMemo, useState } from "react";
import { I18nextProvider, useTranslation } from "react-i18next";
import { useColorScheme } from "react-native";
const RootLayout: React.FC = () => {
const [showSettings, setShowSettings] = useState<boolean>(false);
@ -17,20 +19,36 @@ const RootLayout: React.FC = () => {
[showSettings]
);
const colorScheme = useColorScheme();
const darkMode = useMemo(() => colorScheme === "dark", [colorScheme]);
const colors = useMemo(
() => (darkMode ? COLORS.DARK : COLORS.LIGHT),
[darkMode]
);
return (
<AppContext.Provider value={ctx}>
<I18nextProvider i18n={i18n}>
<Stack
screenOptions={{
contentStyle: {
backgroundColor: colors.BACKGROUND,
},
headerShown: true,
title: t("poker_chips_helper"),
navigationBarColor: colors.PRIMARY,
headerRight: () => (
<MaterialIcons
name="settings"
onPress={() => setShowSettings(!showSettings)}
size={30}
color={colors.TEXT}
/>
),
headerStyle: {
backgroundColor: colors.PRIMARY,
},
headerTintColor: colors.TEXT,
statusBarBackgroundColor: "grey",
}}
/>
</I18nextProvider>

View File

@ -1,5 +1,5 @@
import React, { useState, useEffect, useContext, useMemo } from "react";
import { ScrollView, Alert } from "react-native";
import { ScrollView, Alert, useColorScheme, Appearance } from "react-native";
import Button from "@/containers/Button";
import PlayerSelector from "@/components/PlayerSelector";
import BuyInSelector from "@/components/BuyInSelector";
@ -12,12 +12,11 @@ import {
savePersistentState,
loadPersistentState,
} from "@/util/PersistentState";
import styles from "@/styles/styles";
import styles, { COLORS } from "@/styles/styles";
import Section from "@/containers/Section";
import AppContext from "@/util/context";
import { Picker } from "@react-native-picker/picker";
import i18n from "@/i18n/i18n";
import PokerAppUi from "@/containers/PokerAppUi";
const IndexScreen: React.FC = () => {
const [playerCount, setPlayerCount] = useState(2);
@ -26,8 +25,12 @@ const IndexScreen: React.FC = () => {
const [totalChipsCount, setTotalChipsCount] = useState<number[]>([]);
djwesty commented 2025-03-11 15:11:36 -07:00 (Migrated from github.com)
Review

Keeping track of the color mode ("color scheme") as a state variable here in index.tsx is unfortunately an approach which adds complexity and reduces maintainability. Here are a couple reasons

  • Any component or container which is a child of index, must be passed the dark mode prop. This includes all uses of the Button which now have the darkMode prop. However, it seems the app buttons are not actually taking this prop in at the moment, which directly highlights the issue - it is easy to forget to utilize all the props 100% of the time and keep everything consistent. The experience now seems to be gray buttons on a gray background when using the mode
  • Parent components do not have easy access to this mode. That primarily includes the Stack/Layout component in _layout.tsx and would further apply to things like the header bar

Expo has a native mechanism to help with this issue. I mentioned these docs on PR #18, but I can elaborate a bit.

  • The useColorScheme hook, can be utilize in any components which cares to know the current color scheme and adjust accordingly
  • The setColorScheme function can be used to set the colorScheme

I feel this should be fixed to use the best approach. I am happy to help if this is a technical challenge, so please let me know if so

Keeping track of the color mode ("color scheme") as a state variable here in `index.tsx` is unfortunately an approach which adds complexity and reduces maintainability. Here are a couple reasons * Any component or container which is a child of index, must be passed the dark mode prop. This includes all uses of the `Button` which now have the `darkMode` prop. However, it seems the app buttons are not actually taking this prop in at the moment, which directly highlights the issue - it is easy to forget to utilize all the props 100% of the time and keep everything consistent. The experience now seems to be gray buttons on a gray background when using the mode * Parent components do not have easy access to this mode. That primarily includes the Stack/Layout component in `_layout.tsx` and would further apply to things like the header bar Expo has a native mechanism to help with this issue. I [mentioned](https://github.com/djwesty/poker-chips-helper/issues/18#issuecomment-2706855094) these docs on PR #18, but I can elaborate a bit. * The [useColorScheme](https://docs.expo.dev/develop/user-interface/color-themes/#detect-the-color-scheme) hook, can be utilize in any components which cares to know the current color scheme and adjust accordingly * The [setColorScheme](https://reactnative.dev/docs/appearance?guide=web#setcolorscheme) function can be used to set the `colorScheme` I feel this should be fixed to use the best approach. I am happy to help if this is a technical challenge, so please let me know if so
const [selectedCurrency, setSelectedCurrency] = useState<string>("$");
const [selectedLanguage, setSelectedLanguage] = useState<string>("en");
const [lightGrayMode, setLightGrayMode] = useState<boolean>(false);
const colorScheme = useColorScheme();
const darkMode = useMemo(() => colorScheme === "dark", [colorScheme]);
const colors = useMemo(
() => (darkMode ? COLORS.DARK : COLORS.LIGHT),
[darkMode]
);
const context = useContext(AppContext);
const isSettingsVisible = useMemo(() => context.showSettings, [context]);
@ -87,14 +90,12 @@ const IndexScreen: React.FC = () => {
};
return (
<PokerAppUi darkMode={lightGrayMode}>
<ScrollView
/*style={styles.scrollView}
contentContainerStyle={styles.scrollViewContent}*/
style={{ flex: 1 }}
contentContainerStyle={{ paddingHorizontal: 15, paddingBottom: 30 }}
style={styles.scrollView}
contentContainerStyle={styles.scrollViewContent}
>
{isSettingsVisible && (
<>
<Section
title={i18n.t("appearance")}
iconName={"brightness-4"}
@ -102,17 +103,16 @@ const IndexScreen: React.FC = () => {
>
<Button
title={
lightGrayMode
darkMode
? i18n.t("switch_to_light_mode")
: i18n.t("switch_to_gray_mode")
: i18n.t("switch_to_dark_mode")
}
onPress={() =>
Appearance.setColorScheme(darkMode ? "light" : "dark")
}
onPress={() => setLightGrayMode(!lightGrayMode)}
darkMode={lightGrayMode}
/>
</Section>
)}
{isSettingsVisible && (
<Section
title={i18n.t("select_language")}
iconName={"language"}
@ -121,15 +121,28 @@ const IndexScreen: React.FC = () => {
<Picker
selectedValue={selectedLanguage}
onValueChange={handleLanguageChange}
style={styles.picker}
style={[styles.picker, { color: colors.TEXT }]}
dropdownIconColor={colors.TEXT}
>
<Picker.Item label={i18n.t("english")} value="en" />
<Picker.Item label={i18n.t("spanish")} value="es" />
<Picker.Item
label={i18n.t("english")}
value="en"
style={{
color: colors.TEXT,
backgroundColor: colors.PRIMARY,
}}
/>
<Picker.Item
label={i18n.t("spanish")}
value="es"
style={{
color: colors.TEXT,
backgroundColor: colors.PRIMARY,
}}
/>
</Picker>
</Section>
)}
{isSettingsVisible && (
<Section
title={i18n.t("select_currency")}
iconName={"attach-money"}
@ -140,6 +153,7 @@ const IndexScreen: React.FC = () => {
setSelectedCurrency={setSelectedCurrency}
/>
</Section>
</>
)}
<Section
@ -151,7 +165,6 @@ const IndexScreen: React.FC = () => {
<PlayerSelector
playerCount={playerCount}
setPlayerCount={setPlayerCount}
darkMode={lightGrayMode}
/>
</Section>
@ -162,7 +175,6 @@ const IndexScreen: React.FC = () => {
<BuyInSelector
selectedCurrency={selectedCurrency}
setBuyInAmount={setBuyInAmount}
darkMode={lightGrayMode}
/>
</Section>
@ -176,7 +188,6 @@ const IndexScreen: React.FC = () => {
setTotalChipsCount(chipCountArray);
setNumberOfChips(chipCountArray.length);
}}
darkMode={lightGrayMode}
/>
</Section>
@ -191,7 +202,6 @@ const IndexScreen: React.FC = () => {
setTotalChipsCount={setTotalChipsCount}
numberOfChips={numberOfChips}
setNumberOfChips={setNumberOfChips}
darkMode={lightGrayMode}
/>
</Section>
@ -217,28 +227,23 @@ const IndexScreen: React.FC = () => {
title={i18n.t("save_slot_1")}
onPress={() => handleSave("SLOT1")}
disabled={buyInAmount === null}
darkMode={lightGrayMode}
/>
<Button
title={i18n.t("save_slot_2")}
onPress={() => handleSave("SLOT2")}
disabled={buyInAmount === null}
darkMode={lightGrayMode}
/>
<Button
title={i18n.t("load_slot_1")}
onPress={() => handleLoad("SLOT1")}
darkMode={lightGrayMode}
/>
<Button
title={i18n.t("load_slot_2")}
onPress={() => handleLoad("SLOT2")}
darkMode={lightGrayMode}
/>
</>
</Section>
</ScrollView>
</PokerAppUi>
);
};

View File

@ -1,5 +1,5 @@
import React, { useState } from "react";
import { View, Text, TextInput } from "react-native";
import React, { useMemo, useState } from "react";
import { View, Text, TextInput, useColorScheme } from "react-native";
import styles, { COLORS } from "@/styles/styles";
import Button from "@/containers/Button";
import i18n from "@/i18n/i18n";
@ -7,7 +7,6 @@ import i18n from "@/i18n/i18n";
interface BuyInSelectorProps {
setBuyInAmount: React.Dispatch<React.SetStateAction<number>>;
selectedCurrency: string;
darkMode: boolean;
}
const defaultBuyInOptions = [10, 25, 50];
@ -23,10 +22,15 @@ const parseRoundClamp = (num: string): number => {
const BuyInSelector: React.FC<BuyInSelectorProps> = ({
setBuyInAmount,
selectedCurrency,
darkMode,
}) => {
const [customAmount, setCustomAmount] = useState("");
const [buyInAmount, setBuyInAmountState] = useState<number | null>(null);
const colorScheme = useColorScheme();
const darkMode = useMemo(() => colorScheme === "dark", [colorScheme]);
const colors = useMemo(
() => (darkMode ? COLORS.DARK : COLORS.LIGHT),
[darkMode]
);
const handleCustomAmountChange = (value: string) => {
const numericValue = parseRoundClamp(value);
@ -55,13 +59,13 @@ const BuyInSelector: React.FC<BuyInSelectorProps> = ({
key={amount}
onPress={() => handleBuyInSelection(amount)}
title={`${selectedCurrency} ${amount}`}
darkMode={darkMode}
/>
))}
</View>
<TextInput
style={styles.input}
style={[styles.input, { color: colors.TEXT }]}
placeholderTextColor={colors.TEXT}
value={customAmount}
maxLength={3}
onChangeText={handleCustomAmountChange}
@ -69,7 +73,7 @@ const BuyInSelector: React.FC<BuyInSelectorProps> = ({
keyboardType="numeric"
/>
<Text style={styles.h2}>
<Text style={[styles.h2, { color: colors.TEXT }]}>
{`${i18n.t("selected_buy_in")} `}
{buyInAmount !== null
? `${selectedCurrency} ${buyInAmount}`

View File

@ -6,10 +6,8 @@ import i18n from "@/i18n/i18n";
const ChipDetection = ({
updateChipCount,
darkMode,
}: {
updateChipCount: (chipData: Record<string, number>) => void;
darkMode: boolean;
}) => {
const [imageUri, setImageUri] = useState<string | null>(null);
const [loading, setLoading] = useState(false);
@ -135,16 +133,8 @@ const ChipDetection = ({
marginBottom: 10,
}}
>
<Button
title={i18n.t("pick_an_image")}
onPress={pickImage}
darkMode={darkMode}
/>
<Button
title={i18n.t("take_a_photo")}
onPress={takePhoto}
darkMode={darkMode}
/>
<Button title={i18n.t("pick_an_image")} onPress={pickImage} />
<Button title={i18n.t("take_a_photo")} onPress={takePhoto} />
</View>
{imageUri && (

View File

@ -21,13 +21,11 @@ const ChipInputModal = ({
setShowModal,
totalChipsCount,
update,
darkMode,
}: {
showModal: [boolean, ColorValue];
setShowModal: React.Dispatch<React.SetStateAction<[boolean, ColorValue]>>;
totalChipsCount: number[];
update: Function;
darkMode: boolean;
}) => {
const color: ColorValue = useMemo(() => showModal[1], [showModal]);
const colorIdx = useMemo(() => colors.indexOf(color), [color]);
@ -77,7 +75,6 @@ const ChipInputModal = ({
update(showModal[1], Number.isNaN(value) ? 0 : value);
setShowModal([false, color]);
}}
darkMode={darkMode}
/>
</Modal>
);
@ -119,13 +116,11 @@ const ChipsSelector = ({
totalChipsCount,
setTotalChipsCount,
setNumberOfChips,
darkMode,
}: {
numberOfChips: number;
totalChipsCount: number[];
setTotalChipsCount: React.Dispatch<React.SetStateAction<number[]>>;
setNumberOfChips: React.Dispatch<React.SetStateAction<number>>;
darkMode: boolean;
}) => {
const [showModal, setShowModal] = useState<[boolean, ColorValue]>([
false,
@ -172,7 +167,6 @@ const ChipsSelector = ({
setNumberOfChips(Math.max(1, numberOfChips - 1));
}}
disabled={numberOfChips === 1}
darkMode={darkMode}
/>
<View style={[styles.container, { flexDirection: "row" }]}>
{colorsUsed.map((color) => {
@ -193,7 +187,6 @@ const ChipsSelector = ({
setNumberOfChips(Math.min(5, numberOfChips + 1));
}}
disabled={numberOfChips === 5}
darkMode={darkMode}
/>
<ChipInputModal
@ -201,7 +194,6 @@ const ChipsSelector = ({
setShowModal={setShowModal}
totalChipsCount={totalChipsCount}
update={update}
darkMode={darkMode}
/>
</>
);

View File

@ -1,7 +1,8 @@
import React from "react";
import React, { useMemo } from "react";
import { Picker } from "@react-native-picker/picker";
import styles from "@/styles/styles";
import styles, { COLORS } from "@/styles/styles";
import i18n from "@/i18n/i18n";
import { useColorScheme } from "react-native";
interface CurrencySelectorProps {
selectedCurrency: string;
@ -12,18 +13,53 @@ const CurrencySelector: React.FC<CurrencySelectorProps> = ({
selectedCurrency,
setSelectedCurrency,
}) => {
const colorScheme = useColorScheme();
const darkMode = useMemo(() => colorScheme === "dark", [colorScheme]);
const colors = useMemo(
() => (darkMode ? COLORS.DARK : COLORS.LIGHT),
[darkMode]
);
return (
<>
<Picker
selectedValue={selectedCurrency}
onValueChange={(itemValue) => setSelectedCurrency(itemValue)}
style={styles.picker}
style={[styles.picker, { color: colors.TEXT }]}
dropdownIconColor={colors.TEXT}
testID="currency-picker" // ✅ Add testID here
>
<Picker.Item label={i18n.t("usd")} value="$" />
<Picker.Item label={i18n.t("euro")} value="€" />
<Picker.Item label={i18n.t("pound")} value="£" />
<Picker.Item label={i18n.t("inr")} value="₹" />
<Picker.Item
label={i18n.t("usd")}
value="$"
style={{
color: colors.TEXT,
backgroundColor: colors.PRIMARY,
}}
/>
<Picker.Item
label={i18n.t("euro")}
value="€"
style={{
color: colors.TEXT,
backgroundColor: colors.PRIMARY,
}}
/>
<Picker.Item
label={i18n.t("pound")}
value="£"
style={{
color: colors.TEXT,
backgroundColor: colors.PRIMARY,
}}
/>
<Picker.Item
label={i18n.t("inr")}
value="₹"
style={{
color: colors.TEXT,
backgroundColor: colors.PRIMARY,
}}
/>
</Picker>
</>
);

View File

@ -1,12 +1,11 @@
import React from "react";
import { View, Text } from "react-native";
import React, { useMemo } from "react";
import { View, Text, useColorScheme } from "react-native";
import Button from "@/containers/Button";
import styles from "@/styles/styles";
import styles, { COLORS } from "@/styles/styles";
interface PlayerSelectorProps {
playerCount: number;
setPlayerCount: React.Dispatch<React.SetStateAction<number>>;
darkMode: boolean;
}
const MIN = 2;
@ -15,7 +14,6 @@ const MAX = 8;
const PlayerSelector: React.FC<PlayerSelectorProps> = ({
playerCount,
setPlayerCount,
darkMode,
}) => {
const increasePlayers = () => {
if (playerCount < MAX) setPlayerCount(playerCount + 1);
@ -24,21 +22,25 @@ const PlayerSelector: React.FC<PlayerSelectorProps> = ({
const decreasePlayers = () => {
if (playerCount > MIN) setPlayerCount(playerCount - 1);
};
const colorScheme = useColorScheme();
const darkMode = useMemo(() => colorScheme === "dark", [colorScheme]);
const colors = useMemo(
() => (darkMode ? COLORS.DARK : COLORS.LIGHT),
[darkMode]
);
return (
<View style={{ flexDirection: "row", alignItems: "center" }}>
<View style={{ flexDirection: "row", alignItems: "center", gap: 10 }}>
<Button
title="-"
onPress={decreasePlayers}
disabled={playerCount <= MIN}
darkMode={darkMode}
/>
<Text style={styles.h1}>{playerCount}</Text>
<Text style={[styles.h1, { color: colors.TEXT }]}>{playerCount}</Text>
<Button
title="+"
onPress={increasePlayers}
disabled={playerCount >= MAX}
darkMode={darkMode}
/>
</View>
);

View File

@ -19,7 +19,6 @@ describe("BuyInSelector Component", () => {
<BuyInSelector
setBuyInAmount={setBuyInAmount}
selectedCurrency={selectedCurrency}
darkMode={false}
/>
);
return {

View File

@ -45,7 +45,7 @@ describe("ChipDetection", () => {
it("renders correctly", () => {
const { getByText } = render(
<ChipDetection updateChipCount={mockUpdateChipCount} darkMode={false} />
<ChipDetection updateChipCount={mockUpdateChipCount} />
);
expect(getByText(/pick an image/i)).toBeTruthy();
@ -59,7 +59,7 @@ describe("ChipDetection", () => {
});
const { getByText } = render(
<ChipDetection updateChipCount={mockUpdateChipCount} darkMode={false} />
<ChipDetection updateChipCount={mockUpdateChipCount} />
);
fireEvent.press(getByText(/pick an image/i));
@ -78,7 +78,7 @@ describe("ChipDetection", () => {
});
const { getByText } = render(
<ChipDetection updateChipCount={mockUpdateChipCount} darkMode={false} />
<ChipDetection updateChipCount={mockUpdateChipCount} />
);
fireEvent.press(getByText(/take a photo/i));
@ -99,7 +99,7 @@ describe("ChipDetection", () => {
});
const { getByText } = render(
<ChipDetection updateChipCount={mockUpdateChipCount} darkMode={false} />
<ChipDetection updateChipCount={mockUpdateChipCount} />
);
fireEvent.press(getByText(/take a photo/i));
@ -126,7 +126,7 @@ describe("ChipDetection", () => {
);
const { getByText } = render(
<ChipDetection updateChipCount={mockUpdateChipCount} darkMode={false} />
<ChipDetection updateChipCount={mockUpdateChipCount} />
);
fireEvent.press(getByText(/pick an image/i));
@ -159,7 +159,7 @@ describe("ChipDetection", () => {
);
const { getByText } = render(
<ChipDetection updateChipCount={mockUpdateChipCount} darkMode={false} />
<ChipDetection updateChipCount={mockUpdateChipCount} />
);
fireEvent.press(getByText(/pick an image/i));

View File

@ -28,7 +28,6 @@ const rend = () =>
totalChipsCount={TOTAL_CHIPS_COUNT}
setTotalChipsCount={mocktTotalChipsCount}
setNumberOfChips={mockSetNumberOfChips}
darkMode={false}
/>
);

View File

@ -6,11 +6,7 @@ describe("PlayerSelector Component", () => {
it("renders the initial player count and buttons correctly", () => {
const setPlayerCount = jest.fn();
const { getByText, getByRole } = render(
<PlayerSelector
playerCount={4}
setPlayerCount={setPlayerCount}
darkMode={false}
/>
<PlayerSelector playerCount={4} setPlayerCount={setPlayerCount} />
);
expect(getByText("4")).toBeTruthy();
@ -21,11 +17,7 @@ describe("PlayerSelector Component", () => {
it('increases player count when "+" button is pressed', () => {
const setPlayerCount = jest.fn();
const { getByRole } = render(
<PlayerSelector
playerCount={4}
setPlayerCount={setPlayerCount}
darkMode={false}
/>
<PlayerSelector playerCount={4} setPlayerCount={setPlayerCount} />
);
fireEvent.press(getByRole("button", { name: "+" }));
@ -35,11 +27,7 @@ describe("PlayerSelector Component", () => {
it('decreases player count when "-" button is pressed', () => {
const setPlayerCount = jest.fn();
const { getByRole } = render(
<PlayerSelector
playerCount={4}
setPlayerCount={setPlayerCount}
darkMode={false}
/>
<PlayerSelector playerCount={4} setPlayerCount={setPlayerCount} />
);
fireEvent.press(getByRole("button", { name: "-" }));
@ -49,11 +37,7 @@ describe("PlayerSelector Component", () => {
it("does not increase player count beyond 8", () => {
const setPlayerCount = jest.fn();
const { getByRole } = render(
<PlayerSelector
playerCount={8}
setPlayerCount={setPlayerCount}
darkMode={false}
/>
<PlayerSelector playerCount={8} setPlayerCount={setPlayerCount} />
);
fireEvent.press(getByRole("button", { name: "+" }));
@ -63,11 +47,7 @@ describe("PlayerSelector Component", () => {
it("does not decrease player count below 2", () => {
const setPlayerCount = jest.fn();
const { getByRole } = render(
<PlayerSelector
playerCount={2}
setPlayerCount={setPlayerCount}
darkMode={false}
/>
<PlayerSelector playerCount={2} setPlayerCount={setPlayerCount} />
);
fireEvent.press(getByRole("button", { name: "-" }));

View File

@ -1,19 +1,25 @@
djwesty commented 2025-03-11 14:33:07 -07:00 (Migrated from github.com)
Review

Can you run npx tsc and confirm that this change, and any other new changes are not introducing typescript errors? It appears from my end that they might be. If so, they should be fixed please. However, please see my other comment about prop passing for a color scheme which may make some of these typescript errors redundant

Free to resolve.

Can you run `npx tsc` and confirm that this change, and any other new changes are not introducing typescript errors? It appears from my end that they might be. If so, they should be fixed please. However, please see my other comment about prop passing for a color scheme which may make some of these typescript errors redundant Free to resolve.
djwesty commented 2025-03-11 14:33:07 -07:00 (Migrated from github.com)
Review

Can you run npx tsc and confirm that this change, and any other new changes are not introducing typescript errors? It appears from my end that they might be. If so, they should be fixed please. However, please see my other comment about prop passing for a color scheme which may make some of these typescript errors redundant

Free to resolve.

Can you run `npx tsc` and confirm that this change, and any other new changes are not introducing typescript errors? It appears from my end that they might be. If so, they should be fixed please. However, please see my other comment about prop passing for a color scheme which may make some of these typescript errors redundant Free to resolve.
MantashaNoyela commented 2025-03-13 01:23:31 -07:00 (Migrated from github.com)
Review

fixed these.

fixed these.
MantashaNoyela commented 2025-03-13 01:23:31 -07:00 (Migrated from github.com)
Review

fixed these.

fixed these.
import React from "react";
djwesty commented 2025-03-11 14:33:07 -07:00 (Migrated from github.com)
Review

Can you run npx tsc and confirm that this change, and any other new changes are not introducing typescript errors? It appears from my end that they might be. If so, they should be fixed please. However, please see my other comment about prop passing for a color scheme which may make some of these typescript errors redundant

Free to resolve.

Can you run `npx tsc` and confirm that this change, and any other new changes are not introducing typescript errors? It appears from my end that they might be. If so, they should be fixed please. However, please see my other comment about prop passing for a color scheme which may make some of these typescript errors redundant Free to resolve.
MantashaNoyela commented 2025-03-13 01:23:31 -07:00 (Migrated from github.com)
Review

fixed these.

fixed these.
import { Text, TouchableOpacity, StyleSheet } from "react-native";
djwesty commented 2025-03-11 14:33:07 -07:00 (Migrated from github.com)
Review

Can you run npx tsc and confirm that this change, and any other new changes are not introducing typescript errors? It appears from my end that they might be. If so, they should be fixed please. However, please see my other comment about prop passing for a color scheme which may make some of these typescript errors redundant

Free to resolve.

Can you run `npx tsc` and confirm that this change, and any other new changes are not introducing typescript errors? It appears from my end that they might be. If so, they should be fixed please. However, please see my other comment about prop passing for a color scheme which may make some of these typescript errors redundant Free to resolve.
MantashaNoyela commented 2025-03-13 01:23:31 -07:00 (Migrated from github.com)
Review

fixed these.

fixed these.
import { COLORS } from "@/styles/styles";
djwesty commented 2025-03-11 14:33:07 -07:00 (Migrated from github.com)
Review

Can you run npx tsc and confirm that this change, and any other new changes are not introducing typescript errors? It appears from my end that they might be. If so, they should be fixed please. However, please see my other comment about prop passing for a color scheme which may make some of these typescript errors redundant

Free to resolve.

Can you run `npx tsc` and confirm that this change, and any other new changes are not introducing typescript errors? It appears from my end that they might be. If so, they should be fixed please. However, please see my other comment about prop passing for a color scheme which may make some of these typescript errors redundant Free to resolve.
MantashaNoyela commented 2025-03-13 01:23:31 -07:00 (Migrated from github.com)
Review

fixed these.

fixed these.
import React, { useMemo } from "react";
djwesty commented 2025-03-11 14:33:07 -07:00 (Migrated from github.com)
Review

Can you run npx tsc and confirm that this change, and any other new changes are not introducing typescript errors? It appears from my end that they might be. If so, they should be fixed please. However, please see my other comment about prop passing for a color scheme which may make some of these typescript errors redundant

Free to resolve.

Can you run `npx tsc` and confirm that this change, and any other new changes are not introducing typescript errors? It appears from my end that they might be. If so, they should be fixed please. However, please see my other comment about prop passing for a color scheme which may make some of these typescript errors redundant Free to resolve.
MantashaNoyela commented 2025-03-13 01:23:31 -07:00 (Migrated from github.com)
Review

fixed these.

fixed these.
import {
djwesty commented 2025-03-11 14:33:07 -07:00 (Migrated from github.com)
Review

Can you run npx tsc and confirm that this change, and any other new changes are not introducing typescript errors? It appears from my end that they might be. If so, they should be fixed please. However, please see my other comment about prop passing for a color scheme which may make some of these typescript errors redundant

Free to resolve.

Can you run `npx tsc` and confirm that this change, and any other new changes are not introducing typescript errors? It appears from my end that they might be. If so, they should be fixed please. However, please see my other comment about prop passing for a color scheme which may make some of these typescript errors redundant Free to resolve.
MantashaNoyela commented 2025-03-13 01:23:31 -07:00 (Migrated from github.com)
Review

fixed these.

fixed these.
Text,
djwesty commented 2025-03-11 14:33:07 -07:00 (Migrated from github.com)
Review

Can you run npx tsc and confirm that this change, and any other new changes are not introducing typescript errors? It appears from my end that they might be. If so, they should be fixed please. However, please see my other comment about prop passing for a color scheme which may make some of these typescript errors redundant

Free to resolve.

Can you run `npx tsc` and confirm that this change, and any other new changes are not introducing typescript errors? It appears from my end that they might be. If so, they should be fixed please. However, please see my other comment about prop passing for a color scheme which may make some of these typescript errors redundant Free to resolve.
MantashaNoyela commented 2025-03-13 01:23:31 -07:00 (Migrated from github.com)
Review

fixed these.

fixed these.
TouchableOpacity,
djwesty commented 2025-03-11 14:33:07 -07:00 (Migrated from github.com)
Review

Can you run npx tsc and confirm that this change, and any other new changes are not introducing typescript errors? It appears from my end that they might be. If so, they should be fixed please. However, please see my other comment about prop passing for a color scheme which may make some of these typescript errors redundant

Free to resolve.

Can you run `npx tsc` and confirm that this change, and any other new changes are not introducing typescript errors? It appears from my end that they might be. If so, they should be fixed please. However, please see my other comment about prop passing for a color scheme which may make some of these typescript errors redundant Free to resolve.
MantashaNoyela commented 2025-03-13 01:23:31 -07:00 (Migrated from github.com)
Review

fixed these.

fixed these.
StyleSheet,
djwesty commented 2025-03-11 14:33:07 -07:00 (Migrated from github.com)
Review

Can you run npx tsc and confirm that this change, and any other new changes are not introducing typescript errors? It appears from my end that they might be. If so, they should be fixed please. However, please see my other comment about prop passing for a color scheme which may make some of these typescript errors redundant

Free to resolve.

Can you run `npx tsc` and confirm that this change, and any other new changes are not introducing typescript errors? It appears from my end that they might be. If so, they should be fixed please. However, please see my other comment about prop passing for a color scheme which may make some of these typescript errors redundant Free to resolve.
MantashaNoyela commented 2025-03-13 01:23:31 -07:00 (Migrated from github.com)
Review

fixed these.

fixed these.
useColorScheme,
djwesty commented 2025-03-11 14:33:07 -07:00 (Migrated from github.com)
Review

Can you run npx tsc and confirm that this change, and any other new changes are not introducing typescript errors? It appears from my end that they might be. If so, they should be fixed please. However, please see my other comment about prop passing for a color scheme which may make some of these typescript errors redundant

Free to resolve.

Can you run `npx tsc` and confirm that this change, and any other new changes are not introducing typescript errors? It appears from my end that they might be. If so, they should be fixed please. However, please see my other comment about prop passing for a color scheme which may make some of these typescript errors redundant Free to resolve.
MantashaNoyela commented 2025-03-13 01:23:31 -07:00 (Migrated from github.com)
Review

fixed these.

fixed these.
} from "react-native";
djwesty commented 2025-03-11 14:33:07 -07:00 (Migrated from github.com)
Review

Can you run npx tsc and confirm that this change, and any other new changes are not introducing typescript errors? It appears from my end that they might be. If so, they should be fixed please. However, please see my other comment about prop passing for a color scheme which may make some of these typescript errors redundant

Free to resolve.

Can you run `npx tsc` and confirm that this change, and any other new changes are not introducing typescript errors? It appears from my end that they might be. If so, they should be fixed please. However, please see my other comment about prop passing for a color scheme which may make some of these typescript errors redundant Free to resolve.
MantashaNoyela commented 2025-03-13 01:23:31 -07:00 (Migrated from github.com)
Review

fixed these.

fixed these.
interface ButtonProps {
title: string;
onPress: () => void;
disabled?: boolean;
darkMode: boolean;
djwesty commented 2025-03-11 14:33:07 -07:00 (Migrated from github.com)
Review

Can you run npx tsc and confirm that this change, and any other new changes are not introducing typescript errors? It appears from my end that they might be. If so, they should be fixed please. However, please see my other comment about prop passing for a color scheme which may make some of these typescript errors redundant

Free to resolve.

Can you run `npx tsc` and confirm that this change, and any other new changes are not introducing typescript errors? It appears from my end that they might be. If so, they should be fixed please. However, please see my other comment about prop passing for a color scheme which may make some of these typescript errors redundant Free to resolve.
MantashaNoyela commented 2025-03-13 01:23:31 -07:00 (Migrated from github.com)
Review

fixed these.

fixed these.
}
const Button: React.FC<ButtonProps> = ({
djwesty commented 2025-03-11 14:33:07 -07:00 (Migrated from github.com)
Review

Can you run npx tsc and confirm that this change, and any other new changes are not introducing typescript errors? It appears from my end that they might be. If so, they should be fixed please. However, please see my other comment about prop passing for a color scheme which may make some of these typescript errors redundant

Free to resolve.

Can you run `npx tsc` and confirm that this change, and any other new changes are not introducing typescript errors? It appears from my end that they might be. If so, they should be fixed please. However, please see my other comment about prop passing for a color scheme which may make some of these typescript errors redundant Free to resolve.
MantashaNoyela commented 2025-03-13 01:23:31 -07:00 (Migrated from github.com)
Review

fixed these.

fixed these.
title,
djwesty commented 2025-03-11 14:33:07 -07:00 (Migrated from github.com)
Review

Can you run npx tsc and confirm that this change, and any other new changes are not introducing typescript errors? It appears from my end that they might be. If so, they should be fixed please. However, please see my other comment about prop passing for a color scheme which may make some of these typescript errors redundant

Free to resolve.

Can you run `npx tsc` and confirm that this change, and any other new changes are not introducing typescript errors? It appears from my end that they might be. If so, they should be fixed please. However, please see my other comment about prop passing for a color scheme which may make some of these typescript errors redundant Free to resolve.
MantashaNoyela commented 2025-03-13 01:23:31 -07:00 (Migrated from github.com)
Review

fixed these.

fixed these.
onPress,
djwesty commented 2025-03-11 14:33:07 -07:00 (Migrated from github.com)
Review

Can you run npx tsc and confirm that this change, and any other new changes are not introducing typescript errors? It appears from my end that they might be. If so, they should be fixed please. However, please see my other comment about prop passing for a color scheme which may make some of these typescript errors redundant

Free to resolve.

Can you run `npx tsc` and confirm that this change, and any other new changes are not introducing typescript errors? It appears from my end that they might be. If so, they should be fixed please. However, please see my other comment about prop passing for a color scheme which may make some of these typescript errors redundant Free to resolve.
MantashaNoyela commented 2025-03-13 01:23:31 -07:00 (Migrated from github.com)
Review

fixed these.

fixed these.
disabled,
djwesty commented 2025-03-11 14:33:07 -07:00 (Migrated from github.com)
Review

Can you run npx tsc and confirm that this change, and any other new changes are not introducing typescript errors? It appears from my end that they might be. If so, they should be fixed please. However, please see my other comment about prop passing for a color scheme which may make some of these typescript errors redundant

Free to resolve.

Can you run `npx tsc` and confirm that this change, and any other new changes are not introducing typescript errors? It appears from my end that they might be. If so, they should be fixed please. However, please see my other comment about prop passing for a color scheme which may make some of these typescript errors redundant Free to resolve.
MantashaNoyela commented 2025-03-13 01:23:31 -07:00 (Migrated from github.com)
Review

fixed these.

fixed these.
darkMode,
djwesty commented 2025-03-11 14:33:07 -07:00 (Migrated from github.com)
Review

Can you run npx tsc and confirm that this change, and any other new changes are not introducing typescript errors? It appears from my end that they might be. If so, they should be fixed please. However, please see my other comment about prop passing for a color scheme which may make some of these typescript errors redundant

Free to resolve.

Can you run `npx tsc` and confirm that this change, and any other new changes are not introducing typescript errors? It appears from my end that they might be. If so, they should be fixed please. However, please see my other comment about prop passing for a color scheme which may make some of these typescript errors redundant Free to resolve.
MantashaNoyela commented 2025-03-13 01:23:31 -07:00 (Migrated from github.com)
Review

fixed these.

fixed these.
}) => {
djwesty commented 2025-03-11 14:33:07 -07:00 (Migrated from github.com)
Review

Can you run npx tsc and confirm that this change, and any other new changes are not introducing typescript errors? It appears from my end that they might be. If so, they should be fixed please. However, please see my other comment about prop passing for a color scheme which may make some of these typescript errors redundant

Free to resolve.

Can you run `npx tsc` and confirm that this change, and any other new changes are not introducing typescript errors? It appears from my end that they might be. If so, they should be fixed please. However, please see my other comment about prop passing for a color scheme which may make some of these typescript errors redundant Free to resolve.
MantashaNoyela commented 2025-03-13 01:23:31 -07:00 (Migrated from github.com)
Review

fixed these.

fixed these.
const Button: React.FC<ButtonProps> = ({ title, onPress, disabled }) => {
djwesty commented 2025-03-11 14:33:07 -07:00 (Migrated from github.com)
Review

Can you run npx tsc and confirm that this change, and any other new changes are not introducing typescript errors? It appears from my end that they might be. If so, they should be fixed please. However, please see my other comment about prop passing for a color scheme which may make some of these typescript errors redundant

Free to resolve.

Can you run `npx tsc` and confirm that this change, and any other new changes are not introducing typescript errors? It appears from my end that they might be. If so, they should be fixed please. However, please see my other comment about prop passing for a color scheme which may make some of these typescript errors redundant Free to resolve.
MantashaNoyela commented 2025-03-13 01:23:31 -07:00 (Migrated from github.com)
Review

fixed these.

fixed these.
const colorScheme = useColorScheme();
djwesty commented 2025-03-11 14:33:07 -07:00 (Migrated from github.com)
Review

Can you run npx tsc and confirm that this change, and any other new changes are not introducing typescript errors? It appears from my end that they might be. If so, they should be fixed please. However, please see my other comment about prop passing for a color scheme which may make some of these typescript errors redundant

Free to resolve.

Can you run `npx tsc` and confirm that this change, and any other new changes are not introducing typescript errors? It appears from my end that they might be. If so, they should be fixed please. However, please see my other comment about prop passing for a color scheme which may make some of these typescript errors redundant Free to resolve.
MantashaNoyela commented 2025-03-13 01:23:31 -07:00 (Migrated from github.com)
Review

fixed these.

fixed these.
const darkMode = useMemo(() => colorScheme === "dark", [colorScheme]);
djwesty commented 2025-03-11 14:33:07 -07:00 (Migrated from github.com)
Review

Can you run npx tsc and confirm that this change, and any other new changes are not introducing typescript errors? It appears from my end that they might be. If so, they should be fixed please. However, please see my other comment about prop passing for a color scheme which may make some of these typescript errors redundant

Free to resolve.

Can you run `npx tsc` and confirm that this change, and any other new changes are not introducing typescript errors? It appears from my end that they might be. If so, they should be fixed please. However, please see my other comment about prop passing for a color scheme which may make some of these typescript errors redundant Free to resolve.
MantashaNoyela commented 2025-03-13 01:23:31 -07:00 (Migrated from github.com)
Review

fixed these.

fixed these.
const colors = useMemo(
djwesty commented 2025-03-11 14:33:07 -07:00 (Migrated from github.com)
Review

Can you run npx tsc and confirm that this change, and any other new changes are not introducing typescript errors? It appears from my end that they might be. If so, they should be fixed please. However, please see my other comment about prop passing for a color scheme which may make some of these typescript errors redundant

Free to resolve.

Can you run `npx tsc` and confirm that this change, and any other new changes are not introducing typescript errors? It appears from my end that they might be. If so, they should be fixed please. However, please see my other comment about prop passing for a color scheme which may make some of these typescript errors redundant Free to resolve.
MantashaNoyela commented 2025-03-13 01:23:31 -07:00 (Migrated from github.com)
Review

fixed these.

fixed these.
() => (darkMode ? COLORS.DARK : COLORS.LIGHT),
djwesty commented 2025-03-11 14:33:07 -07:00 (Migrated from github.com)
Review

Can you run npx tsc and confirm that this change, and any other new changes are not introducing typescript errors? It appears from my end that they might be. If so, they should be fixed please. However, please see my other comment about prop passing for a color scheme which may make some of these typescript errors redundant

Free to resolve.

Can you run `npx tsc` and confirm that this change, and any other new changes are not introducing typescript errors? It appears from my end that they might be. If so, they should be fixed please. However, please see my other comment about prop passing for a color scheme which may make some of these typescript errors redundant Free to resolve.
MantashaNoyela commented 2025-03-13 01:23:31 -07:00 (Migrated from github.com)
Review

fixed these.

fixed these.
[darkMode]
djwesty commented 2025-03-11 14:33:07 -07:00 (Migrated from github.com)
Review

Can you run npx tsc and confirm that this change, and any other new changes are not introducing typescript errors? It appears from my end that they might be. If so, they should be fixed please. However, please see my other comment about prop passing for a color scheme which may make some of these typescript errors redundant

Free to resolve.

Can you run `npx tsc` and confirm that this change, and any other new changes are not introducing typescript errors? It appears from my end that they might be. If so, they should be fixed please. However, please see my other comment about prop passing for a color scheme which may make some of these typescript errors redundant Free to resolve.
MantashaNoyela commented 2025-03-13 01:23:31 -07:00 (Migrated from github.com)
Review

fixed these.

fixed these.
);
djwesty commented 2025-03-11 14:33:07 -07:00 (Migrated from github.com)
Review

Can you run npx tsc and confirm that this change, and any other new changes are not introducing typescript errors? It appears from my end that they might be. If so, they should be fixed please. However, please see my other comment about prop passing for a color scheme which may make some of these typescript errors redundant

Free to resolve.

Can you run `npx tsc` and confirm that this change, and any other new changes are not introducing typescript errors? It appears from my end that they might be. If so, they should be fixed please. However, please see my other comment about prop passing for a color scheme which may make some of these typescript errors redundant Free to resolve.
MantashaNoyela commented 2025-03-13 01:23:31 -07:00 (Migrated from github.com)
Review

fixed these.

fixed these.
return (
<TouchableOpacity
onPress={onPress}
@ -21,18 +27,11 @@ const Button: React.FC<ButtonProps> = ({
djwesty commented 2025-03-11 14:33:07 -07:00 (Migrated from github.com)
Review

Can you run npx tsc and confirm that this change, and any other new changes are not introducing typescript errors? It appears from my end that they might be. If so, they should be fixed please. However, please see my other comment about prop passing for a color scheme which may make some of these typescript errors redundant

Free to resolve.

Can you run `npx tsc` and confirm that this change, and any other new changes are not introducing typescript errors? It appears from my end that they might be. If so, they should be fixed please. However, please see my other comment about prop passing for a color scheme which may make some of these typescript errors redundant Free to resolve.
djwesty commented 2025-03-11 14:33:07 -07:00 (Migrated from github.com)
Review

Can you run npx tsc and confirm that this change, and any other new changes are not introducing typescript errors? It appears from my end that they might be. If so, they should be fixed please. However, please see my other comment about prop passing for a color scheme which may make some of these typescript errors redundant

Free to resolve.

Can you run `npx tsc` and confirm that this change, and any other new changes are not introducing typescript errors? It appears from my end that they might be. If so, they should be fixed please. However, please see my other comment about prop passing for a color scheme which may make some of these typescript errors redundant Free to resolve.
MantashaNoyela commented 2025-03-13 01:23:31 -07:00 (Migrated from github.com)
Review

fixed these.

fixed these.
MantashaNoyela commented 2025-03-13 01:23:31 -07:00 (Migrated from github.com)
Review

fixed these.

fixed these.
accessibilityRole="button"
style={[
styles.button,
darkMode ? styles.darkButton : styles.lightButton,
djwesty commented 2025-03-11 14:33:07 -07:00 (Migrated from github.com)
Review

Can you run npx tsc and confirm that this change, and any other new changes are not introducing typescript errors? It appears from my end that they might be. If so, they should be fixed please. However, please see my other comment about prop passing for a color scheme which may make some of these typescript errors redundant

Free to resolve.

Can you run `npx tsc` and confirm that this change, and any other new changes are not introducing typescript errors? It appears from my end that they might be. If so, they should be fixed please. However, please see my other comment about prop passing for a color scheme which may make some of these typescript errors redundant Free to resolve.
MantashaNoyela commented 2025-03-13 01:23:31 -07:00 (Migrated from github.com)
Review

fixed these.

fixed these.
{ backgroundColor: colors.PRIMARY },
djwesty commented 2025-03-11 14:33:07 -07:00 (Migrated from github.com)
Review

Can you run npx tsc and confirm that this change, and any other new changes are not introducing typescript errors? It appears from my end that they might be. If so, they should be fixed please. However, please see my other comment about prop passing for a color scheme which may make some of these typescript errors redundant

Free to resolve.

Can you run `npx tsc` and confirm that this change, and any other new changes are not introducing typescript errors? It appears from my end that they might be. If so, they should be fixed please. However, please see my other comment about prop passing for a color scheme which may make some of these typescript errors redundant Free to resolve.
MantashaNoyela commented 2025-03-13 01:23:31 -07:00 (Migrated from github.com)
Review

fixed these.

fixed these.
disabled && styles.disabled,
]}
>
<Text
djwesty commented 2025-03-11 14:33:07 -07:00 (Migrated from github.com)
Review

Can you run npx tsc and confirm that this change, and any other new changes are not introducing typescript errors? It appears from my end that they might be. If so, they should be fixed please. However, please see my other comment about prop passing for a color scheme which may make some of these typescript errors redundant

Free to resolve.

Can you run `npx tsc` and confirm that this change, and any other new changes are not introducing typescript errors? It appears from my end that they might be. If so, they should be fixed please. However, please see my other comment about prop passing for a color scheme which may make some of these typescript errors redundant Free to resolve.
MantashaNoyela commented 2025-03-13 01:23:31 -07:00 (Migrated from github.com)
Review

fixed these.

fixed these.
style={[
djwesty commented 2025-03-11 14:33:07 -07:00 (Migrated from github.com)
Review

Can you run npx tsc and confirm that this change, and any other new changes are not introducing typescript errors? It appears from my end that they might be. If so, they should be fixed please. However, please see my other comment about prop passing for a color scheme which may make some of these typescript errors redundant

Free to resolve.

Can you run `npx tsc` and confirm that this change, and any other new changes are not introducing typescript errors? It appears from my end that they might be. If so, they should be fixed please. However, please see my other comment about prop passing for a color scheme which may make some of these typescript errors redundant Free to resolve.
MantashaNoyela commented 2025-03-13 01:23:31 -07:00 (Migrated from github.com)
Review

fixed these.

fixed these.
styles.buttonText,
djwesty commented 2025-03-11 14:33:07 -07:00 (Migrated from github.com)
Review

Can you run npx tsc and confirm that this change, and any other new changes are not introducing typescript errors? It appears from my end that they might be. If so, they should be fixed please. However, please see my other comment about prop passing for a color scheme which may make some of these typescript errors redundant

Free to resolve.

Can you run `npx tsc` and confirm that this change, and any other new changes are not introducing typescript errors? It appears from my end that they might be. If so, they should be fixed please. However, please see my other comment about prop passing for a color scheme which may make some of these typescript errors redundant Free to resolve.
MantashaNoyela commented 2025-03-13 01:23:31 -07:00 (Migrated from github.com)
Review

fixed these.

fixed these.
darkMode ? styles.darkText : styles.lightText,
djwesty commented 2025-03-11 14:33:07 -07:00 (Migrated from github.com)
Review

Can you run npx tsc and confirm that this change, and any other new changes are not introducing typescript errors? It appears from my end that they might be. If so, they should be fixed please. However, please see my other comment about prop passing for a color scheme which may make some of these typescript errors redundant

Free to resolve.

Can you run `npx tsc` and confirm that this change, and any other new changes are not introducing typescript errors? It appears from my end that they might be. If so, they should be fixed please. However, please see my other comment about prop passing for a color scheme which may make some of these typescript errors redundant Free to resolve.
MantashaNoyela commented 2025-03-13 01:23:31 -07:00 (Migrated from github.com)
Review

fixed these.

fixed these.
]}
djwesty commented 2025-03-11 14:33:07 -07:00 (Migrated from github.com)
Review

Can you run npx tsc and confirm that this change, and any other new changes are not introducing typescript errors? It appears from my end that they might be. If so, they should be fixed please. However, please see my other comment about prop passing for a color scheme which may make some of these typescript errors redundant

Free to resolve.

Can you run `npx tsc` and confirm that this change, and any other new changes are not introducing typescript errors? It appears from my end that they might be. If so, they should be fixed please. However, please see my other comment about prop passing for a color scheme which may make some of these typescript errors redundant Free to resolve.
MantashaNoyela commented 2025-03-13 01:23:31 -07:00 (Migrated from github.com)
Review

fixed these.

fixed these.
>
djwesty commented 2025-03-11 14:33:07 -07:00 (Migrated from github.com)
Review

Can you run npx tsc and confirm that this change, and any other new changes are not introducing typescript errors? It appears from my end that they might be. If so, they should be fixed please. However, please see my other comment about prop passing for a color scheme which may make some of these typescript errors redundant

Free to resolve.

Can you run `npx tsc` and confirm that this change, and any other new changes are not introducing typescript errors? It appears from my end that they might be. If so, they should be fixed please. However, please see my other comment about prop passing for a color scheme which may make some of these typescript errors redundant Free to resolve.
MantashaNoyela commented 2025-03-13 01:23:31 -07:00 (Migrated from github.com)
Review

fixed these.

fixed these.
{title}
djwesty commented 2025-03-11 14:33:07 -07:00 (Migrated from github.com)
Review

Can you run npx tsc and confirm that this change, and any other new changes are not introducing typescript errors? It appears from my end that they might be. If so, they should be fixed please. However, please see my other comment about prop passing for a color scheme which may make some of these typescript errors redundant

Free to resolve.

Can you run `npx tsc` and confirm that this change, and any other new changes are not introducing typescript errors? It appears from my end that they might be. If so, they should be fixed please. However, please see my other comment about prop passing for a color scheme which may make some of these typescript errors redundant Free to resolve.
MantashaNoyela commented 2025-03-13 01:23:31 -07:00 (Migrated from github.com)
Review

fixed these.

fixed these.
</Text>
djwesty commented 2025-03-11 14:33:07 -07:00 (Migrated from github.com)
Review

Can you run npx tsc and confirm that this change, and any other new changes are not introducing typescript errors? It appears from my end that they might be. If so, they should be fixed please. However, please see my other comment about prop passing for a color scheme which may make some of these typescript errors redundant

Free to resolve.

Can you run `npx tsc` and confirm that this change, and any other new changes are not introducing typescript errors? It appears from my end that they might be. If so, they should be fixed please. However, please see my other comment about prop passing for a color scheme which may make some of these typescript errors redundant Free to resolve.
MantashaNoyela commented 2025-03-13 01:23:31 -07:00 (Migrated from github.com)
Review

fixed these.

fixed these.
<Text style={[styles.buttonText, { color: colors.TEXT }]}>{title}</Text>
djwesty commented 2025-03-11 14:33:07 -07:00 (Migrated from github.com)
Review

Can you run npx tsc and confirm that this change, and any other new changes are not introducing typescript errors? It appears from my end that they might be. If so, they should be fixed please. However, please see my other comment about prop passing for a color scheme which may make some of these typescript errors redundant

Free to resolve.

Can you run `npx tsc` and confirm that this change, and any other new changes are not introducing typescript errors? It appears from my end that they might be. If so, they should be fixed please. However, please see my other comment about prop passing for a color scheme which may make some of these typescript errors redundant Free to resolve.
MantashaNoyela commented 2025-03-13 01:23:31 -07:00 (Migrated from github.com)
Review

fixed these.

fixed these.
</TouchableOpacity>
);
};

djwesty commented 2025-03-11 14:33:07 -07:00 (Migrated from github.com)
Review

Can you run npx tsc and confirm that this change, and any other new changes are not introducing typescript errors? It appears from my end that they might be. If so, they should be fixed please. However, please see my other comment about prop passing for a color scheme which may make some of these typescript errors redundant

Free to resolve.

Can you run `npx tsc` and confirm that this change, and any other new changes are not introducing typescript errors? It appears from my end that they might be. If so, they should be fixed please. However, please see my other comment about prop passing for a color scheme which may make some of these typescript errors redundant Free to resolve.
djwesty commented 2025-03-11 14:33:07 -07:00 (Migrated from github.com)
Review

Can you run npx tsc and confirm that this change, and any other new changes are not introducing typescript errors? It appears from my end that they might be. If so, they should be fixed please. However, please see my other comment about prop passing for a color scheme which may make some of these typescript errors redundant

Free to resolve.

Can you run `npx tsc` and confirm that this change, and any other new changes are not introducing typescript errors? It appears from my end that they might be. If so, they should be fixed please. However, please see my other comment about prop passing for a color scheme which may make some of these typescript errors redundant Free to resolve.
MantashaNoyela commented 2025-03-13 01:23:31 -07:00 (Migrated from github.com)
Review

fixed these.

fixed these.
MantashaNoyela commented 2025-03-13 01:23:31 -07:00 (Migrated from github.com)
Review

fixed these.

fixed these.

View File

@ -1,52 +0,0 @@
djwesty commented 2025-03-11 15:24:22 -07:00 (Migrated from github.com)
Review

I may be wrong, but it seems like the purpose of this component is to be a wrapper of sorts for stylistic purposes, to serve the global app layout.

If that is correct, consider that expos stack navigation system provides a purpose built and best practice system to do this universally, and reduce complexity by not needing wrapper components.

For example, our Apps <Stack> (as implemented in _layout.tsx) can take a screen options parameter called contentStyle. This is an object which can contain a backgroundColor. That would be the expo way to set the background color for our app, even dynamically. The <Stack> props are powerfull and can take all sorts of nested style options for the main app content, header, title, etc.

We can discuss this in sync to make sure we are all on the right path

I may be wrong, but it seems like the purpose of this component is to be a wrapper of sorts for stylistic purposes, to serve the global app layout. If that is correct, consider that [expos stack navigation](https://docs.expo.dev/router/advanced/stack/#configure-header-bar) system provides a purpose built and best practice system to do this universally, and reduce complexity by not needing wrapper components. For example, our Apps `<Stack>` (as implemented in `_layout.tsx`) can take a screen options parameter called `contentStyle`. This is an object which can contain a `backgroundColor`. That would be the expo way to set the background color for our app, even dynamically. The `<Stack>` props are powerfull and can take all sorts of nested style options for the main app content, header, title, etc. We can discuss this in sync to make sure we are all on the right path
djwesty commented 2025-03-11 15:24:22 -07:00 (Migrated from github.com)
Review

I may be wrong, but it seems like the purpose of this component is to be a wrapper of sorts for stylistic purposes, to serve the global app layout.

If that is correct, consider that expos stack navigation system provides a purpose built and best practice system to do this universally, and reduce complexity by not needing wrapper components.

For example, our Apps <Stack> (as implemented in _layout.tsx) can take a screen options parameter called contentStyle. This is an object which can contain a backgroundColor. That would be the expo way to set the background color for our app, even dynamically. The <Stack> props are powerfull and can take all sorts of nested style options for the main app content, header, title, etc.

We can discuss this in sync to make sure we are all on the right path

I may be wrong, but it seems like the purpose of this component is to be a wrapper of sorts for stylistic purposes, to serve the global app layout. If that is correct, consider that [expos stack navigation](https://docs.expo.dev/router/advanced/stack/#configure-header-bar) system provides a purpose built and best practice system to do this universally, and reduce complexity by not needing wrapper components. For example, our Apps `<Stack>` (as implemented in `_layout.tsx`) can take a screen options parameter called `contentStyle`. This is an object which can contain a `backgroundColor`. That would be the expo way to set the background color for our app, even dynamically. The `<Stack>` props are powerfull and can take all sorts of nested style options for the main app content, header, title, etc. We can discuss this in sync to make sure we are all on the right path
djwesty commented 2025-03-11 15:25:24 -07:00 (Migrated from github.com)
Review

Do you know what the status bar is doing for the app?

Do you know what the status bar is doing for the app?
djwesty commented 2025-03-11 15:25:24 -07:00 (Migrated from github.com)
Review

Do you know what the status bar is doing for the app?

Do you know what the status bar is doing for the app?
MantashaNoyela commented 2025-03-13 01:07:46 -07:00 (Migrated from github.com)
Review

The StatusBar is used to control the appearance of the mobile device's status bar when the app is running.

The StatusBar is used to control the appearance of the mobile device's status bar when the app is running.
MantashaNoyela commented 2025-03-13 01:07:46 -07:00 (Migrated from github.com)
Review

The StatusBar is used to control the appearance of the mobile device's status bar when the app is running.

The StatusBar is used to control the appearance of the mobile device's status bar when the app is running.
MantashaNoyela commented 2025-03-17 18:24:20 -07:00 (Migrated from github.com)
Review

I believe this issue is solved

I believe this issue is solved
MantashaNoyela commented 2025-03-17 18:24:20 -07:00 (Migrated from github.com)
Review

I believe this issue is solved

I believe this issue is solved
import React, { ReactNode } from "react";
djwesty commented 2025-03-11 15:24:22 -07:00 (Migrated from github.com)
Review

I may be wrong, but it seems like the purpose of this component is to be a wrapper of sorts for stylistic purposes, to serve the global app layout.

If that is correct, consider that expos stack navigation system provides a purpose built and best practice system to do this universally, and reduce complexity by not needing wrapper components.

For example, our Apps <Stack> (as implemented in _layout.tsx) can take a screen options parameter called contentStyle. This is an object which can contain a backgroundColor. That would be the expo way to set the background color for our app, even dynamically. The <Stack> props are powerfull and can take all sorts of nested style options for the main app content, header, title, etc.

We can discuss this in sync to make sure we are all on the right path

I may be wrong, but it seems like the purpose of this component is to be a wrapper of sorts for stylistic purposes, to serve the global app layout. If that is correct, consider that [expos stack navigation](https://docs.expo.dev/router/advanced/stack/#configure-header-bar) system provides a purpose built and best practice system to do this universally, and reduce complexity by not needing wrapper components. For example, our Apps `<Stack>` (as implemented in `_layout.tsx`) can take a screen options parameter called `contentStyle`. This is an object which can contain a `backgroundColor`. That would be the expo way to set the background color for our app, even dynamically. The `<Stack>` props are powerfull and can take all sorts of nested style options for the main app content, header, title, etc. We can discuss this in sync to make sure we are all on the right path
djwesty commented 2025-03-11 15:25:24 -07:00 (Migrated from github.com)
Review

Do you know what the status bar is doing for the app?

Do you know what the status bar is doing for the app?
MantashaNoyela commented 2025-03-13 01:07:46 -07:00 (Migrated from github.com)
Review

The StatusBar is used to control the appearance of the mobile device's status bar when the app is running.

The StatusBar is used to control the appearance of the mobile device's status bar when the app is running.
MantashaNoyela commented 2025-03-17 18:24:20 -07:00 (Migrated from github.com)
Review

I believe this issue is solved

I believe this issue is solved
import {
djwesty commented 2025-03-11 15:24:22 -07:00 (Migrated from github.com)
Review

I may be wrong, but it seems like the purpose of this component is to be a wrapper of sorts for stylistic purposes, to serve the global app layout.

If that is correct, consider that expos stack navigation system provides a purpose built and best practice system to do this universally, and reduce complexity by not needing wrapper components.

For example, our Apps <Stack> (as implemented in _layout.tsx) can take a screen options parameter called contentStyle. This is an object which can contain a backgroundColor. That would be the expo way to set the background color for our app, even dynamically. The <Stack> props are powerfull and can take all sorts of nested style options for the main app content, header, title, etc.

We can discuss this in sync to make sure we are all on the right path

I may be wrong, but it seems like the purpose of this component is to be a wrapper of sorts for stylistic purposes, to serve the global app layout. If that is correct, consider that [expos stack navigation](https://docs.expo.dev/router/advanced/stack/#configure-header-bar) system provides a purpose built and best practice system to do this universally, and reduce complexity by not needing wrapper components. For example, our Apps `<Stack>` (as implemented in `_layout.tsx`) can take a screen options parameter called `contentStyle`. This is an object which can contain a `backgroundColor`. That would be the expo way to set the background color for our app, even dynamically. The `<Stack>` props are powerfull and can take all sorts of nested style options for the main app content, header, title, etc. We can discuss this in sync to make sure we are all on the right path
djwesty commented 2025-03-11 15:25:24 -07:00 (Migrated from github.com)
Review

Do you know what the status bar is doing for the app?

Do you know what the status bar is doing for the app?
MantashaNoyela commented 2025-03-13 01:07:46 -07:00 (Migrated from github.com)
Review

The StatusBar is used to control the appearance of the mobile device's status bar when the app is running.

The StatusBar is used to control the appearance of the mobile device's status bar when the app is running.
MantashaNoyela commented 2025-03-17 18:24:20 -07:00 (Migrated from github.com)
Review

I believe this issue is solved

I believe this issue is solved
SafeAreaView,
djwesty commented 2025-03-11 15:24:22 -07:00 (Migrated from github.com)
Review

I may be wrong, but it seems like the purpose of this component is to be a wrapper of sorts for stylistic purposes, to serve the global app layout.

If that is correct, consider that expos stack navigation system provides a purpose built and best practice system to do this universally, and reduce complexity by not needing wrapper components.

For example, our Apps <Stack> (as implemented in _layout.tsx) can take a screen options parameter called contentStyle. This is an object which can contain a backgroundColor. That would be the expo way to set the background color for our app, even dynamically. The <Stack> props are powerfull and can take all sorts of nested style options for the main app content, header, title, etc.

We can discuss this in sync to make sure we are all on the right path

I may be wrong, but it seems like the purpose of this component is to be a wrapper of sorts for stylistic purposes, to serve the global app layout. If that is correct, consider that [expos stack navigation](https://docs.expo.dev/router/advanced/stack/#configure-header-bar) system provides a purpose built and best practice system to do this universally, and reduce complexity by not needing wrapper components. For example, our Apps `<Stack>` (as implemented in `_layout.tsx`) can take a screen options parameter called `contentStyle`. This is an object which can contain a `backgroundColor`. That would be the expo way to set the background color for our app, even dynamically. The `<Stack>` props are powerfull and can take all sorts of nested style options for the main app content, header, title, etc. We can discuss this in sync to make sure we are all on the right path
djwesty commented 2025-03-11 15:25:24 -07:00 (Migrated from github.com)
Review

Do you know what the status bar is doing for the app?

Do you know what the status bar is doing for the app?
MantashaNoyela commented 2025-03-13 01:07:46 -07:00 (Migrated from github.com)
Review

The StatusBar is used to control the appearance of the mobile device's status bar when the app is running.

The StatusBar is used to control the appearance of the mobile device's status bar when the app is running.
MantashaNoyela commented 2025-03-17 18:24:20 -07:00 (Migrated from github.com)
Review

I believe this issue is solved

I believe this issue is solved
StatusBar,
djwesty commented 2025-03-11 15:24:22 -07:00 (Migrated from github.com)
Review

I may be wrong, but it seems like the purpose of this component is to be a wrapper of sorts for stylistic purposes, to serve the global app layout.

If that is correct, consider that expos stack navigation system provides a purpose built and best practice system to do this universally, and reduce complexity by not needing wrapper components.

For example, our Apps <Stack> (as implemented in _layout.tsx) can take a screen options parameter called contentStyle. This is an object which can contain a backgroundColor. That would be the expo way to set the background color for our app, even dynamically. The <Stack> props are powerfull and can take all sorts of nested style options for the main app content, header, title, etc.

We can discuss this in sync to make sure we are all on the right path

I may be wrong, but it seems like the purpose of this component is to be a wrapper of sorts for stylistic purposes, to serve the global app layout. If that is correct, consider that [expos stack navigation](https://docs.expo.dev/router/advanced/stack/#configure-header-bar) system provides a purpose built and best practice system to do this universally, and reduce complexity by not needing wrapper components. For example, our Apps `<Stack>` (as implemented in `_layout.tsx`) can take a screen options parameter called `contentStyle`. This is an object which can contain a `backgroundColor`. That would be the expo way to set the background color for our app, even dynamically. The `<Stack>` props are powerfull and can take all sorts of nested style options for the main app content, header, title, etc. We can discuss this in sync to make sure we are all on the right path
djwesty commented 2025-03-11 15:25:24 -07:00 (Migrated from github.com)
Review

Do you know what the status bar is doing for the app?

Do you know what the status bar is doing for the app?
MantashaNoyela commented 2025-03-13 01:07:46 -07:00 (Migrated from github.com)
Review

The StatusBar is used to control the appearance of the mobile device's status bar when the app is running.

The StatusBar is used to control the appearance of the mobile device's status bar when the app is running.
MantashaNoyela commented 2025-03-17 18:24:20 -07:00 (Migrated from github.com)
Review

I believe this issue is solved

I believe this issue is solved
View,
djwesty commented 2025-03-11 15:24:22 -07:00 (Migrated from github.com)
Review

I may be wrong, but it seems like the purpose of this component is to be a wrapper of sorts for stylistic purposes, to serve the global app layout.

If that is correct, consider that expos stack navigation system provides a purpose built and best practice system to do this universally, and reduce complexity by not needing wrapper components.

For example, our Apps <Stack> (as implemented in _layout.tsx) can take a screen options parameter called contentStyle. This is an object which can contain a backgroundColor. That would be the expo way to set the background color for our app, even dynamically. The <Stack> props are powerfull and can take all sorts of nested style options for the main app content, header, title, etc.

We can discuss this in sync to make sure we are all on the right path

I may be wrong, but it seems like the purpose of this component is to be a wrapper of sorts for stylistic purposes, to serve the global app layout. If that is correct, consider that [expos stack navigation](https://docs.expo.dev/router/advanced/stack/#configure-header-bar) system provides a purpose built and best practice system to do this universally, and reduce complexity by not needing wrapper components. For example, our Apps `<Stack>` (as implemented in `_layout.tsx`) can take a screen options parameter called `contentStyle`. This is an object which can contain a `backgroundColor`. That would be the expo way to set the background color for our app, even dynamically. The `<Stack>` props are powerfull and can take all sorts of nested style options for the main app content, header, title, etc. We can discuss this in sync to make sure we are all on the right path
djwesty commented 2025-03-11 15:25:24 -07:00 (Migrated from github.com)
Review

Do you know what the status bar is doing for the app?

Do you know what the status bar is doing for the app?
MantashaNoyela commented 2025-03-13 01:07:46 -07:00 (Migrated from github.com)
Review

The StatusBar is used to control the appearance of the mobile device's status bar when the app is running.

The StatusBar is used to control the appearance of the mobile device's status bar when the app is running.
MantashaNoyela commented 2025-03-17 18:24:20 -07:00 (Migrated from github.com)
Review

I believe this issue is solved

I believe this issue is solved
StyleSheet,
djwesty commented 2025-03-11 15:24:22 -07:00 (Migrated from github.com)
Review

I may be wrong, but it seems like the purpose of this component is to be a wrapper of sorts for stylistic purposes, to serve the global app layout.

If that is correct, consider that expos stack navigation system provides a purpose built and best practice system to do this universally, and reduce complexity by not needing wrapper components.

For example, our Apps <Stack> (as implemented in _layout.tsx) can take a screen options parameter called contentStyle. This is an object which can contain a backgroundColor. That would be the expo way to set the background color for our app, even dynamically. The <Stack> props are powerfull and can take all sorts of nested style options for the main app content, header, title, etc.

We can discuss this in sync to make sure we are all on the right path

I may be wrong, but it seems like the purpose of this component is to be a wrapper of sorts for stylistic purposes, to serve the global app layout. If that is correct, consider that [expos stack navigation](https://docs.expo.dev/router/advanced/stack/#configure-header-bar) system provides a purpose built and best practice system to do this universally, and reduce complexity by not needing wrapper components. For example, our Apps `<Stack>` (as implemented in `_layout.tsx`) can take a screen options parameter called `contentStyle`. This is an object which can contain a `backgroundColor`. That would be the expo way to set the background color for our app, even dynamically. The `<Stack>` props are powerfull and can take all sorts of nested style options for the main app content, header, title, etc. We can discuss this in sync to make sure we are all on the right path
djwesty commented 2025-03-11 15:25:24 -07:00 (Migrated from github.com)
Review

Do you know what the status bar is doing for the app?

Do you know what the status bar is doing for the app?
MantashaNoyela commented 2025-03-13 01:07:46 -07:00 (Migrated from github.com)
Review

The StatusBar is used to control the appearance of the mobile device's status bar when the app is running.

The StatusBar is used to control the appearance of the mobile device's status bar when the app is running.
MantashaNoyela commented 2025-03-17 18:24:20 -07:00 (Migrated from github.com)
Review

I believe this issue is solved

I believe this issue is solved
Dimensions,
djwesty commented 2025-03-11 15:24:22 -07:00 (Migrated from github.com)
Review

I may be wrong, but it seems like the purpose of this component is to be a wrapper of sorts for stylistic purposes, to serve the global app layout.

If that is correct, consider that expos stack navigation system provides a purpose built and best practice system to do this universally, and reduce complexity by not needing wrapper components.

For example, our Apps <Stack> (as implemented in _layout.tsx) can take a screen options parameter called contentStyle. This is an object which can contain a backgroundColor. That would be the expo way to set the background color for our app, even dynamically. The <Stack> props are powerfull and can take all sorts of nested style options for the main app content, header, title, etc.

We can discuss this in sync to make sure we are all on the right path

I may be wrong, but it seems like the purpose of this component is to be a wrapper of sorts for stylistic purposes, to serve the global app layout. If that is correct, consider that [expos stack navigation](https://docs.expo.dev/router/advanced/stack/#configure-header-bar) system provides a purpose built and best practice system to do this universally, and reduce complexity by not needing wrapper components. For example, our Apps `<Stack>` (as implemented in `_layout.tsx`) can take a screen options parameter called `contentStyle`. This is an object which can contain a `backgroundColor`. That would be the expo way to set the background color for our app, even dynamically. The `<Stack>` props are powerfull and can take all sorts of nested style options for the main app content, header, title, etc. We can discuss this in sync to make sure we are all on the right path
djwesty commented 2025-03-11 15:25:24 -07:00 (Migrated from github.com)
Review

Do you know what the status bar is doing for the app?

Do you know what the status bar is doing for the app?
MantashaNoyela commented 2025-03-13 01:07:46 -07:00 (Migrated from github.com)
Review

The StatusBar is used to control the appearance of the mobile device's status bar when the app is running.

The StatusBar is used to control the appearance of the mobile device's status bar when the app is running.
MantashaNoyela commented 2025-03-17 18:24:20 -07:00 (Migrated from github.com)
Review

I believe this issue is solved

I believe this issue is solved
} from "react-native";
djwesty commented 2025-03-11 15:24:22 -07:00 (Migrated from github.com)
Review

I may be wrong, but it seems like the purpose of this component is to be a wrapper of sorts for stylistic purposes, to serve the global app layout.

If that is correct, consider that expos stack navigation system provides a purpose built and best practice system to do this universally, and reduce complexity by not needing wrapper components.

For example, our Apps <Stack> (as implemented in _layout.tsx) can take a screen options parameter called contentStyle. This is an object which can contain a backgroundColor. That would be the expo way to set the background color for our app, even dynamically. The <Stack> props are powerfull and can take all sorts of nested style options for the main app content, header, title, etc.

We can discuss this in sync to make sure we are all on the right path

I may be wrong, but it seems like the purpose of this component is to be a wrapper of sorts for stylistic purposes, to serve the global app layout. If that is correct, consider that [expos stack navigation](https://docs.expo.dev/router/advanced/stack/#configure-header-bar) system provides a purpose built and best practice system to do this universally, and reduce complexity by not needing wrapper components. For example, our Apps `<Stack>` (as implemented in `_layout.tsx`) can take a screen options parameter called `contentStyle`. This is an object which can contain a `backgroundColor`. That would be the expo way to set the background color for our app, even dynamically. The `<Stack>` props are powerfull and can take all sorts of nested style options for the main app content, header, title, etc. We can discuss this in sync to make sure we are all on the right path
djwesty commented 2025-03-11 15:25:24 -07:00 (Migrated from github.com)
Review

Do you know what the status bar is doing for the app?

Do you know what the status bar is doing for the app?
MantashaNoyela commented 2025-03-13 01:07:46 -07:00 (Migrated from github.com)
Review

The StatusBar is used to control the appearance of the mobile device's status bar when the app is running.

The StatusBar is used to control the appearance of the mobile device's status bar when the app is running.
MantashaNoyela commented 2025-03-17 18:24:20 -07:00 (Migrated from github.com)
Review

I believe this issue is solved

I believe this issue is solved
djwesty commented 2025-03-11 15:24:22 -07:00 (Migrated from github.com)
Review

I may be wrong, but it seems like the purpose of this component is to be a wrapper of sorts for stylistic purposes, to serve the global app layout.

If that is correct, consider that expos stack navigation system provides a purpose built and best practice system to do this universally, and reduce complexity by not needing wrapper components.

For example, our Apps <Stack> (as implemented in _layout.tsx) can take a screen options parameter called contentStyle. This is an object which can contain a backgroundColor. That would be the expo way to set the background color for our app, even dynamically. The <Stack> props are powerfull and can take all sorts of nested style options for the main app content, header, title, etc.

We can discuss this in sync to make sure we are all on the right path

I may be wrong, but it seems like the purpose of this component is to be a wrapper of sorts for stylistic purposes, to serve the global app layout. If that is correct, consider that [expos stack navigation](https://docs.expo.dev/router/advanced/stack/#configure-header-bar) system provides a purpose built and best practice system to do this universally, and reduce complexity by not needing wrapper components. For example, our Apps `<Stack>` (as implemented in `_layout.tsx`) can take a screen options parameter called `contentStyle`. This is an object which can contain a `backgroundColor`. That would be the expo way to set the background color for our app, even dynamically. The `<Stack>` props are powerfull and can take all sorts of nested style options for the main app content, header, title, etc. We can discuss this in sync to make sure we are all on the right path
djwesty commented 2025-03-11 15:25:24 -07:00 (Migrated from github.com)
Review

Do you know what the status bar is doing for the app?

Do you know what the status bar is doing for the app?
MantashaNoyela commented 2025-03-13 01:07:46 -07:00 (Migrated from github.com)
Review

The StatusBar is used to control the appearance of the mobile device's status bar when the app is running.

The StatusBar is used to control the appearance of the mobile device's status bar when the app is running.
MantashaNoyela commented 2025-03-17 18:24:20 -07:00 (Migrated from github.com)
Review

I believe this issue is solved

I believe this issue is solved
interface PokerAppUiProps {
djwesty commented 2025-03-11 15:24:22 -07:00 (Migrated from github.com)
Review

I may be wrong, but it seems like the purpose of this component is to be a wrapper of sorts for stylistic purposes, to serve the global app layout.

If that is correct, consider that expos stack navigation system provides a purpose built and best practice system to do this universally, and reduce complexity by not needing wrapper components.

For example, our Apps <Stack> (as implemented in _layout.tsx) can take a screen options parameter called contentStyle. This is an object which can contain a backgroundColor. That would be the expo way to set the background color for our app, even dynamically. The <Stack> props are powerfull and can take all sorts of nested style options for the main app content, header, title, etc.

We can discuss this in sync to make sure we are all on the right path

I may be wrong, but it seems like the purpose of this component is to be a wrapper of sorts for stylistic purposes, to serve the global app layout. If that is correct, consider that [expos stack navigation](https://docs.expo.dev/router/advanced/stack/#configure-header-bar) system provides a purpose built and best practice system to do this universally, and reduce complexity by not needing wrapper components. For example, our Apps `<Stack>` (as implemented in `_layout.tsx`) can take a screen options parameter called `contentStyle`. This is an object which can contain a `backgroundColor`. That would be the expo way to set the background color for our app, even dynamically. The `<Stack>` props are powerfull and can take all sorts of nested style options for the main app content, header, title, etc. We can discuss this in sync to make sure we are all on the right path
djwesty commented 2025-03-11 15:25:24 -07:00 (Migrated from github.com)
Review

Do you know what the status bar is doing for the app?

Do you know what the status bar is doing for the app?
MantashaNoyela commented 2025-03-13 01:07:46 -07:00 (Migrated from github.com)
Review

The StatusBar is used to control the appearance of the mobile device's status bar when the app is running.

The StatusBar is used to control the appearance of the mobile device's status bar when the app is running.
MantashaNoyela commented 2025-03-17 18:24:20 -07:00 (Migrated from github.com)
Review

I believe this issue is solved

I believe this issue is solved
children: ReactNode;
djwesty commented 2025-03-11 15:24:22 -07:00 (Migrated from github.com)
Review

I may be wrong, but it seems like the purpose of this component is to be a wrapper of sorts for stylistic purposes, to serve the global app layout.

If that is correct, consider that expos stack navigation system provides a purpose built and best practice system to do this universally, and reduce complexity by not needing wrapper components.

For example, our Apps <Stack> (as implemented in _layout.tsx) can take a screen options parameter called contentStyle. This is an object which can contain a backgroundColor. That would be the expo way to set the background color for our app, even dynamically. The <Stack> props are powerfull and can take all sorts of nested style options for the main app content, header, title, etc.

We can discuss this in sync to make sure we are all on the right path

I may be wrong, but it seems like the purpose of this component is to be a wrapper of sorts for stylistic purposes, to serve the global app layout. If that is correct, consider that [expos stack navigation](https://docs.expo.dev/router/advanced/stack/#configure-header-bar) system provides a purpose built and best practice system to do this universally, and reduce complexity by not needing wrapper components. For example, our Apps `<Stack>` (as implemented in `_layout.tsx`) can take a screen options parameter called `contentStyle`. This is an object which can contain a `backgroundColor`. That would be the expo way to set the background color for our app, even dynamically. The `<Stack>` props are powerfull and can take all sorts of nested style options for the main app content, header, title, etc. We can discuss this in sync to make sure we are all on the right path
djwesty commented 2025-03-11 15:25:24 -07:00 (Migrated from github.com)
Review

Do you know what the status bar is doing for the app?

Do you know what the status bar is doing for the app?
MantashaNoyela commented 2025-03-13 01:07:46 -07:00 (Migrated from github.com)
Review

The StatusBar is used to control the appearance of the mobile device's status bar when the app is running.

The StatusBar is used to control the appearance of the mobile device's status bar when the app is running.
MantashaNoyela commented 2025-03-17 18:24:20 -07:00 (Migrated from github.com)
Review

I believe this issue is solved

I believe this issue is solved
darkMode?: boolean;
djwesty commented 2025-03-11 15:24:22 -07:00 (Migrated from github.com)
Review

I may be wrong, but it seems like the purpose of this component is to be a wrapper of sorts for stylistic purposes, to serve the global app layout.

If that is correct, consider that expos stack navigation system provides a purpose built and best practice system to do this universally, and reduce complexity by not needing wrapper components.

For example, our Apps <Stack> (as implemented in _layout.tsx) can take a screen options parameter called contentStyle. This is an object which can contain a backgroundColor. That would be the expo way to set the background color for our app, even dynamically. The <Stack> props are powerfull and can take all sorts of nested style options for the main app content, header, title, etc.

We can discuss this in sync to make sure we are all on the right path

I may be wrong, but it seems like the purpose of this component is to be a wrapper of sorts for stylistic purposes, to serve the global app layout. If that is correct, consider that [expos stack navigation](https://docs.expo.dev/router/advanced/stack/#configure-header-bar) system provides a purpose built and best practice system to do this universally, and reduce complexity by not needing wrapper components. For example, our Apps `<Stack>` (as implemented in `_layout.tsx`) can take a screen options parameter called `contentStyle`. This is an object which can contain a `backgroundColor`. That would be the expo way to set the background color for our app, even dynamically. The `<Stack>` props are powerfull and can take all sorts of nested style options for the main app content, header, title, etc. We can discuss this in sync to make sure we are all on the right path
djwesty commented 2025-03-11 15:25:24 -07:00 (Migrated from github.com)
Review

Do you know what the status bar is doing for the app?

Do you know what the status bar is doing for the app?
MantashaNoyela commented 2025-03-13 01:07:46 -07:00 (Migrated from github.com)
Review

The StatusBar is used to control the appearance of the mobile device's status bar when the app is running.

The StatusBar is used to control the appearance of the mobile device's status bar when the app is running.
MantashaNoyela commented 2025-03-17 18:24:20 -07:00 (Migrated from github.com)
Review

I believe this issue is solved

I believe this issue is solved
}
djwesty commented 2025-03-11 15:24:22 -07:00 (Migrated from github.com)
Review

I may be wrong, but it seems like the purpose of this component is to be a wrapper of sorts for stylistic purposes, to serve the global app layout.

If that is correct, consider that expos stack navigation system provides a purpose built and best practice system to do this universally, and reduce complexity by not needing wrapper components.

For example, our Apps <Stack> (as implemented in _layout.tsx) can take a screen options parameter called contentStyle. This is an object which can contain a backgroundColor. That would be the expo way to set the background color for our app, even dynamically. The <Stack> props are powerfull and can take all sorts of nested style options for the main app content, header, title, etc.

We can discuss this in sync to make sure we are all on the right path

I may be wrong, but it seems like the purpose of this component is to be a wrapper of sorts for stylistic purposes, to serve the global app layout. If that is correct, consider that [expos stack navigation](https://docs.expo.dev/router/advanced/stack/#configure-header-bar) system provides a purpose built and best practice system to do this universally, and reduce complexity by not needing wrapper components. For example, our Apps `<Stack>` (as implemented in `_layout.tsx`) can take a screen options parameter called `contentStyle`. This is an object which can contain a `backgroundColor`. That would be the expo way to set the background color for our app, even dynamically. The `<Stack>` props are powerfull and can take all sorts of nested style options for the main app content, header, title, etc. We can discuss this in sync to make sure we are all on the right path
djwesty commented 2025-03-11 15:25:24 -07:00 (Migrated from github.com)
Review

Do you know what the status bar is doing for the app?

Do you know what the status bar is doing for the app?
MantashaNoyela commented 2025-03-13 01:07:46 -07:00 (Migrated from github.com)
Review

The StatusBar is used to control the appearance of the mobile device's status bar when the app is running.

The StatusBar is used to control the appearance of the mobile device's status bar when the app is running.
MantashaNoyela commented 2025-03-17 18:24:20 -07:00 (Migrated from github.com)
Review

I believe this issue is solved

I believe this issue is solved
djwesty commented 2025-03-11 15:24:22 -07:00 (Migrated from github.com)
Review

I may be wrong, but it seems like the purpose of this component is to be a wrapper of sorts for stylistic purposes, to serve the global app layout.

If that is correct, consider that expos stack navigation system provides a purpose built and best practice system to do this universally, and reduce complexity by not needing wrapper components.

For example, our Apps <Stack> (as implemented in _layout.tsx) can take a screen options parameter called contentStyle. This is an object which can contain a backgroundColor. That would be the expo way to set the background color for our app, even dynamically. The <Stack> props are powerfull and can take all sorts of nested style options for the main app content, header, title, etc.

We can discuss this in sync to make sure we are all on the right path

I may be wrong, but it seems like the purpose of this component is to be a wrapper of sorts for stylistic purposes, to serve the global app layout. If that is correct, consider that [expos stack navigation](https://docs.expo.dev/router/advanced/stack/#configure-header-bar) system provides a purpose built and best practice system to do this universally, and reduce complexity by not needing wrapper components. For example, our Apps `<Stack>` (as implemented in `_layout.tsx`) can take a screen options parameter called `contentStyle`. This is an object which can contain a `backgroundColor`. That would be the expo way to set the background color for our app, even dynamically. The `<Stack>` props are powerfull and can take all sorts of nested style options for the main app content, header, title, etc. We can discuss this in sync to make sure we are all on the right path
djwesty commented 2025-03-11 15:25:24 -07:00 (Migrated from github.com)
Review

Do you know what the status bar is doing for the app?

Do you know what the status bar is doing for the app?
MantashaNoyela commented 2025-03-13 01:07:46 -07:00 (Migrated from github.com)
Review

The StatusBar is used to control the appearance of the mobile device's status bar when the app is running.

The StatusBar is used to control the appearance of the mobile device's status bar when the app is running.
MantashaNoyela commented 2025-03-17 18:24:20 -07:00 (Migrated from github.com)
Review

I believe this issue is solved

I believe this issue is solved
const PokerAppUi: React.FC<PokerAppUiProps> = ({
djwesty commented 2025-03-11 15:24:22 -07:00 (Migrated from github.com)
Review

I may be wrong, but it seems like the purpose of this component is to be a wrapper of sorts for stylistic purposes, to serve the global app layout.

If that is correct, consider that expos stack navigation system provides a purpose built and best practice system to do this universally, and reduce complexity by not needing wrapper components.

For example, our Apps <Stack> (as implemented in _layout.tsx) can take a screen options parameter called contentStyle. This is an object which can contain a backgroundColor. That would be the expo way to set the background color for our app, even dynamically. The <Stack> props are powerfull and can take all sorts of nested style options for the main app content, header, title, etc.

We can discuss this in sync to make sure we are all on the right path

I may be wrong, but it seems like the purpose of this component is to be a wrapper of sorts for stylistic purposes, to serve the global app layout. If that is correct, consider that [expos stack navigation](https://docs.expo.dev/router/advanced/stack/#configure-header-bar) system provides a purpose built and best practice system to do this universally, and reduce complexity by not needing wrapper components. For example, our Apps `<Stack>` (as implemented in `_layout.tsx`) can take a screen options parameter called `contentStyle`. This is an object which can contain a `backgroundColor`. That would be the expo way to set the background color for our app, even dynamically. The `<Stack>` props are powerfull and can take all sorts of nested style options for the main app content, header, title, etc. We can discuss this in sync to make sure we are all on the right path
djwesty commented 2025-03-11 15:25:24 -07:00 (Migrated from github.com)
Review

Do you know what the status bar is doing for the app?

Do you know what the status bar is doing for the app?
MantashaNoyela commented 2025-03-13 01:07:46 -07:00 (Migrated from github.com)
Review

The StatusBar is used to control the appearance of the mobile device's status bar when the app is running.

The StatusBar is used to control the appearance of the mobile device's status bar when the app is running.
MantashaNoyela commented 2025-03-17 18:24:20 -07:00 (Migrated from github.com)
Review

I believe this issue is solved

I believe this issue is solved
children,
djwesty commented 2025-03-11 15:24:22 -07:00 (Migrated from github.com)
Review

I may be wrong, but it seems like the purpose of this component is to be a wrapper of sorts for stylistic purposes, to serve the global app layout.

If that is correct, consider that expos stack navigation system provides a purpose built and best practice system to do this universally, and reduce complexity by not needing wrapper components.

For example, our Apps <Stack> (as implemented in _layout.tsx) can take a screen options parameter called contentStyle. This is an object which can contain a backgroundColor. That would be the expo way to set the background color for our app, even dynamically. The <Stack> props are powerfull and can take all sorts of nested style options for the main app content, header, title, etc.

We can discuss this in sync to make sure we are all on the right path

I may be wrong, but it seems like the purpose of this component is to be a wrapper of sorts for stylistic purposes, to serve the global app layout. If that is correct, consider that [expos stack navigation](https://docs.expo.dev/router/advanced/stack/#configure-header-bar) system provides a purpose built and best practice system to do this universally, and reduce complexity by not needing wrapper components. For example, our Apps `<Stack>` (as implemented in `_layout.tsx`) can take a screen options parameter called `contentStyle`. This is an object which can contain a `backgroundColor`. That would be the expo way to set the background color for our app, even dynamically. The `<Stack>` props are powerfull and can take all sorts of nested style options for the main app content, header, title, etc. We can discuss this in sync to make sure we are all on the right path
djwesty commented 2025-03-11 15:25:24 -07:00 (Migrated from github.com)
Review

Do you know what the status bar is doing for the app?

Do you know what the status bar is doing for the app?
MantashaNoyela commented 2025-03-13 01:07:46 -07:00 (Migrated from github.com)
Review

The StatusBar is used to control the appearance of the mobile device's status bar when the app is running.

The StatusBar is used to control the appearance of the mobile device's status bar when the app is running.
MantashaNoyela commented 2025-03-17 18:24:20 -07:00 (Migrated from github.com)
Review

I believe this issue is solved

I believe this issue is solved
darkMode = false,
djwesty commented 2025-03-11 15:24:22 -07:00 (Migrated from github.com)
Review

I may be wrong, but it seems like the purpose of this component is to be a wrapper of sorts for stylistic purposes, to serve the global app layout.

If that is correct, consider that expos stack navigation system provides a purpose built and best practice system to do this universally, and reduce complexity by not needing wrapper components.

For example, our Apps <Stack> (as implemented in _layout.tsx) can take a screen options parameter called contentStyle. This is an object which can contain a backgroundColor. That would be the expo way to set the background color for our app, even dynamically. The <Stack> props are powerfull and can take all sorts of nested style options for the main app content, header, title, etc.

We can discuss this in sync to make sure we are all on the right path

I may be wrong, but it seems like the purpose of this component is to be a wrapper of sorts for stylistic purposes, to serve the global app layout. If that is correct, consider that [expos stack navigation](https://docs.expo.dev/router/advanced/stack/#configure-header-bar) system provides a purpose built and best practice system to do this universally, and reduce complexity by not needing wrapper components. For example, our Apps `<Stack>` (as implemented in `_layout.tsx`) can take a screen options parameter called `contentStyle`. This is an object which can contain a `backgroundColor`. That would be the expo way to set the background color for our app, even dynamically. The `<Stack>` props are powerfull and can take all sorts of nested style options for the main app content, header, title, etc. We can discuss this in sync to make sure we are all on the right path
djwesty commented 2025-03-11 15:25:24 -07:00 (Migrated from github.com)
Review

Do you know what the status bar is doing for the app?

Do you know what the status bar is doing for the app?
MantashaNoyela commented 2025-03-13 01:07:46 -07:00 (Migrated from github.com)
Review

The StatusBar is used to control the appearance of the mobile device's status bar when the app is running.

The StatusBar is used to control the appearance of the mobile device's status bar when the app is running.
MantashaNoyela commented 2025-03-17 18:24:20 -07:00 (Migrated from github.com)
Review

I believe this issue is solved

I believe this issue is solved
}) => {
djwesty commented 2025-03-11 15:24:22 -07:00 (Migrated from github.com)
Review

I may be wrong, but it seems like the purpose of this component is to be a wrapper of sorts for stylistic purposes, to serve the global app layout.

If that is correct, consider that expos stack navigation system provides a purpose built and best practice system to do this universally, and reduce complexity by not needing wrapper components.

For example, our Apps <Stack> (as implemented in _layout.tsx) can take a screen options parameter called contentStyle. This is an object which can contain a backgroundColor. That would be the expo way to set the background color for our app, even dynamically. The <Stack> props are powerfull and can take all sorts of nested style options for the main app content, header, title, etc.

We can discuss this in sync to make sure we are all on the right path

I may be wrong, but it seems like the purpose of this component is to be a wrapper of sorts for stylistic purposes, to serve the global app layout. If that is correct, consider that [expos stack navigation](https://docs.expo.dev/router/advanced/stack/#configure-header-bar) system provides a purpose built and best practice system to do this universally, and reduce complexity by not needing wrapper components. For example, our Apps `<Stack>` (as implemented in `_layout.tsx`) can take a screen options parameter called `contentStyle`. This is an object which can contain a `backgroundColor`. That would be the expo way to set the background color for our app, even dynamically. The `<Stack>` props are powerfull and can take all sorts of nested style options for the main app content, header, title, etc. We can discuss this in sync to make sure we are all on the right path
djwesty commented 2025-03-11 15:25:24 -07:00 (Migrated from github.com)
Review

Do you know what the status bar is doing for the app?

Do you know what the status bar is doing for the app?
MantashaNoyela commented 2025-03-13 01:07:46 -07:00 (Migrated from github.com)
Review

The StatusBar is used to control the appearance of the mobile device's status bar when the app is running.

The StatusBar is used to control the appearance of the mobile device's status bar when the app is running.
MantashaNoyela commented 2025-03-17 18:24:20 -07:00 (Migrated from github.com)
Review

I believe this issue is solved

I believe this issue is solved
const screenHeight = Dimensions.get("window").height;
djwesty commented 2025-03-11 15:24:22 -07:00 (Migrated from github.com)
Review

I may be wrong, but it seems like the purpose of this component is to be a wrapper of sorts for stylistic purposes, to serve the global app layout.

If that is correct, consider that expos stack navigation system provides a purpose built and best practice system to do this universally, and reduce complexity by not needing wrapper components.

For example, our Apps <Stack> (as implemented in _layout.tsx) can take a screen options parameter called contentStyle. This is an object which can contain a backgroundColor. That would be the expo way to set the background color for our app, even dynamically. The <Stack> props are powerfull and can take all sorts of nested style options for the main app content, header, title, etc.

We can discuss this in sync to make sure we are all on the right path

I may be wrong, but it seems like the purpose of this component is to be a wrapper of sorts for stylistic purposes, to serve the global app layout. If that is correct, consider that [expos stack navigation](https://docs.expo.dev/router/advanced/stack/#configure-header-bar) system provides a purpose built and best practice system to do this universally, and reduce complexity by not needing wrapper components. For example, our Apps `<Stack>` (as implemented in `_layout.tsx`) can take a screen options parameter called `contentStyle`. This is an object which can contain a `backgroundColor`. That would be the expo way to set the background color for our app, even dynamically. The `<Stack>` props are powerfull and can take all sorts of nested style options for the main app content, header, title, etc. We can discuss this in sync to make sure we are all on the right path
djwesty commented 2025-03-11 15:25:24 -07:00 (Migrated from github.com)
Review

Do you know what the status bar is doing for the app?

Do you know what the status bar is doing for the app?
MantashaNoyela commented 2025-03-13 01:07:46 -07:00 (Migrated from github.com)
Review

The StatusBar is used to control the appearance of the mobile device's status bar when the app is running.

The StatusBar is used to control the appearance of the mobile device's status bar when the app is running.
MantashaNoyela commented 2025-03-17 18:24:20 -07:00 (Migrated from github.com)
Review

I believe this issue is solved

I believe this issue is solved
djwesty commented 2025-03-11 15:24:22 -07:00 (Migrated from github.com)
Review

I may be wrong, but it seems like the purpose of this component is to be a wrapper of sorts for stylistic purposes, to serve the global app layout.

If that is correct, consider that expos stack navigation system provides a purpose built and best practice system to do this universally, and reduce complexity by not needing wrapper components.

For example, our Apps <Stack> (as implemented in _layout.tsx) can take a screen options parameter called contentStyle. This is an object which can contain a backgroundColor. That would be the expo way to set the background color for our app, even dynamically. The <Stack> props are powerfull and can take all sorts of nested style options for the main app content, header, title, etc.

We can discuss this in sync to make sure we are all on the right path

I may be wrong, but it seems like the purpose of this component is to be a wrapper of sorts for stylistic purposes, to serve the global app layout. If that is correct, consider that [expos stack navigation](https://docs.expo.dev/router/advanced/stack/#configure-header-bar) system provides a purpose built and best practice system to do this universally, and reduce complexity by not needing wrapper components. For example, our Apps `<Stack>` (as implemented in `_layout.tsx`) can take a screen options parameter called `contentStyle`. This is an object which can contain a `backgroundColor`. That would be the expo way to set the background color for our app, even dynamically. The `<Stack>` props are powerfull and can take all sorts of nested style options for the main app content, header, title, etc. We can discuss this in sync to make sure we are all on the right path
djwesty commented 2025-03-11 15:25:24 -07:00 (Migrated from github.com)
Review

Do you know what the status bar is doing for the app?

Do you know what the status bar is doing for the app?
MantashaNoyela commented 2025-03-13 01:07:46 -07:00 (Migrated from github.com)
Review

The StatusBar is used to control the appearance of the mobile device's status bar when the app is running.

The StatusBar is used to control the appearance of the mobile device's status bar when the app is running.
MantashaNoyela commented 2025-03-17 18:24:20 -07:00 (Migrated from github.com)
Review

I believe this issue is solved

I believe this issue is solved
return (
djwesty commented 2025-03-11 15:24:22 -07:00 (Migrated from github.com)
Review

I may be wrong, but it seems like the purpose of this component is to be a wrapper of sorts for stylistic purposes, to serve the global app layout.

If that is correct, consider that expos stack navigation system provides a purpose built and best practice system to do this universally, and reduce complexity by not needing wrapper components.

For example, our Apps <Stack> (as implemented in _layout.tsx) can take a screen options parameter called contentStyle. This is an object which can contain a backgroundColor. That would be the expo way to set the background color for our app, even dynamically. The <Stack> props are powerfull and can take all sorts of nested style options for the main app content, header, title, etc.

We can discuss this in sync to make sure we are all on the right path

I may be wrong, but it seems like the purpose of this component is to be a wrapper of sorts for stylistic purposes, to serve the global app layout. If that is correct, consider that [expos stack navigation](https://docs.expo.dev/router/advanced/stack/#configure-header-bar) system provides a purpose built and best practice system to do this universally, and reduce complexity by not needing wrapper components. For example, our Apps `<Stack>` (as implemented in `_layout.tsx`) can take a screen options parameter called `contentStyle`. This is an object which can contain a `backgroundColor`. That would be the expo way to set the background color for our app, even dynamically. The `<Stack>` props are powerfull and can take all sorts of nested style options for the main app content, header, title, etc. We can discuss this in sync to make sure we are all on the right path
djwesty commented 2025-03-11 15:25:24 -07:00 (Migrated from github.com)
Review

Do you know what the status bar is doing for the app?

Do you know what the status bar is doing for the app?
MantashaNoyela commented 2025-03-13 01:07:46 -07:00 (Migrated from github.com)
Review

The StatusBar is used to control the appearance of the mobile device's status bar when the app is running.

The StatusBar is used to control the appearance of the mobile device's status bar when the app is running.
MantashaNoyela commented 2025-03-17 18:24:20 -07:00 (Migrated from github.com)
Review

I believe this issue is solved

I believe this issue is solved
<SafeAreaView
djwesty commented 2025-03-11 15:24:22 -07:00 (Migrated from github.com)
Review

I may be wrong, but it seems like the purpose of this component is to be a wrapper of sorts for stylistic purposes, to serve the global app layout.

If that is correct, consider that expos stack navigation system provides a purpose built and best practice system to do this universally, and reduce complexity by not needing wrapper components.

For example, our Apps <Stack> (as implemented in _layout.tsx) can take a screen options parameter called contentStyle. This is an object which can contain a backgroundColor. That would be the expo way to set the background color for our app, even dynamically. The <Stack> props are powerfull and can take all sorts of nested style options for the main app content, header, title, etc.

We can discuss this in sync to make sure we are all on the right path

I may be wrong, but it seems like the purpose of this component is to be a wrapper of sorts for stylistic purposes, to serve the global app layout. If that is correct, consider that [expos stack navigation](https://docs.expo.dev/router/advanced/stack/#configure-header-bar) system provides a purpose built and best practice system to do this universally, and reduce complexity by not needing wrapper components. For example, our Apps `<Stack>` (as implemented in `_layout.tsx`) can take a screen options parameter called `contentStyle`. This is an object which can contain a `backgroundColor`. That would be the expo way to set the background color for our app, even dynamically. The `<Stack>` props are powerfull and can take all sorts of nested style options for the main app content, header, title, etc. We can discuss this in sync to make sure we are all on the right path
djwesty commented 2025-03-11 15:25:24 -07:00 (Migrated from github.com)
Review

Do you know what the status bar is doing for the app?

Do you know what the status bar is doing for the app?
MantashaNoyela commented 2025-03-13 01:07:46 -07:00 (Migrated from github.com)
Review

The StatusBar is used to control the appearance of the mobile device's status bar when the app is running.

The StatusBar is used to control the appearance of the mobile device's status bar when the app is running.
MantashaNoyela commented 2025-03-17 18:24:20 -07:00 (Migrated from github.com)
Review

I believe this issue is solved

I believe this issue is solved
style={[styles.safeArea, darkMode ? styles.lightGray : styles.light]}
djwesty commented 2025-03-11 15:24:22 -07:00 (Migrated from github.com)
Review

I may be wrong, but it seems like the purpose of this component is to be a wrapper of sorts for stylistic purposes, to serve the global app layout.

If that is correct, consider that expos stack navigation system provides a purpose built and best practice system to do this universally, and reduce complexity by not needing wrapper components.

For example, our Apps <Stack> (as implemented in _layout.tsx) can take a screen options parameter called contentStyle. This is an object which can contain a backgroundColor. That would be the expo way to set the background color for our app, even dynamically. The <Stack> props are powerfull and can take all sorts of nested style options for the main app content, header, title, etc.

We can discuss this in sync to make sure we are all on the right path

I may be wrong, but it seems like the purpose of this component is to be a wrapper of sorts for stylistic purposes, to serve the global app layout. If that is correct, consider that [expos stack navigation](https://docs.expo.dev/router/advanced/stack/#configure-header-bar) system provides a purpose built and best practice system to do this universally, and reduce complexity by not needing wrapper components. For example, our Apps `<Stack>` (as implemented in `_layout.tsx`) can take a screen options parameter called `contentStyle`. This is an object which can contain a `backgroundColor`. That would be the expo way to set the background color for our app, even dynamically. The `<Stack>` props are powerfull and can take all sorts of nested style options for the main app content, header, title, etc. We can discuss this in sync to make sure we are all on the right path
djwesty commented 2025-03-11 15:25:24 -07:00 (Migrated from github.com)
Review

Do you know what the status bar is doing for the app?

Do you know what the status bar is doing for the app?
MantashaNoyela commented 2025-03-13 01:07:46 -07:00 (Migrated from github.com)
Review

The StatusBar is used to control the appearance of the mobile device's status bar when the app is running.

The StatusBar is used to control the appearance of the mobile device's status bar when the app is running.
MantashaNoyela commented 2025-03-17 18:24:20 -07:00 (Migrated from github.com)
Review

I believe this issue is solved

I believe this issue is solved
>
djwesty commented 2025-03-11 15:24:22 -07:00 (Migrated from github.com)
Review

I may be wrong, but it seems like the purpose of this component is to be a wrapper of sorts for stylistic purposes, to serve the global app layout.

If that is correct, consider that expos stack navigation system provides a purpose built and best practice system to do this universally, and reduce complexity by not needing wrapper components.

For example, our Apps <Stack> (as implemented in _layout.tsx) can take a screen options parameter called contentStyle. This is an object which can contain a backgroundColor. That would be the expo way to set the background color for our app, even dynamically. The <Stack> props are powerfull and can take all sorts of nested style options for the main app content, header, title, etc.

We can discuss this in sync to make sure we are all on the right path

I may be wrong, but it seems like the purpose of this component is to be a wrapper of sorts for stylistic purposes, to serve the global app layout. If that is correct, consider that [expos stack navigation](https://docs.expo.dev/router/advanced/stack/#configure-header-bar) system provides a purpose built and best practice system to do this universally, and reduce complexity by not needing wrapper components. For example, our Apps `<Stack>` (as implemented in `_layout.tsx`) can take a screen options parameter called `contentStyle`. This is an object which can contain a `backgroundColor`. That would be the expo way to set the background color for our app, even dynamically. The `<Stack>` props are powerfull and can take all sorts of nested style options for the main app content, header, title, etc. We can discuss this in sync to make sure we are all on the right path
djwesty commented 2025-03-11 15:25:24 -07:00 (Migrated from github.com)
Review

Do you know what the status bar is doing for the app?

Do you know what the status bar is doing for the app?
MantashaNoyela commented 2025-03-13 01:07:46 -07:00 (Migrated from github.com)
Review

The StatusBar is used to control the appearance of the mobile device's status bar when the app is running.

The StatusBar is used to control the appearance of the mobile device's status bar when the app is running.
MantashaNoyela commented 2025-03-17 18:24:20 -07:00 (Migrated from github.com)
Review

I believe this issue is solved

I believe this issue is solved
<StatusBar barStyle={"dark-content"} />
djwesty commented 2025-03-11 15:24:22 -07:00 (Migrated from github.com)
Review

I may be wrong, but it seems like the purpose of this component is to be a wrapper of sorts for stylistic purposes, to serve the global app layout.

If that is correct, consider that expos stack navigation system provides a purpose built and best practice system to do this universally, and reduce complexity by not needing wrapper components.

For example, our Apps <Stack> (as implemented in _layout.tsx) can take a screen options parameter called contentStyle. This is an object which can contain a backgroundColor. That would be the expo way to set the background color for our app, even dynamically. The <Stack> props are powerfull and can take all sorts of nested style options for the main app content, header, title, etc.

We can discuss this in sync to make sure we are all on the right path

I may be wrong, but it seems like the purpose of this component is to be a wrapper of sorts for stylistic purposes, to serve the global app layout. If that is correct, consider that [expos stack navigation](https://docs.expo.dev/router/advanced/stack/#configure-header-bar) system provides a purpose built and best practice system to do this universally, and reduce complexity by not needing wrapper components. For example, our Apps `<Stack>` (as implemented in `_layout.tsx`) can take a screen options parameter called `contentStyle`. This is an object which can contain a `backgroundColor`. That would be the expo way to set the background color for our app, even dynamically. The `<Stack>` props are powerfull and can take all sorts of nested style options for the main app content, header, title, etc. We can discuss this in sync to make sure we are all on the right path
djwesty commented 2025-03-11 15:25:24 -07:00 (Migrated from github.com)
Review

Do you know what the status bar is doing for the app?

Do you know what the status bar is doing for the app?
MantashaNoyela commented 2025-03-13 01:07:46 -07:00 (Migrated from github.com)
Review

The StatusBar is used to control the appearance of the mobile device's status bar when the app is running.

The StatusBar is used to control the appearance of the mobile device's status bar when the app is running.
MantashaNoyela commented 2025-03-17 18:24:20 -07:00 (Migrated from github.com)
Review

I believe this issue is solved

I believe this issue is solved
<View style={[styles.container, { minHeight: screenHeight }]}>
djwesty commented 2025-03-11 15:24:22 -07:00 (Migrated from github.com)
Review

I may be wrong, but it seems like the purpose of this component is to be a wrapper of sorts for stylistic purposes, to serve the global app layout.

If that is correct, consider that expos stack navigation system provides a purpose built and best practice system to do this universally, and reduce complexity by not needing wrapper components.

For example, our Apps <Stack> (as implemented in _layout.tsx) can take a screen options parameter called contentStyle. This is an object which can contain a backgroundColor. That would be the expo way to set the background color for our app, even dynamically. The <Stack> props are powerfull and can take all sorts of nested style options for the main app content, header, title, etc.

We can discuss this in sync to make sure we are all on the right path

I may be wrong, but it seems like the purpose of this component is to be a wrapper of sorts for stylistic purposes, to serve the global app layout. If that is correct, consider that [expos stack navigation](https://docs.expo.dev/router/advanced/stack/#configure-header-bar) system provides a purpose built and best practice system to do this universally, and reduce complexity by not needing wrapper components. For example, our Apps `<Stack>` (as implemented in `_layout.tsx`) can take a screen options parameter called `contentStyle`. This is an object which can contain a `backgroundColor`. That would be the expo way to set the background color for our app, even dynamically. The `<Stack>` props are powerfull and can take all sorts of nested style options for the main app content, header, title, etc. We can discuss this in sync to make sure we are all on the right path
djwesty commented 2025-03-11 15:25:24 -07:00 (Migrated from github.com)
Review

Do you know what the status bar is doing for the app?

Do you know what the status bar is doing for the app?
MantashaNoyela commented 2025-03-13 01:07:46 -07:00 (Migrated from github.com)
Review

The StatusBar is used to control the appearance of the mobile device's status bar when the app is running.

The StatusBar is used to control the appearance of the mobile device's status bar when the app is running.
MantashaNoyela commented 2025-03-17 18:24:20 -07:00 (Migrated from github.com)
Review

I believe this issue is solved

I believe this issue is solved
{children}
djwesty commented 2025-03-11 15:24:22 -07:00 (Migrated from github.com)
Review

I may be wrong, but it seems like the purpose of this component is to be a wrapper of sorts for stylistic purposes, to serve the global app layout.

If that is correct, consider that expos stack navigation system provides a purpose built and best practice system to do this universally, and reduce complexity by not needing wrapper components.

For example, our Apps <Stack> (as implemented in _layout.tsx) can take a screen options parameter called contentStyle. This is an object which can contain a backgroundColor. That would be the expo way to set the background color for our app, even dynamically. The <Stack> props are powerfull and can take all sorts of nested style options for the main app content, header, title, etc.

We can discuss this in sync to make sure we are all on the right path

I may be wrong, but it seems like the purpose of this component is to be a wrapper of sorts for stylistic purposes, to serve the global app layout. If that is correct, consider that [expos stack navigation](https://docs.expo.dev/router/advanced/stack/#configure-header-bar) system provides a purpose built and best practice system to do this universally, and reduce complexity by not needing wrapper components. For example, our Apps `<Stack>` (as implemented in `_layout.tsx`) can take a screen options parameter called `contentStyle`. This is an object which can contain a `backgroundColor`. That would be the expo way to set the background color for our app, even dynamically. The `<Stack>` props are powerfull and can take all sorts of nested style options for the main app content, header, title, etc. We can discuss this in sync to make sure we are all on the right path
djwesty commented 2025-03-11 15:25:24 -07:00 (Migrated from github.com)
Review

Do you know what the status bar is doing for the app?

Do you know what the status bar is doing for the app?
MantashaNoyela commented 2025-03-13 01:07:46 -07:00 (Migrated from github.com)
Review

The StatusBar is used to control the appearance of the mobile device's status bar when the app is running.

The StatusBar is used to control the appearance of the mobile device's status bar when the app is running.
MantashaNoyela commented 2025-03-17 18:24:20 -07:00 (Migrated from github.com)
Review

I believe this issue is solved

I believe this issue is solved
</View>
djwesty commented 2025-03-11 15:24:22 -07:00 (Migrated from github.com)
Review

I may be wrong, but it seems like the purpose of this component is to be a wrapper of sorts for stylistic purposes, to serve the global app layout.

If that is correct, consider that expos stack navigation system provides a purpose built and best practice system to do this universally, and reduce complexity by not needing wrapper components.

For example, our Apps <Stack> (as implemented in _layout.tsx) can take a screen options parameter called contentStyle. This is an object which can contain a backgroundColor. That would be the expo way to set the background color for our app, even dynamically. The <Stack> props are powerfull and can take all sorts of nested style options for the main app content, header, title, etc.

We can discuss this in sync to make sure we are all on the right path

I may be wrong, but it seems like the purpose of this component is to be a wrapper of sorts for stylistic purposes, to serve the global app layout. If that is correct, consider that [expos stack navigation](https://docs.expo.dev/router/advanced/stack/#configure-header-bar) system provides a purpose built and best practice system to do this universally, and reduce complexity by not needing wrapper components. For example, our Apps `<Stack>` (as implemented in `_layout.tsx`) can take a screen options parameter called `contentStyle`. This is an object which can contain a `backgroundColor`. That would be the expo way to set the background color for our app, even dynamically. The `<Stack>` props are powerfull and can take all sorts of nested style options for the main app content, header, title, etc. We can discuss this in sync to make sure we are all on the right path
djwesty commented 2025-03-11 15:25:24 -07:00 (Migrated from github.com)
Review

Do you know what the status bar is doing for the app?

Do you know what the status bar is doing for the app?
MantashaNoyela commented 2025-03-13 01:07:46 -07:00 (Migrated from github.com)
Review

The StatusBar is used to control the appearance of the mobile device's status bar when the app is running.

The StatusBar is used to control the appearance of the mobile device's status bar when the app is running.
MantashaNoyela commented 2025-03-17 18:24:20 -07:00 (Migrated from github.com)
Review

I believe this issue is solved

I believe this issue is solved
</SafeAreaView>
djwesty commented 2025-03-11 15:24:22 -07:00 (Migrated from github.com)
Review

I may be wrong, but it seems like the purpose of this component is to be a wrapper of sorts for stylistic purposes, to serve the global app layout.

If that is correct, consider that expos stack navigation system provides a purpose built and best practice system to do this universally, and reduce complexity by not needing wrapper components.

For example, our Apps <Stack> (as implemented in _layout.tsx) can take a screen options parameter called contentStyle. This is an object which can contain a backgroundColor. That would be the expo way to set the background color for our app, even dynamically. The <Stack> props are powerfull and can take all sorts of nested style options for the main app content, header, title, etc.

We can discuss this in sync to make sure we are all on the right path

I may be wrong, but it seems like the purpose of this component is to be a wrapper of sorts for stylistic purposes, to serve the global app layout. If that is correct, consider that [expos stack navigation](https://docs.expo.dev/router/advanced/stack/#configure-header-bar) system provides a purpose built and best practice system to do this universally, and reduce complexity by not needing wrapper components. For example, our Apps `<Stack>` (as implemented in `_layout.tsx`) can take a screen options parameter called `contentStyle`. This is an object which can contain a `backgroundColor`. That would be the expo way to set the background color for our app, even dynamically. The `<Stack>` props are powerfull and can take all sorts of nested style options for the main app content, header, title, etc. We can discuss this in sync to make sure we are all on the right path
djwesty commented 2025-03-11 15:25:24 -07:00 (Migrated from github.com)
Review

Do you know what the status bar is doing for the app?

Do you know what the status bar is doing for the app?
MantashaNoyela commented 2025-03-13 01:07:46 -07:00 (Migrated from github.com)
Review

The StatusBar is used to control the appearance of the mobile device's status bar when the app is running.

The StatusBar is used to control the appearance of the mobile device's status bar when the app is running.
MantashaNoyela commented 2025-03-17 18:24:20 -07:00 (Migrated from github.com)
Review

I believe this issue is solved

I believe this issue is solved
);
djwesty commented 2025-03-11 15:24:22 -07:00 (Migrated from github.com)
Review

I may be wrong, but it seems like the purpose of this component is to be a wrapper of sorts for stylistic purposes, to serve the global app layout.

If that is correct, consider that expos stack navigation system provides a purpose built and best practice system to do this universally, and reduce complexity by not needing wrapper components.

For example, our Apps <Stack> (as implemented in _layout.tsx) can take a screen options parameter called contentStyle. This is an object which can contain a backgroundColor. That would be the expo way to set the background color for our app, even dynamically. The <Stack> props are powerfull and can take all sorts of nested style options for the main app content, header, title, etc.

We can discuss this in sync to make sure we are all on the right path

I may be wrong, but it seems like the purpose of this component is to be a wrapper of sorts for stylistic purposes, to serve the global app layout. If that is correct, consider that [expos stack navigation](https://docs.expo.dev/router/advanced/stack/#configure-header-bar) system provides a purpose built and best practice system to do this universally, and reduce complexity by not needing wrapper components. For example, our Apps `<Stack>` (as implemented in `_layout.tsx`) can take a screen options parameter called `contentStyle`. This is an object which can contain a `backgroundColor`. That would be the expo way to set the background color for our app, even dynamically. The `<Stack>` props are powerfull and can take all sorts of nested style options for the main app content, header, title, etc. We can discuss this in sync to make sure we are all on the right path
djwesty commented 2025-03-11 15:25:24 -07:00 (Migrated from github.com)
Review

Do you know what the status bar is doing for the app?

Do you know what the status bar is doing for the app?
MantashaNoyela commented 2025-03-13 01:07:46 -07:00 (Migrated from github.com)
Review

The StatusBar is used to control the appearance of the mobile device's status bar when the app is running.

The StatusBar is used to control the appearance of the mobile device's status bar when the app is running.
MantashaNoyela commented 2025-03-17 18:24:20 -07:00 (Migrated from github.com)
Review

I believe this issue is solved

I believe this issue is solved
};
djwesty commented 2025-03-11 15:24:22 -07:00 (Migrated from github.com)
Review

I may be wrong, but it seems like the purpose of this component is to be a wrapper of sorts for stylistic purposes, to serve the global app layout.

If that is correct, consider that expos stack navigation system provides a purpose built and best practice system to do this universally, and reduce complexity by not needing wrapper components.

For example, our Apps <Stack> (as implemented in _layout.tsx) can take a screen options parameter called contentStyle. This is an object which can contain a backgroundColor. That would be the expo way to set the background color for our app, even dynamically. The <Stack> props are powerfull and can take all sorts of nested style options for the main app content, header, title, etc.

We can discuss this in sync to make sure we are all on the right path

I may be wrong, but it seems like the purpose of this component is to be a wrapper of sorts for stylistic purposes, to serve the global app layout. If that is correct, consider that [expos stack navigation](https://docs.expo.dev/router/advanced/stack/#configure-header-bar) system provides a purpose built and best practice system to do this universally, and reduce complexity by not needing wrapper components. For example, our Apps `<Stack>` (as implemented in `_layout.tsx`) can take a screen options parameter called `contentStyle`. This is an object which can contain a `backgroundColor`. That would be the expo way to set the background color for our app, even dynamically. The `<Stack>` props are powerfull and can take all sorts of nested style options for the main app content, header, title, etc. We can discuss this in sync to make sure we are all on the right path
djwesty commented 2025-03-11 15:25:24 -07:00 (Migrated from github.com)
Review

Do you know what the status bar is doing for the app?

Do you know what the status bar is doing for the app?
MantashaNoyela commented 2025-03-13 01:07:46 -07:00 (Migrated from github.com)
Review

The StatusBar is used to control the appearance of the mobile device's status bar when the app is running.

The StatusBar is used to control the appearance of the mobile device's status bar when the app is running.
MantashaNoyela commented 2025-03-17 18:24:20 -07:00 (Migrated from github.com)
Review

I believe this issue is solved

I believe this issue is solved
djwesty commented 2025-03-11 15:24:22 -07:00 (Migrated from github.com)
Review

I may be wrong, but it seems like the purpose of this component is to be a wrapper of sorts for stylistic purposes, to serve the global app layout.

If that is correct, consider that expos stack navigation system provides a purpose built and best practice system to do this universally, and reduce complexity by not needing wrapper components.

For example, our Apps <Stack> (as implemented in _layout.tsx) can take a screen options parameter called contentStyle. This is an object which can contain a backgroundColor. That would be the expo way to set the background color for our app, even dynamically. The <Stack> props are powerfull and can take all sorts of nested style options for the main app content, header, title, etc.

We can discuss this in sync to make sure we are all on the right path

I may be wrong, but it seems like the purpose of this component is to be a wrapper of sorts for stylistic purposes, to serve the global app layout. If that is correct, consider that [expos stack navigation](https://docs.expo.dev/router/advanced/stack/#configure-header-bar) system provides a purpose built and best practice system to do this universally, and reduce complexity by not needing wrapper components. For example, our Apps `<Stack>` (as implemented in `_layout.tsx`) can take a screen options parameter called `contentStyle`. This is an object which can contain a `backgroundColor`. That would be the expo way to set the background color for our app, even dynamically. The `<Stack>` props are powerfull and can take all sorts of nested style options for the main app content, header, title, etc. We can discuss this in sync to make sure we are all on the right path
djwesty commented 2025-03-11 15:25:24 -07:00 (Migrated from github.com)
Review

Do you know what the status bar is doing for the app?

Do you know what the status bar is doing for the app?
MantashaNoyela commented 2025-03-13 01:07:46 -07:00 (Migrated from github.com)
Review

The StatusBar is used to control the appearance of the mobile device's status bar when the app is running.

The StatusBar is used to control the appearance of the mobile device's status bar when the app is running.
MantashaNoyela commented 2025-03-17 18:24:20 -07:00 (Migrated from github.com)
Review

I believe this issue is solved

I believe this issue is solved
const styles = StyleSheet.create({
djwesty commented 2025-03-11 15:24:22 -07:00 (Migrated from github.com)
Review

I may be wrong, but it seems like the purpose of this component is to be a wrapper of sorts for stylistic purposes, to serve the global app layout.

If that is correct, consider that expos stack navigation system provides a purpose built and best practice system to do this universally, and reduce complexity by not needing wrapper components.

For example, our Apps <Stack> (as implemented in _layout.tsx) can take a screen options parameter called contentStyle. This is an object which can contain a backgroundColor. That would be the expo way to set the background color for our app, even dynamically. The <Stack> props are powerfull and can take all sorts of nested style options for the main app content, header, title, etc.

We can discuss this in sync to make sure we are all on the right path

I may be wrong, but it seems like the purpose of this component is to be a wrapper of sorts for stylistic purposes, to serve the global app layout. If that is correct, consider that [expos stack navigation](https://docs.expo.dev/router/advanced/stack/#configure-header-bar) system provides a purpose built and best practice system to do this universally, and reduce complexity by not needing wrapper components. For example, our Apps `<Stack>` (as implemented in `_layout.tsx`) can take a screen options parameter called `contentStyle`. This is an object which can contain a `backgroundColor`. That would be the expo way to set the background color for our app, even dynamically. The `<Stack>` props are powerfull and can take all sorts of nested style options for the main app content, header, title, etc. We can discuss this in sync to make sure we are all on the right path
djwesty commented 2025-03-11 15:25:24 -07:00 (Migrated from github.com)
Review

Do you know what the status bar is doing for the app?

Do you know what the status bar is doing for the app?
MantashaNoyela commented 2025-03-13 01:07:46 -07:00 (Migrated from github.com)
Review

The StatusBar is used to control the appearance of the mobile device's status bar when the app is running.

The StatusBar is used to control the appearance of the mobile device's status bar when the app is running.
MantashaNoyela commented 2025-03-17 18:24:20 -07:00 (Migrated from github.com)
Review

I believe this issue is solved

I believe this issue is solved
safeArea: {
djwesty commented 2025-03-11 15:24:22 -07:00 (Migrated from github.com)
Review

I may be wrong, but it seems like the purpose of this component is to be a wrapper of sorts for stylistic purposes, to serve the global app layout.

If that is correct, consider that expos stack navigation system provides a purpose built and best practice system to do this universally, and reduce complexity by not needing wrapper components.

For example, our Apps <Stack> (as implemented in _layout.tsx) can take a screen options parameter called contentStyle. This is an object which can contain a backgroundColor. That would be the expo way to set the background color for our app, even dynamically. The <Stack> props are powerfull and can take all sorts of nested style options for the main app content, header, title, etc.

We can discuss this in sync to make sure we are all on the right path

I may be wrong, but it seems like the purpose of this component is to be a wrapper of sorts for stylistic purposes, to serve the global app layout. If that is correct, consider that [expos stack navigation](https://docs.expo.dev/router/advanced/stack/#configure-header-bar) system provides a purpose built and best practice system to do this universally, and reduce complexity by not needing wrapper components. For example, our Apps `<Stack>` (as implemented in `_layout.tsx`) can take a screen options parameter called `contentStyle`. This is an object which can contain a `backgroundColor`. That would be the expo way to set the background color for our app, even dynamically. The `<Stack>` props are powerfull and can take all sorts of nested style options for the main app content, header, title, etc. We can discuss this in sync to make sure we are all on the right path
djwesty commented 2025-03-11 15:25:24 -07:00 (Migrated from github.com)
Review

Do you know what the status bar is doing for the app?

Do you know what the status bar is doing for the app?
MantashaNoyela commented 2025-03-13 01:07:46 -07:00 (Migrated from github.com)
Review

The StatusBar is used to control the appearance of the mobile device's status bar when the app is running.

The StatusBar is used to control the appearance of the mobile device's status bar when the app is running.
MantashaNoyela commented 2025-03-17 18:24:20 -07:00 (Migrated from github.com)
Review

I believe this issue is solved

I believe this issue is solved
flex: 1,
djwesty commented 2025-03-11 15:24:22 -07:00 (Migrated from github.com)
Review

I may be wrong, but it seems like the purpose of this component is to be a wrapper of sorts for stylistic purposes, to serve the global app layout.

If that is correct, consider that expos stack navigation system provides a purpose built and best practice system to do this universally, and reduce complexity by not needing wrapper components.

For example, our Apps <Stack> (as implemented in _layout.tsx) can take a screen options parameter called contentStyle. This is an object which can contain a backgroundColor. That would be the expo way to set the background color for our app, even dynamically. The <Stack> props are powerfull and can take all sorts of nested style options for the main app content, header, title, etc.

We can discuss this in sync to make sure we are all on the right path

I may be wrong, but it seems like the purpose of this component is to be a wrapper of sorts for stylistic purposes, to serve the global app layout. If that is correct, consider that [expos stack navigation](https://docs.expo.dev/router/advanced/stack/#configure-header-bar) system provides a purpose built and best practice system to do this universally, and reduce complexity by not needing wrapper components. For example, our Apps `<Stack>` (as implemented in `_layout.tsx`) can take a screen options parameter called `contentStyle`. This is an object which can contain a `backgroundColor`. That would be the expo way to set the background color for our app, even dynamically. The `<Stack>` props are powerfull and can take all sorts of nested style options for the main app content, header, title, etc. We can discuss this in sync to make sure we are all on the right path
djwesty commented 2025-03-11 15:25:24 -07:00 (Migrated from github.com)
Review

Do you know what the status bar is doing for the app?

Do you know what the status bar is doing for the app?
MantashaNoyela commented 2025-03-13 01:07:46 -07:00 (Migrated from github.com)
Review

The StatusBar is used to control the appearance of the mobile device's status bar when the app is running.

The StatusBar is used to control the appearance of the mobile device's status bar when the app is running.
MantashaNoyela commented 2025-03-17 18:24:20 -07:00 (Migrated from github.com)
Review

I believe this issue is solved

I believe this issue is solved
},
djwesty commented 2025-03-11 15:24:22 -07:00 (Migrated from github.com)
Review

I may be wrong, but it seems like the purpose of this component is to be a wrapper of sorts for stylistic purposes, to serve the global app layout.

If that is correct, consider that expos stack navigation system provides a purpose built and best practice system to do this universally, and reduce complexity by not needing wrapper components.

For example, our Apps <Stack> (as implemented in _layout.tsx) can take a screen options parameter called contentStyle. This is an object which can contain a backgroundColor. That would be the expo way to set the background color for our app, even dynamically. The <Stack> props are powerfull and can take all sorts of nested style options for the main app content, header, title, etc.

We can discuss this in sync to make sure we are all on the right path

I may be wrong, but it seems like the purpose of this component is to be a wrapper of sorts for stylistic purposes, to serve the global app layout. If that is correct, consider that [expos stack navigation](https://docs.expo.dev/router/advanced/stack/#configure-header-bar) system provides a purpose built and best practice system to do this universally, and reduce complexity by not needing wrapper components. For example, our Apps `<Stack>` (as implemented in `_layout.tsx`) can take a screen options parameter called `contentStyle`. This is an object which can contain a `backgroundColor`. That would be the expo way to set the background color for our app, even dynamically. The `<Stack>` props are powerfull and can take all sorts of nested style options for the main app content, header, title, etc. We can discuss this in sync to make sure we are all on the right path
djwesty commented 2025-03-11 15:25:24 -07:00 (Migrated from github.com)
Review

Do you know what the status bar is doing for the app?

Do you know what the status bar is doing for the app?
MantashaNoyela commented 2025-03-13 01:07:46 -07:00 (Migrated from github.com)
Review

The StatusBar is used to control the appearance of the mobile device's status bar when the app is running.

The StatusBar is used to control the appearance of the mobile device's status bar when the app is running.
MantashaNoyela commented 2025-03-17 18:24:20 -07:00 (Migrated from github.com)
Review

I believe this issue is solved

I believe this issue is solved
container: {
djwesty commented 2025-03-11 15:24:22 -07:00 (Migrated from github.com)
Review

I may be wrong, but it seems like the purpose of this component is to be a wrapper of sorts for stylistic purposes, to serve the global app layout.

If that is correct, consider that expos stack navigation system provides a purpose built and best practice system to do this universally, and reduce complexity by not needing wrapper components.

For example, our Apps <Stack> (as implemented in _layout.tsx) can take a screen options parameter called contentStyle. This is an object which can contain a backgroundColor. That would be the expo way to set the background color for our app, even dynamically. The <Stack> props are powerfull and can take all sorts of nested style options for the main app content, header, title, etc.

We can discuss this in sync to make sure we are all on the right path

I may be wrong, but it seems like the purpose of this component is to be a wrapper of sorts for stylistic purposes, to serve the global app layout. If that is correct, consider that [expos stack navigation](https://docs.expo.dev/router/advanced/stack/#configure-header-bar) system provides a purpose built and best practice system to do this universally, and reduce complexity by not needing wrapper components. For example, our Apps `<Stack>` (as implemented in `_layout.tsx`) can take a screen options parameter called `contentStyle`. This is an object which can contain a `backgroundColor`. That would be the expo way to set the background color for our app, even dynamically. The `<Stack>` props are powerfull and can take all sorts of nested style options for the main app content, header, title, etc. We can discuss this in sync to make sure we are all on the right path
djwesty commented 2025-03-11 15:25:24 -07:00 (Migrated from github.com)
Review

Do you know what the status bar is doing for the app?

Do you know what the status bar is doing for the app?
MantashaNoyela commented 2025-03-13 01:07:46 -07:00 (Migrated from github.com)
Review

The StatusBar is used to control the appearance of the mobile device's status bar when the app is running.

The StatusBar is used to control the appearance of the mobile device's status bar when the app is running.
MantashaNoyela commented 2025-03-17 18:24:20 -07:00 (Migrated from github.com)
Review

I believe this issue is solved

I believe this issue is solved
flex: 1,
djwesty commented 2025-03-11 15:24:22 -07:00 (Migrated from github.com)
Review

I may be wrong, but it seems like the purpose of this component is to be a wrapper of sorts for stylistic purposes, to serve the global app layout.

If that is correct, consider that expos stack navigation system provides a purpose built and best practice system to do this universally, and reduce complexity by not needing wrapper components.

For example, our Apps <Stack> (as implemented in _layout.tsx) can take a screen options parameter called contentStyle. This is an object which can contain a backgroundColor. That would be the expo way to set the background color for our app, even dynamically. The <Stack> props are powerfull and can take all sorts of nested style options for the main app content, header, title, etc.

We can discuss this in sync to make sure we are all on the right path

I may be wrong, but it seems like the purpose of this component is to be a wrapper of sorts for stylistic purposes, to serve the global app layout. If that is correct, consider that [expos stack navigation](https://docs.expo.dev/router/advanced/stack/#configure-header-bar) system provides a purpose built and best practice system to do this universally, and reduce complexity by not needing wrapper components. For example, our Apps `<Stack>` (as implemented in `_layout.tsx`) can take a screen options parameter called `contentStyle`. This is an object which can contain a `backgroundColor`. That would be the expo way to set the background color for our app, even dynamically. The `<Stack>` props are powerfull and can take all sorts of nested style options for the main app content, header, title, etc. We can discuss this in sync to make sure we are all on the right path
djwesty commented 2025-03-11 15:25:24 -07:00 (Migrated from github.com)
Review

Do you know what the status bar is doing for the app?

Do you know what the status bar is doing for the app?
MantashaNoyela commented 2025-03-13 01:07:46 -07:00 (Migrated from github.com)
Review

The StatusBar is used to control the appearance of the mobile device's status bar when the app is running.

The StatusBar is used to control the appearance of the mobile device's status bar when the app is running.
MantashaNoyela commented 2025-03-17 18:24:20 -07:00 (Migrated from github.com)
Review

I believe this issue is solved

I believe this issue is solved
width: "100%",
djwesty commented 2025-03-11 15:24:22 -07:00 (Migrated from github.com)
Review

I may be wrong, but it seems like the purpose of this component is to be a wrapper of sorts for stylistic purposes, to serve the global app layout.

If that is correct, consider that expos stack navigation system provides a purpose built and best practice system to do this universally, and reduce complexity by not needing wrapper components.

For example, our Apps <Stack> (as implemented in _layout.tsx) can take a screen options parameter called contentStyle. This is an object which can contain a backgroundColor. That would be the expo way to set the background color for our app, even dynamically. The <Stack> props are powerfull and can take all sorts of nested style options for the main app content, header, title, etc.

We can discuss this in sync to make sure we are all on the right path

I may be wrong, but it seems like the purpose of this component is to be a wrapper of sorts for stylistic purposes, to serve the global app layout. If that is correct, consider that [expos stack navigation](https://docs.expo.dev/router/advanced/stack/#configure-header-bar) system provides a purpose built and best practice system to do this universally, and reduce complexity by not needing wrapper components. For example, our Apps `<Stack>` (as implemented in `_layout.tsx`) can take a screen options parameter called `contentStyle`. This is an object which can contain a `backgroundColor`. That would be the expo way to set the background color for our app, even dynamically. The `<Stack>` props are powerfull and can take all sorts of nested style options for the main app content, header, title, etc. We can discuss this in sync to make sure we are all on the right path
djwesty commented 2025-03-11 15:25:24 -07:00 (Migrated from github.com)
Review

Do you know what the status bar is doing for the app?

Do you know what the status bar is doing for the app?
MantashaNoyela commented 2025-03-13 01:07:46 -07:00 (Migrated from github.com)
Review

The StatusBar is used to control the appearance of the mobile device's status bar when the app is running.

The StatusBar is used to control the appearance of the mobile device's status bar when the app is running.
MantashaNoyela commented 2025-03-17 18:24:20 -07:00 (Migrated from github.com)
Review

I believe this issue is solved

I believe this issue is solved
padding: 16,
djwesty commented 2025-03-11 15:24:22 -07:00 (Migrated from github.com)
Review

I may be wrong, but it seems like the purpose of this component is to be a wrapper of sorts for stylistic purposes, to serve the global app layout.

If that is correct, consider that expos stack navigation system provides a purpose built and best practice system to do this universally, and reduce complexity by not needing wrapper components.

For example, our Apps <Stack> (as implemented in _layout.tsx) can take a screen options parameter called contentStyle. This is an object which can contain a backgroundColor. That would be the expo way to set the background color for our app, even dynamically. The <Stack> props are powerfull and can take all sorts of nested style options for the main app content, header, title, etc.

We can discuss this in sync to make sure we are all on the right path

I may be wrong, but it seems like the purpose of this component is to be a wrapper of sorts for stylistic purposes, to serve the global app layout. If that is correct, consider that [expos stack navigation](https://docs.expo.dev/router/advanced/stack/#configure-header-bar) system provides a purpose built and best practice system to do this universally, and reduce complexity by not needing wrapper components. For example, our Apps `<Stack>` (as implemented in `_layout.tsx`) can take a screen options parameter called `contentStyle`. This is an object which can contain a `backgroundColor`. That would be the expo way to set the background color for our app, even dynamically. The `<Stack>` props are powerfull and can take all sorts of nested style options for the main app content, header, title, etc. We can discuss this in sync to make sure we are all on the right path
djwesty commented 2025-03-11 15:25:24 -07:00 (Migrated from github.com)
Review

Do you know what the status bar is doing for the app?

Do you know what the status bar is doing for the app?
MantashaNoyela commented 2025-03-13 01:07:46 -07:00 (Migrated from github.com)
Review

The StatusBar is used to control the appearance of the mobile device's status bar when the app is running.

The StatusBar is used to control the appearance of the mobile device's status bar when the app is running.
MantashaNoyela commented 2025-03-17 18:24:20 -07:00 (Migrated from github.com)
Review

I believe this issue is solved

I believe this issue is solved
justifyContent: "flex-start",
djwesty commented 2025-03-11 15:24:22 -07:00 (Migrated from github.com)
Review

I may be wrong, but it seems like the purpose of this component is to be a wrapper of sorts for stylistic purposes, to serve the global app layout.

If that is correct, consider that expos stack navigation system provides a purpose built and best practice system to do this universally, and reduce complexity by not needing wrapper components.

For example, our Apps <Stack> (as implemented in _layout.tsx) can take a screen options parameter called contentStyle. This is an object which can contain a backgroundColor. That would be the expo way to set the background color for our app, even dynamically. The <Stack> props are powerfull and can take all sorts of nested style options for the main app content, header, title, etc.

We can discuss this in sync to make sure we are all on the right path

I may be wrong, but it seems like the purpose of this component is to be a wrapper of sorts for stylistic purposes, to serve the global app layout. If that is correct, consider that [expos stack navigation](https://docs.expo.dev/router/advanced/stack/#configure-header-bar) system provides a purpose built and best practice system to do this universally, and reduce complexity by not needing wrapper components. For example, our Apps `<Stack>` (as implemented in `_layout.tsx`) can take a screen options parameter called `contentStyle`. This is an object which can contain a `backgroundColor`. That would be the expo way to set the background color for our app, even dynamically. The `<Stack>` props are powerfull and can take all sorts of nested style options for the main app content, header, title, etc. We can discuss this in sync to make sure we are all on the right path
djwesty commented 2025-03-11 15:25:24 -07:00 (Migrated from github.com)
Review

Do you know what the status bar is doing for the app?

Do you know what the status bar is doing for the app?
MantashaNoyela commented 2025-03-13 01:07:46 -07:00 (Migrated from github.com)
Review

The StatusBar is used to control the appearance of the mobile device's status bar when the app is running.

The StatusBar is used to control the appearance of the mobile device's status bar when the app is running.
MantashaNoyela commented 2025-03-17 18:24:20 -07:00 (Migrated from github.com)
Review

I believe this issue is solved

I believe this issue is solved
alignItems: "center",
djwesty commented 2025-03-11 15:24:22 -07:00 (Migrated from github.com)
Review

I may be wrong, but it seems like the purpose of this component is to be a wrapper of sorts for stylistic purposes, to serve the global app layout.

If that is correct, consider that expos stack navigation system provides a purpose built and best practice system to do this universally, and reduce complexity by not needing wrapper components.

For example, our Apps <Stack> (as implemented in _layout.tsx) can take a screen options parameter called contentStyle. This is an object which can contain a backgroundColor. That would be the expo way to set the background color for our app, even dynamically. The <Stack> props are powerfull and can take all sorts of nested style options for the main app content, header, title, etc.

We can discuss this in sync to make sure we are all on the right path

I may be wrong, but it seems like the purpose of this component is to be a wrapper of sorts for stylistic purposes, to serve the global app layout. If that is correct, consider that [expos stack navigation](https://docs.expo.dev/router/advanced/stack/#configure-header-bar) system provides a purpose built and best practice system to do this universally, and reduce complexity by not needing wrapper components. For example, our Apps `<Stack>` (as implemented in `_layout.tsx`) can take a screen options parameter called `contentStyle`. This is an object which can contain a `backgroundColor`. That would be the expo way to set the background color for our app, even dynamically. The `<Stack>` props are powerfull and can take all sorts of nested style options for the main app content, header, title, etc. We can discuss this in sync to make sure we are all on the right path
djwesty commented 2025-03-11 15:25:24 -07:00 (Migrated from github.com)
Review

Do you know what the status bar is doing for the app?

Do you know what the status bar is doing for the app?
MantashaNoyela commented 2025-03-13 01:07:46 -07:00 (Migrated from github.com)
Review

The StatusBar is used to control the appearance of the mobile device's status bar when the app is running.

The StatusBar is used to control the appearance of the mobile device's status bar when the app is running.
MantashaNoyela commented 2025-03-17 18:24:20 -07:00 (Migrated from github.com)
Review

I believe this issue is solved

I believe this issue is solved
},
djwesty commented 2025-03-11 15:24:22 -07:00 (Migrated from github.com)
Review

I may be wrong, but it seems like the purpose of this component is to be a wrapper of sorts for stylistic purposes, to serve the global app layout.

If that is correct, consider that expos stack navigation system provides a purpose built and best practice system to do this universally, and reduce complexity by not needing wrapper components.

For example, our Apps <Stack> (as implemented in _layout.tsx) can take a screen options parameter called contentStyle. This is an object which can contain a backgroundColor. That would be the expo way to set the background color for our app, even dynamically. The <Stack> props are powerfull and can take all sorts of nested style options for the main app content, header, title, etc.

We can discuss this in sync to make sure we are all on the right path

I may be wrong, but it seems like the purpose of this component is to be a wrapper of sorts for stylistic purposes, to serve the global app layout. If that is correct, consider that [expos stack navigation](https://docs.expo.dev/router/advanced/stack/#configure-header-bar) system provides a purpose built and best practice system to do this universally, and reduce complexity by not needing wrapper components. For example, our Apps `<Stack>` (as implemented in `_layout.tsx`) can take a screen options parameter called `contentStyle`. This is an object which can contain a `backgroundColor`. That would be the expo way to set the background color for our app, even dynamically. The `<Stack>` props are powerfull and can take all sorts of nested style options for the main app content, header, title, etc. We can discuss this in sync to make sure we are all on the right path
djwesty commented 2025-03-11 15:25:24 -07:00 (Migrated from github.com)
Review

Do you know what the status bar is doing for the app?

Do you know what the status bar is doing for the app?
MantashaNoyela commented 2025-03-13 01:07:46 -07:00 (Migrated from github.com)
Review

The StatusBar is used to control the appearance of the mobile device's status bar when the app is running.

The StatusBar is used to control the appearance of the mobile device's status bar when the app is running.
MantashaNoyela commented 2025-03-17 18:24:20 -07:00 (Migrated from github.com)
Review

I believe this issue is solved

I believe this issue is solved
light: {
djwesty commented 2025-03-11 15:24:22 -07:00 (Migrated from github.com)
Review

I may be wrong, but it seems like the purpose of this component is to be a wrapper of sorts for stylistic purposes, to serve the global app layout.

If that is correct, consider that expos stack navigation system provides a purpose built and best practice system to do this universally, and reduce complexity by not needing wrapper components.

For example, our Apps <Stack> (as implemented in _layout.tsx) can take a screen options parameter called contentStyle. This is an object which can contain a backgroundColor. That would be the expo way to set the background color for our app, even dynamically. The <Stack> props are powerfull and can take all sorts of nested style options for the main app content, header, title, etc.

We can discuss this in sync to make sure we are all on the right path

I may be wrong, but it seems like the purpose of this component is to be a wrapper of sorts for stylistic purposes, to serve the global app layout. If that is correct, consider that [expos stack navigation](https://docs.expo.dev/router/advanced/stack/#configure-header-bar) system provides a purpose built and best practice system to do this universally, and reduce complexity by not needing wrapper components. For example, our Apps `<Stack>` (as implemented in `_layout.tsx`) can take a screen options parameter called `contentStyle`. This is an object which can contain a `backgroundColor`. That would be the expo way to set the background color for our app, even dynamically. The `<Stack>` props are powerfull and can take all sorts of nested style options for the main app content, header, title, etc. We can discuss this in sync to make sure we are all on the right path
djwesty commented 2025-03-11 15:25:24 -07:00 (Migrated from github.com)
Review

Do you know what the status bar is doing for the app?

Do you know what the status bar is doing for the app?
MantashaNoyela commented 2025-03-13 01:07:46 -07:00 (Migrated from github.com)
Review

The StatusBar is used to control the appearance of the mobile device's status bar when the app is running.

The StatusBar is used to control the appearance of the mobile device's status bar when the app is running.
MantashaNoyela commented 2025-03-17 18:24:20 -07:00 (Migrated from github.com)
Review

I believe this issue is solved

I believe this issue is solved
backgroundColor: "#F5F5F5",
djwesty commented 2025-03-11 15:24:22 -07:00 (Migrated from github.com)
Review

I may be wrong, but it seems like the purpose of this component is to be a wrapper of sorts for stylistic purposes, to serve the global app layout.

If that is correct, consider that expos stack navigation system provides a purpose built and best practice system to do this universally, and reduce complexity by not needing wrapper components.

For example, our Apps <Stack> (as implemented in _layout.tsx) can take a screen options parameter called contentStyle. This is an object which can contain a backgroundColor. That would be the expo way to set the background color for our app, even dynamically. The <Stack> props are powerfull and can take all sorts of nested style options for the main app content, header, title, etc.

We can discuss this in sync to make sure we are all on the right path

I may be wrong, but it seems like the purpose of this component is to be a wrapper of sorts for stylistic purposes, to serve the global app layout. If that is correct, consider that [expos stack navigation](https://docs.expo.dev/router/advanced/stack/#configure-header-bar) system provides a purpose built and best practice system to do this universally, and reduce complexity by not needing wrapper components. For example, our Apps `<Stack>` (as implemented in `_layout.tsx`) can take a screen options parameter called `contentStyle`. This is an object which can contain a `backgroundColor`. That would be the expo way to set the background color for our app, even dynamically. The `<Stack>` props are powerfull and can take all sorts of nested style options for the main app content, header, title, etc. We can discuss this in sync to make sure we are all on the right path
djwesty commented 2025-03-11 15:25:24 -07:00 (Migrated from github.com)
Review

Do you know what the status bar is doing for the app?

Do you know what the status bar is doing for the app?
MantashaNoyela commented 2025-03-13 01:07:46 -07:00 (Migrated from github.com)
Review

The StatusBar is used to control the appearance of the mobile device's status bar when the app is running.

The StatusBar is used to control the appearance of the mobile device's status bar when the app is running.
MantashaNoyela commented 2025-03-17 18:24:20 -07:00 (Migrated from github.com)
Review

I believe this issue is solved

I believe this issue is solved
},
djwesty commented 2025-03-11 15:24:22 -07:00 (Migrated from github.com)
Review

I may be wrong, but it seems like the purpose of this component is to be a wrapper of sorts for stylistic purposes, to serve the global app layout.

If that is correct, consider that expos stack navigation system provides a purpose built and best practice system to do this universally, and reduce complexity by not needing wrapper components.

For example, our Apps <Stack> (as implemented in _layout.tsx) can take a screen options parameter called contentStyle. This is an object which can contain a backgroundColor. That would be the expo way to set the background color for our app, even dynamically. The <Stack> props are powerfull and can take all sorts of nested style options for the main app content, header, title, etc.

We can discuss this in sync to make sure we are all on the right path

I may be wrong, but it seems like the purpose of this component is to be a wrapper of sorts for stylistic purposes, to serve the global app layout. If that is correct, consider that [expos stack navigation](https://docs.expo.dev/router/advanced/stack/#configure-header-bar) system provides a purpose built and best practice system to do this universally, and reduce complexity by not needing wrapper components. For example, our Apps `<Stack>` (as implemented in `_layout.tsx`) can take a screen options parameter called `contentStyle`. This is an object which can contain a `backgroundColor`. That would be the expo way to set the background color for our app, even dynamically. The `<Stack>` props are powerfull and can take all sorts of nested style options for the main app content, header, title, etc. We can discuss this in sync to make sure we are all on the right path
djwesty commented 2025-03-11 15:25:24 -07:00 (Migrated from github.com)
Review

Do you know what the status bar is doing for the app?

Do you know what the status bar is doing for the app?
MantashaNoyela commented 2025-03-13 01:07:46 -07:00 (Migrated from github.com)
Review

The StatusBar is used to control the appearance of the mobile device's status bar when the app is running.

The StatusBar is used to control the appearance of the mobile device's status bar when the app is running.
MantashaNoyela commented 2025-03-17 18:24:20 -07:00 (Migrated from github.com)
Review

I believe this issue is solved

I believe this issue is solved
lightGray: {
djwesty commented 2025-03-11 15:24:22 -07:00 (Migrated from github.com)
Review

I may be wrong, but it seems like the purpose of this component is to be a wrapper of sorts for stylistic purposes, to serve the global app layout.

If that is correct, consider that expos stack navigation system provides a purpose built and best practice system to do this universally, and reduce complexity by not needing wrapper components.

For example, our Apps <Stack> (as implemented in _layout.tsx) can take a screen options parameter called contentStyle. This is an object which can contain a backgroundColor. That would be the expo way to set the background color for our app, even dynamically. The <Stack> props are powerfull and can take all sorts of nested style options for the main app content, header, title, etc.

We can discuss this in sync to make sure we are all on the right path

I may be wrong, but it seems like the purpose of this component is to be a wrapper of sorts for stylistic purposes, to serve the global app layout. If that is correct, consider that [expos stack navigation](https://docs.expo.dev/router/advanced/stack/#configure-header-bar) system provides a purpose built and best practice system to do this universally, and reduce complexity by not needing wrapper components. For example, our Apps `<Stack>` (as implemented in `_layout.tsx`) can take a screen options parameter called `contentStyle`. This is an object which can contain a `backgroundColor`. That would be the expo way to set the background color for our app, even dynamically. The `<Stack>` props are powerfull and can take all sorts of nested style options for the main app content, header, title, etc. We can discuss this in sync to make sure we are all on the right path
djwesty commented 2025-03-11 15:25:24 -07:00 (Migrated from github.com)
Review

Do you know what the status bar is doing for the app?

Do you know what the status bar is doing for the app?
MantashaNoyela commented 2025-03-13 01:07:46 -07:00 (Migrated from github.com)
Review

The StatusBar is used to control the appearance of the mobile device's status bar when the app is running.

The StatusBar is used to control the appearance of the mobile device's status bar when the app is running.
MantashaNoyela commented 2025-03-17 18:24:20 -07:00 (Migrated from github.com)
Review

I believe this issue is solved

I believe this issue is solved
backgroundColor: "#D3D3D3",
djwesty commented 2025-03-11 15:24:22 -07:00 (Migrated from github.com)
Review

I may be wrong, but it seems like the purpose of this component is to be a wrapper of sorts for stylistic purposes, to serve the global app layout.

If that is correct, consider that expos stack navigation system provides a purpose built and best practice system to do this universally, and reduce complexity by not needing wrapper components.

For example, our Apps <Stack> (as implemented in _layout.tsx) can take a screen options parameter called contentStyle. This is an object which can contain a backgroundColor. That would be the expo way to set the background color for our app, even dynamically. The <Stack> props are powerfull and can take all sorts of nested style options for the main app content, header, title, etc.

We can discuss this in sync to make sure we are all on the right path

I may be wrong, but it seems like the purpose of this component is to be a wrapper of sorts for stylistic purposes, to serve the global app layout. If that is correct, consider that [expos stack navigation](https://docs.expo.dev/router/advanced/stack/#configure-header-bar) system provides a purpose built and best practice system to do this universally, and reduce complexity by not needing wrapper components. For example, our Apps `<Stack>` (as implemented in `_layout.tsx`) can take a screen options parameter called `contentStyle`. This is an object which can contain a `backgroundColor`. That would be the expo way to set the background color for our app, even dynamically. The `<Stack>` props are powerfull and can take all sorts of nested style options for the main app content, header, title, etc. We can discuss this in sync to make sure we are all on the right path
djwesty commented 2025-03-11 15:25:24 -07:00 (Migrated from github.com)
Review

Do you know what the status bar is doing for the app?

Do you know what the status bar is doing for the app?
MantashaNoyela commented 2025-03-13 01:07:46 -07:00 (Migrated from github.com)
Review

The StatusBar is used to control the appearance of the mobile device's status bar when the app is running.

The StatusBar is used to control the appearance of the mobile device's status bar when the app is running.
MantashaNoyela commented 2025-03-17 18:24:20 -07:00 (Migrated from github.com)
Review

I believe this issue is solved

I believe this issue is solved
},
djwesty commented 2025-03-11 15:24:22 -07:00 (Migrated from github.com)
Review

I may be wrong, but it seems like the purpose of this component is to be a wrapper of sorts for stylistic purposes, to serve the global app layout.

If that is correct, consider that expos stack navigation system provides a purpose built and best practice system to do this universally, and reduce complexity by not needing wrapper components.

For example, our Apps <Stack> (as implemented in _layout.tsx) can take a screen options parameter called contentStyle. This is an object which can contain a backgroundColor. That would be the expo way to set the background color for our app, even dynamically. The <Stack> props are powerfull and can take all sorts of nested style options for the main app content, header, title, etc.

We can discuss this in sync to make sure we are all on the right path

I may be wrong, but it seems like the purpose of this component is to be a wrapper of sorts for stylistic purposes, to serve the global app layout. If that is correct, consider that [expos stack navigation](https://docs.expo.dev/router/advanced/stack/#configure-header-bar) system provides a purpose built and best practice system to do this universally, and reduce complexity by not needing wrapper components. For example, our Apps `<Stack>` (as implemented in `_layout.tsx`) can take a screen options parameter called `contentStyle`. This is an object which can contain a `backgroundColor`. That would be the expo way to set the background color for our app, even dynamically. The `<Stack>` props are powerfull and can take all sorts of nested style options for the main app content, header, title, etc. We can discuss this in sync to make sure we are all on the right path
djwesty commented 2025-03-11 15:25:24 -07:00 (Migrated from github.com)
Review

Do you know what the status bar is doing for the app?

Do you know what the status bar is doing for the app?
MantashaNoyela commented 2025-03-13 01:07:46 -07:00 (Migrated from github.com)
Review

The StatusBar is used to control the appearance of the mobile device's status bar when the app is running.

The StatusBar is used to control the appearance of the mobile device's status bar when the app is running.
MantashaNoyela commented 2025-03-17 18:24:20 -07:00 (Migrated from github.com)
Review

I believe this issue is solved

I believe this issue is solved
});
djwesty commented 2025-03-11 15:24:22 -07:00 (Migrated from github.com)
Review

I may be wrong, but it seems like the purpose of this component is to be a wrapper of sorts for stylistic purposes, to serve the global app layout.

If that is correct, consider that expos stack navigation system provides a purpose built and best practice system to do this universally, and reduce complexity by not needing wrapper components.

For example, our Apps <Stack> (as implemented in _layout.tsx) can take a screen options parameter called contentStyle. This is an object which can contain a backgroundColor. That would be the expo way to set the background color for our app, even dynamically. The <Stack> props are powerfull and can take all sorts of nested style options for the main app content, header, title, etc.

We can discuss this in sync to make sure we are all on the right path

I may be wrong, but it seems like the purpose of this component is to be a wrapper of sorts for stylistic purposes, to serve the global app layout. If that is correct, consider that [expos stack navigation](https://docs.expo.dev/router/advanced/stack/#configure-header-bar) system provides a purpose built and best practice system to do this universally, and reduce complexity by not needing wrapper components. For example, our Apps `<Stack>` (as implemented in `_layout.tsx`) can take a screen options parameter called `contentStyle`. This is an object which can contain a `backgroundColor`. That would be the expo way to set the background color for our app, even dynamically. The `<Stack>` props are powerfull and can take all sorts of nested style options for the main app content, header, title, etc. We can discuss this in sync to make sure we are all on the right path
djwesty commented 2025-03-11 15:25:24 -07:00 (Migrated from github.com)
Review

Do you know what the status bar is doing for the app?

Do you know what the status bar is doing for the app?
MantashaNoyela commented 2025-03-13 01:07:46 -07:00 (Migrated from github.com)
Review

The StatusBar is used to control the appearance of the mobile device's status bar when the app is running.

The StatusBar is used to control the appearance of the mobile device's status bar when the app is running.
MantashaNoyela commented 2025-03-17 18:24:20 -07:00 (Migrated from github.com)
Review

I believe this issue is solved

I believe this issue is solved
djwesty commented 2025-03-11 15:24:22 -07:00 (Migrated from github.com)
Review

I may be wrong, but it seems like the purpose of this component is to be a wrapper of sorts for stylistic purposes, to serve the global app layout.

If that is correct, consider that expos stack navigation system provides a purpose built and best practice system to do this universally, and reduce complexity by not needing wrapper components.

For example, our Apps <Stack> (as implemented in _layout.tsx) can take a screen options parameter called contentStyle. This is an object which can contain a backgroundColor. That would be the expo way to set the background color for our app, even dynamically. The <Stack> props are powerfull and can take all sorts of nested style options for the main app content, header, title, etc.

We can discuss this in sync to make sure we are all on the right path

I may be wrong, but it seems like the purpose of this component is to be a wrapper of sorts for stylistic purposes, to serve the global app layout. If that is correct, consider that [expos stack navigation](https://docs.expo.dev/router/advanced/stack/#configure-header-bar) system provides a purpose built and best practice system to do this universally, and reduce complexity by not needing wrapper components. For example, our Apps `<Stack>` (as implemented in `_layout.tsx`) can take a screen options parameter called `contentStyle`. This is an object which can contain a `backgroundColor`. That would be the expo way to set the background color for our app, even dynamically. The `<Stack>` props are powerfull and can take all sorts of nested style options for the main app content, header, title, etc. We can discuss this in sync to make sure we are all on the right path
djwesty commented 2025-03-11 15:25:24 -07:00 (Migrated from github.com)
Review

Do you know what the status bar is doing for the app?

Do you know what the status bar is doing for the app?
MantashaNoyela commented 2025-03-13 01:07:46 -07:00 (Migrated from github.com)
Review

The StatusBar is used to control the appearance of the mobile device's status bar when the app is running.

The StatusBar is used to control the appearance of the mobile device's status bar when the app is running.
MantashaNoyela commented 2025-03-17 18:24:20 -07:00 (Migrated from github.com)
Review

I believe this issue is solved

I believe this issue is solved
export default PokerAppUi;
djwesty commented 2025-03-11 15:24:22 -07:00 (Migrated from github.com)
Review

I may be wrong, but it seems like the purpose of this component is to be a wrapper of sorts for stylistic purposes, to serve the global app layout.

If that is correct, consider that expos stack navigation system provides a purpose built and best practice system to do this universally, and reduce complexity by not needing wrapper components.

For example, our Apps <Stack> (as implemented in _layout.tsx) can take a screen options parameter called contentStyle. This is an object which can contain a backgroundColor. That would be the expo way to set the background color for our app, even dynamically. The <Stack> props are powerfull and can take all sorts of nested style options for the main app content, header, title, etc.

We can discuss this in sync to make sure we are all on the right path

I may be wrong, but it seems like the purpose of this component is to be a wrapper of sorts for stylistic purposes, to serve the global app layout. If that is correct, consider that [expos stack navigation](https://docs.expo.dev/router/advanced/stack/#configure-header-bar) system provides a purpose built and best practice system to do this universally, and reduce complexity by not needing wrapper components. For example, our Apps `<Stack>` (as implemented in `_layout.tsx`) can take a screen options parameter called `contentStyle`. This is an object which can contain a `backgroundColor`. That would be the expo way to set the background color for our app, even dynamically. The `<Stack>` props are powerfull and can take all sorts of nested style options for the main app content, header, title, etc. We can discuss this in sync to make sure we are all on the right path
djwesty commented 2025-03-11 15:25:24 -07:00 (Migrated from github.com)
Review

Do you know what the status bar is doing for the app?

Do you know what the status bar is doing for the app?
MantashaNoyela commented 2025-03-13 01:07:46 -07:00 (Migrated from github.com)
Review

The StatusBar is used to control the appearance of the mobile device's status bar when the app is running.

The StatusBar is used to control the appearance of the mobile device's status bar when the app is running.
MantashaNoyela commented 2025-03-17 18:24:20 -07:00 (Migrated from github.com)
Review

I believe this issue is solved

I believe this issue is solved

View File

@ -1,7 +1,7 @@
import { View, Text, StyleSheet } from "react-native";
import React from "react";
import { View, Text, StyleSheet, useColorScheme } from "react-native";
import React, { useMemo } from "react";
import { MaterialIcons } from "@expo/vector-icons";
import globalStyles from "@/styles/styles";
import globalStyles, { COLORS } from "@/styles/styles";
const titleCase = (input: string) =>
input
@ -23,6 +23,12 @@ const Section = ({
orientation?: "row" | "column";
contentStyle?: object;
}) => {
const colorScheme = useColorScheme();
const darkMode = useMemo(() => colorScheme === "dark", [colorScheme]);
const colors = useMemo(
() => (darkMode ? COLORS.DARK : COLORS.LIGHT),
[darkMode]
);
return (
<View style={styles.container}>
<View style={styles.header}>
@ -30,9 +36,11 @@ const Section = ({
style={styles.icon}
name={iconName}
size={30}
color={"black"}
color={colors.TEXT}
/>
<Text style={styles.title}>{titleCase(title)}</Text>
<Text style={[styles.title, { color: colors.TEXT }]}>
{titleCase(title)}
</Text>
</View>
<View
style={{

View File

@ -48,7 +48,7 @@
"please_select_valid_buyin": "Please select a valid buy-in amount",
"chip_value_warn": "Be advised that the value of the distributed chips does not equal the buy-in for these inputs.\n\nHowever, results shown are fair to all players",
"appearance": "Appearance",
"switch_to_gray_mode": "Switch to Gray Mode",
"switch_to_dark_mode": "Switch to Dark Mode",
"switch_to_light_mode": "Switch to Light Mode"
}
}

View File

@ -49,7 +49,7 @@
"please_select_valid_buyin": "Por favor seleccione una cantidad de buy-in válida",
"chip_value_warn": "Tenga en cuenta que el valor de las fichas distribuidas no es igual al buy-in para estas entradas.\n\nSin embargo, los resultados que se muestran son justos para todos los jugadores.",
"appearance": "Apariencia",
"switch_to_gray_mode": "Cambiar a Modo Gris",
"switch_to_dark_mode": "Cambiar a Modo Oscuro",
"switch_to_light_mode": "Cambiar a Modo Claro"
}
}

View File

@ -1,16 +1,23 @@
import { StyleSheet } from "react-native";
export const COLORS = {
PRIMARY: "#007bff",
SECONDARY: "#6c757d",
SUCCESS: "#28a745",
DANGER: "#dc3545",
WARNING: "#c79c28",
LIGHT: {
TEXT: "black",
PRIMARY: "lightgrey",
SECONDARY: "azure",
BACKGROUND: "ghostwhite",
DISABLED: "gray",
},
DARK: {
TEXT: "white",
PRIMARY: "black",
SECONDARY: "teal",
BACKGROUND: "dimgrey",
DISABLED: "gray",
},
};
const lightStyles = StyleSheet.create({});
const darkStyles = StyleSheet.create({});
const GlobalStyles = StyleSheet.create({
scrollView: {},
scrollViewContent: {
@ -51,9 +58,11 @@ const GlobalStyles = StyleSheet.create({
textShadowRadius: 10,
},
picker: {
height: 50,
borderRadius: 10,
height: 55,
width: 150,
},
pickerItem: {},
});
export default GlobalStyles;