david/poker-chips-helper
1
1
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Implement Player Count Selector Component (Issue #2) #14

Merged
Vutukuri15 merged 1 commits from vutukuri15/2 into main 2025-02-09 15:10:51 -08:00
Conversation 2 Commits 1 Files Changed 5 +358 -12
Vutukuri15 commented 2025-02-09 14:20:36 -08:00 (Migrated from github.com)
Copy Link

This addresses the requirement specified in Issue #2.

This PR introduces a new PlayerSelector component for selecting and adjusting the number of players in the game. The component allows users to increase or decrease the player count within the range of 2 to 8 players. It also includes corresponding unit tests to ensure the functionality works as expected.

This addresses the requirement specified in Issue #2. This PR introduces a new PlayerSelector component for selecting and adjusting the number of players in the game. The component allows users to increase or decrease the player count within the range of 2 to 8 players. It also includes corresponding unit tests to ensure the functionality works as expected.
MantashaNoyela (Migrated from github.com) reviewed 2025-02-09 14:20:36 -08:00
djwesty commented 2025-02-09 14:33:43 -08:00 (Migrated from github.com)
Copy Link

Good work.
My only suggestion is to keep the name of the PR more broad/abstract and maybe mention the issue number in the title (like how I did for my PR). Most PRs in the future will have multiple commits so it won't usually make sense to just use a commit message as the name.

Also you may want to link this PR to the relevant issue with the "Development" tab on the right.

Good work. My only suggestion is to keep the name of the PR more broad/abstract and maybe mention the issue number in the title (like how I did for my PR). Most PRs in the future will have multiple commits so it won't usually make sense to just use a commit message as the name. Also you may want to link this PR to the relevant issue with the "Development" tab on the right.
djwesty (Migrated from github.com) approved these changes 2025-02-09 14:33:57 -08:00
Vutukuri15 commented 2025-02-09 15:09:55 -08:00 (Migrated from github.com)
Copy Link

Thank you for the feedback! @djwesty
I’ve updated the title to be more abstract and included the issue number. I’ve also linked the PR to the relevant issue.

Thank you for the feedback! @djwesty I’ve updated the title to be more abstract and included the issue number. I’ve also linked the PR to the relevant issue.
Sign in to join this conversation.
Reviewers
No reviewers
MantashaNoyela
djwesty
Labels
Clear labels   
Large

5-10 Days

  
Medium

2-5 Days

  
Small

0-2 Days

  
bug

Something isn't working

  
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
invalid

This doesn't seem right

  
question

Further information is requested

  
wontfix

This will not be worked on

No Label
Large
Medium
Small
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Project Sprint 1
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: david/poker-chips-helper#14
No description provided.
Delete Branch "vutukuri15/2"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?