Implemented code for Dark Background and The Test Code #19

Closed
MantashaNoyela wants to merge 1 commits from MantashaNoyela/18 into main
MantashaNoyela commented 2025-02-11 17:22:20 -08:00 (Migrated from github.com)

The DarkModeToggle component allows users to switch between light mode and dark mode(Gray) in a React Native app. It takes two props:

  • darkMode (boolean) – Determines the current theme state.

  • onToggle (function) – Handles the toggle action when the button is pressed.

The UI updates dynamically, changing the background and text color based on the selected mode. This ensures a smooth and visually adaptive experience for users.

The DarkModeToggle component allows users to switch between light mode and dark mode(Gray) in a React Native app. It takes two props: - darkMode (boolean) – Determines the current theme state. - onToggle (function) – Handles the toggle action when the button is pressed. The UI updates dynamically, changing the background and text color based on the selected mode. This ensures a smooth and visually adaptive experience for users.
djwesty (Migrated from github.com) reviewed 2025-02-11 19:52:48 -08:00
djwesty (Migrated from github.com) left a comment

I like this feature, the app definitely should have a dark mode.

The challenge here is that with each component defining its own styles, that will mean dark mode will needs to be passed into each component as props with custom logic at every point. Rather than doing more work with the current approach and updating all the sub-components, let's put in a new issue to refactor styles in a shared heirarchy, and have this be blocked by that.

I like this feature, the app definitely should have a dark mode. The challenge here is that with each component defining its own styles, that will mean dark mode will needs to be passed into each component as props with custom logic at every point. Rather than doing more work with the current approach and updating all the sub-components, let's put in a new issue to refactor styles in a shared heirarchy, and have this be blocked by that.
MantashaNoyela commented 2025-03-18 15:13:22 -07:00 (Migrated from github.com)

Already worked on dark mode in another PR.

Already worked on dark mode in another PR.

Pull request closed

Sign in to join this conversation.
No description provided.