david/poker-chips-helper
1
1
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fixed issue with extra colors of image input # 57 #58

Merged
Vutukuri15 merged 2 commits from vutukuri15/57 into main 2025-03-10 12:08:52 -07:00
Conversation 2 Commits 2 Files Changed 2 +23 -6
Vutukuri15 commented 2025-03-09 21:08:45 -07:00 (Migrated from github.com)
Copy Link

This PR improves the ChipDetection component by ensuring the correct ordering of detected chip colors and handling unexpected colors in the AI response. Previously, the response parsing did not guarantee a fixed order for chip colors, and extra colors (e.g., "purple") could cause misalignment in the flattened array.

This PR improves the ChipDetection component by ensuring the correct ordering of detected chip colors and handling unexpected colors in the AI response. Previously, the response parsing did not guarantee a fixed order for chip colors, and extra colors (e.g., "purple") could cause misalignment in the flattened array.
MantashaNoyela (Migrated from github.com) reviewed 2025-03-09 21:08:45 -07:00
djwesty commented 2025-03-09 23:18:34 -07:00 (Migrated from github.com)
Copy Link

Good work. I gave it a quick test with some debugging to change the data. It does the job

Good work. I gave it a quick test with some debugging to change the data. It does the job
djwesty (Migrated from github.com) approved these changes 2025-03-09 23:18:41 -07:00
Vutukuri15 commented 2025-03-10 12:06:05 -07:00 (Migrated from github.com)
Copy Link

I fixed test code

I fixed test code
djwesty (Migrated from github.com) approved these changes 2025-03-10 12:06:45 -07:00
Sign in to join this conversation.
Reviewers
No reviewers
MantashaNoyela
djwesty
Labels
Clear labels   
Large

5-10 Days

  
Medium

2-5 Days

  
Small

0-2 Days

  
bug

Something isn't working

  
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
invalid

This doesn't seem right

  
question

Further information is requested

  
wontfix

This will not be worked on

No Label
Large
Medium
Small
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Project Sprint 3
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: david/poker-chips-helper#58
No description provided.
Delete Branch "vutukuri15/57"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?